124728 2013-11-21 11:26:46 -0800 Ensure future layouts use the correct linebox layout path when adding a float 2014-02-13 03:46:20 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 robert robert commit-queue esprehn+autocc glenn koivisto kondapallykalyan robert oldest_to_newest 953187 0 robert 2013-11-21 11:26:46 -0800 When adding a float to an object the simple linebox layout path won't work for it anymore, so ensure it checks again which layout path to use. 953191 1 217586 robert 2013-11-21 11:31:56 -0800 Created attachment 217586 Patch 953195 2 217588 robert 2013-11-21 11:34:52 -0800 Created attachment 217588 Patch 953209 3 robert 2013-11-21 11:47:16 -0800 Hi Antti, After updating trunk to upload this patch it looks like the regression I caused in r159575 was fixed by r159579 - simple line layout now supports floats so there's nothing to worry about anymore. 980213 4 217588 ossy 2014-02-13 03:46:20 -0800 Comment on attachment 217588 Patch Cleared review? from attachment 217588 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 217586 2013-11-21 11:31:56 -0800 2013-11-21 11:34:43 -0800 Patch bug-124728-20131121193154.patch text/plain 3699 robert U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5NTc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWU5YmNiMmQ1YjEzZWZk NzUzMDNmOWY4M2UxMGY2OGZhNTc0NmIxZS4uNzg5YzA5OWIzMTcwNDEyNDk2MjczNGIwODM5YTdm ODFjZDVjNTBmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTExLTIxICBSb2Jl cnQgSG9nYW4gIDxyb2JlcnRAd2Via2l0Lm9yZz4KKworICAgICAgICBFbnN1cmUgZnV0dXJlIGxh eW91dHMgdXNlIHRoZSBjb3JyZWN0IGxpbmVib3ggbGF5b3V0IHBhdGggd2hlbiBhZGRpbmcgYSBm bG9hdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI0 NzI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhp cyB3YXMgYSByZWdyZXNzaW9uIGluIHIxNTk1NzUuCisgICAgICAgIENvdmVyZWQgYnkgZmFzdC9i bG9jay9tYXJnaW4tY29sbGFwc2UvZW1wdHktY2xlYXItYmxvY2tzLmh0bWwKKworICAgICAgICAq IHJlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVy QmxvY2tGbG93OjphZGRJbnRydWRpbmdGbG9hdHMpOgorCiAyMDEzLTExLTIwICBSb2JlcnQgSG9n YW4gIDxyb2JlcnRAd2Via2l0Lm9yZz4KIAogICAgICAgICBSRUdSRVNTSU9OKHIxMjcxNjMpOiBS ZXNwZWN0IGNsZWFyYW5jZSBzZXQgb24gYW5jZXN0b3JzIHdoZW4gcGxhY2luZyBmbG9hdHMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrRmxvdy5jcHAKaW5kZXggZDFiZjgy ZDNmYzBlYTI1ODcxYTE4NTdiM2MyMDkwN2JjNzY2OTViYi4uNGZjZDQ5NjQ3MDM5YmZiMmM2NWQz NzJiY2ZjNjc2ZTZjMDYzYzlhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckJsb2NrRmxvdy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckJsb2NrRmxvdy5jcHAKQEAgLTI0MjYsNiArMjQyNiw5IEBAIHZvaWQgUmVuZGVyQmxvY2tGbG93 OjphZGRJbnRydWRpbmdGbG9hdHMoUmVuZGVyQmxvY2tGbG93KiBwcmV2LCBMYXlvdXRVbml0IGxv Z2ljCiAgICAgICAgICAgICAgICAgaWYgKCFtX2Zsb2F0aW5nT2JqZWN0cykKICAgICAgICAgICAg ICAgICAgICAgY3JlYXRlRmxvYXRpbmdPYmplY3RzKCk7CiAKKyAgICAgICAgICAgICAgICAvLyBO b3cgdGhhdCB3ZSdyZSBhZGRpbmcgYSBmbG9hdCB3ZSBtYXkgbm90IHF1YWxpZnkgZm9yIHRoZSBz aW1wbGUgbGluZWJveCBwYXRoIGFueW1vcmUuCisgICAgICAgICAgICAgICAgbV9saW5lTGF5b3V0 UGF0aCA9IFVuZGV0ZXJtaW5lZFBhdGg7CisKICAgICAgICAgICAgICAgICAvLyBBcHBseWluZyB0 aGUgY2hpbGQncyBtYXJnaW4gbWFrZXMgbm8gc2Vuc2UgaW4gdGhlIGNhc2Ugd2hlcmUgdGhlIGNo aWxkIHdhcyBwYXNzZWQgaW4uCiAgICAgICAgICAgICAgICAgLy8gc2luY2UgdGhpcyBtYXJnaW4g d2FzIGFkZGVkIGFscmVhZHkgdGhyb3VnaCB0aGUgbW9kaWZpY2F0aW9uIG9mIHRoZSB8bG9naWNh bExlZnRPZmZzZXR8IHZhcmlhYmxlCiAgICAgICAgICAgICAgICAgLy8gYWJvdmUuIHxsb2dpY2Fs TGVmdE9mZnNldHwgd2lsbCBlcXVhbCB0aGUgbWFyZ2luIGluIHRoaXMgY2FzZSwgc28gaXQncyBh bHJlYWR5IGJlZW4gdGFrZW4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBmMDI1NzliMjUyZTVmZWQxNmY0ZjZmZmM0NmE2OGNj YzRkZTA0YzUxLi5iODIzMGExMTE1OWMyYmU4MGRhYjQ0MGU2Y2VmNjc5NWRhMDAyNTFmIDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTIgQEAKKzIwMTMtMTEtMjEgIFJvYmVydCBIb2dhbiAgPHJvYmVydEB3ZWJr aXQub3JnPgorCisgICAgICAgIEVuc3VyZSBmdXR1cmUgbGF5b3V0cyB1c2UgdGhlIGNvcnJlY3Qg bGluZWJveCBsYXlvdXQgcGF0aCB3aGVuIGFkZGluZyBhIGZsb2F0CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQ3MjgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9mYXN0L2Jsb2Nr L21hcmdpbi1jb2xsYXBzZS9lbXB0eS1jbGVhci1ibG9ja3MtZXhwZWN0ZWQudHh0OgorCiAyMDEz LTExLTIwICBSb2JlcnQgSG9nYW4gIDxyb2JlcnRAd2Via2l0Lm9yZz4KIAogICAgICAgICBSRUdS RVNTSU9OKHIxMjcxNjMpOiBSZXNwZWN0IGNsZWFyYW5jZSBzZXQgb24gYW5jZXN0b3JzIHdoZW4g cGxhY2luZyBmbG9hdHMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0 L2Jsb2NrL21hcmdpbi1jb2xsYXBzZS9lbXB0eS1jbGVhci1ibG9ja3MtZXhwZWN0ZWQudHh0IGIv TGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvYmxvY2svbWFyZ2luLWNvbGxhcHNlL2VtcHR5 LWNsZWFyLWJsb2Nrcy1leHBlY3RlZC50eHQKaW5kZXggYzY4YjBmMDdiN2M5ODZjZDJkYzg4ZGQw ODkyMzFiMTMwNTNmMTY4Zi4uZmZiODc3YjM4N2ViZjU0YmU4YTQyYTc0MmM3NjBhNmM5NGE0NDIy ZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvYmxvY2svbWFyZ2lu LWNvbGxhcHNlL2VtcHR5LWNsZWFyLWJsb2Nrcy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVz dHMvcGxhdGZvcm0vbWFjL2Zhc3QvYmxvY2svbWFyZ2luLWNvbGxhcHNlL2VtcHR5LWNsZWFyLWJs b2Nrcy1leHBlY3RlZC50eHQKQEAgLTM5LDggKzM5LDggQEAgbGF5ZXIgYXQgKDAsMCkgc2l6ZSA3 ODV4MTEzMAogICAgICAgICAgIHRleHQgcnVuIGF0ICgxMDAsMCkgd2lkdGggMjg0OiAiVGhpcyBw YXJhZ3JhcGggaGFzIGEgYm90dG9tIG1hcmdpbiBvZiA1MHB4LiIKICAgICAgIFJlbmRlckJsb2Nr IHtTUEFOfSBhdCAoMCwzOTIpIHNpemUgNzY5eDAKICAgICAgIFJlbmRlckJsb2NrIHtTUEFOfSBh dCAoMCwzNjIpIHNpemUgNzY5eDE4Ci0gICAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoMCww KSBzaXplIDI2OHgxOAotICAgICAgICAgIHRleHQgcnVuIGF0ICgwLDApIHdpZHRoIDI2ODogIlRo aXMgdGV4dCBzaG91bGQgYmUgdG8gdGhlIHJpZ2h0IG9mIHRoZSBmbG9hdC4iCisgICAgICAgIFJl bmRlclRleHQgeyN0ZXh0fSBhdCAoMTAwLDApIHNpemUgMjY4eDE4CisgICAgICAgICAgdGV4dCBy dW4gYXQgKDEwMCwwKSB3aWR0aCAyNjg6ICJUaGlzIHRleHQgc2hvdWxkIGJlIHRvIHRoZSByaWdo dCBvZiB0aGUgZmxvYXQuIgogICAgICAgUmVuZGVyQmxvY2sge0hSfSBhdCAoMTAwLDM4OCkgc2l6 ZSA2Njl4MiBbYm9yZGVyOiAoMXB4IGluc2V0ICMwMDAwMDApXQogICAgICAgUmVuZGVyQmxvY2sg e1NQQU59IGF0ICgwLDM5OCkgc2l6ZSA3Njl4MTgKICAgICAgICAgUmVuZGVyQmxvY2sgKGZsb2F0 aW5nKSB7RElWfSBhdCAoMCwwKSBzaXplIDEwMHgxMDAgW2JnY29sb3I9IzAwRkYwMF0K 217588 2013-11-21 11:34:52 -0800 2014-02-13 03:46:20 -0800 Patch bug-124728-20131121193450.patch text/plain 1798 robert U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5NjM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGY5OWQ5NDBhNDE0MmQ1 MDg4ZmVhYWNkMWYwYjA1NmY0YzZjYjc2Mi4uMmExZjU2YWM5N2Q2MWZiYTM1YjdmOTc2N2I3Yzg2 YTI1MDY5MDc0ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEzLTExLTIxICBSb2Jl cnQgSG9nYW4gIDxyb2JlcnRAd2Via2l0Lm9yZz4KKworICAgICAgICBFbnN1cmUgZnV0dXJlIGxh eW91dHMgdXNlIHRoZSBjb3JyZWN0IGxpbmVib3ggbGF5b3V0IHBhdGggd2hlbiBhZGRpbmcgYSBm bG9hdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI0 NzI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhp cyB3YXMgYSByZWdyZXNzaW9uIGluIHIxNTk1NzUuCisgICAgICAgIENvdmVyZWQgYnkgZmFzdC9i bG9jay9tYXJnaW4tY29sbGFwc2UvZW1wdHktY2xlYXItYmxvY2tzLmh0bWwKKworICAgICAgICAq IHJlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVy QmxvY2tGbG93OjphZGRJbnRydWRpbmdGbG9hdHMpOgorCiAyMDEzLTExLTIxICBBbGV4ZXkgUHJv c2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIEltcGxlbWVudCBXZWJDcnlwdG8g dW53cmFwS2V5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxv Y2tGbG93LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3Bw CmluZGV4IGY5ZTUwZDA1YzMxMWFmZjA0NWRjYTY2YTVkNjVhN2M4OWUyZmIzMWMuLjk1NWUzNGZk YWFjNGE2ZjVjZmUzNGU4ZTllOGFmYjY1MmUwZGNhZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwCkBAIC0yNDMzLDYgKzI0MzMsOSBAQCB2b2lkIFJl bmRlckJsb2NrRmxvdzo6YWRkSW50cnVkaW5nRmxvYXRzKFJlbmRlckJsb2NrRmxvdyogcHJldiwg TGF5b3V0VW5pdCBsb2dpYwogICAgICAgICAgICAgICAgIGlmICghbV9mbG9hdGluZ09iamVjdHMp CiAgICAgICAgICAgICAgICAgICAgIGNyZWF0ZUZsb2F0aW5nT2JqZWN0cygpOwogCisgICAgICAg ICAgICAgICAgLy8gTm93IHRoYXQgd2UncmUgYWRkaW5nIGEgZmxvYXQgd2UgbWF5IG5vdCBxdWFs aWZ5IGZvciB0aGUgc2ltcGxlIGxpbmVib3ggcGF0aCBhbnltb3JlLgorICAgICAgICAgICAgICAg IG1fbGluZUxheW91dFBhdGggPSBVbmRldGVybWluZWRQYXRoOworCiAgICAgICAgICAgICAgICAg Ly8gQXBwbHlpbmcgdGhlIGNoaWxkJ3MgbWFyZ2luIG1ha2VzIG5vIHNlbnNlIGluIHRoZSBjYXNl IHdoZXJlIHRoZSBjaGlsZCB3YXMgcGFzc2VkIGluLgogICAgICAgICAgICAgICAgIC8vIHNpbmNl IHRoaXMgbWFyZ2luIHdhcyBhZGRlZCBhbHJlYWR5IHRocm91Z2ggdGhlIG1vZGlmaWNhdGlvbiBv ZiB0aGUgfGxvZ2ljYWxMZWZ0T2Zmc2V0fCB2YXJpYWJsZQogICAgICAgICAgICAgICAgIC8vIGFi b3ZlLiB8bG9naWNhbExlZnRPZmZzZXR8IHdpbGwgZXF1YWwgdGhlIG1hcmdpbiBpbiB0aGlzIGNh c2UsIHNvIGl0J3MgYWxyZWFkeSBiZWVuIHRha2VuCg==