124717 2013-11-21 07:23:28 -0800 process_file() should throw instead of exiting directly in filereader.py 2013-11-21 19:47:26 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dbatyai.u-szeged webkit-unassigned commit-queue glenn ossy rniwa oldest_to_newest 953092 0 dbatyai.u-szeged 2013-11-21 07:23:28 -0800 In filereader.py, process_file() should throw instead of exiting directly when the file doesn't exist FIXME: This should throw or return instead of exiting directly. 953093 1 217566 dbatyai.u-szeged 2013-11-21 07:25:39 -0800 Created attachment 217566 Proposed patch 953418 2 217566 commit-queue 2013-11-21 19:47:25 -0800 Comment on attachment 217566 Proposed patch Clearing flags on attachment: 217566 Committed r159672: <http://trac.webkit.org/changeset/159672> 953419 3 commit-queue 2013-11-21 19:47:26 -0800 All reviewed patches have been landed. Closing bug. 217566 2013-11-21 07:25:39 -0800 2013-11-21 19:47:24 -0800 Proposed patch proposedpatch.patch text/plain 2132 dbatyai.u-szeged ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBiOWIz ZWU2Li40NjlhNzJiIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTMtMTEtMjEgIETDoW5pZWwgQsOhdHlhaSAgPEJh dHlhaS5EYW5pZWxAc3R1ZC51LXN6ZWdlZC5odT4KKworICAgICAgICBJbiBmaWxlcmVhZGVyLnB5 LCBwcm9jZXNzX2ZpbGUoKSBzaG91bGQgdGhyb3cgaW5zdGVhZCBvZiBleGl0aW5nIGRpcmVjdGx5 IHdoZW4gdGhlIGZpbGUgZG9lc24ndCBleGlzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI0NzE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2ZpbGVyZWFkZXIu cHk6CisgICAgICAgIChUZXh0RmlsZVJlYWRlci5wcm9jZXNzX2ZpbGUpOgorICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvc3R5bGUvZmlsZXJlYWRlcl91bml0dGVzdC5weToKKyAgICAgICAgKFRl eHRGaWxlUmVhZGVyVGVzdC50ZXN0X3Byb2Nlc3NfZmlsZV9fZG9lc19ub3RfZXhpc3QpOgorCiAy MDEzLTExLTIwICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAg ICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTU5NDk2LgpkaWZmIC0tZ2l0IGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9zdHlsZS9maWxlcmVhZGVyLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9zdHlsZS9maWxlcmVhZGVyLnB5CmluZGV4IDExODFhZDQuLjVmMDRmYWQgMTAwNjQ0Ci0t LSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvZmlsZXJlYWRlci5weQorKysgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2ZpbGVyZWFkZXIucHkKQEAgLTExMyw3ICsxMTMsNyBA QCBjbGFzcyBUZXh0RmlsZVJlYWRlcihvYmplY3QpOgogCiAgICAgICAgIGlmIG5vdCBzZWxmLmZp bGVzeXN0ZW0uZXhpc3RzKGZpbGVfcGF0aCkgYW5kIGZpbGVfcGF0aCAhPSAiLSI6CiAgICAgICAg ICAgICBfbG9nLmVycm9yKCJGaWxlIGRvZXMgbm90IGV4aXN0OiAnJXMnIiAlIGZpbGVfcGF0aCkK LSAgICAgICAgICAgIHN5cy5leGl0KDEpICAjIEZJWE1FOiBUaGlzIHNob3VsZCB0aHJvdyBvciBy ZXR1cm4gaW5zdGVhZCBvZiBleGl0aW5nIGRpcmVjdGx5LgorICAgICAgICAgICAgcmFpc2UgSU9F cnJvcigiRmlsZSBkb2VzIG5vdCBleGlzdCIpCiAKICAgICAgICAgaWYgbm90IHNlbGYuX3Byb2Nl c3Nvci5zaG91bGRfcHJvY2VzcyhmaWxlX3BhdGgpOgogICAgICAgICAgICAgX2xvZy5kZWJ1Zygi U2tpcHBpbmcgZmlsZTogJyVzJyIgJSBmaWxlX3BhdGgpCmRpZmYgLS1naXQgYS9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L3N0eWxlL2ZpbGVyZWFkZXJfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L3N0eWxlL2ZpbGVyZWFkZXJfdW5pdHRlc3QucHkKaW5kZXggMmM1MDZlYy4uNGMz MGFhOCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9maWxlcmVhZGVy X3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvZmlsZXJlYWRl cl91bml0dGVzdC5weQpAQCAtODAsOCArODAsOCBAQCBjbGFzcyBUZXh0RmlsZVJlYWRlclRlc3Qo TG9nZ2luZ1Rlc3RDYXNlKToKICAgICBkZWYgdGVzdF9wcm9jZXNzX2ZpbGVfX2RvZXNfbm90X2V4 aXN0KHNlbGYpOgogICAgICAgICB0cnk6CiAgICAgICAgICAgICBzZWxmLl9maWxlX3JlYWRlci5w cm9jZXNzX2ZpbGUoJ2RvZXNfbm90X2V4aXN0LnR4dCcpCi0gICAgICAgIGV4Y2VwdCBTeXN0ZW1F eGl0LCBlcnI6Ci0gICAgICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHN0cihlcnIpLCAnMScpCisg ICAgICAgIGV4Y2VwdCBJT0Vycm9yLCBlcnI6CisgICAgICAgICAgICBzZWxmLmFzc2VydEVxdWFs KHN0cihlcnIpLCAiRmlsZSBkb2VzIG5vdCBleGlzdCIpCiAgICAgICAgIGVsc2U6CiAgICAgICAg ICAgICBzZWxmLmZhaWwoJ05vIEV4Y2VwdGlvbiByYWlzZWQuJykKICAgICAgICAgc2VsZi5fYXNz ZXJ0X2ZpbGVfcmVhZGVyKFtdLCAxKQo=