124716 2013-11-21 07:20:22 -0800 [MIPS] Build fails since r159545. 2013-11-21 10:29:48 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kilvadyb webkit-unassigned commit-queue fpizlo fu gergely ggaren jbriance msaboff palfia oldest_to_newest 953089 0 kilvadyb 2013-11-21 07:20:22 -0800 The "memfence" opcode is missing from LLINT and the following implementations are missing from MacroAssemblerMIPS.h since r159545: - void memoryFence() - void store8(RegisterID, const void*) 953132 1 217576 kilvadyb 2013-11-21 09:30:32 -0800 Created attachment 217576 proposed patch. 953134 2 217576 jbriance 2013-11-21 09:34:04 -0800 Comment on attachment 217576 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=217576&action=review > Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:998 > + m_assembler.sb(immTempRegister, addrTempRegister, 0); Why src RegisterID parameter is not used here? 953139 3 217577 kilvadyb 2013-11-21 09:39:10 -0800 Created attachment 217577 fixed patch. 953162 4 217577 commit-queue 2013-11-21 10:29:46 -0800 Comment on attachment 217577 fixed patch. Clearing flags on attachment: 217577 Committed r159635: <http://trac.webkit.org/changeset/159635> 953163 5 commit-queue 2013-11-21 10:29:48 -0800 All reviewed patches have been landed. Closing bug. 217576 2013-11-21 09:30:32 -0800 2013-11-21 09:35:14 -0800 proposed patch. mem.diff text/plain 2675 kilvadyb ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDdkMGZiNWEuLmY3MjZlY2QgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTExLTIxICBCYWxhenMgS2lsdmFk eSAgPGtpbHZhZHliQGhvbWVqaW5uaS5jb20+CisKKyAgICAgICAgW01JUFNdIEJ1aWxkIGZhaWxz IHNpbmNlIHIxNTk1NDUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMjQ3MTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBBZGQgbWlzc2luZyBpbXBsZW1lbnRhdGlvbnMgaW4gTWFjcm9Bc3NlbWJsZXIgYW5k IExMSW50IGZvciBNSVBTLgorCisgICAgICAgICogYXNzZW1ibGVyL01JUFNBc3NlbWJsZXIuaDoK KyAgICAgICAgKEpTQzo6TUlQU0Fzc2VtYmxlcjo6c3luYyk6CisgICAgICAgICogYXNzZW1ibGVy L01hY3JvQXNzZW1ibGVyTUlQUy5oOgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2VtYmxlck1JUFM6 OnN0b3JlOCk6CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyTUlQUzo6bWVtb3J5RmVuY2Up OgorICAgICAgICAqIG9mZmxpbmVhc20vbWlwcy5yYjoKKwogMjAxMy0xMS0yMCAgTWFyayBMYW0g IDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgSW50cm9kdWNpbmcgVk1FbnRyeVNjb3Bl IHRvIHVwZGF0ZSB0aGUgVk0gc3RhY2sgbGltaXQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvYXNzZW1ibGVyL01JUFNBc3NlbWJsZXIuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9hc3NlbWJsZXIvTUlQU0Fzc2VtYmxlci5oCmluZGV4IDE4NGM0NmUuLmI3NWI0ZDAgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTUlQU0Fzc2VtYmxlci5oCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTUlQU0Fzc2VtYmxlci5oCkBAIC0x OTMsNiArMTkzLDExIEBAIHB1YmxpYzoKICAgICAgICAgZW1pdEluc3QoMHgwMDAwMDAwMCk7CiAg ICAgfQogCisgICAgdm9pZCBzeW5jKCkKKyAgICB7CisgICAgICAgIGVtaXRJbnN0KDB4MDAwMDAw MGYpOworICAgIH0KKwogICAgIC8qIE5lZWQgdG8gaW5zZXJ0IG9uZSBsb2FkIGRhdGEgZGVsYXkg bm9wIGZvciBtaXBzMS4gICovCiAgICAgdm9pZCBsb2FkRGVsYXlOb3AoKQogICAgIHsKZGlmZiAt LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBT LmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5o CmluZGV4IDdjNjNiOGQuLjQ2NTA5ZjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlck1JUFMuaApAQCAtOTkyLDYgKzk5MiwxMiBAQCBw dWJsaWM6CiAgICAgICAgIH0KICAgICB9CiAKKyAgICB2b2lkIHN0b3JlOChSZWdpc3RlcklEIHNy Yywgdm9pZCogYWRkcmVzcykKKyAgICB7CisgICAgICAgIG1vdmUoVHJ1c3RlZEltbVB0cihhZGRy ZXNzKSwgYWRkclRlbXBSZWdpc3Rlcik7CisgICAgICAgIG1fYXNzZW1ibGVyLnNiKGltbVRlbXBS ZWdpc3RlciwgYWRkclRlbXBSZWdpc3RlciwgMCk7CisgICAgfQorCiAgICAgdm9pZCBzdG9yZTgo VHJ1c3RlZEltbTMyIGltbSwgdm9pZCogYWRkcmVzcykKICAgICB7CiAgICAgICAgIC8qCkBAIC0y NzIzLDYgKzI3MjksMTEgQEAgcHVibGljOgogICAgICAgICBtX2Fzc2VtYmxlci5ub3AoKTsKICAg ICB9CiAKKyAgICB2b2lkIG1lbW9yeUZlbmNlKCkKKyAgICB7CisgICAgICAgIG1fYXNzZW1ibGVy LnN5bmMoKTsKKyAgICB9CisKICAgICBzdGF0aWMgRnVuY3Rpb25QdHIgcmVhZENhbGxUYXJnZXQo Q29kZUxvY2F0aW9uQ2FsbCBjYWxsKQogICAgIHsKICAgICAgICAgcmV0dXJuIEZ1bmN0aW9uUHRy KHJlaW50ZXJwcmV0X2Nhc3Q8dm9pZCgqKSgpPihNSVBTQXNzZW1ibGVyOjpyZWFkQ2FsbFRhcmdl dChjYWxsLmRhdGFMb2NhdGlvbigpKSkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRD b3JlL29mZmxpbmVhc20vbWlwcy5yYiBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNt L21pcHMucmIKaW5kZXggNjliOGViMS4uMTc4ZTdmNSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL29mZmxpbmVhc20vbWlwcy5yYgorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv b2ZmbGluZWFzbS9taXBzLnJiCkBAIC05MDUsNiArOTA1LDggQEAgY2xhc3MgSW5zdHJ1Y3Rpb24K ICAgICAgICAgd2hlbiAicGljaGRycmEiCiAgICAgICAgICAgICAkYXNtLnB1dFN0cigiT0ZGTElO RV9BU01fQ1BMT0FEKCQzMSkiKQogICAgICAgICAgICAgJGFzbS5wdXRzICJtb3ZlICRzNCwgJGdw IgorICAgICAgICB3aGVuICJtZW1mZW5jZSIKKyAgICAgICAgICAgICRhc20ucHV0cyAic3luYyIK ICAgICAgICAgZWxzZQogICAgICAgICAgICAgbG93ZXJEZWZhdWx0CiAgICAgICAgIGVuZAo= 217577 2013-11-21 09:39:10 -0800 2013-11-21 10:29:46 -0800 fixed patch. mem.diff text/plain 2663 kilvadyb ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDdkMGZiNWEuLmY3MjZlY2QgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTExLTIxICBCYWxhenMgS2lsdmFk eSAgPGtpbHZhZHliQGhvbWVqaW5uaS5jb20+CisKKyAgICAgICAgW01JUFNdIEJ1aWxkIGZhaWxz IHNpbmNlIHIxNTk1NDUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMjQ3MTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBBZGQgbWlzc2luZyBpbXBsZW1lbnRhdGlvbnMgaW4gTWFjcm9Bc3NlbWJsZXIgYW5k IExMSW50IGZvciBNSVBTLgorCisgICAgICAgICogYXNzZW1ibGVyL01JUFNBc3NlbWJsZXIuaDoK KyAgICAgICAgKEpTQzo6TUlQU0Fzc2VtYmxlcjo6c3luYyk6CisgICAgICAgICogYXNzZW1ibGVy L01hY3JvQXNzZW1ibGVyTUlQUy5oOgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2VtYmxlck1JUFM6 OnN0b3JlOCk6CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyTUlQUzo6bWVtb3J5RmVuY2Up OgorICAgICAgICAqIG9mZmxpbmVhc20vbWlwcy5yYjoKKwogMjAxMy0xMS0yMCAgTWFyayBMYW0g IDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgSW50cm9kdWNpbmcgVk1FbnRyeVNjb3Bl IHRvIHVwZGF0ZSB0aGUgVk0gc3RhY2sgbGltaXQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvYXNzZW1ibGVyL01JUFNBc3NlbWJsZXIuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9hc3NlbWJsZXIvTUlQU0Fzc2VtYmxlci5oCmluZGV4IDE4NGM0NmUuLmI3NWI0ZDAgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTUlQU0Fzc2VtYmxlci5oCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTUlQU0Fzc2VtYmxlci5oCkBAIC0x OTMsNiArMTkzLDExIEBAIHB1YmxpYzoKICAgICAgICAgZW1pdEluc3QoMHgwMDAwMDAwMCk7CiAg ICAgfQogCisgICAgdm9pZCBzeW5jKCkKKyAgICB7CisgICAgICAgIGVtaXRJbnN0KDB4MDAwMDAw MGYpOworICAgIH0KKwogICAgIC8qIE5lZWQgdG8gaW5zZXJ0IG9uZSBsb2FkIGRhdGEgZGVsYXkg bm9wIGZvciBtaXBzMS4gICovCiAgICAgdm9pZCBsb2FkRGVsYXlOb3AoKQogICAgIHsKZGlmZiAt LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBT LmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5o CmluZGV4IDdjNjNiOGQuLmE0NTI5ZWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlck1JUFMuaApAQCAtOTkyLDYgKzk5MiwxMiBAQCBw dWJsaWM6CiAgICAgICAgIH0KICAgICB9CiAKKyAgICB2b2lkIHN0b3JlOChSZWdpc3RlcklEIHNy Yywgdm9pZCogYWRkcmVzcykKKyAgICB7CisgICAgICAgIG1vdmUoVHJ1c3RlZEltbVB0cihhZGRy ZXNzKSwgYWRkclRlbXBSZWdpc3Rlcik7CisgICAgICAgIG1fYXNzZW1ibGVyLnNiKHNyYywgYWRk clRlbXBSZWdpc3RlciwgMCk7CisgICAgfQorCiAgICAgdm9pZCBzdG9yZTgoVHJ1c3RlZEltbTMy IGltbSwgdm9pZCogYWRkcmVzcykKICAgICB7CiAgICAgICAgIC8qCkBAIC0yNzIzLDYgKzI3Mjks MTEgQEAgcHVibGljOgogICAgICAgICBtX2Fzc2VtYmxlci5ub3AoKTsKICAgICB9CiAKKyAgICB2 b2lkIG1lbW9yeUZlbmNlKCkKKyAgICB7CisgICAgICAgIG1fYXNzZW1ibGVyLnN5bmMoKTsKKyAg ICB9CisKICAgICBzdGF0aWMgRnVuY3Rpb25QdHIgcmVhZENhbGxUYXJnZXQoQ29kZUxvY2F0aW9u Q2FsbCBjYWxsKQogICAgIHsKICAgICAgICAgcmV0dXJuIEZ1bmN0aW9uUHRyKHJlaW50ZXJwcmV0 X2Nhc3Q8dm9pZCgqKSgpPihNSVBTQXNzZW1ibGVyOjpyZWFkQ2FsbFRhcmdldChjYWxsLmRhdGFM b2NhdGlvbigpKSkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVh c20vbWlwcy5yYiBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL21pcHMucmIKaW5k ZXggNjliOGViMS4uMTc4ZTdmNSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL29m ZmxpbmVhc20vbWlwcy5yYgorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9t aXBzLnJiCkBAIC05MDUsNiArOTA1LDggQEAgY2xhc3MgSW5zdHJ1Y3Rpb24KICAgICAgICAgd2hl biAicGljaGRycmEiCiAgICAgICAgICAgICAkYXNtLnB1dFN0cigiT0ZGTElORV9BU01fQ1BMT0FE KCQzMSkiKQogICAgICAgICAgICAgJGFzbS5wdXRzICJtb3ZlICRzNCwgJGdwIgorICAgICAgICB3 aGVuICJtZW1mZW5jZSIKKyAgICAgICAgICAgICRhc20ucHV0cyAic3luYyIKICAgICAgICAgZWxz ZQogICAgICAgICAgICAgbG93ZXJEZWZhdWx0CiAgICAgICAgIGVuZAo=