124715 2013-11-21 07:08:12 -0800 [GStreamer] Invalid command line error when visiting www.chessbase.com 2013-11-27 02:45:21 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://www.chessbase.com P2 Normal --- 85994 1 svillar calvaris calvaris commit-queue eric.carlson glenn gustavo jer.noble menard mrobinson pnormand svillar vjaquez oldest_to_newest 953081 0 svillar 2013-11-21 07:08:12 -0800 Whenever I visit that page I get a popup window with this error: "gstreamer|1.0|WebKitWebProcess|decodificador text/html|decoder-text/html" because apparently there is a wrong parameter. 953847 1 217763 calvaris 2013-11-24 09:46:29 -0800 Created attachment 217763 Patch HTTP errors were not being handled at the GStreamer WebKit source 953907 2 217763 pnormand 2013-11-24 23:07:58 -0800 Comment on attachment 217763 Patch Hum, please talk to Andres, he has a patch for this code too. 953912 3 217763 calvaris 2013-11-25 00:51:03 -0800 Comment on attachment 217763 Patch There's a problem with the comment. 954024 4 217814 calvaris 2013-11-25 09:25:32 -0800 Created attachment 217814 Patch Rebased 954029 5 217814 svillar 2013-11-25 09:37:17 -0800 Comment on attachment 217814 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217814&action=review I guess this won't be accepted without a test case. > Source/WebCore/ChangeLog:5 > + You used an incorrect bug number to create this patch > Source/WebCore/ChangeLog:7 > + Short explanation missing here. > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:847 > + Don't know a lot about GStreamer but shouldn't this be protected by the locker? Also looks like the error handling code is exactly the same as the one bellow that handles invald partial respones (!= 206). Could it be possible to refactor it in some function or macro? 954033 6 calvaris 2013-11-25 09:59:52 -0800 (In reply to comment #5) > (From update of attachment 217814 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=217814&action=review > > I guess this won't be accepted without a test case. It is very port specific, writing a test for this and flagging it everywhere that is not gstreamer port feels wrong, specially because this is not a new feature. > > Source/WebCore/ChangeLog:5 > > + > > You used an incorrect bug number to create this patch Roger. > > Source/WebCore/ChangeLog:7 > > + > > Short explanation missing here. Roger. > > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:847 > > + > > Don't know a lot about GStreamer but shouldn't this be protected by the locker? Well, I considered that, but we would lock, check the response code and then unlock. I don't think it is necessary, though maybe Phil thinks otherwise. > Also looks like the error handling code is exactly the same as the one bellow that handles invald partial respones (!= 206). Could it be possible to refactor it in some function or macro? I though about it but as we have that locker, that I didn't have the intention to use, that is a stack variable, I would have to pass it and I though it wasn't worth, or writing a macro. 954279 7 217882 calvaris 2013-11-26 09:29:10 -0800 Created attachment 217882 Patch Added test. It doesn't fail either because it doesn't play either though for a different reason. 954280 8 calvaris 2013-11-26 09:31:03 -0800 (In reply to comment #6) > > I guess this won't be accepted without a test case. > > It is very port specific, writing a test for this and flagging it everywhere that is not gstreamer port feels wrong, specially because this is not a new feature. Now that I think about it, I could use the internals to know the reason of the failure and check if it is the right one, but it seems overkilling to me. 954486 9 217882 commit-queue 2013-11-27 02:45:18 -0800 Comment on attachment 217882 Patch Clearing flags on attachment: 217882 Committed r159810: <http://trac.webkit.org/changeset/159810> 954487 10 commit-queue 2013-11-27 02:45:21 -0800 All reviewed patches have been landed. Closing bug. 217763 2013-11-24 09:46:29 -0800 2013-11-25 09:25:27 -0800 Patch bug-124715-20131124184628.patch text/plain 1897 calvaris U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5NzMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDU1OWU4MWZhZWZiMjRi MzQwZWRjMTM2OWNiMzVlZDhmZTliNzVjOC4uYjdhYTM2NTQ1ZDBjOGQxOTBkNGE0OWQ1YWU5NzZl ZjEyOGVmNTZlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTExLTI0ICBYYWJp ZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dT dHJlYW1lcl0gSW52YWxpZCBjb21tYW5kIGxpbmUgZXJyb3Igd2hlbiB2aXNpdGluZyB3d3cuY2hl c3NiYXNlLmNvbQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTI0NzE1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0V2ViU291cmNlR1N0cmVhbWVy LmNwcDoKKyAgICAgICAgKFN0cmVhbWluZ0NsaWVudDo6aGFuZGxlUmVzcG9uc2VSZWNlaXZlZCk6 IEhUVFAgZXJyb3JzIGhhbmRsZWQgYW5kCisgICAgICAgIHJhaXNlZCBhIGdzdCBlcnJvciBpbiB0 aGUgZ3N0IHNvdXJjZS4KKwogMjAxMy0xMS0yMyAgWGFiaWVyIFJvZHJpZ3VleiBDYWx2YXIgIDxj YWx2YXJpc0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHU3RyZWFtZXJdIFJlbW92ZSAwLjEwIGNv ZGVwYXRoCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3Ry ZWFtZXIvV2ViS2l0V2ViU291cmNlR1N0cmVhbWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIuY3BwCmluZGV4 IGZmMTg4OWE1ZTczNzViZjExY2YwMTIzN2JlMzNlZTllMjA3MzU5ODIuLjA3MGVjZTQzNDViODA2 YzllZGY0NjYyMzRjNTIwYmUwOWRjZTFmYzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJT b3VyY2VHU3RyZWFtZXIuY3BwCkBAIC04NDAsOSArODQwLDkgQEAgdm9pZCBTdHJlYW1pbmdDbGll bnQ6OmhhbmRsZVJlc3BvbnNlUmVjZWl2ZWQoY29uc3QgUmVzb3VyY2VSZXNwb25zZSYgcmVzcG9u c2UpCiAgICAgR011dGV4TG9ja2VyIGxvY2tlcihHU1RfT0JKRUNUX0dFVF9MT0NLKHNyYykpOwog CiAgICAgLy8gSWYgd2Ugc2Vla2VkIHdlIG5lZWQgMjA2ID09IFBBUlRJQUxfQ09OVEVOVAotICAg IGlmIChwcml2LT5yZXF1ZXN0ZWRPZmZzZXQgJiYgcmVzcG9uc2UuaHR0cFN0YXR1c0NvZGUoKSAh PSAyMDYpIHsKKyAgICBpZiAocmVzcG9uc2UuaHR0cFN0YXR1c0NvZGUoKSA+PSA0MDAgfHwgKHBy aXYtPnJlcXVlc3RlZE9mZnNldCAmJiByZXNwb25zZS5odHRwU3RhdHVzQ29kZSgpICE9IDIwNikp IHsKICAgICAgICAgbG9ja2VyLnVubG9jaygpOwotICAgICAgICBHU1RfRUxFTUVOVF9FUlJPUihz cmMsIFJFU09VUkNFLCBSRUFELCAoMCksICgwKSk7CisgICAgICAgIEdTVF9FTEVNRU5UX0VSUk9S KHNyYywgUkVTT1VSQ0UsIFJFQUQsICgiUmVjZWl2ZWQgJWQgSFRUUCBlcnJvciBjb2RlIiwgcmVz cG9uc2UuaHR0cFN0YXR1c0NvZGUoKSksICgwKSk7CiAgICAgICAgIGdzdF9hcHBfc3JjX2VuZF9v Zl9zdHJlYW0ocHJpdi0+YXBwc3JjKTsKICAgICAgICAgd2ViS2l0V2ViU3JjU3RvcChzcmMpOwog ICAgICAgICByZXR1cm47Cg== 217814 2013-11-25 09:25:32 -0800 2013-11-26 09:29:05 -0800 Patch bug-124715-20131125182531.patch text/plain 1757 calvaris U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5NzQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTFjNzMzZjcxNmIxYTc2 YzRlNDYxZmI4M2IzYzg1OWJhNDkxYzQ0OC4uYTc4NWQ0MzdhM2M4ZjcwZTYyMWY3MGI2ODkwMWFm NWYwY2Y3MGRjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEzLTExLTI1ICBYYWJp ZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dT dHJlYW1lcl0gUmVtb3ZlIDAuMTAgY29kZXBhdGgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDcxNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktp dFdlYlNvdXJjZUdTdHJlYW1lci5jcHA6CisgICAgICAgIChTdHJlYW1pbmdDbGllbnQ6OmhhbmRs ZVJlc3BvbnNlUmVjZWl2ZWQpOiBIVFRQIGVycm9ycyBoYW5kbGVkIGFuZAorICAgICAgICByYWlz ZWQgYSBnc3QgZXJyb3IgaW4gdGhlIGdzdCBzb3VyY2UuCisKIDIwMTMtMTEtMjUgIExhc3psbyBW aWRhY3MgIDxsYWNAaW5mLnUtc3plZ2VkLmh1PgogCiAgICAgICAgIFZlcnRpY2FsIGJvcmRlciBz cGFjaW5nIGlzIGRvdWJsZWQgYmV0d2VlbiB0YWJsZSByb3cgZ3JvdXBzCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0V2ViU291cmNl R1N0cmVhbWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1l ci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIuY3BwCmluZGV4IGE5NDQ5MzNmMWVhZGUzZDgwZDg1 MTUzNmM4ZjFhMjA3MmQwMDBmZDQuLmFmNzhhZTAwZGM5ZmI5MzJkNTNjZGQ4OWM0MzkzYTQyYzU3 MDg3ZTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJl YW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIuY3BwCkBA IC04MzcsNiArODM3LDE0IEBAIHZvaWQgU3RyZWFtaW5nQ2xpZW50OjpoYW5kbGVSZXNwb25zZVJl Y2VpdmVkKGNvbnN0IFJlc291cmNlUmVzcG9uc2UmIHJlc3BvbnNlKQogCiAgICAgR1NUX0RFQlVH X09CSkVDVChzcmMsICJSZWNlaXZlZCByZXNwb25zZTogJWQiLCByZXNwb25zZS5odHRwU3RhdHVz Q29kZSgpKTsKIAorICAgIGlmIChyZXNwb25zZS5odHRwU3RhdHVzQ29kZSgpID49IDQwMCkgewor ICAgICAgICAvLyBSZWNlaXZlZCBlcnJvciBjb2RlCisgICAgICAgIEdTVF9FTEVNRU5UX0VSUk9S KHNyYywgUkVTT1VSQ0UsIFJFQUQsICgiUmVjZWl2ZWQgJWQgSFRUUCBlcnJvciBjb2RlIiwgcmVz cG9uc2UuaHR0cFN0YXR1c0NvZGUoKSksICgwKSk7CisgICAgICAgIGdzdF9hcHBfc3JjX2VuZF9v Zl9zdHJlYW0ocHJpdi0+YXBwc3JjKTsKKyAgICAgICAgd2ViS2l0V2ViU3JjU3RvcChzcmMpOwor ICAgICAgICByZXR1cm47CisgICAgfQorCiAgICAgR011dGV4TG9ja2VyIGxvY2tlcihHU1RfT0JK RUNUX0dFVF9MT0NLKHNyYykpOwogCiAgICAgaWYgKHByaXYtPnNlZWtJRCkgewo= 217882 2013-11-26 09:29:10 -0800 2013-11-27 02:45:18 -0800 Patch bug-124715-20131126182908.patch text/plain 5247 calvaris U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5NzQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTFjNzMzZjcxNmIxYTc2 YzRlNDYxZmI4M2IzYzg1OWJhNDkxYzQ0OC4uZmM4Y2Q5YWE0OTJjZGJkYjQwZjJiZGVkNjYxNjhi YmQxMWU2NTg0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTExLTI2ICBYYWJp ZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dT dHJlYW1lcl0gSW52YWxpZCBjb21tYW5kIGxpbmUgZXJyb3Igd2hlbiB2aXNpdGluZyB3d3cuY2hl c3NiYXNlLmNvbQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTI0NzE1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgV2Ugd2VyZSBub3QgaGFuZGxpbmcgdGhlIEhUVFAgZXJyb3JzIGluIHRoZSBXZWJLaXQgR1N0 cmVhbWVyCisgICAgICAgIHNvdXJjZSBhbmQgdGhlcmVmb3JlIHRoZSA0MDQgZXJyb3IgcGFnZSB3 YXMgYmVpbmcgJ2RlY29kZWQnLiBBcyBubworICAgICAgICBkZWNvZGVyIGNvdWxkIGJlIGZvdW5k IChmb3Igb2J2aW91cyByZWFzb25zKSwgcGxheWJhY2sgZmFpbGVkLCBidXQKKyAgICAgICAgaXQg c2hvdWxkIGJlIGZhaWxpbmcgZm9yIHRoZSBzb3VyY2Ugbm90IGJlaW5nIGZvdW5kIGluc3RlYWQg b2YgdGhlCisgICAgICAgIGRlY29kaW5nIHByb2JsZW0uCisKKyAgICAgICAgVGVzdDogaHR0cC90 ZXN0cy9tZWRpYS92aWRlby1lcnJvci1kb2VzLW5vdC1leGlzdC5odG1sCisKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0V2ViU291cmNlR1N0cmVhbWVyLmNwcDoK KyAgICAgICAgKFN0cmVhbWluZ0NsaWVudDo6aGFuZGxlUmVzcG9uc2VSZWNlaXZlZCk6IEhhbmRs ZSBIVFRQIGVycm9ycyBpbgorICAgICAgICB0aGUgc291cmNlIGFuZCByYWlzZSBhIEdTdHJlYW1l ciBlcnJvciB0byB0aGUgcGlwZWxpbmUuCisKIDIwMTMtMTEtMjUgIExhc3psbyBWaWRhY3MgIDxs YWNAaW5mLnUtc3plZ2VkLmh1PgogCiAgICAgICAgIFZlcnRpY2FsIGJvcmRlciBzcGFjaW5nIGlz IGRvdWJsZWQgYmV0d2VlbiB0YWJsZSByb3cgZ3JvdXBzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0V2ViU291cmNlR1N0cmVhbWVy LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRX ZWJTb3VyY2VHU3RyZWFtZXIuY3BwCmluZGV4IGE5NDQ5MzNmMWVhZGUzZDgwZDg1MTUzNmM4ZjFh MjA3MmQwMDBmZDQuLmFmNzhhZTAwZGM5ZmI5MzJkNTNjZGQ4OWM0MzkzYTQyYzU3MDg3ZTAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJL aXRXZWJTb3VyY2VHU3RyZWFtZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIuY3BwCkBAIC04MzcsNiAr ODM3LDE0IEBAIHZvaWQgU3RyZWFtaW5nQ2xpZW50OjpoYW5kbGVSZXNwb25zZVJlY2VpdmVkKGNv bnN0IFJlc291cmNlUmVzcG9uc2UmIHJlc3BvbnNlKQogCiAgICAgR1NUX0RFQlVHX09CSkVDVChz cmMsICJSZWNlaXZlZCByZXNwb25zZTogJWQiLCByZXNwb25zZS5odHRwU3RhdHVzQ29kZSgpKTsK IAorICAgIGlmIChyZXNwb25zZS5odHRwU3RhdHVzQ29kZSgpID49IDQwMCkgeworICAgICAgICAv LyBSZWNlaXZlZCBlcnJvciBjb2RlCisgICAgICAgIEdTVF9FTEVNRU5UX0VSUk9SKHNyYywgUkVT T1VSQ0UsIFJFQUQsICgiUmVjZWl2ZWQgJWQgSFRUUCBlcnJvciBjb2RlIiwgcmVzcG9uc2UuaHR0 cFN0YXR1c0NvZGUoKSksICgwKSk7CisgICAgICAgIGdzdF9hcHBfc3JjX2VuZF9vZl9zdHJlYW0o cHJpdi0+YXBwc3JjKTsKKyAgICAgICAgd2ViS2l0V2ViU3JjU3RvcChzcmMpOworICAgICAgICBy ZXR1cm47CisgICAgfQorCiAgICAgR011dGV4TG9ja2VyIGxvY2tlcihHU1RfT0JKRUNUX0dFVF9M T0NLKHNyYykpOwogCiAgICAgaWYgKHByaXYtPnNlZWtJRCkgewpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDg3Y2Q4N2RhZThh MDY4MTAwZjZkZjc0MTdhOTgyNTQ2MTc4ZjRiZDcuLmM5ODU5NjE0YWRmYjcyMjUzZTllYzU0NTU1 YjAxOTYxZjJiYmYzYjQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMy0xMS0yNiAgWGFiaWVy IFJvZHJpZ3VleiBDYWx2YXIgIDxjYWx2YXJpc0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtHU3Ry ZWFtZXJdIEludmFsaWQgY29tbWFuZCBsaW5lIGVycm9yIHdoZW4gdmlzaXRpbmcgd3d3LmNoZXNz YmFzZS5jb20KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEyNDcxNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IENvcGllZCBhbmQgYWRhcHRlZCBmb3IgSFRUUCBmcm9tCisgICAgICAgIG1lZGlhL3ZpZGVvLWVy cm9yLWRvZXMtbm90LWV4aXN0Lmh0bWwuCisKKyAgICAgICAgKiBodHRwL3Rlc3RzL21lZGlhL3Zp ZGVvLWVycm9yLWRvZXMtbm90LWV4aXN0LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICog aHR0cC90ZXN0cy9tZWRpYS92aWRlby1lcnJvci1kb2VzLW5vdC1leGlzdC5odG1sOiBBZGRlZC4K KwogMjAxMy0xMS0yNSAgTGFzemxvIFZpZGFjcyAgPGxhY0BpbmYudS1zemVnZWQuaHU+CiAKICAg ICAgICAgVmVydGljYWwgYm9yZGVyIHNwYWNpbmcgaXMgZG91YmxlZCBiZXR3ZWVuIHRhYmxlIHJv dyBncm91cHMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbWVkaWEvdmlkZW8t ZXJyb3ItZG9lcy1ub3QtZXhpc3QtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0 cy9tZWRpYS92aWRlby1lcnJvci1kb2VzLW5vdC1leGlzdC1leHBlY3RlZC50eHQKbmV3IGZpbGUg bW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MC4uMTlkYzEyOTM1YzlhZTg1ODA5MGUwMWJlMTY2N2M5MDU3N2I3ZmJkZgotLS0gL2Rldi9udWxs CisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbWVkaWEvdmlkZW8tZXJyb3ItZG9lcy1ub3Qt ZXhpc3QtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTcgQEAKK1Rlc3QgdGhhdCB0aGUgbWVkaWEg ZWxlbWVudCBpcyBpbiBjb3JyZWN0IHN0YXRlIGFmdGVyIGxvYWQgZmFpbHMgZnJvbSBIVFRQLgor CisKKworRVhQRUNURUQgKHZpZGVvLmVycm9yID09ICdudWxsJykgT0sKKworRVZFTlQoZXJyb3Ip CitFWFBFQ1RFRCAodmlkZW8uZXJyb3IgIT0gJ251bGwnKSBPSworRVhQRUNURUQgKHZpZGVvLmVy cm9yLmNvZGUgPT0gJzQnKSBPSworRVhQRUNURUQgKHZpZGVvLm5ldHdvcmtTdGF0ZSA9PSAnMycp IE9LCitFWFBFQ1RFRCAoaXNOYU4odmlkZW8uZHVyYXRpb24pID09ICd0cnVlJykgT0sKK0VYUEVD VEVEICh2aWRlby5jdXJyZW50VGltZSA9PSAnMCcpIE9LCitFWFBFQ1RFRCAodmlkZW8uYnVmZmVy ZWQubGVuZ3RoID09ICcwJykgT0sKK0VYUEVDVEVEICh2aWRlby5zZWVrYWJsZS5sZW5ndGggPT0g JzAnKSBPSworRVhQRUNURUQgKHZpZGVvLmJ1ZmZlcmVkLmxlbmd0aCA9PSAnMCcpIE9LCitFTkQg T0YgVEVTVAorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21lZGlhL3ZpZGVv LWVycm9yLWRvZXMtbm90LWV4aXN0Lmh0bWwgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21lZGlh L3ZpZGVvLWVycm9yLWRvZXMtbm90LWV4aXN0Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYTQwMjNhNTFhMTIw M2I1ZDJmMGIyNjUzNzA5NWI3MWQzNDcxZjk1OQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRl c3RzL2h0dHAvdGVzdHMvbWVkaWEvdmlkZW8tZXJyb3ItZG9lcy1ub3QtZXhpc3QuaHRtbApAQCAt MCwwICsxLDI4IEBACis8cD5UZXN0IHRoYXQgdGhlIG1lZGlhIGVsZW1lbnQgaXMgaW4gY29ycmVj dCBzdGF0ZSBhZnRlciBsb2FkIGZhaWxzIGZyb20gSFRUUC48L3A+Cis8dmlkZW8gY29udHJvbHM+ PC92aWRlbz4KKzxzY3JpcHQgc3JjPS4uLy4uL21lZGlhLXJlc291cmNlcy92aWRlby10ZXN0Lmpz Pjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Li4vLi4vbWVkaWEtcmVzb3VyY2VzL21lZGlhLWZpbGUu anM+PC9zY3JpcHQ+Cis8c2NyaXB0PgorCisgICAgY29uc29sZVdyaXRlKCIiKTsKKyAgICB0ZXN0 RXhwZWN0ZWQoInZpZGVvLmVycm9yIiwgbnVsbCk7CisKKyAgICB3YWl0Rm9yRXZlbnRBbmRUZXN0 KCJjYW5wbGF5dGhyb3VnaCIsICJmYWxzZSIpOworICAgIAorICAgIHdhaXRGb3JFdmVudCgiZXJy b3IiLCBmdW5jdGlvbiAoKSB7CisgICAgICAgIHRlc3RFeHBlY3RlZCgidmlkZW8uZXJyb3IiLCBu dWxsLCAiIT0iKTsKKyAgICAgICAgdGVzdEV4cGVjdGVkKCJ2aWRlby5lcnJvci5jb2RlIiwgTWVk aWFFcnJvci5NRURJQV9FUlJfU1JDX05PVF9TVVBQT1JURUQpOworICAgIAorICAgICAgICB0ZXN0 RXhwZWN0ZWQoInZpZGVvLm5ldHdvcmtTdGF0ZSIsIEhUTUxNZWRpYUVsZW1lbnQuTkVUV09SS19O T19TT1VSQ0UpOworICAgIAorICAgICAgICB0ZXN0RXhwZWN0ZWQoImlzTmFOKHZpZGVvLmR1cmF0 aW9uKSIsIHRydWUpOworICAgICAgICB0ZXN0RXhwZWN0ZWQoInZpZGVvLmN1cnJlbnRUaW1lIiwg MCk7CisgICAgICAgIHRlc3RFeHBlY3RlZCgidmlkZW8uYnVmZmVyZWQubGVuZ3RoIiwgMCk7Cisg ICAgICAgIHRlc3RFeHBlY3RlZCgidmlkZW8uc2Vla2FibGUubGVuZ3RoIiwgMCk7CisgICAgICAg IHRlc3RFeHBlY3RlZCgidmlkZW8uYnVmZmVyZWQubGVuZ3RoIiwgMCk7CisgICAgICAgIGVuZFRl c3QoKTsKKyAgICB9KTsKKyAgICAKKyAgICB2aWRlby5zcmMgPSAiaHR0cDovLzEyNy4wLjAuMTo4 MDAwL2RvZXMtbm90LWV4aXN0Lm1wZWciOworICAgIGNvbnNvbGVXcml0ZSgiIik7Cis8L3Njcmlw dD4K