124713 2013-11-21 06:20:24 -0800 [sh4] Build fails since r159545 2013-11-21 09:09:14 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jbriance webkit-unassigned commit-queue msaboff oldest_to_newest 953060 0 jbriance 2013-11-21 06:20:24 -0800 The "memfence" opcode is missing from LLINT and the following implementations are missing from macro assembler since r159545 for sh4 architecture: - void memoryFence() - void load8(const void*, RegisterID) - void store8(RegisterID, const void*) 953063 1 217557 jbriance 2013-11-21 06:30:09 -0800 Created attachment 217557 Add missing implementations in macro assembler and LLINT for sh4. 953064 2 commit-queue 2013-11-21 06:31:33 -0800 Attachment 217557 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/assembler/MacroAssemblerSH4.h', u'Source/JavaScriptCore/assembler/SH4Assembler.h', u'Source/JavaScriptCore/offlineasm/sh4.rb']" exit_code: 1 Source/JavaScriptCore/assembler/SH4Assembler.h:185: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 953119 3 217557 commit-queue 2013-11-21 09:09:11 -0800 Comment on attachment 217557 Add missing implementations in macro assembler and LLINT for sh4. Clearing flags on attachment: 217557 Committed r159629: <http://trac.webkit.org/changeset/159629> 953120 4 commit-queue 2013-11-21 09:09:14 -0800 All reviewed patches have been landed. Closing bug. 217557 2013-11-21 06:30:09 -0800 2013-11-21 09:09:11 -0800 Add missing implementations in macro assembler and LLINT for sh4. bug-124713.patch text/plain 3445 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU5NjIwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDEzLTExLTIxICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgorCisg ICAgICAgIEZpeCBzaDQgYnVpbGQgYWZ0ZXIgcjE1OTU0NS4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDcxMworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBtaXNzaW5nIGltcGxlbWVudGF0aW9ucyBp biBtYWNybyBhc3NlbWJsZXIgYW5kIExMSU5UIGZvciBzaDQuCisKKyAgICAgICAgKiBhc3NlbWJs ZXIvTWFjcm9Bc3NlbWJsZXJTSDQuaDoKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJTSDQ6 OmxvYWQ4KToKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJTSDQ6OnN0b3JlOCk6CisgICAg ICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyU0g0OjptZW1vcnlGZW5jZSk6CisgICAgICAgICogYXNz ZW1ibGVyL1NINEFzc2VtYmxlci5oOgorICAgICAgICAoSlNDOjpTSDRBc3NlbWJsZXI6OnN5bmNv KToKKyAgICAgICAgKiBvZmZsaW5lYXNtL3NoNC5yYjogSGFuZGxlICJtZW1mZW5jZSIgb3Bjb2Rl LgorCiAyMDEzLTExLTIwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAg ICBJbnRyb2R1Y2luZyBWTUVudHJ5U2NvcGUgdG8gdXBkYXRlIHRoZSBWTSBzdGFjayBsaW1pdC4K SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJTSDQu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNz ZW1ibGVyU0g0LmgJKHJldmlzaW9uIDE1OTYxMykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9h c3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJTSDQuaAkod29ya2luZyBjb3B5KQpAQCAtNzA3LDYgKzcw NywxMSBAQCBwdWJsaWM6CiAgICAgICAgIG1fYXNzZW1ibGVyLmV4dHViKGRlc3QsIGRlc3QpOwog ICAgIH0KIAorICAgIHZvaWQgbG9hZDgoY29uc3Qgdm9pZCogYWRkcmVzcywgUmVnaXN0ZXJJRCBk ZXN0KQorICAgIHsKKyAgICAgICAgbG9hZDgoQWJzb2x1dGVBZGRyZXNzKGFkZHJlc3MpLCBkZXN0 KTsKKyAgICB9CisKICAgICB2b2lkIGxvYWQ4UG9zdEluYyhSZWdpc3RlcklEIGJhc2UsIFJlZ2lz dGVySUQgZGVzdCkKICAgICB7CiAgICAgICAgIG1fYXNzZW1ibGVyLm1vdmJNZW1SZWdJbihiYXNl LCBkZXN0KTsKQEAgLTkwNiw2ICs5MTEsMTQgQEAgcHVibGljOgogICAgICAgICByZWxlYXNlU2Ny YXRjaChzY3IpOwogICAgIH0KIAorICAgIHZvaWQgc3RvcmU4KFJlZ2lzdGVySUQgc3JjLCB2b2lk KiBhZGRyZXNzKQorICAgIHsKKyAgICAgICAgUmVnaXN0ZXJJRCBkZXN0cHRyID0gY2xhaW1TY3Jh dGNoKCk7CisgICAgICAgIG1vdmUoVHJ1c3RlZEltbVB0cihhZGRyZXNzKSwgZGVzdHB0cik7Cisg ICAgICAgIG1fYXNzZW1ibGVyLm1vdmJSZWdNZW0oc3JjLCBkZXN0cHRyKTsKKyAgICAgICAgcmVs ZWFzZVNjcmF0Y2goZGVzdHB0cik7CisgICAgfQorCiAgICAgdm9pZCBzdG9yZTgoVHJ1c3RlZElt bTMyIGltbSwgdm9pZCogYWRkcmVzcykKICAgICB7CiAgICAgICAgIEFTU0VSVCgoaW1tLm1fdmFs dWUgPj0gLTEyOCkgJiYgKGltbS5tX3ZhbHVlIDw9IDEyNykpOwpAQCAtMjQzOSw2ICsyNDUyLDEx IEBAIHB1YmxpYzoKICAgICAgICAgbV9hc3NlbWJsZXIubm9wKCk7CiAgICAgfQogCisgICAgdm9p ZCBtZW1vcnlGZW5jZSgpCisgICAgeworICAgICAgICBtX2Fzc2VtYmxlci5zeW5jbygpOworICAg IH0KKwogICAgIHN0YXRpYyBGdW5jdGlvblB0ciByZWFkQ2FsbFRhcmdldChDb2RlTG9jYXRpb25D YWxsIGNhbGwpCiAgICAgewogICAgICAgICByZXR1cm4gRnVuY3Rpb25QdHIocmVpbnRlcnByZXRf Y2FzdDx2b2lkKCopKCk+KFNINEFzc2VtYmxlcjo6cmVhZENhbGxUYXJnZXQoY2FsbC5kYXRhTG9j YXRpb24oKSkpKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvU0g0QXNz ZW1ibGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9T SDRBc3NlbWJsZXIuaAkocmV2aXNpb24gMTU5NjEzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L2Fzc2VtYmxlci9TSDRBc3NlbWJsZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMTgyLDYgKzE4Miw3 IEBAIGVudW0gewogICAgIEZTUVJUX09QQ09ERSA9IDB4ZjA2ZCwKICAgICBGU0NIR19PUENPREUg PSAweGYzZmQsCiAgICAgQ0xSVF9PUENPREUgPSA4LAorICAgIFNZTkNPX09QQ09ERSA9IDB4MDBh YiwKIH07CiAKIG5hbWVzcGFjZSBTSDRSZWdpc3RlcnMgewpAQCAtNzIwLDYgKzcyMSwxMSBAQCBw dWJsaWM6CiAgICAgICAgIG9uZVNob3J0T3AoTk9QX09QQ09ERSwgZmFsc2UpOwogICAgIH0KIAor ICAgIHZvaWQgc3luY28oKQorICAgIHsKKyAgICAgICAgb25lU2hvcnRPcChTWU5DT19PUENPREUp OworICAgIH0KKwogICAgIHZvaWQgc2V0dCgpCiAgICAgewogICAgICAgICBvbmVTaG9ydE9wKFNF VFRfT1BDT0RFKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL3NoNC5y Ygo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9zaDQucmIJ KHJldmlzaW9uIDE1OTYxMykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL3No NC5yYgkod29ya2luZyBjb3B5KQpAQCAtMTAzNyw2ICsxMDM3LDggQEAgY2xhc3MgSW5zdHJ1Y3Rp b24KICAgICAgICAgICAgICRhc20ucHV0cyAibGRzICN7c2g0T3BlcmFuZHMob3BlcmFuZHMpfSwg cHIiCiAgICAgICAgIHdoZW4gInN0c3ByIgogICAgICAgICAgICAgJGFzbS5wdXRzICJzdHMgcHIs ICN7c2g0T3BlcmFuZHMob3BlcmFuZHMpfSIKKyAgICAgICAgd2hlbiAibWVtZmVuY2UiCisgICAg ICAgICAgICAkYXNtLnB1dHMgInN5bmNvIgogICAgICAgICB3aGVuICJwb3BDYWxsZWVTYXZlcyIK ICAgICAgICAgICAgICRhc20ucHV0cyAibW92LmwgQHIxNSssIHI4IgogICAgICAgICAgICAgJGFz bS5wdXRzICJtb3YubCBAcjE1KywgcjkiCg==