124704 2013-11-21 01:44:28 -0800 Fix WinCairo unreachable code warnings in SimpleLineLayout.cpp 2013-11-21 18:57:22 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 lvidacs.u-szeged webkit-unassigned commit-queue esprehn+autocc galpeter glenn koivisto kondapallykalyan ossy oldest_to_newest 952993 0 lvidacs.u-szeged 2013-11-21 01:44:28 -0800 Early return causes unreachable code warnings on specific platforms. http://build.webkit.org/builders/WinCairo%20Release/builds/33430/steps/compile-webkit/logs/stdio 952998 1 217535 lvidacs.u-szeged 2013-11-21 01:51:37 -0800 Created attachment 217535 Patch 953130 2 217535 koivisto 2013-11-21 09:28:31 -0800 Comment on attachment 217535 Patch You should fix the warning settings instead. 953138 3 ossy 2013-11-21 09:36:12 -0800 (In reply to comment #2) > (From update of attachment 217535 [details]) > You should fix the warning settings instead. Do you really prefer ignoring unreachable code warnings instead of getting rid the unreachable codes from the source with proper guarding? I don't think if it is a good idea. 953267 4 koivisto 2013-11-21 13:20:57 -0800 One port using different warning settings than every other port just creates churn. 953269 5 ossy 2013-11-21 13:30:02 -0800 (In reply to comment #4) > One port using different warning settings than every other port just creates churn. It's not a about warning settings. There is an ifdef guard: "#if !PLATFORM(MAC) && !PLATFORM(GTK) && !PLATFORM(EFL)" with early return. After the #endif everything is unreachable code on all platform which is not Mac, GTK and EFL. Unreachable code is unreachable code and not warning setting. 953308 6 217535 koivisto 2013-11-21 14:34:17 -0800 Comment on attachment 217535 Patch Ok ok. The real solution here is to remove the whole ifdef and fix the 8bit run issues. That should really be done by people maintaining these platforms. 953397 7 217535 commit-queue 2013-11-21 18:57:20 -0800 Comment on attachment 217535 Patch Clearing flags on attachment: 217535 Committed r159666: <http://trac.webkit.org/changeset/159666> 953398 8 commit-queue 2013-11-21 18:57:22 -0800 All reviewed patches have been landed. Closing bug. 217535 2013-11-21 01:51:37 -0800 2013-11-21 18:57:19 -0800 Patch bug-124704-20131121105135.patch text/plain 1587 lvidacs.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5NTc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWU5YmNiMmQ1YjEzZWZk NzUzMDNmOWY4M2UxMGY2OGZhNTc0NmIxZS4uNjI4NjNkMzEzZDZlMjE1YzY1MGJkNjhjZTMxNWRh YWExZGEzZjJiNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTExLTIxICBMYXN6 bG8gVmlkYWNzICA8bGFjQGluZi51LXN6ZWdlZC5odT4KKworICAgICAgICBGaXggV2luQ2Fpcm8g dW5yZWFjaGFibGUgY29kZSB3YXJuaW5ncyBpbiBTaW1wbGVMaW5lTGF5b3V0LmNwcAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI0NzA0CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IHVucmVhY2hhYmxl IGNvZGUgd2FybmluZ3MgdXNpbmcgY29uZGl0aW9uYWwgZGlyZWN0aXZlcy4KKworICAgICAgICAq IHJlbmRlcmluZy9TaW1wbGVMaW5lTGF5b3V0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNpbXBs ZUxpbmVMYXlvdXQ6OmNhblVzZUZvcik6CisKIDIwMTMtMTEtMjAgIFJvYmVydCBIb2dhbiAgPHJv YmVydEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjEyNzE2Myk6IFJlc3BlY3Qg Y2xlYXJhbmNlIHNldCBvbiBhbmNlc3RvcnMgd2hlbiBwbGFjaW5nIGZsb2F0cwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1NpbXBsZUxpbmVMYXlvdXQuY3BwIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1NpbXBsZUxpbmVMYXlvdXQuY3BwCmluZGV4IDcyMGQxZDMwOWU1 MGE2ZDA2N2RiMGU0MTgxZmM2ZGJjYTIzZjcxYmQuLjBlMDgyZmRlNTJkY2U2ZDAwZjc2NTA4NjIz ODBlMzJiMzgyZTBjYmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9TaW1w bGVMaW5lTGF5b3V0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvU2ltcGxlTGlu ZUxheW91dC5jcHAKQEAgLTk0LDcgKzk0LDcgQEAgYm9vbCBjYW5Vc2VGb3IoY29uc3QgUmVuZGVy QmxvY2tGbG93JiBmbG93KQogICAgIC8vIEZJWE1FOiBOb24tbWFjIHBsYXRmb3JtcyBhcmUgaGl0 dGluZyBBU1NFUlQocnVuLmNoYXJhY3RlcnNMZW5ndGgoKSA+PSBydW4ubGVuZ3RoKCkpCiAgICAg Ly8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMzMzOAogICAgIHJl dHVybiBmYWxzZTsKLSNlbmRpZgorI2Vsc2UKICAgICBpZiAoIWZsb3cuZnJhbWUoKS5zZXR0aW5n cygpLnNpbXBsZUxpbmVMYXlvdXRFbmFibGVkKCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAg ICBpZiAoIWZsb3cuZmlyc3RDaGlsZCgpKQpAQCAtMjAxLDYgKzIwMSw3IEBAIGJvb2wgY2FuVXNl Rm9yKGNvbnN0IFJlbmRlckJsb2NrRmxvdyYgZmxvdykKICAgICAgICAgcmV0dXJuIGZhbHNlOwog CiAgICAgcmV0dXJuIHRydWU7CisjZW5kaWYKIH0KIAogc3RydWN0IFN0eWxlIHsK