124697 2013-11-20 22:06:24 -0800 REGRESSION(r159599): webkitdirs.pm spits out warnings at lines 851 and 852 2013-11-21 06:39:19 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Regression P1 Normal --- 124581 1 rniwa rego commit-queue dbates eocanha nick.diego rego oldest_to_newest 952938 0 rniwa 2013-11-20 22:06:24 -0800 After http://trac.webkit.org/changeset/159599, I'm getting errors like the one below everywhere: server:git-webkit rniwa$ Tools/Scripts/run-webkit-tests --debug LayoutTests/fast/dom LayoutTests/fast/html LayoutTests/fast/forms LayoutTests/svg LayoutTests/html5lib/ Use of uninitialized value in splice at /Volumes/Data/git-webkit/Tools/Scripts/webkitdirs.pm line 851. Use of uninitialized value in splice at /Volumes/Data/git-webkit/Tools/Scripts/webkitdirs.pm line 852. Use of uninitialized value in splice at /Volumes/Data/git-webkit/Tools/Scripts/webkitdirs.pm line 851. Use of uninitialized value in splice at /Volumes/Data/git-webkit/Tools/Scripts/webkitdirs.pm line 852. Use of uninitialized value in splice at /Volumes/Data/git-webkit/Tools/Scripts/webkitdirs.pm line 851. Use of uninitialized value in splice at /Volumes/Data/git-webkit/Tools/Scripts/webkitdirs.pm line 852. Use of uninitialized value in splice at /Volumes/Data/git-webkit/Tools/Scripts/webkitdirs.pm line 851. Use of uninitialized value in splice at /Volumes/Data/git-webkit/Tools/Scripts/webkitdirs.pm line 852. Use of uninitialized value in splice at /Volumes/Data/git-webkit/Tools/Scripts/webkitdirs.pm line 851. Use of uninitialized value in splice at /Volumes/Data/git-webkit/Tools/Scripts/webkitdirs.pm line 852. Use of uninitialized value in splice at /Volumes/Data/git-webkit/Tools/Scripts/webkitdirs.pm line 851. Use of uninitialized value in splice at /Volumes/Data/git-webkit/Tools/Scripts/webkitdirs.pm line 852. We're also seeing them on various builders on build.webkit.org. Please fix it ASAP. 953000 1 rego 2013-11-21 01:55:43 -0800 BTW, this causes that Tools/Scripts/run-launcher ignores the arguments at least in GTK+ port. For example the following case will ignore the URL: Tools/Scripts/run-launcher --gtk http://www.webkit.org 953020 2 217543 rego 2013-11-21 03:34:36 -0800 Created attachment 217543 Patch This fix the warnings for me. It was trying to access to first element of an array when array has 0 elements. 953029 3 217543 commit-queue 2013-11-21 04:23:42 -0800 Comment on attachment 217543 Patch Clearing flags on attachment: 217543 Committed r159616: <http://trac.webkit.org/changeset/159616> 953030 4 commit-queue 2013-11-21 04:23:44 -0800 All reviewed patches have been landed. Closing bug. 217543 2013-11-21 03:34:36 -0800 2013-11-21 04:23:41 -0800 Patch bug-124697-20131121123635.patch text/plain 1385 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5NjExCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmYwNDhiOTg3MjhiY2UzNjc0NDBjOWJkMjkyMjg5Mjdk MDAyN2FkYy4uMDRkNzIzZjk1Mzg3YzMxMWYyNjc5YWVjYTYyMTQ4ZjUyN2MxMGIzNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDEzLTExLTIxICBNYW51ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29t PgorCisgICAgICAgIFJFR1JFU1NJT04ocjE1OTU5OSk6IHdlYmtpdGRpcnMucG0gc3BpdHMgb3V0 IHdhcm5pbmdzIGF0IGxpbmVzIDg1MSBhbmQgODUyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQ2OTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAg KGNoZWNrRm9yQXJndW1lbnRBbmRSZW1vdmVGcm9tQVJHVkdldHRpbmdWYWx1ZSk6IEZpeCBjaGVj ayBvZiBhcnJheSBzaXplCisgICAgICAgIGJlZm9yZSB0cnlpbmcgdG8gYWNjZXNzIHRvIHRoZSBm aXJzdCBlbGVtZW50LgorCiAyMDEzLTExLTIwICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNv bT4KIAogICAgICAgICBBbGxvdyBzZXR0aW5ncyB0byBiZSBzaG93bi9oaWRkZW4gb24gYnVpbGQu d2Via2l0Lm9yZy9kYXNoYm9hcmQKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGly cy5wbSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQppbmRleCAxZjY4MmQ1YjYyMzIwMDBm ZTExNTc3Y2ExOTM4Njg5NDI5ZDQwOTFmLi5mZDZlMjE0MzM4ZTU3N2JhODI0MzBhZWI4YWQ2Nzgx YWJiZTBhMDc5IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KKysrIGIv VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCkBAIC04NDcsNyArODQ3LDcgQEAgc3ViIGNoZWNr Rm9yQXJndW1lbnRBbmRSZW1vdmVGcm9tQVJHVkdldHRpbmdWYWx1ZSgkJCkKIHsKICAgICBteSAo JGFyZ1RvQ2hlY2ssICR2YWx1ZVJlZikgPSBAXzsKICAgICBteSBAbWF0Y2hpbmdJbmRpY2VzID0g ZmluZE1hdGNoaW5nQXJndW1lbnRzKCRhcmdUb0NoZWNrLCBcQEFSR1YpOwotICAgIHJldHVybiAw IHVubGVzcyAoJCNtYXRjaGluZ0luZGljZXMgIT0gMSk7CisgICAgcmV0dXJuIDAgaWYgKCQjbWF0 Y2hpbmdJbmRpY2VzICE9IDEpOwogICAgIHNwbGljZShAQVJHViwgJG1hdGNoaW5nSW5kaWNlc1sw XSwgMSk7CiAgICAgcmV0dXJuICQkdmFsdWVSZWYgPSBzcGxpY2UoQEFSR1YsICRtYXRjaGluZ0lu ZGljZXNbMF0sIDEpOwogfQo=