124694 2013-11-20 17:42:24 -0800 Allow settings to be shown/hidden on build.webkit.org/dashboard 2013-11-20 17:59:04 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dino dino oldest_to_newest 952887 0 dino 2013-11-20 17:42:24 -0800 In preparation for more options, add a way to hide all the goop on the dashboard. This patch adds a little gear icon in the top left which toggles all the settings. 952889 1 217506 dino 2013-11-20 17:45:21 -0800 Created attachment 217506 Patch 952893 2 217506 thorton 2013-11-20 17:52:59 -0800 Comment on attachment 217506 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217506&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:181 > + settingsButton.addEventListener("click", function () { settings.toggleSettingsDisplay(); }); space before ()? I don't remember 952896 3 dino 2013-11-20 17:59:04 -0800 Committed r159602: <http://trac.webkit.org/changeset/159602> 217506 2013-11-20 17:45:21 -0800 2013-11-20 17:52:59 -0800 Patch bug-124694-20131121124520.patch text/plain 6561 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5NTg5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTYzOTY4MzM5MTIyODU2OGRhNGIzNWY3YTQzZmVjYzNj MDNmMzE5My4uZGE3OWJmMTgzYTc3Y2RjODQwNDc1NWMzNGQ0ZDcxYzU5MThkYTg3OSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI3 IEBACiAyMDEzLTExLTIwICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KIAorICAgICAg ICBBbGxvdyBzZXR0aW5ncyB0byBiZSBzaG93bi9oaWRkZW4gb24gYnVpbGQud2Via2l0Lm9yZy9k YXNoYm9hcmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEyNDY5NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEluIHByZXBhcmF0aW9uIGZvciBtb3JlIG9wdGlvbnMvYnV0dG9ucywgYWxsb3cgdGhlIHBhZ2Ug dG8KKyAgICAgICAgc2hvdyBvciBoaWRlIGFsbCB0aGUgaW50ZXJhY3RpdmUgdGhpbmdzIHVzaW5n IGEgbGl0dGxlIGdlYXIgaWNvbgorICAgICAgICBpbiB0aGUgdG9wIGxlZnQgY29ybmVyLgorCisg ICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGlj X2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvTWFpbi5qczoKKyAgICAgICAgKiBCdWlsZFNsYXZlU3Vw cG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0 cy9TZXR0aW5ncy5qczoKKyAgICAgICAgKFNldHRpbmdzLnByb3RvdHlwZS50b2dnbGVTZXR0aW5n c0Rpc3BsYXkpOgorICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmct Y29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TdHlsZXMvTWFpbi5jc3M6CisgICAgICAgIChk aXYuY2VsbEJ1dHRvbi5oaWRlKToKKyAgICAgICAgKGRpdi5jZWxsQnV0dG9uLnVuaGlkZSk6Cisg ICAgICAgICguc2V0dGluZ3MtdmlzaWJsZSBkaXYuY2VsbEJ1dHRvbi5oaWRlLCAuc2V0dGluZ3Mt dmlzaWJsZSBkaXYuY2VsbEJ1dHRvbi51bmhpZGUpOgorICAgICAgICAoLnNldHRpbmdzKToKKyAg ICAgICAgKC5zZXR0aW5nczpob3Zlcik6CisgICAgICAgICguc2V0dGluZ3MtdmlzaWJsZSAuc2V0 dGluZ3MpOgorCisyMDEzLTExLTIwICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKwog ICAgICAgICBObyBuZWVkIHRvIGJhc2U2NCBTVkcgb24gYnVpbGQud2Via2l0Lm9yZy9kYXNoYm9h cmQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDY4 NwogCmRpZmYgLS1naXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn LWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9NYWluLmpzIGIvVG9vbHMvQnVp bGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJv YXJkL1NjcmlwdHMvTWFpbi5qcwppbmRleCA3NThjOTRmYTIxMTY4MGM2MTY5ZmQzMjM3NzEzNjIy ZTg0NDZmNjRkLi43NWY5Y2FlNzkzOGQ2ZWU4OTQ0NDkyNzIxOTU0NGYzMjEwZTBmMDFkIDEwMDY0 NAotLS0gYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9w dWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9NYWluLmpzCisrKyBiL1Rvb2xzL0J1aWxkU2xh dmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9T Y3JpcHRzL01haW4uanMKQEAgLTE3Nyw2ICsxNzcsMTEgQEAgZnVuY3Rpb24gZG9jdW1lbnRSZWFk eSgpCiAKICAgICBkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKHRhYmxlKTsKIAorICAgIHZhciBz ZXR0aW5nc0J1dHRvbiA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOworICAgIHNldHRp bmdzQnV0dG9uLmFkZEV2ZW50TGlzdGVuZXIoImNsaWNrIiwgZnVuY3Rpb24gKCkgeyBzZXR0aW5n cy50b2dnbGVTZXR0aW5nc0Rpc3BsYXkoKTsgfSk7CisgICAgc2V0dGluZ3NCdXR0b24uY2xhc3NM aXN0LmFkZCgic2V0dGluZ3MiKTsKKyAgICBkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKHNldHRp bmdzQnV0dG9uKTsKKwogICAgIHVwZGF0ZUhpZGRlblBsYXRmb3JtcygpOwogICAgIHNldHRpbmdz LmFkZFNldHRpbmdMaXN0ZW5lcigiaGlkZGVuUGxhdGZvcm1zIiwgdXBkYXRlSGlkZGVuUGxhdGZv cm1zKTsKIH0KZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtp dC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL1NldHRpbmdzLmpzIGIv VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0 bWwvZGFzaGJvYXJkL1NjcmlwdHMvU2V0dGluZ3MuanMKaW5kZXggNmRhMTdiYzA2ZDA3MWIxZTNh YTQ3NTkwMGE2MjZkNTlhOTQ0MzRhMS4uYWJlNDljYTRjMWVkMTliYmVlYzQ0ZWVhOGI5M2UzYTQ4 ZjU0ZmNiYiAxMDA2NDQKLS0tIGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0 Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvU2V0dGluZ3MuanMKKysr IGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGlj X2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvU2V0dGluZ3MuanMKQEAgLTYyLDYgKzYyLDExIEBAIFNl dHRpbmdzLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIGNhbGxiYWNrc1tpXSgpOwogICAgIH0s CiAKKyAgICB0b2dnbGVTZXR0aW5nc0Rpc3BsYXk6IGZ1bmN0aW9uKCkKKyAgICB7CisgICAgICAg IGRvY3VtZW50LmJvZHkuY2xhc3NMaXN0LnRvZ2dsZSgic2V0dGluZ3MtdmlzaWJsZSIpOworICAg IH0sCisKICAgICB0b2dnbGVIaWRkZW5QbGF0Zm9ybTogZnVuY3Rpb24ocGxhdGZvcm0pCiAgICAg ewogICAgICAgICB2YXIgaGlkZGVuUGxhdGZvcm1zID0gdGhpcy5nZXRPYmplY3QoImhpZGRlblBs YXRmb3JtcyIpOwpkaWZmIC0tZ2l0IGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Vi a2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1N0eWxlcy9NYWluLmNzcyBiL1Rv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1s L2Rhc2hib2FyZC9TdHlsZXMvTWFpbi5jc3MKaW5kZXggNzkxNzFmNzU3MTAzMWM1YTgzM2JkZGNh NjNhNjY3ZmQzM2VhOGRjZS4uN2Y5ZWNjMjA2ODU0M2U3NGVhM2QyYzNhMDVkODQ3MDE1YjYxYzY0 ZSAxMDA2NDQKLS0tIGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1j b25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1N0eWxlcy9NYWluLmNzcworKysgYi9Ub29scy9C dWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNo Ym9hcmQvU3R5bGVzL01haW4uY3NzCkBAIC00NiwxNSArNDYsNDIgQEAgZGl2LmNlbGxCdXR0b24g ewogfQogCiBkaXYuY2VsbEJ1dHRvbi5oaWRlIHsKKyAgICBkaXNwbGF5OiBub25lOwogICAgIHBv c2l0aW9uOiBhYnNvbHV0ZTsKICAgICBib3R0b206IDJweDsKICAgICByaWdodDogNHB4OwogfQog CitkaXYuY2VsbEJ1dHRvbi51bmhpZGUgeworICAgIGRpc3BsYXk6IG5vbmU7Cit9CisKKy5zZXR0 aW5ncy12aXNpYmxlIGRpdi5jZWxsQnV0dG9uLmhpZGUsIC5zZXR0aW5ncy12aXNpYmxlIGRpdi5j ZWxsQnV0dG9uLnVuaGlkZSB7CisgICAgZGlzcGxheTogYmxvY2s7Cit9CisKIC5oaWRkZW4gewog ICAgIGRpc3BsYXk6IG5vbmU7CiB9CiAKKy5zZXR0aW5ncyB7CisgICAgcG9zaXRpb246IGFic29s dXRlOworICAgIHRvcDogNXB4OworICAgIGxlZnQ6IDVweDsKKyAgICB3aWR0aDogMzVweDsKKyAg ICBoZWlnaHQ6IDM1cHg7CisgICAgYmFja2dyb3VuZC1pbWFnZTogdXJsKCdkYXRhOmltYWdlL3N2 Zyt4bWwsPHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjAg MCAyNTAgMjUwIj48cGF0aCBmaWxsPSJyZ2IoMTY2LCAxNTgsIDEzMCkiIGQ9Ik0yMTMsMTQ0di0z OWgtMjEuMDU1Yy0xLjQ3Ni01LTMuNTEtMTAuMDg1LTYuMDUxLTE0LjY2OGwxNC42NzMtMTQuNjk3 bC0yNy41NzgtMjcuNTg5bC0xNC41MjEsMTQuNjY1IEMxNTMuODg1LDYwLjE3LDE0OSw1OC4xMywx NDQsNTYuNjU0VjM2aC0zOXYyMC42NTRjLTUsMS40NzYtMTAuMTg2LDMuNTEtMTQuNzY5LDYuMDUx TDc1LjQ4NCw0OC4wMzNMNDcuODY5LDc1LjYwOWwxNC42NTIsMTQuNzIzIEM1OS45ODEsOTQuOTE1 LDU3LjkyOSwxMDAsNTYuNDUzLDEwNUgzNnYzOWgyMC40NTNjMS40NzYsNSwzLjUxMSw5Ljk4NSw2 LjA1MSwxNC41NjlsLTE0LjY3MiwxNC42NDZsMjcuNTc3LDI3LjU2NWwxNC44MjItMTQuNjc5IGM0 LjU4MywyLjU0MSw5Ljc2OSw0LjU2OSwxNC43NjksNi4wNDVWMjEzaDM5di0yMC44NTRjNS0xLjQ3 Niw5Ljg4NS0zLjUxLDE0LjQ2OC02LjA1MWwxNC41OTcsMTQuNjcybDI3LjU0MS0yNy41NzZsLTE0 LjY5MS0xNC42MjMgYzIuNTQtNC41ODMsNC41NTYtOS41NjgsNi4wMzEtMTQuNTY4SDIxM3ogTTEy NC4xOTksMTY0LjljLTIyLjM2NywwLTQwLjUtMTguMTMzLTQwLjUtNDAuNXMxOC4xMzMtNDAuNSw0 MC41LTQwLjUgczQwLjUsMTguMTMzLDQwLjUsNDAuNVMxNDYuNTY2LDE2NC45LDEyNC4xOTksMTY0 Ljl6Ii8+PC9zdmc+Jyk7CisgICAgY3Vyc29yOiBwb2ludGVyOworfQorCisuc2V0dGluZ3M6aG92 ZXIgeworICAgIGJhY2tncm91bmQtaW1hZ2U6IHVybCgnZGF0YTppbWFnZS9zdmcreG1sLDxzdmcg eG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIiB2aWV3Qm94PSIwIDAgMjUwIDI1MCI+ PHBhdGggZmlsbD0icmdiKDE4NSwgMTc1LCAxMjUpIiBkPSJNMjEzLDE0NHYtMzloLTIxLjA1NWMt MS40NzYtNS0zLjUxLTEwLjA4NS02LjA1MS0xNC42NjhsMTQuNjczLTE0LjY5N2wtMjcuNTc4LTI3 LjU4OWwtMTQuNTIxLDE0LjY2NSBDMTUzLjg4NSw2MC4xNywxNDksNTguMTMsMTQ0LDU2LjY1NFYz NmgtMzl2MjAuNjU0Yy01LDEuNDc2LTEwLjE4NiwzLjUxLTE0Ljc2OSw2LjA1MUw3NS40ODQsNDgu MDMzTDQ3Ljg2OSw3NS42MDlsMTQuNjUyLDE0LjcyMyBDNTkuOTgxLDk0LjkxNSw1Ny45MjksMTAw LDU2LjQ1MywxMDVIMzZ2MzloMjAuNDUzYzEuNDc2LDUsMy41MTEsOS45ODUsNi4wNTEsMTQuNTY5 bC0xNC42NzIsMTQuNjQ2bDI3LjU3NywyNy41NjVsMTQuODIyLTE0LjY3OSBjNC41ODMsMi41NDEs OS43NjksNC41NjksMTQuNzY5LDYuMDQ1VjIxM2gzOXYtMjAuODU0YzUtMS40NzYsOS44ODUtMy41 MSwxNC40NjgtNi4wNTFsMTQuNTk3LDE0LjY3MmwyNy41NDEtMjcuNTc2bC0xNC42OTEtMTQuNjIz IGMyLjU0LTQuNTgzLDQuNTU2LTkuNTY4LDYuMDMxLTE0LjU2OEgyMTN6IE0xMjQuMTk5LDE2NC45 Yy0yMi4zNjcsMC00MC41LTE4LjEzMy00MC41LTQwLjVzMTguMTMzLTQwLjUsNDAuNS00MC41IHM0 MC41LDE4LjEzMyw0MC41LDQwLjVTMTQ2LjU2NiwxNjQuOSwxMjQuMTk5LDE2NC45eiIvPjwvc3Zn PicpOworfQorCisuc2V0dGluZ3MtdmlzaWJsZSAuc2V0dGluZ3MgeworICAgIGJhY2tncm91bmQt aW1hZ2U6IHVybCgnZGF0YTppbWFnZS9zdmcreG1sLDxzdmcgeG1sbnM9Imh0dHA6Ly93d3cudzMu b3JnLzIwMDAvc3ZnIiB2aWV3Qm94PSIwIDAgMjUwIDI1MCI+PHBhdGggZmlsbD0icmdiKDc2LCAx NTEsIDYxKSIgZD0iTTIxMywxNDR2LTM5aC0yMS4wNTVjLTEuNDc2LTUtMy41MS0xMC4wODUtNi4w NTEtMTQuNjY4bDE0LjY3My0xNC42OTdsLTI3LjU3OC0yNy41ODlsLTE0LjUyMSwxNC42NjUgQzE1 My44ODUsNjAuMTcsMTQ5LDU4LjEzLDE0NCw1Ni42NTRWMzZoLTM5djIwLjY1NGMtNSwxLjQ3Ni0x MC4xODYsMy41MS0xNC43NjksNi4wNTFMNzUuNDg0LDQ4LjAzM0w0Ny44NjksNzUuNjA5bDE0LjY1 MiwxNC43MjMgQzU5Ljk4MSw5NC45MTUsNTcuOTI5LDEwMCw1Ni40NTMsMTA1SDM2djM5aDIwLjQ1 M2MxLjQ3Niw1LDMuNTExLDkuOTg1LDYuMDUxLDE0LjU2OWwtMTQuNjcyLDE0LjY0NmwyNy41Nzcs MjcuNTY1bDE0LjgyMi0xNC42NzkgYzQuNTgzLDIuNTQxLDkuNzY5LDQuNTY5LDE0Ljc2OSw2LjA0 NVYyMTNoMzl2LTIwLjg1NGM1LTEuNDc2LDkuODg1LTMuNTEsMTQuNDY4LTYuMDUxbDE0LjU5Nywx NC42NzJsMjcuNTQxLTI3LjU3NmwtMTQuNjkxLTE0LjYyMyBjMi41NC00LjU4Myw0LjU1Ni05LjU2 OCw2LjAzMS0xNC41NjhIMjEzeiBNMTI0LjE5OSwxNjQuOWMtMjIuMzY3LDAtNDAuNS0xOC4xMzMt NDAuNS00MC41czE4LjEzMy00MC41LDQwLjUtNDAuNSBzNDAuNSwxOC4xMzMsNDAuNSw0MC41UzE0 Ni41NjYsMTY0LjksMTI0LjE5OSwxNjQuOXoiLz48L3N2Zz4nKTsKK30KKwogYm9keSB7CiAgICAg YmFja2dyb3VuZC1jb2xvcjogcmdiKDIzMywgMjMxLCAyMjMpOwogICAgIHRleHQtYWxpZ246IGNl bnRlcjsK