124690 2013-11-20 17:05:08 -0800 Move activeURL getter to PageLoadState 2013-11-21 11:41:57 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 952864 0 andersca 2013-11-20 17:05:08 -0800 Move activeURL getter to PageLoadState 952865 1 217498 andersca 2013-11-20 17:06:02 -0800 Created attachment 217498 Patch 952866 2 217499 andersca 2013-11-20 17:06:37 -0800 Created attachment 217499 Patch 952869 3 217499 thorton 2013-11-20 17:09:04 -0800 Comment on attachment 217499 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217499&action=review > Source/WebKit2/UIProcess/PageLoadState.cpp:53 > + // If there is a currently pending url, it is the active URL, url or URL? 953205 4 andersca 2013-11-21 11:41:57 -0800 Committed r159638: <http://trac.webkit.org/changeset/159638> 217498 2013-11-20 17:06:02 -0800 2013-11-20 17:06:31 -0800 Patch bug-124690-20131120170601.patch text/plain 3720 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5NTg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMDg1OThhMGJkNGRjMmRl NjI5MzVlNWI0ZGQ0MDFiZTMyNTI3YzI5ZC4uMzQ4ZWEyNGNkNjAzZDg4YTBiYzgzZWRlMmMzNjQy ZTkxNjg0NDg3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDEzLTExLTIwICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgTW92ZSBhY3RpdmVV UkwgZ2V0dGVyIHRvIFBhZ2VMb2FkU3RhdGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEyNDY5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL1BhZ2VMb2FkU3RhdGUuY3BwOgorICAgICAg ICAoV2ViS2l0OjpQYWdlTG9hZFN0YXRlOjphY3RpdmVVUkwpOgorICAgICAgICAqIFVJUHJvY2Vz cy9QYWdlTG9hZFN0YXRlLmg6CisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHA6 CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6YWN0aXZlVVJMKToKKworMjAxMy0xMS0y MCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCiAgICAgICAgIEVuYWJs ZSBQYWdlTG9hZFRlc3QgYXNzZXJ0aW9ucyBhZ2FpbgogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI0NjgxCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9QYWdlTG9hZFN0YXRlLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9QYWdlTG9hZFN0YXRlLmNwcAppbmRleCBhNWFjMzViZDg3OGU3N2Q2NTY0MzI2NmU0ZGRhZjNl N2Y1NTljZDgyLi5kNjMyMDdiOTE5YjVlNmYwNGI5YTFmNWI2Y2M3MWMzNTVjZjg1OTM4IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGFnZUxvYWRTdGF0ZS5jcHAKKysrIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BhZ2VMb2FkU3RhdGUuY3BwCkBAIC00OCw2ICs0OCwz MCBAQCB2b2lkIFBhZ2VMb2FkU3RhdGU6OnJlc2V0KCkKICAgICBtX2xhc3RVbnJlYWNoYWJsZVVS TCA9IFN0cmluZygpOwogfQogCitTdHJpbmcgUGFnZUxvYWRTdGF0ZTo6YWN0aXZlVVJMKCkgY29u c3QKK3sKKyAgICAvLyBJZiB0aGVyZSBpcyBhIGN1cnJlbnRseSBwZW5kaW5nIHVybCwgaXQgaXMg dGhlIGFjdGl2ZSBVUkwsCisgICAgLy8gZXZlbiB3aGVuIHRoZXJlJ3Mgbm8gbWFpbiBmcmFtZSB5 ZXQsIGFzIGl0IG1pZ2h0IGJlIHRoZQorICAgIC8vIGZpcnN0IEFQSSByZXF1ZXN0LgorICAgIGlm ICghbV9wZW5kaW5nQVBJUmVxdWVzdFVSTC5pc051bGwoKSkKKyAgICAgICAgcmV0dXJuIG1fcHBl bmRpbmdBUElSZXF1ZXN0VVJMLnBlbmRpbmdBUElSZXF1ZXN0VVJMKCk7CisKKyAgICBpZiAoIW1f dW5yZWFjaGFibGVVUkwuaXNFbXB0eSgpKQorICAgICAgICByZXR1cm4gbV91bnJlYWNoYWJsZVVS TDsKKworICAgIHN3aXRjaCAobV9zdGF0ZSkgeworICAgIGNhc2UgU3RhdGU6OlByb3Zpc2lvbmFs OgorICAgICAgICByZXR1cm4gbV9wcm92aXNpb25hbFVSTDsKKyAgICBjYXNlIFN0YXRlOjpDb21t aXR0ZWQ6CisgICAgY2FzZSBTdGF0ZTo6RmluaXNoZWQ6CisgICAgICAgIHJldHVybiBtX3VybDsK KyAgICB9CisKKyAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICByZXR1cm4gU3RyaW5nKCk7 CisKK30KKwogY29uc3QgU3RyaW5nJiBQYWdlTG9hZFN0YXRlOjpwZW5kaW5nQVBJUmVxdWVzdFVS TCgpIGNvbnN0CiB7CiAgICAgcmV0dXJuIG1fcGVuZGluZ0FQSVJlcXVlc3RVUkw7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGFnZUxvYWRTdGF0ZS5oIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL1BhZ2VMb2FkU3RhdGUuaAppbmRleCAyYzBiNzQwMzZlMDFmYTg0MGVj ZTg5OGI3MGU0OGExMmQ0NzY3MjAwLi5iYzYyN2EyYzE1OGExMmJlZGVjMzgzNGE5NTE0NjAxMTAz N2ZjYjg1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGFnZUxvYWRTdGF0 ZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QYWdlTG9hZFN0YXRlLmgKQEAgLTQz LDYgKzQzLDggQEAgcHVibGljOgogCiAgICAgdm9pZCByZXNldCgpOwogCisgICAgU3RyaW5nIGFj dGl2ZVVSTCgpIGNvbnN0OworCiAgICAgY29uc3QgU3RyaW5nJiBwZW5kaW5nQVBJUmVxdWVzdFVS TCgpIGNvbnN0OwogICAgIHZvaWQgc2V0UGVuZGluZ0FQSVJlcXVlc3RVUkwoY29uc3QgU3RyaW5n Jik7CiAgICAgdm9pZCBjbGVhclBlbmRpbmdBUElSZXF1ZXN0VVJMKCk7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCmluZGV4IDhlOGQ1OTU1NjgxN2E0YTQzN2MzMzQx NjgyNTBlOTNlNTlmZjRlNDUuLmQwM2UxNzRiYmE3MTk3MzQxNDdhZmVkOTczZWJjYWE0NTBjYTBm OWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCkBAIC04Mzgs MjggKzgzOCw3IEBAIHZvaWQgV2ViUGFnZVByb3h5Ojp3aWxsR29Ub0JhY2tGb3J3YXJkTGlzdEl0 ZW0odWludDY0X3QgaXRlbUlELCBDb3JlSVBDOjpNZXNzYWdlCiAKIFN0cmluZyBXZWJQYWdlUHJv eHk6OmFjdGl2ZVVSTCgpIGNvbnN0CiB7Ci0gICAgLy8gSWYgdGhlcmUgaXMgYSBjdXJyZW50bHkg cGVuZGluZyB1cmwsIGl0IGlzIHRoZSBhY3RpdmUgVVJMLAotICAgIC8vIGV2ZW4gd2hlbiB0aGVy ZSdzIG5vIG1haW4gZnJhbWUgeWV0LCBhcyBpdCBtaWdodCBiZSB0aGUKLSAgICAvLyBmaXJzdCBB UEkgcmVxdWVzdC4KLSAgICBpZiAoIW1fcGFnZUxvYWRTdGF0ZS5wZW5kaW5nQVBJUmVxdWVzdFVS TCgpLmlzTnVsbCgpKQotICAgICAgICByZXR1cm4gbV9wYWdlTG9hZFN0YXRlLnBlbmRpbmdBUElS ZXF1ZXN0VVJMKCk7Ci0KLSAgICBpZiAoIW1fbWFpbkZyYW1lKQotICAgICAgICByZXR1cm4gU3Ry aW5nKCk7Ci0KLSAgICBpZiAoIW1fbWFpbkZyYW1lLT51bnJlYWNoYWJsZVVSTCgpLmlzRW1wdHko KSkKLSAgICAgICAgcmV0dXJuIG1fbWFpbkZyYW1lLT51bnJlYWNoYWJsZVVSTCgpOwotCi0gICAg c3dpdGNoIChtX21haW5GcmFtZS0+ZnJhbWVMb2FkU3RhdGUoKS5tX3N0YXRlKSB7Ci0gICAgY2Fz ZSBGcmFtZUxvYWRTdGF0ZTo6U3RhdGU6OlByb3Zpc2lvbmFsOgotICAgICAgICByZXR1cm4gbV9t YWluRnJhbWUtPnByb3Zpc2lvbmFsVVJMKCk7Ci0gICAgY2FzZSBGcmFtZUxvYWRTdGF0ZTo6U3Rh dGU6OkNvbW1pdHRlZDoKLSAgICBjYXNlIEZyYW1lTG9hZFN0YXRlOjpTdGF0ZTo6RmluaXNoZWQ6 Ci0gICAgICAgIHJldHVybiBtX21haW5GcmFtZS0+dXJsKCk7Ci0gICAgfQotCi0gICAgQVNTRVJU X05PVF9SRUFDSEVEKCk7Ci0gICAgcmV0dXJuIFN0cmluZygpOworICAgIHJldHVybiBtX3BhZ2VM b2FkU3RhdGUuYWN0aXZlVVJMKCk7CiB9CiAKIFN0cmluZyBXZWJQYWdlUHJveHk6OnByb3Zpc2lv bmFsVVJMKCkgY29uc3QK 217499 2013-11-20 17:06:37 -0800 2013-11-20 17:09:04 -0800 Patch bug-124690-20131120170636.patch text/plain 3696 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5NTg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMDg1OThhMGJkNGRjMmRl NjI5MzVlNWI0ZGQ0MDFiZTMyNTI3YzI5ZC4uMzQ4ZWEyNGNkNjAzZDg4YTBiYzgzZWRlMmMzNjQy ZTkxNjg0NDg3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDEzLTExLTIwICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgTW92ZSBhY3RpdmVV UkwgZ2V0dGVyIHRvIFBhZ2VMb2FkU3RhdGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEyNDY5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL1BhZ2VMb2FkU3RhdGUuY3BwOgorICAgICAg ICAoV2ViS2l0OjpQYWdlTG9hZFN0YXRlOjphY3RpdmVVUkwpOgorICAgICAgICAqIFVJUHJvY2Vz cy9QYWdlTG9hZFN0YXRlLmg6CisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHA6 CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6YWN0aXZlVVJMKToKKworMjAxMy0xMS0y MCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCiAgICAgICAgIEVuYWJs ZSBQYWdlTG9hZFRlc3QgYXNzZXJ0aW9ucyBhZ2FpbgogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI0NjgxCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9QYWdlTG9hZFN0YXRlLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9QYWdlTG9hZFN0YXRlLmNwcAppbmRleCBhNWFjMzViZDg3OGU3N2Q2NTY0MzI2NmU0ZGRhZjNl N2Y1NTljZDgyLi42ZDhlOGI5NTI2Zjk1ZThhMzM3ZjA0ZWI2OTQwYTE1MTMwOGYyOGMwIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGFnZUxvYWRTdGF0ZS5jcHAKKysrIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BhZ2VMb2FkU3RhdGUuY3BwCkBAIC00OCw2ICs0OCwz MCBAQCB2b2lkIFBhZ2VMb2FkU3RhdGU6OnJlc2V0KCkKICAgICBtX2xhc3RVbnJlYWNoYWJsZVVS TCA9IFN0cmluZygpOwogfQogCitTdHJpbmcgUGFnZUxvYWRTdGF0ZTo6YWN0aXZlVVJMKCkgY29u c3QKK3sKKyAgICAvLyBJZiB0aGVyZSBpcyBhIGN1cnJlbnRseSBwZW5kaW5nIHVybCwgaXQgaXMg dGhlIGFjdGl2ZSBVUkwsCisgICAgLy8gZXZlbiB3aGVuIHRoZXJlJ3Mgbm8gbWFpbiBmcmFtZSB5 ZXQsIGFzIGl0IG1pZ2h0IGJlIHRoZQorICAgIC8vIGZpcnN0IEFQSSByZXF1ZXN0LgorICAgIGlm ICghbV9wZW5kaW5nQVBJUmVxdWVzdFVSTC5pc051bGwoKSkKKyAgICAgICAgcmV0dXJuIG1fcGVu ZGluZ0FQSVJlcXVlc3RVUkw7CisKKyAgICBpZiAoIW1fdW5yZWFjaGFibGVVUkwuaXNFbXB0eSgp KQorICAgICAgICByZXR1cm4gbV91bnJlYWNoYWJsZVVSTDsKKworICAgIHN3aXRjaCAobV9zdGF0 ZSkgeworICAgIGNhc2UgU3RhdGU6OlByb3Zpc2lvbmFsOgorICAgICAgICByZXR1cm4gbV9wcm92 aXNpb25hbFVSTDsKKyAgICBjYXNlIFN0YXRlOjpDb21taXR0ZWQ6CisgICAgY2FzZSBTdGF0ZTo6 RmluaXNoZWQ6CisgICAgICAgIHJldHVybiBtX3VybDsKKyAgICB9CisKKyAgICBBU1NFUlRfTk9U X1JFQUNIRUQoKTsKKyAgICByZXR1cm4gU3RyaW5nKCk7CisKK30KKwogY29uc3QgU3RyaW5nJiBQ YWdlTG9hZFN0YXRlOjpwZW5kaW5nQVBJUmVxdWVzdFVSTCgpIGNvbnN0CiB7CiAgICAgcmV0dXJu IG1fcGVuZGluZ0FQSVJlcXVlc3RVUkw7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvUGFnZUxvYWRTdGF0ZS5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BhZ2VMb2Fk U3RhdGUuaAppbmRleCAyYzBiNzQwMzZlMDFmYTg0MGVjZTg5OGI3MGU0OGExMmQ0NzY3MjAwLi5i YzYyN2EyYzE1OGExMmJlZGVjMzgzNGE5NTE0NjAxMTAzN2ZjYjg1IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGFnZUxvYWRTdGF0ZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9QYWdlTG9hZFN0YXRlLmgKQEAgLTQzLDYgKzQzLDggQEAgcHVibGljOgogCiAg ICAgdm9pZCByZXNldCgpOwogCisgICAgU3RyaW5nIGFjdGl2ZVVSTCgpIGNvbnN0OworCiAgICAg Y29uc3QgU3RyaW5nJiBwZW5kaW5nQVBJUmVxdWVzdFVSTCgpIGNvbnN0OwogICAgIHZvaWQgc2V0 UGVuZGluZ0FQSVJlcXVlc3RVUkwoY29uc3QgU3RyaW5nJik7CiAgICAgdm9pZCBjbGVhclBlbmRp bmdBUElSZXF1ZXN0VVJMKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv V2ViUGFnZVByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHku Y3BwCmluZGV4IDhlOGQ1OTU1NjgxN2E0YTQzN2MzMzQxNjgyNTBlOTNlNTlmZjRlNDUuLmQwM2Ux NzRiYmE3MTk3MzQxNDdhZmVkOTczZWJjYWE0NTBjYTBmOWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCkBAIC04MzgsMjggKzgzOCw3IEBAIHZvaWQgV2ViUGFn ZVByb3h5Ojp3aWxsR29Ub0JhY2tGb3J3YXJkTGlzdEl0ZW0odWludDY0X3QgaXRlbUlELCBDb3Jl SVBDOjpNZXNzYWdlCiAKIFN0cmluZyBXZWJQYWdlUHJveHk6OmFjdGl2ZVVSTCgpIGNvbnN0CiB7 Ci0gICAgLy8gSWYgdGhlcmUgaXMgYSBjdXJyZW50bHkgcGVuZGluZyB1cmwsIGl0IGlzIHRoZSBh Y3RpdmUgVVJMLAotICAgIC8vIGV2ZW4gd2hlbiB0aGVyZSdzIG5vIG1haW4gZnJhbWUgeWV0LCBh cyBpdCBtaWdodCBiZSB0aGUKLSAgICAvLyBmaXJzdCBBUEkgcmVxdWVzdC4KLSAgICBpZiAoIW1f cGFnZUxvYWRTdGF0ZS5wZW5kaW5nQVBJUmVxdWVzdFVSTCgpLmlzTnVsbCgpKQotICAgICAgICBy ZXR1cm4gbV9wYWdlTG9hZFN0YXRlLnBlbmRpbmdBUElSZXF1ZXN0VVJMKCk7Ci0KLSAgICBpZiAo IW1fbWFpbkZyYW1lKQotICAgICAgICByZXR1cm4gU3RyaW5nKCk7Ci0KLSAgICBpZiAoIW1fbWFp bkZyYW1lLT51bnJlYWNoYWJsZVVSTCgpLmlzRW1wdHkoKSkKLSAgICAgICAgcmV0dXJuIG1fbWFp bkZyYW1lLT51bnJlYWNoYWJsZVVSTCgpOwotCi0gICAgc3dpdGNoIChtX21haW5GcmFtZS0+ZnJh bWVMb2FkU3RhdGUoKS5tX3N0YXRlKSB7Ci0gICAgY2FzZSBGcmFtZUxvYWRTdGF0ZTo6U3RhdGU6 OlByb3Zpc2lvbmFsOgotICAgICAgICByZXR1cm4gbV9tYWluRnJhbWUtPnByb3Zpc2lvbmFsVVJM KCk7Ci0gICAgY2FzZSBGcmFtZUxvYWRTdGF0ZTo6U3RhdGU6OkNvbW1pdHRlZDoKLSAgICBjYXNl IEZyYW1lTG9hZFN0YXRlOjpTdGF0ZTo6RmluaXNoZWQ6Ci0gICAgICAgIHJldHVybiBtX21haW5G cmFtZS0+dXJsKCk7Ci0gICAgfQotCi0gICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7Ci0gICAgcmV0 dXJuIFN0cmluZygpOworICAgIHJldHVybiBtX3BhZ2VMb2FkU3RhdGUuYWN0aXZlVVJMKCk7CiB9 CiAKIFN0cmluZyBXZWJQYWdlUHJveHk6OnByb3Zpc2lvbmFsVVJMKCkgY29uc3QK