12469 2007-01-29 21:29:18 -0800 window.alert from onUnload listener does not show when users close the window 2008-07-09 11:59:41 -0700 1 1 1 Unclassified WebKit DOM 419.x Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 george.zhu webkit-unassigned ap george.zhu jchaffraix oldest_to_newest 30703 0 george.zhu 2007-01-29 21:29:18 -0800 The window object has an event onUnload, the Mozilla document describe it as: The unload event is raised when the document is unloaded. It is true that now this event fires when the document reload, the same as Firefox and IE. (this was fixed in bug 3402) But the event fail to fire when user close the window. It is well known that closing window also requires unloading of document, so it would be fine if Safari can also support this feature as it is already implemented in Firefox and IE. 30681 1 12774 george.zhu 2007-01-29 21:39:06 -0800 Created attachment 12774 Open the page directly and test. Open the page directly and test. 71794 2 jchaffraix 2008-02-24 16:00:46 -0800 > But the event fail to fire when user close the window. It is well known that > closing window also requires unloading of document, so it would be fine if > Safari can also support this feature as it is already implemented in Firefox > and IE. I have done some debugging and the event is dispatched when closing the window. The issue is that the listener try to call window.alert and fails in WebChromeClient::runJavaScriptAlert because the UIDelegate is null. The cause is that Cocoa calls (void)setUIDelegate:delegate (in WebKit/mac/WebView/WebView.mm) to set it to null *before* sending the unload event. My knowledge of the mac port is quite limited so I do not who to blame (Cocoa or WebKit) 71985 3 ap 2008-02-26 02:55:27 -0800 In my testing, -[WebView setUIDelegate:] is called from WebKit itself: #0 -[WebView setUIDelegate:] (self=0x37ed4c0, _cmd=0x3e1ab6, delegate=0x0) at /Users/ap/Safari/OpenSource/WebKit/mac/WebView/WebView.mm:2091 #1 0x003949e6 in -[WebView(WebPrivate) _close] (self=0x37ed4c0, _cmd=0x926aa890) at /Users/ap/Safari/OpenSource/WebKit/mac/WebView/WebView.mm:703 ... I'm not sure why this is classified as a major bug - what kind of important consequences does it have? Does showing an alert from onunload serve any purpose except for annoying the user? 72017 4 jchaffraix 2008-02-26 09:29:03 -0800 (In reply to comment #3) > In my testing, -[WebView setUIDelegate:] is called from WebKit itself: > > #0 -[WebView setUIDelegate:] (self=0x37ed4c0, _cmd=0x3e1ab6, delegate=0x0) at > /Users/ap/Safari/OpenSource/WebKit/mac/WebView/WebView.mm:2091 > #1 0x003949e6 in -[WebView(WebPrivate) _close] (self=0x37ed4c0, > _cmd=0x926aa890) at > /Users/ap/Safari/OpenSource/WebKit/mac/WebView/WebView.mm:703 > ... > Odd, I have another call to setUIDelegate before the one you mention on my machine which originate from Cocoa : #0 -[WebView setUIDelegate:] (self=0x2554c10, _cmd=0x3e13f8, delegate=0x0) at /Users/julien/Webkit/WebKit/WebKit/mac/WebView/WebView.mm:2093 #1 0x00049d21 in ?? () #2 0x925f3059 in -[NSArray makeObjectsPerformSelector:withObject:] () #3 0x925f3059 in -[NSArray makeObjectsPerformSelector:withObject:] () #4 0x92603d2d in -[NSArray makeObjectsPerformSelector:] () (...) Beside the one you are pointing at is executed after the unload listener : in WebView _close, the unload event is dispatched in mainLoader->detachFromParent() and setUIDelegate is called afterwards. > I'm not sure why this is classified as a major bug - what kind of important > consequences does it have? Does showing an alert from onunload serve any > purpose except for annoying the user? > Updated the summary and the severity as the original bug was that we were not dispatching an unload event when closing the window (which is major). I agree with you about how annoying alert from onunload listener can be but Firefox and Opera have chosen to display those so it is believed we should do the same. 82060 5 ddkilzer 2008-06-01 08:50:48 -0700 See Bug 18341. 85561 6 vicki 2008-07-09 11:59:41 -0700 I can't reproduce this anymore, using WebKit nightly r34367. 12774 2007-01-29 21:39:06 -0800 2007-01-29 21:39:06 -0800 Open the page directly and test. OnUnload.htm text/html 717 george.zhu PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBYSFRNTCAxLjAgVHJhbnNpdGlvbmFs Ly9FTiIgImh0dHA6Ly93d3cudzMub3JnL1RSL3hodG1sMS9EVEQveGh0bWwxLXRyYW5zaXRpb25h bC5kdGQiPg0KPGh0bWwgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwiID4NCjxo ZWFkPg0KICAgIDx0aXRsZT5VbnRpdGxlZCBQYWdlPC90aXRsZT4NCiAgICA8c2NyaXB0IHR5cGUg PSJ0ZXh0L2phdmFzY3JpcHQiID4NCiAgICBmdW5jdGlvbiBPblVubG9hZCgpDQogICAgew0KCQlh bGVydCgnb25VbmxvYWQgZXZlbnQgaXMgZmlyZWQhJyk7DQogICAgfQ0KICAgIDwvc2NyaXB0Pg0K PC9oZWFkPg0KPGJvZHkgb251bmxvYWQgPSJqYXZhc2NyaXB0Ok9uVW5sb2FkKCk7Ij4NCgk8c3Bh biBzdHlsZT0iZm9udC1zaXplOiAxNHB0Ij5UbyB0ZXN0IHRoZSBvblVubG9hZCBldmVudCwgcGxl YXNlIGNsb3NlIHRoZSB3aW5kb3cuDQoJCUlmIHlvdSBnZXQgYSBtZXNzYWdlIGJveCwgaXQgbWVh bnMgb25VbmxvYWQgZXZlbnQgaXMgZmlyZWQuDQoJCTxiciAvPg0KCQk8YnIgLz4NCgkJSW4gU2Fm YXJpLCB5b3Ugd2lsbCBmaW5kIG5vdGhpbmcgaGFwcGVuZWQgYWZ0ZXIgeW91IGNsb3NlIHRoZSB3 aW5kb3csIHdoaWxlIGluIEZpcmVmb3gNCgkJYW5kIElFLCBhIG1lc3NhZ2UgYm94IHdpbGwgcHJv bXB0Ljwvc3Bhbj4NCg0KPC9ib2R5Pg0KPC9odG1sPg0K