124689 2013-11-20 17:00:53 -0800 Add argument coders for IDBDatabaseMetadata 2013-11-20 17:09:27 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 124521 1 beidson beidson andersca ap commit-queue oldest_to_newest 952854 0 beidson 2013-11-20 17:00:53 -0800 Add argument coders for IDBDatabaseMetadata They will be used shortly for upcoming patches related to https://bugs.webkit.org/show_bug.cgi?id=124521 This is such a separable piece of work it makes it easier to review as a separate patch. 952857 1 217497 beidson 2013-11-20 17:03:02 -0800 Created attachment 217497 Patch v1 952859 2 commit-queue 2013-11-20 17:04:30 -0800 Attachment 217497 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/WebCoreArgumentCoders.cpp', u'Source/WebKit2/Shared/WebCoreArgumentCoders.h']" exit_code: 1 Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:1394: Non-label code inside switch statements should be indented. [whitespace/indent] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 952860 3 217497 andersca 2013-11-20 17:04:39 -0800 Comment on attachment 217497 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=217497&action=review > Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:1394 > + case IDBKeyPath::StringType: > + { Brace should go on same line as the case. > Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:1403 > + case IDBKeyPath::ArrayType: > + { Ditto. 952870 4 beidson 2013-11-20 17:09:27 -0800 http://trac.webkit.org/changeset/159597 217497 2013-11-20 17:03:02 -0800 2013-11-20 17:04:39 -0800 Patch v1 patch text/plain 6790 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA3MzZjNjZiLi5jMDE5YjZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjMg QEAKIDIwMTMtMTEtMjAgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCisgICAg ICAgIEFkZCBhcmd1bWVudCBjb2RlcnMgZm9yIElEQkRhdGFiYXNlTWV0YWRhdGEgY2xhc3Nlcwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI0Njg5CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGNvZGVy cyBmb3I6CisgICAgICAgICAgLSBJREJEYXRhYmFzZU1ldGFkYXRhCisgICAgICAgICAgLSBJREJJ bmRleE1ldGFkYXRhCisgICAgICAgICAgLSBJREJLZXlQYXRoCisgICAgICAgICAgLSBJREJPYmpl Y3RTdG9yZU1ldGFkYXRhCisKKyAgICAgICAgKiBTaGFyZWQvV2ViQ29yZUFyZ3VtZW50Q29kZXJz LmNwcDoKKyAgICAgICAgKENvcmVJUEM6Ojo6ZW5jb2RlKToKKyAgICAgICAgKENvcmVJUEM6Ojo6 ZGVjb2RlKToKKyAgICAgICAgKiBTaGFyZWQvV2ViQ29yZUFyZ3VtZW50Q29kZXJzLmg6CisKKzIw MTMtMTEtMjAgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCiAgICAgICAgIENs ZWFudXAgZ2V0T3JFc3RhYmxpc2hJREJEYXRhYmFzZU1ldGFkYXRhIGFuZCBzdHViIGl0IG91dCBp biBXSzIKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy NDYzNQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViQ29yZUFyZ3VtZW50 Q29kZXJzLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJDb3JlQXJndW1lbnRDb2RlcnMu Y3BwCmluZGV4IDU3ZWQ2Y2IuLjI4ZmE4MjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1No YXJlZC9XZWJDb3JlQXJndW1lbnRDb2RlcnMuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJl ZC9XZWJDb3JlQXJndW1lbnRDb2RlcnMuY3BwCkBAIC00MCw2ICs0MCw4IEBACiAjaW5jbHVkZSA8 V2ViQ29yZS9GaWx0ZXJPcGVyYXRpb25zLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9HcmFwaGljc0Nv bnRleHQuaD4KICNpbmNsdWRlIDxXZWJDb3JlL0dyYXBoaWNzTGF5ZXIuaD4KKyNpbmNsdWRlIDxX ZWJDb3JlL0lEQkRhdGFiYXNlTWV0YWRhdGEuaD4KKyNpbmNsdWRlIDxXZWJDb3JlL0lEQktleVBh dGguaD4KICNpbmNsdWRlIDxXZWJDb3JlL0ltYWdlLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9MZW5n dGguaD4KICNpbmNsdWRlIDxXZWJDb3JlL1BsdWdpbkRhdGEuaD4KQEAgLTEzMDgsNCArMTMxMCwx MzYgQEAgYm9vbCBBcmd1bWVudENvZGVyPEZpbHRlck9wZXJhdGlvbnM+OjpkZWNvZGUoQXJndW1l bnREZWNvZGVyJiBkZWNvZGVyLCBGaWx0ZXJPcGUKIH0KICNlbmRpZiAvLyBFTkFCTEUoQ1NTX0ZJ TFRFUlMpICYmICFVU0UoQ09PUkRJTkFURURfR1JBUEhJQ1MpCiAKKyNpZiBFTkFCTEUoSU5ERVhF RF9EQVRBQkFTRSkKK3ZvaWQgQXJndW1lbnRDb2RlcjxJREJEYXRhYmFzZU1ldGFkYXRhPjo6ZW5j b2RlKEFyZ3VtZW50RW5jb2RlciYgZW5jb2RlciwgY29uc3QgSURCRGF0YWJhc2VNZXRhZGF0YSYg bWV0YWRhdGEpCit7CisgICAgZW5jb2RlciA8PCBtZXRhZGF0YS5uYW1lIDw8IG1ldGFkYXRhLmlk IDw8IG1ldGFkYXRhLnZlcnNpb24gPDwgbWV0YWRhdGEubWF4T2JqZWN0U3RvcmVJZCA8PCBtZXRh ZGF0YS5vYmplY3RTdG9yZXM7Cit9CisKK2Jvb2wgQXJndW1lbnRDb2RlcjxJREJEYXRhYmFzZU1l dGFkYXRhPjo6ZGVjb2RlKEFyZ3VtZW50RGVjb2RlciYgZGVjb2RlciwgSURCRGF0YWJhc2VNZXRh ZGF0YSYgbWV0YWRhdGEpCit7CisgICAgaWYgKCFkZWNvZGVyLmRlY29kZShtZXRhZGF0YS5uYW1l KSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgaWYgKCFkZWNvZGVyLmRlY29kZShtZXRh ZGF0YS5pZCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIGlmICghZGVjb2Rlci5kZWNv ZGUobWV0YWRhdGEudmVyc2lvbikpCisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIGlmICgh ZGVjb2Rlci5kZWNvZGUobWV0YWRhdGEubWF4T2JqZWN0U3RvcmVJZCkpCisgICAgICAgIHJldHVy biBmYWxzZTsKKworICAgIGlmICghZGVjb2Rlci5kZWNvZGUobWV0YWRhdGEub2JqZWN0U3RvcmVz KSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgcmV0dXJuIHRydWU7Cit9CisKK3ZvaWQg QXJndW1lbnRDb2RlcjxJREJJbmRleE1ldGFkYXRhPjo6ZW5jb2RlKEFyZ3VtZW50RW5jb2RlciYg ZW5jb2RlciwgY29uc3QgSURCSW5kZXhNZXRhZGF0YSYgbWV0YWRhdGEpCit7CisgICAgZW5jb2Rl ciA8PCBtZXRhZGF0YS5uYW1lIDw8IG1ldGFkYXRhLmlkIDw8IG1ldGFkYXRhLmtleVBhdGggPDwg bWV0YWRhdGEudW5pcXVlIDw8IG1ldGFkYXRhLm11bHRpRW50cnk7Cit9CisKK2Jvb2wgQXJndW1l bnRDb2RlcjxJREJJbmRleE1ldGFkYXRhPjo6ZGVjb2RlKEFyZ3VtZW50RGVjb2RlciYgZGVjb2Rl ciwgSURCSW5kZXhNZXRhZGF0YSYgbWV0YWRhdGEpCit7CisgICAgaWYgKCFkZWNvZGVyLmRlY29k ZShtZXRhZGF0YS5uYW1lKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgaWYgKCFkZWNv ZGVyLmRlY29kZShtZXRhZGF0YS5pZCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIGlm ICghZGVjb2Rlci5kZWNvZGUobWV0YWRhdGEua2V5UGF0aCkpCisgICAgICAgIHJldHVybiBmYWxz ZTsKKworICAgIGlmICghZGVjb2Rlci5kZWNvZGUobWV0YWRhdGEudW5pcXVlKSkKKyAgICAgICAg cmV0dXJuIGZhbHNlOworCisgICAgaWYgKCFkZWNvZGVyLmRlY29kZShtZXRhZGF0YS5tdWx0aUVu dHJ5KSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgcmV0dXJuIHRydWU7Cit9CisKK3Zv aWQgQXJndW1lbnRDb2RlcjxJREJLZXlQYXRoPjo6ZW5jb2RlKEFyZ3VtZW50RW5jb2RlciYgZW5j b2RlciwgY29uc3QgSURCS2V5UGF0aCYga2V5UGF0aCkKK3sKKyAgICBlbmNvZGVyLmVuY29kZUVu dW0oa2V5UGF0aC50eXBlKCkpOworCisgICAgc3dpdGNoIChrZXlQYXRoLnR5cGUoKSkgeworICAg IGNhc2UgSURCS2V5UGF0aDo6TnVsbFR5cGU6CisgICAgICAgIGJyZWFrOworICAgIGNhc2UgSURC S2V5UGF0aDo6U3RyaW5nVHlwZToKKyAgICAgICAgZW5jb2RlciA8PCBrZXlQYXRoLnN0cmluZygp OworICAgICAgICBicmVhazsKKyAgICBjYXNlIElEQktleVBhdGg6OkFycmF5VHlwZToKKyAgICAg ICAgZW5jb2RlciA8PCBrZXlQYXRoLmFycmF5KCk7CisgICAgICAgIGJyZWFrOworICAgIGRlZmF1 bHQ6CisgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgIH0KK30KKworYm9vbCBBcmd1 bWVudENvZGVyPElEQktleVBhdGg+OjpkZWNvZGUoQXJndW1lbnREZWNvZGVyJiBkZWNvZGVyLCBJ REJLZXlQYXRoJiBrZXlQYXRoKQoreworICAgIElEQktleVBhdGg6OlR5cGUgdHlwZTsKKyAgICBp ZiAoIWRlY29kZXIuZGVjb2RlRW51bSh0eXBlKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCisg ICAgc3dpdGNoICh0eXBlKSB7CisgICAgY2FzZSBJREJLZXlQYXRoOjpOdWxsVHlwZToKKyAgICAg ICAga2V5UGF0aCA9IElEQktleVBhdGgoKTsKKyAgICAgICAgcmV0dXJuIHRydWU7CisKKyAgICBj YXNlIElEQktleVBhdGg6OlN0cmluZ1R5cGU6CisgICAgeworICAgICAgICBTdHJpbmcgc3RyaW5n OworICAgICAgICBpZiAoIWRlY29kZXIuZGVjb2RlKHN0cmluZykpCisgICAgICAgICAgICByZXR1 cm4gZmFsc2U7CisKKyAgICAgICAga2V5UGF0aCA9IElEQktleVBhdGgoc3RyaW5nKTsKKyAgICAg ICAgcmV0dXJuIHRydWU7CisgICAgfQorICAgIGNhc2UgSURCS2V5UGF0aDo6QXJyYXlUeXBlOgor ICAgIHsKKyAgICAgICAgVmVjdG9yPFN0cmluZz4gYXJyYXk7CisgICAgICAgIGlmICghZGVjb2Rl ci5kZWNvZGUoYXJyYXkpKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgICAgIGtl eVBhdGggPSBJREJLZXlQYXRoKGFycmF5KTsKKyAgICAgICAgcmV0dXJuIHRydWU7CisgICAgfQor ICAgIGRlZmF1bHQ6CisgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICB9Cit9CisKK3ZvaWQgQXJn dW1lbnRDb2RlcjxJREJPYmplY3RTdG9yZU1ldGFkYXRhPjo6ZW5jb2RlKEFyZ3VtZW50RW5jb2Rl ciYgZW5jb2RlciwgY29uc3QgSURCT2JqZWN0U3RvcmVNZXRhZGF0YSYgbWV0YWRhdGEpCit7Cisg ICAgZW5jb2RlciA8PCBtZXRhZGF0YS5uYW1lIDw8IG1ldGFkYXRhLmlkIDw8IG1ldGFkYXRhLmtl eVBhdGggPDwgbWV0YWRhdGEuYXV0b0luY3JlbWVudCA8PCBtZXRhZGF0YS5tYXhJbmRleElkIDw8 IG1ldGFkYXRhLmluZGV4ZXM7Cit9CisKK2Jvb2wgQXJndW1lbnRDb2RlcjxJREJPYmplY3RTdG9y ZU1ldGFkYXRhPjo6ZGVjb2RlKEFyZ3VtZW50RGVjb2RlciYgZGVjb2RlciwgSURCT2JqZWN0U3Rv cmVNZXRhZGF0YSYgbWV0YWRhdGEpCit7CisgICAgaWYgKCFkZWNvZGVyLmRlY29kZShtZXRhZGF0 YS5uYW1lKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgaWYgKCFkZWNvZGVyLmRlY29k ZShtZXRhZGF0YS5pZCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIGlmICghZGVjb2Rl ci5kZWNvZGUobWV0YWRhdGEua2V5UGF0aCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAg IGlmICghZGVjb2Rlci5kZWNvZGUobWV0YWRhdGEuYXV0b0luY3JlbWVudCkpCisgICAgICAgIHJl dHVybiBmYWxzZTsKKworICAgIGlmICghZGVjb2Rlci5kZWNvZGUobWV0YWRhdGEubWF4SW5kZXhJ ZCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIGlmICghZGVjb2Rlci5kZWNvZGUobWV0 YWRhdGEuaW5kZXhlcykpCisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIHJldHVybiB0cnVl OworfQorI2VuZGlmCisKIH0gLy8gbmFtZXNwYWNlIENvcmVJUEMKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1NoYXJlZC9XZWJDb3JlQXJndW1lbnRDb2RlcnMuaCBiL1NvdXJjZS9XZWJLaXQy L1NoYXJlZC9XZWJDb3JlQXJndW1lbnRDb2RlcnMuaAppbmRleCAxOGRiY2Y4Li42ODg4MTM5IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViQ29yZUFyZ3VtZW50Q29kZXJzLmgK KysrIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYkNvcmVBcmd1bWVudENvZGVycy5oCkBAIC00 MSw2ICs0MSw3IEBAIGNsYXNzIEZsb2F0UG9pbnQzRDsKIGNsYXNzIEZsb2F0UmVjdDsKIGNsYXNz IEZsb2F0U2l6ZTsKIGNsYXNzIEhUVFBIZWFkZXJNYXA7CitjbGFzcyBJREJLZXlQYXRoOwogY2xh c3MgSW50UG9pbnQ7CiBjbGFzcyBJbnRSZWN0OwogY2xhc3MgSW50U2l6ZTsKQEAgLTYwLDYgKzYx LDkgQEAgc3RydWN0IENvb2tpZTsKIHN0cnVjdCBEaWN0YXRpb25BbHRlcm5hdGl2ZTsKIHN0cnVj dCBEcmFnU2Vzc2lvbjsKIHN0cnVjdCBGaWxlQ2hvb3NlclNldHRpbmdzOworc3RydWN0IElEQkRh dGFiYXNlTWV0YWRhdGE7CitzdHJ1Y3QgSURCSW5kZXhNZXRhZGF0YTsKK3N0cnVjdCBJREJPYmpl Y3RTdG9yZU1ldGFkYXRhOwogc3RydWN0IExlbmd0aDsKIHN0cnVjdCBHcmFtbWFyRGV0YWlsOwog c3RydWN0IE1pbWVDbGFzc0luZm87CkBAIC0yOTgsNiArMzAyLDI4IEBAIHRlbXBsYXRlPD4gc3Ry dWN0IEFyZ3VtZW50Q29kZXI8V2ViQ29yZTo6RmlsdGVyT3BlcmF0aW9ucz4gewogfTsKICNlbmRp ZgogCisjaWYgRU5BQkxFKElOREVYRURfREFUQUJBU0UpCit0ZW1wbGF0ZTw+IHN0cnVjdCBBcmd1 bWVudENvZGVyPFdlYkNvcmU6OklEQkRhdGFiYXNlTWV0YWRhdGE+IHsKKyAgICBzdGF0aWMgdm9p ZCBlbmNvZGUoQXJndW1lbnRFbmNvZGVyJiwgY29uc3QgV2ViQ29yZTo6SURCRGF0YWJhc2VNZXRh ZGF0YSYpOworICAgIHN0YXRpYyBib29sIGRlY29kZShBcmd1bWVudERlY29kZXImLCBXZWJDb3Jl OjpJREJEYXRhYmFzZU1ldGFkYXRhJik7Cit9OworCit0ZW1wbGF0ZTw+IHN0cnVjdCBBcmd1bWVu dENvZGVyPFdlYkNvcmU6OklEQkluZGV4TWV0YWRhdGE+IHsKKyAgICBzdGF0aWMgdm9pZCBlbmNv ZGUoQXJndW1lbnRFbmNvZGVyJiwgY29uc3QgV2ViQ29yZTo6SURCSW5kZXhNZXRhZGF0YSYpOwor ICAgIHN0YXRpYyBib29sIGRlY29kZShBcmd1bWVudERlY29kZXImLCBXZWJDb3JlOjpJREJJbmRl eE1ldGFkYXRhJik7Cit9OworCit0ZW1wbGF0ZTw+IHN0cnVjdCBBcmd1bWVudENvZGVyPFdlYkNv cmU6OklEQktleVBhdGg+IHsKKyAgICBzdGF0aWMgdm9pZCBlbmNvZGUoQXJndW1lbnRFbmNvZGVy JiwgY29uc3QgV2ViQ29yZTo6SURCS2V5UGF0aCYpOworICAgIHN0YXRpYyBib29sIGRlY29kZShB cmd1bWVudERlY29kZXImLCBXZWJDb3JlOjpJREJLZXlQYXRoJik7Cit9OworCit0ZW1wbGF0ZTw+ IHN0cnVjdCBBcmd1bWVudENvZGVyPFdlYkNvcmU6OklEQk9iamVjdFN0b3JlTWV0YWRhdGE+IHsK KyAgICBzdGF0aWMgdm9pZCBlbmNvZGUoQXJndW1lbnRFbmNvZGVyJiwgY29uc3QgV2ViQ29yZTo6 SURCT2JqZWN0U3RvcmVNZXRhZGF0YSYpOworICAgIHN0YXRpYyBib29sIGRlY29kZShBcmd1bWVu dERlY29kZXImLCBXZWJDb3JlOjpJREJPYmplY3RTdG9yZU1ldGFkYXRhJik7Cit9OworI2VuZGlm CisKIH0gLy8gbmFtZXNwYWNlIENvcmVJUEMKIAogI2VuZGlmIC8vIFdlYkNvcmVBcmd1bWVudENv ZGVyc19oCg==