124688 2013-11-20 16:27:31 -0800 REGRESSION(159395) Fix branch8(…, AbsoluteAddress, …) in ARM64 MacroAssembler 2013-11-21 16:29:34 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 952843 0 msaboff 2013-11-20 16:27:31 -0800 Since http://trac.webkit.org/changeset/159395, ARM64 build won't compile due to broken implementation of branch8(RelationalCondition cond, AbsoluteAddress left, TrustedImm32 right). The load8() of the AbsoluteAddress needs to be handle differently. 953331 1 217623 msaboff 2013-11-21 16:13:58 -0800 Created attachment 217623 Patch 953333 2 217623 ggaren 2013-11-21 16:17:05 -0800 Comment on attachment 217623 Patch r=me 953340 3 msaboff 2013-11-21 16:29:34 -0800 Committed r159653: <http://trac.webkit.org/changeset/159653> 217623 2013-11-21 16:13:58 -0800 2013-11-21 16:17:05 -0800 Patch 124688.patch text/plain 1514 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU5NjUyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEzLTExLTIxICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFJFR1JFU1NJT04oMTU5Mzk1KSBGaXggYnJhbmNoOCjigKYsIEFic29sdXRlQWRkcmVzcywg 4oCmKSBpbiBBUk02NCBNYWNyb0Fzc2VtYmxlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI0Njg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQ2hhbmdlZCBoYW5kbGluZyBvZiB0aGUgYWRkcmVzcyBmb3Ig dGhlIGxvYWQ4KCkgaW4gdGhlIGJyYW5jaDgoQWJzb2x1dGVBZGRyZXNzKSB0byBiZSBsaWtlCisg ICAgICAgIHRoZSByZXN0IG9mIHRoZSBicmFuY2hYWChBYnNvbHV0ZUFkZHJlc3MpIGZ1Y250aW9u cy4KKworICAgICAgICAqIGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTTY0Lmg6CisgICAgICAg IChKU0M6Ok1hY3JvQXNzZW1ibGVyQVJNNjQ6OmJyYW5jaDgpOgorCiAyMDEzLTExLTIxICBGaWxp cCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgQnl0ZWNvZGVHZW5lcmF0b3Ig c2hvdWxkIGFsaWduIHRoZSBzdGFjayBhY2NvcmRpbmcgdG8gbmF0aXZlIGNvbnZlbnRpb25zCklu ZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNNjQu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNz ZW1ibGVyQVJNNjQuaAkocmV2aXNpb24gMTU5NjUxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTTY0LmgJKHdvcmtpbmcgY29weSkKQEAgLTE2NDEs NyArMTY0MSw3IEBAIHB1YmxpYzoKICAgICBKdW1wIGJyYW5jaDgoUmVsYXRpb25hbENvbmRpdGlv biBjb25kLCBBYnNvbHV0ZUFkZHJlc3MgbGVmdCwgVHJ1c3RlZEltbTMyIHJpZ2h0KQogICAgIHsK ICAgICAgICAgQVNTRVJUKCEoMHhmZmZmZmYwMCAmIHJpZ2h0Lm1fdmFsdWUpKTsKLSAgICAgICAg bG9hZDgobGVmdCwgZ2V0Q2FjaGVkTWVtb3J5VGVtcFJlZ2lzdGVySURBbmRJbnZhbGlkYXRlKCkp OworICAgICAgICBsb2FkOChsZWZ0Lm1fcHRyLCBnZXRDYWNoZWREYXRhVGVtcFJlZ2lzdGVySURB bmRJbnZhbGlkYXRlKCkpOwogICAgICAgICByZXR1cm4gYnJhbmNoMzIoY29uZCwgbWVtb3J5VGVt cFJlZ2lzdGVyLCByaWdodCk7CiAgICAgfQogICAgIAo=