<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>124684</bug_id>
          
          <creation_ts>2013-11-20 15:35:48 -0800</creation_ts>
          <short_desc>Add compile flag for SH_UNFOLD_SHORT_CIRCUIT when compiling shaders.</short_desc>
          <delta_ts>2013-11-20 16:03:10 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebGL</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Roger Fong">roger_fong</reporter>
          <assigned_to name="Roger Fong">roger_fong</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dino</cc>
    
    <cc>kondapallykalyan</cc>
    
    <cc>noam</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>952814</commentid>
    <comment_count>0</comment_count>
    <who name="Roger Fong">roger_fong</who>
    <bug_when>2013-11-20 15:35:48 -0800</bug_when>
    <thetext>Add compile flag for SH_UNFOLD_SHORT_CIRCUIT when compiling shaders.
Fixes  webgl conformance 1.0.2 test, glsl/misc/shader-with-short-circuiting-operators.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>952815</commentid>
    <comment_count>1</comment_count>
    <who name="Roger Fong">roger_fong</who>
    <bug_when>2013-11-20 15:36:01 -0800</bug_when>
    <thetext>&lt;rdar://problem/15203356&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>952817</commentid>
    <comment_count>2</comment_count>
      <attachid>217486</attachid>
    <who name="Roger Fong">roger_fong</who>
    <bug_when>2013-11-20 15:37:30 -0800</bug_when>
    <thetext>Created attachment 217486
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>952818</commentid>
    <comment_count>3</comment_count>
      <attachid>217486</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2013-11-20 15:40:28 -0800</bug_when>
    <thetext>Comment on attachment 217486
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>952830</commentid>
    <comment_count>4</comment_count>
      <attachid>217486</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2013-11-20 16:03:08 -0800</bug_when>
    <thetext>Comment on attachment 217486
Patch

Clearing flags on attachment: 217486

Committed r159590: &lt;http://trac.webkit.org/changeset/159590&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>952831</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2013-11-20 16:03:10 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>217486</attachid>
            <date>2013-11-20 15:37:30 -0800</date>
            <delta_ts>2013-11-20 16:03:08 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-124684-20131120153729.patch</filename>
            <type>text/plain</type>
            <size>1570</size>
            <attacher name="Roger Fong">roger_fong</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1OTU4NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTExLTIwICBSb2dlciBG
b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIGNvbXBpbGUgZmxhZyBT
SF9VTkZPTERfU0hPUlRfQ0lSQ1VJVCB3aGVuIGNvbXBpbGluZyBzaGFkZXJzLgorICAgICAgICBo
dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI0Njg0LgorCisgICAgICAg
IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEV4aXN0aW5nIHRlc3Qgd2Vi
Z2wvMS4wLjIvY29uZm9ybWFuY2UvZ2xzbC9taXNjL3NoYWRlci13aXRoLXNob3J0LWNpcmN1aXRp
bmctb3BlcmF0b3JzLmh0bWwKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9F
eHRlbnNpb25zM0RPcGVuR0xDb21tb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6RXh0ZW5zaW9u
czNET3BlbkdMQ29tbW9uOjpnZXRUcmFuc2xhdGVkU2hhZGVyU291cmNlQU5HTEUpOgorCiAyMDEz
LTExLTIwICBSb2JlcnQgU2lwa2EgIDxzaXBrYUBpbmYudS1zemVnZWQuaHU+CiAKICAgICAgICAg
W2N1cmxdIEltcHJvdmUgZGV0ZWN0aW5nIGFuZCBoYW5kbGluZyBvZiBTU0wgcmVsYXRlZCBlcnJv
cnMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9FeHRlbnNp
b25zM0RPcGVuR0xDb21tb24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRm
b3JtL2dyYXBoaWNzL29wZW5nbC9FeHRlbnNpb25zM0RPcGVuR0xDb21tb24uY3BwCShyZXZpc2lv
biAxNTk1NDIpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvRXh0
ZW5zaW9uczNET3BlbkdMQ29tbW9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTcwLDcgKzE3MCw3
IEBAIFN0cmluZyBFeHRlbnNpb25zM0RPcGVuR0xDb21tb246OmdldFRyYW4KIAogICAgIFN0cmlu
ZyB0cmFuc2xhdGVkU2hhZGVyU291cmNlOwogICAgIFN0cmluZyBzaGFkZXJJbmZvTG9nOwotICAg
IGludCBleHRyYUNvbXBpbGVPcHRpb25zID0gU0hfTUFQX0xPTkdfVkFSSUFCTEVfTkFNRVMgfCBT
SF9DTEFNUF9JTkRJUkVDVF9BUlJBWV9CT1VORFM7CisgICAgaW50IGV4dHJhQ29tcGlsZU9wdGlv
bnMgPSBTSF9NQVBfTE9OR19WQVJJQUJMRV9OQU1FUyB8IFNIX0NMQU1QX0lORElSRUNUX0FSUkFZ
X0JPVU5EUyB8IFNIX1VORk9MRF9TSE9SVF9DSVJDVUlUOwogCiAgICAgaWYgKG1fcmVxdWlyZXNC
dWlsdEluRnVuY3Rpb25FbXVsYXRpb24pCiAgICAgICAgIGV4dHJhQ29tcGlsZU9wdGlvbnMgfD0g
U0hfRU1VTEFURV9CVUlMVF9JTl9GVU5DVElPTlM7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>