124681 2013-11-20 15:00:50 -0800 Enable PageLoadTest assertions again 2014-09-01 06:41:48 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 952795 0 andersca 2013-11-20 15:00:50 -0800 Enable PageLoadTest assertions again 952798 1 217484 andersca 2013-11-20 15:04:39 -0800 Created attachment 217484 Patch 952803 2 andersca 2013-11-20 15:20:19 -0800 Committed r159586: <http://trac.webkit.org/changeset/159586> 1032482 3 217484 cgarcia 2014-09-01 06:41:48 -0700 Comment on attachment 217484 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217484&action=review > Source/WebKit2/UIProcess/PageLoadState.cpp:112 > - ASSERT(!m_url.isEmpty()); > + Why was this wrong? shouldn't we reset the url in didStartProvisionalLoad? I've noticed a problem because of this: 1.- load something successfully, m_url is updated 2.- load something that fails 3.- the active URL is the one from the previous load, because at this point the pending API request URL has been reset, there's no unreachable URL and state finish. I also wonder if we should use the provisional URL as the unreachable one in case of provisional load failure, when there's no last unreachable url. We should definitely add a unit tests for these things. 217484 2013-11-20 15:04:39 -0800 2014-09-01 06:41:48 -0700 Patch bug-124681-20131120150437.patch text/plain 4961 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5NTg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZDIyM2Y0Y2Y2YzEzZjhj ZWMxYWE1NzgwOWEwOWNlMjZjNzA2OGNkMC4uZDYwNTA4NzhhY2NiYjA5MDcwNmUxYzVhOTZiYjUx N2Y4YjYxMDgwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDEzLTExLTIwICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgRW5hYmxlIFBhZ2VM b2FkVGVzdCBhc3NlcnRpb25zIGFnYWluCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMjQ2ODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBSZW1vdmUgYW4gb3ZlcnplYWxvdXMgYXNzZXJ0aW9uIGFuZCByZS1l bmFibGUgYXNzZXJ0aW9ucyBpbiBQYWdlTG9hZFN0YXRlIGFnYWluLgorCisgICAgICAgICogVUlQ cm9jZXNzL1BhZ2VMb2FkU3RhdGUuY3BwOgorICAgICAgICAoV2ViS2l0OjpQYWdlTG9hZFN0YXRl OjpkaWRDb21taXRMb2FkKToKKyAgICAgICAgUmVtb3ZlIGFzc2VydGlvbiAtIGl0J3MgZmluZSBm b3IgYSBwYWdlIHRvIGhhdmUgYSBudWxsIFVSTC4KKworICAgICAgICAoV2ViS2l0OjpQYWdlTG9h ZFN0YXRlOjpkaWRGaW5pc2hMb2FkKToKKyAgICAgICAgRGl0dG8uCisKKyAgICAgICAgKFdlYktp dDo6UGFnZUxvYWRTdGF0ZTo6ZGlkRmFpbExvYWQpOgorICAgICAgICBVcGRhdGUgdGhlIHN0YXRl LgorCisyMDEzLTExLTIwICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisK ICAgICAgICAgUGFnZUxvYWRTdGF0ZSBzaG91bGQga2VlcCB0cmFjayBvZiB1bnJlYWNoYWJsZSBV UkxzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQ2 NzcKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BhZ2VMb2FkU3RhdGUu Y3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BhZ2VMb2FkU3RhdGUuY3BwCmluZGV4IGVl NWU0NTJjODY5ZDNmYjcwZGVmY2EzNmVmMGFiY2E2MTg0NDM4MjQuLmE1YWMzNWJkODc4ZTc3ZDY1 NjQzMjY2ZTRkZGFmM2U3ZjU1OWNkODIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9QYWdlTG9hZFN0YXRlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGFn ZUxvYWRTdGF0ZS5jcHAKQEAgLTI2LDkgKzI2LDYgQEAKICNpbmNsdWRlICJjb25maWcuaCIKICNp bmNsdWRlICJQYWdlTG9hZFN0YXRlLmgiCiAKLSN1bmRlZiBBU1NFUlQKLSNkZWZpbmUgQVNTRVJU KHgpICgodm9pZCkwKQotCiBuYW1lc3BhY2UgV2ViS2l0IHsKIAogUGFnZUxvYWRTdGF0ZTo6UGFn ZUxvYWRTdGF0ZSgpCkBAIC05NSw3ICs5Miw2IEBAIHZvaWQgUGFnZUxvYWRTdGF0ZTo6ZGlkRmFp bFByb3Zpc2lvbmFsTG9hZCgpCiB2b2lkIFBhZ2VMb2FkU3RhdGU6OmRpZENvbW1pdExvYWQoKQog ewogICAgIEFTU0VSVChtX3N0YXRlID09IFN0YXRlOjpQcm92aXNpb25hbCk7Ci0gICAgQVNTRVJU KCFtX3Byb3Zpc2lvbmFsVVJMLmlzRW1wdHkoKSk7CiAKICAgICBtX3N0YXRlID0gU3RhdGU6OkNv bW1pdHRlZDsKICAgICBtX3VybCA9IG1fcHJvdmlzaW9uYWxVUkw7CkBAIC0xMDYsNyArMTAyLDYg QEAgdm9pZCBQYWdlTG9hZFN0YXRlOjpkaWRGaW5pc2hMb2FkKCkKIHsKICAgICBBU1NFUlQobV9z dGF0ZSA9PSBTdGF0ZTo6Q29tbWl0dGVkKTsKICAgICBBU1NFUlQobV9wcm92aXNpb25hbFVSTC5p c0VtcHR5KCkpOwotICAgIEFTU0VSVCghbV91cmwuaXNFbXB0eSgpKTsKIAogICAgIG1fc3RhdGUg PSBTdGF0ZTo6RmluaXNoZWQ7CiB9CkBAIC0xMTQsNyArMTA5LDggQEAgdm9pZCBQYWdlTG9hZFN0 YXRlOjpkaWRGaW5pc2hMb2FkKCkKIHZvaWQgUGFnZUxvYWRTdGF0ZTo6ZGlkRmFpbExvYWQoKQog ewogICAgIEFTU0VSVChtX3Byb3Zpc2lvbmFsVVJMLmlzRW1wdHkoKSk7Ci0gICAgQVNTRVJUKCFt X3VybC5pc0VtcHR5KCkpOworCisgICAgbV9zdGF0ZSA9IFN0YXRlOjpGaW5pc2hlZDsKIH0KIAog dm9pZCBQYWdlTG9hZFN0YXRlOjpkaWRTYW1lRG9jdW1lbnROYXZpZ2F0aW9uKGNvbnN0IFN0cmlu ZyYgdXJsKQpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmlu ZGV4IDEzM2QzZGUyMzU4M2EwOWVhNmQ3YjVkNGMwN2QxYzM0YWYyNTllZWUuLjNiNjI4MmQ2MDhk NzZiYWM0YmNkZjkxZTg0ZTdiYzc3NDkwNTgyOTYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxv ZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMy0xMS0yMCAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCisgICAgICAgIEVuYWJsZSBQYWdl TG9hZFRlc3QgYXNzZXJ0aW9ucyBhZ2FpbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTI0NjgxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RXZWJLaXRBUEkueGNvZGVwcm9q L3Byb2plY3QucGJ4cHJvajoKKyAgICAgICAgQWN0dWFsbHkgaW5zdGFsbCBhbGwtY29udGVudC1p bi1vbmUtaWZyYW1lLmh0bWwsIG5vdGljZWQgd2hpbGUgZGVidWdnaW5nIHRoaXMgYXNzZXJ0aW9u LgorCiAyMDEzLTExLTIwICBNYXJrIFJvd2UgIDxtcm93ZUBhcHBsZS5jb20+CiAKICAgICAgICAg UmVtb3ZlIHNvbWUgb2Jzb2xldGUgbG9naWMgZnJvbSBXZWJLaXQuYXBwLgpkaWZmIC0tZ2l0IGEv VG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0V2ViS2l0QVBJLnhjb2RlcHJvai9wcm9qZWN0LnBieHBy b2ogYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RXZWJLaXRBUEkueGNvZGVwcm9qL3Byb2plY3Qu cGJ4cHJvagppbmRleCA0Y2IzMGYwZTZlODAyNDIyOTgzODhlNzQ1ZWFlODQyZThlZjJiNzBmLi40 OTM2YjFjOGE0ZTJmM2Y0ZWJhZWJjZjc2NjY2NWI0NjZmM2U4MTg1IDEwMDY0NAotLS0gYS9Ub29s cy9UZXN0V2ViS2l0QVBJL1Rlc3RXZWJLaXRBUEkueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagor KysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RXZWJLaXRBUEkueGNvZGVwcm9qL3Byb2plY3Qu cGJ4cHJvagpAQCAtMTksNiArMTksNyBAQAogCQkxQTAyQzg0RjEyNUQ0QTg0MDBFM0Y0QkQgLyog RmluZC5jcHAgaW4gU291cmNlcyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSAx QTAyQzg0RTEyNUQ0QTg0MDBFM0Y0QkQgLyogRmluZC5jcHAgKi87IH07CiAJCTFBMDJDODcwMTI1 RDRDRkQwMEUzRjRCRCAvKiBmaW5kLmh0bWwgaW4gQ29weSBSZXNvdXJjZXMgKi8gPSB7aXNhID0g UEJYQnVpbGRGaWxlOyBmaWxlUmVmID0gMUEwMkM4NEIxMjVENEE1RTAwRTNGNEJEIC8qIGZpbmQu aHRtbCAqLzsgfTsKIAkJMUE1RkVGREQxMjcwRTJBMzAwMEUyOTIxIC8qIEV2YWx1YXRlSmF2YVNj cmlwdC5jcHAgaW4gU291cmNlcyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSAx QTVGRUZEQzEyNzBFMkEzMDAwRTI5MjEgLyogRXZhbHVhdGVKYXZhU2NyaXB0LmNwcCAqLzsgfTsK KwkJMUE2MzQ3OUYxODNENzJBNDAwNUIxNzA3IC8qIGFsbC1jb250ZW50LWluLW9uZS1pZnJhbWUu aHRtbCBpbiBDb3B5IFJlc291cmNlcyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYg PSA5M0QzRDE5QjE3QjFBN0IwMDBDN0M0MTUgLyogYWxsLWNvbnRlbnQtaW4tb25lLWlmcmFtZS5o dG1sICovOyB9OwogCQkxQTdCRkMwQzE3MUEwQkRCMDBCQzVGNjQgLyogV2lsbFNlbmRTdWJtaXRF dmVudC5tbSBpbiBTb3VyY2VzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IDFB N0JGQzBBMTcxQTBCREIwMEJDNUY2NCAvKiBXaWxsU2VuZFN1Ym1pdEV2ZW50Lm1tICovOyB9Owog CQkxQTdFOEIzNDE4MTIwOERFMDBBRUI3NEEgLyogRnJhZ21lbnROYXZpZ2F0aW9uLm1tIGluIFNv dXJjZXMgKi8gPSB7aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0gMUE3RThCMzMxODEyMDhE RTAwQUVCNzRBIC8qIEZyYWdtZW50TmF2aWdhdGlvbi5tbSAqLzsgfTsKIAkJMUE3RThCMzYxODEy MEIyRjAwQUVCNzRBIC8qIEZyYWdtZW50TmF2aWdhdGlvbi5odG1sIGluIENvcHkgUmVzb3VyY2Vz ICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IDFBN0U4QjM1MTgxMjA5MzYwMEFF Qjc0QSAvKiBGcmFnbWVudE5hdmlnYXRpb24uaHRtbCAqLzsgfTsKQEAgLTI4Miw2ICsyODMsNyBA QAogCQkJCUY2QjdCRTk3MTc0NjlCOTYwMDhBMzQ0NSAvKiBhc3NvY2lhdGUtZm9ybS1jb250cm9s cy5odG1sIGluIENvcHkgUmVzb3VyY2VzICovLAogCQkJCTM3OTAyOEI5MTRGQUMyNEMwMDdFNkI0 MyAvKiBhY2NlcHRzRmlyc3RNb3VzZS5odG1sIGluIENvcHkgUmVzb3VyY2VzICovLAogCQkJCUI1 NUYxMUJFMTUxOTFBMDYwMDkxNTkxNiAvKiBBaGVtLnR0ZiBpbiBDb3B5IFJlc291cmNlcyAqLywK KwkJCQkxQTYzNDc5RjE4M0Q3MkE0MDA1QjE3MDcgLyogYWxsLWNvbnRlbnQtaW4tb25lLWlmcmFt ZS5odG1sIGluIENvcHkgUmVzb3VyY2VzICovLAogCQkJCUI1NUYxMUI3MTUxN0QwMzMwMDkxNTkx NiAvKiBhdHRyaWJ1dGVkU3RyaW5nQ3VzdG9tRm9udC5odG1sIGluIENvcHkgUmVzb3VyY2VzICov LAogCQkJCTdDOUVEOThCMTdBMTlGNEIwMEU0REMzMyAvKiBhdHRyaWJ1dGVkU3RyaW5nU3RyaWtl dGhyb3VnaC5odG1sIGluIENvcHkgUmVzb3VyY2VzICovLAogCQkJCTc2RTE4MkRGMTU0NzY3RTYw MEYxRkFERCAvKiBhdXRvLXN1Ym1pdHRpbmctZm9ybS5odG1sIGluIENvcHkgUmVzb3VyY2VzICov LAo=