124654 2013-11-20 07:20:22 -0800 [GStreamer] GStreamerVersioning's funtion utility setGstBufferSize casts from signed values to unsigned without checking 2013-12-08 11:40:20 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 124534 1 agomez webkit-unassigned andersca commit-queue eric.carlson gustavo menard mrobinson ossy pnormand sam oldest_to_newest 952562 0 agomez 2013-11-20 07:20:22 -0800 setGstBufferSize allows an "int" typed value as newSize and casts to unsigned "gsize" type for the 0.10 version. 952564 1 217428 agomez 2013-11-20 07:24:22 -0800 Created attachment 217428 Patch 952606 2 217428 mrobinson 2013-11-20 08:41:29 -0800 Comment on attachment 217428 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217428&action=review setGstBufferSize will be going away once the GStreamer 0.10 code is removed. It might be better to re-evaluate your patch then. > Source/WebCore/platform/graphics/gstreamer/GStreamerVersioning.cpp:166 > + ASSERT((static_cast<gint64>(G_MINSSIZE) > newSize) > + || (static_cast<gint64>(G_MAXSSIZE) < newSize)); This should be one line. > Source/WebCore/platform/graphics/gstreamer/GStreamerVersioning.cpp:171 > + ASSERT((0 > newSize) > + || (static_cast<gint64>(G_MAXUINT) < newSize)); Ditto. 952635 3 agomez 2013-11-20 09:45:58 -0800 (In reply to comment #2) > (From update of attachment 217428 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=217428&action=review > > setGstBufferSize will be going away once the GStreamer 0.10 code is removed. It might be better to re-evaluate your patch then. Blocking with bug 124534 , then. > > Source/WebCore/platform/graphics/gstreamer/GStreamerVersioning.cpp:166 > > + ASSERT((static_cast<gint64>(G_MINSSIZE) > newSize) > > + || (static_cast<gint64>(G_MAXSSIZE) < newSize)); > > This should be one line. Just to know for further patches. I was just following the recommendation in the point 5. of the "Indentation" section at: http://www.webkit.org/coding/coding-style.html Then, which is the maximum line length or when it is OK to write a sentence in more than one line? 953933 4 agomez 2013-11-25 02:29:38 -0800 After closing bug 124534 this becomes INVALID. 957680 5 217428 zan 2013-12-08 11:40:20 -0800 Comment on attachment 217428 Patch Clearing the reviewing flags since the patch was closed as invalid. 217428 2013-11-20 07:24:22 -0800 2013-12-08 11:40:20 -0800 Patch bug-124654-20131120172421.patch text/plain 2998 agomez U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5Mjg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODNiZDAwZDljN2IxMjU0 YjNhMzUyNjc0MGU5MDcwMzM5MmZlNjdiZS4uMDliOWYxMjhkZDFlN2ViYWUzOWY4NDZiNmViM2Mx MTYxNGZlMGI2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEzLTExLTIwICBBbmRy ZXMgR29tZXogIDxhZ29tZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVyXSBHU3Ry ZWFtZXJWZXJzaW9uaW5nJ3MgZnVudGlvbiB1dGlsaXR5IHNldEdzdEJ1ZmZlclNpemUgY2FzdHMg ZnJvbSBzaWduZWQgdmFsdWVzIHRvIHVuc2lnbmVkIHdpdGhvdXQgY2hlY2tpbmcKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDY1NAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vZGlmaWVkIEFQSSB0byBs ZXQgYSB0eXBlIHRoYXQgd291bGQgaG9sZCBhbnkgdmFsaWQgdmFsdWUgZm9yIHRoZQorICAgICAg ICBHU3RyZWFtZXIgMS4wIG9yIDAuMTAgQVBJcy4KKworICAgICAgICBJdCB3b3VsZCBhc3NlcnQg aWYgdGhlIHBhc3NlZCB2YWx1ZSBpcyBub3QgdmFsaWQgZm9yIHRoZSBzcGVjaWZpYworICAgICAg ICBHU3RyZWFtZXIgdmVyc2lvbi4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJl YW1lci9HU3RyZWFtZXJWZXJzaW9uaW5nLmNwcDoKKyAgICAgICAgKHNldEdzdEJ1ZmZlclNpemUp OiBBc3NlcnRpbmcgb24gbm9uIHZhbGlkIHZhbHVlcyBmb3IgdGhlIHNwZWNpZmljCisgICAgICAg IEFQSSB2ZXJzaW9uLgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9HU3Ry ZWFtZXJWZXJzaW9uaW5nLmg6IEFQSSB1c2VzIG5vdworICAgICAgICBnaW50NjQgZm9yIHRoZSBu ZXdTaXplIHZhbHVlLgorCiAyMDEzLTExLTE0ICBTZW9ranUgS3dvbiAgPHNlb2tqdUB3ZWJraXQu b3JnPgogCiAgICAgICAgIFVzZSBbSW1wbGVtZW50ZWRBcz1kZWZhdWx0U3RhdHVzXSBmb3IgV2lu ZG93LmRlZmF1bHRzdGF0dXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2dzdHJlYW1lci9HU3RyZWFtZXJWZXJzaW9uaW5nLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9HU3RyZWFtZXJWZXJzaW9uaW5nLmNwcAppbmRl eCAzNWU5NmIzNDJiYmQ3YmQ3MjQwZGFjMmYzMTQxNTk4NTNhYWE5MzQ1Li4wMzg3ZDk0YzZiMjUy MzA4YTEzZTFlODNhOTQzMGFiMDU5NTY3MzE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvR1N0cmVhbWVyVmVyc2lvbmluZy5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dTdHJlYW1lclZlcnNp b25pbmcuY3BwCkBAIC0xNTksMTIgKzE1OSwxOCBAQCBpbnQgZ2V0R3N0QnVmZmVyU2l6ZShHc3RC dWZmZXIqIGJ1ZmZlcikKICNlbmRpZgogfQogCi12b2lkIHNldEdzdEJ1ZmZlclNpemUoR3N0QnVm ZmVyKiBidWZmZXIsIGludCBuZXdTaXplKQordm9pZCBzZXRHc3RCdWZmZXJTaXplKEdzdEJ1ZmZl ciogYnVmZmVyLCBnaW50NjQgbmV3U2l6ZSkKIHsKICNpZmRlZiBHU1RfQVBJX1ZFUlNJT05fMQor ICAgIEFTU0VSVCgoc3RhdGljX2Nhc3Q8Z2ludDY0PihHX01JTlNTSVpFKSA+IG5ld1NpemUpCisg ICAgICAgIHx8IChzdGF0aWNfY2FzdDxnaW50NjQ+KEdfTUFYU1NJWkUpIDwgbmV3U2l6ZSkpOwor CiAgICAgZ3N0X2J1ZmZlcl9zZXRfc2l6ZShidWZmZXIsIHN0YXRpY19jYXN0PGdzc2l6ZT4obmV3 U2l6ZSkpOwogI2Vsc2UKLSAgICBHU1RfQlVGRkVSX1NJWkUoYnVmZmVyKSA9IHN0YXRpY19jYXN0 PGdzaXplPihuZXdTaXplKTsKKyAgICBBU1NFUlQoKDAgPiBuZXdTaXplKQorICAgICAgICB8fCAo c3RhdGljX2Nhc3Q8Z2ludDY0PihHX01BWFVJTlQpIDwgbmV3U2l6ZSkpOworCisgICAgR1NUX0JV RkZFUl9TSVpFKGJ1ZmZlcikgPSBzdGF0aWNfY2FzdDxndWludD4obmV3U2l6ZSk7CiAjZW5kaWYK IH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVh bWVyL0dTdHJlYW1lclZlcnNpb25pbmcuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2dzdHJlYW1lci9HU3RyZWFtZXJWZXJzaW9uaW5nLmgKaW5kZXggMjQwNTViYjc0MWZkOTA3 YWRjMjU5YzVhNzg0MzEzNGQ2YzU3ZWVmZC4uNzMxM2UyMTFkZTk2MWU1YzY5YmJiMDU4ZTlhNzJm MWI5NTJhN2VhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Z3N0cmVhbWVyL0dTdHJlYW1lclZlcnNpb25pbmcuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvR1N0cmVhbWVyVmVyc2lvbmluZy5oCkBAIC02MCw3ICs2 MCw3IEBAIGJvb2wgZ2V0VmlkZW9TaXplQW5kRm9ybWF0RnJvbUNhcHMoR3N0Q2FwcyosIFdlYkNv cmU6OkludFNpemUmLCBHc3RWaWRlb0Zvcm1hdCYsCiBHc3RCdWZmZXIqIGNyZWF0ZUdzdEJ1ZmZl cihHc3RCdWZmZXIqKTsKIEdzdEJ1ZmZlciogY3JlYXRlR3N0QnVmZmVyRm9yRGF0YShjb25zdCBj aGFyKiBkYXRhLCBpbnQgbGVuZ3RoKTsKIGludCBnZXRHc3RCdWZmZXJTaXplKEdzdEJ1ZmZlciop Owotdm9pZCBzZXRHc3RCdWZmZXJTaXplKEdzdEJ1ZmZlciosIGludCBuZXdTaXplKTsKK3ZvaWQg c2V0R3N0QnVmZmVyU2l6ZShHc3RCdWZmZXIqLCBnaW50NjQgbmV3U2l6ZSk7CiBjaGFyKiBnZXRH c3RCdWZmZXJEYXRhUG9pbnRlcihHc3RCdWZmZXIqKTsKICNpZmRlZiBHU1RfQVBJX1ZFUlNJT05f MQogdm9pZCBtYXBHc3RCdWZmZXIoR3N0QnVmZmVyKik7Cg==