124648 2013-11-20 02:11:05 -0800 [GTK] Do not use deprecated callbacks in WebKitPolicyClient 2013-11-20 02:32:52 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned commit-queue gustavo mrobinson pnormand oldest_to_newest 952503 0 cgarcia 2013-11-20 02:11:05 -0800 Fixes compile warnings for uninitialized callbacks. 952504 1 217410 cgarcia 2013-11-20 02:14:02 -0800 Created attachment 217410 Patch 952505 2 commit-queue 2013-11-20 02:15:48 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 952507 3 cgarcia 2013-11-20 02:32:52 -0800 Committed r159556: <http://trac.webkit.org/changeset/159556> 217410 2013-11-20 02:14:02 -0800 2013-11-20 02:30:21 -0800 Patch wk2-policy-client.diff text/plain 4458 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAxMDExOTAyMC4uZDA4MjM2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEzLTExLTIwICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNv bT4KKworICAgICAgICBbR1RLXSBEbyBub3QgdXNlIGRlcHJlY2F0ZWQgY2FsbGJhY2tzIGluIFdl YktpdFBvbGljeUNsaWVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTI0NjQ4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRml4ZXMgY29tcGlsZSB3YXJuaW5ncyBmb3IgdW5pbml0aWFsaXplZCBjYWxsYmFj a3MuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRQb2xpY3lDbGllbnQuY3Bw OgorICAgICAgICAoZGVjaWRlUG9saWN5Rm9yTmF2aWdhdGlvbkFjdGlvbik6IEFkZCBvcmlnaW5h dGluZ0ZyYW1lIHBhcmFtZXRlci4KKyAgICAgICAgKGRlY2lkZVBvbGljeUZvck5ld1dpbmRvd0Fj dGlvbik6IFJlbmFtZWQgZm9yIGNvbnNpc3RlbmN5LgorICAgICAgICAoZGVjaWRlUG9saWN5Rm9y UmVzcG9uc2UpOiBBZGQgY2FuU2hvd01JTUVUeXBlIHBhcmFtZXRlci4KKyAgICAgICAgKGF0dGFj aFBvbGljeUNsaWVudFRvVmlldyk6IEFkZCBuZXcgY2FsbGJhY2tzLgorCiAyMDEzLTExLTE5ICBS eW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIEVuYWJsZSBIVE1MVGVt cGxhdGVFbGVtZW50IG9uIE1hYyBwb3J0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL2d0ay9XZWJLaXRQb2xpY3lDbGllbnQuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9ndGsvV2ViS2l0UG9saWN5Q2xpZW50LmNwcAppbmRleCA3MmE1MjY2Li4wZWFh OWJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRQ b2xpY3lDbGllbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dl YktpdFBvbGljeUNsaWVudC5jcHAKQEAgLTI5LDcgKzI5LDcgQEAKIAogdXNpbmcgbmFtZXNwYWNl IFdlYktpdDsKIAotc3RhdGljIHZvaWQgZGVjaWRlUG9saWN5Rm9yTmF2aWdhdGlvbkFjdGlvbkNh bGxiYWNrKFdLUGFnZVJlZiBwYWdlLCBXS0ZyYW1lUmVmIGZyYW1lLCBXS0ZyYW1lTmF2aWdhdGlv blR5cGUgbmF2aWdhdGlvblR5cGUsIFdLRXZlbnRNb2RpZmllcnMgbW9kaWZpZXJzLCBXS0V2ZW50 TW91c2VCdXR0b24gbW91c2VCdXR0b24sIFdLVVJMUmVxdWVzdFJlZiByZXF1ZXN0LCBXS0ZyYW1l UG9saWN5TGlzdGVuZXJSZWYgbGlzdGVuZXIsIFdLVHlwZVJlZiB1c2VyRGF0YSwgY29uc3Qgdm9p ZCogY2xpZW50SW5mbykKK3N0YXRpYyB2b2lkIGRlY2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rp b24oV0tQYWdlUmVmIHBhZ2UsIFdLRnJhbWVSZWYgZnJhbWUsIFdLRnJhbWVOYXZpZ2F0aW9uVHlw ZSBuYXZpZ2F0aW9uVHlwZSwgV0tFdmVudE1vZGlmaWVycyBtb2RpZmllcnMsIFdLRXZlbnRNb3Vz ZUJ1dHRvbiBtb3VzZUJ1dHRvbiwgV0tGcmFtZVJlZiBvcmlnaW5hdGluZ0ZyYW1lLCBXS1VSTFJl cXVlc3RSZWYgcmVxdWVzdCwgV0tGcmFtZVBvbGljeUxpc3RlbmVyUmVmIGxpc3RlbmVyLCBXS1R5 cGVSZWYgdXNlckRhdGEsIGNvbnN0IHZvaWQqIGNsaWVudEluZm8pCiB7CiAgICAgR1JlZlB0cjxX ZWJLaXROYXZpZ2F0aW9uUG9saWN5RGVjaXNpb24+IGRlY2lzaW9uID0KICAgICAgICAgYWRvcHRH UmVmKHdlYmtpdE5hdmlnYXRpb25Qb2xpY3lEZWNpc2lvbkNyZWF0ZShzdGF0aWNfY2FzdDxXZWJL aXROYXZpZ2F0aW9uVHlwZT4obmF2aWdhdGlvblR5cGUpLApAQCAtNDMsNyArNDMsNyBAQCBzdGF0 aWMgdm9pZCBkZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uQ2FsbGJhY2soV0tQYWdlUmVm IHBhZ2UsIFdLRnJhbWVSZWYgZgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg V0VCS0lUX1BPTElDWV9ERUNJU0lPTihkZWNpc2lvbi5nZXQoKSkpOwogfQogCi1zdGF0aWMgdm9p ZCBkZWNpZGVQb2xpY3lGb3JOZXdXaW5kb3dBY3Rpb25DYWxsYmFjayhXS1BhZ2VSZWYgcGFnZSwg V0tGcmFtZVJlZiBmcmFtZSwgV0tGcmFtZU5hdmlnYXRpb25UeXBlIG5hdmlnYXRpb25UeXBlLCBX S0V2ZW50TW9kaWZpZXJzIG1vZGlmaWVycywgV0tFdmVudE1vdXNlQnV0dG9uIG1vdXNlQnV0dG9u LCBXS1VSTFJlcXVlc3RSZWYgcmVxdWVzdCwgV0tTdHJpbmdSZWYgZnJhbWVOYW1lLCBXS0ZyYW1l UG9saWN5TGlzdGVuZXJSZWYgbGlzdGVuZXIsIFdLVHlwZVJlZiB1c2VyRGF0YSwgY29uc3Qgdm9p ZCogY2xpZW50SW5mbykKK3N0YXRpYyB2b2lkIGRlY2lkZVBvbGljeUZvck5ld1dpbmRvd0FjdGlv bihXS1BhZ2VSZWYgcGFnZSwgV0tGcmFtZVJlZiBmcmFtZSwgV0tGcmFtZU5hdmlnYXRpb25UeXBl IG5hdmlnYXRpb25UeXBlLCBXS0V2ZW50TW9kaWZpZXJzIG1vZGlmaWVycywgV0tFdmVudE1vdXNl QnV0dG9uIG1vdXNlQnV0dG9uLCBXS1VSTFJlcXVlc3RSZWYgcmVxdWVzdCwgV0tTdHJpbmdSZWYg ZnJhbWVOYW1lLCBXS0ZyYW1lUG9saWN5TGlzdGVuZXJSZWYgbGlzdGVuZXIsIFdLVHlwZVJlZiB1 c2VyRGF0YSwgY29uc3Qgdm9pZCogY2xpZW50SW5mbykKIHsKICAgICBHUmVmUHRyPFdlYktpdE5h dmlnYXRpb25Qb2xpY3lEZWNpc2lvbj4gZGVjaXNpb24gPQogICAgICAgICBhZG9wdEdSZWYod2Vi a2l0TmF2aWdhdGlvblBvbGljeURlY2lzaW9uQ3JlYXRlKHN0YXRpY19jYXN0PFdlYktpdE5hdmln YXRpb25UeXBlPihuYXZpZ2F0aW9uVHlwZSksCkBAIC01Nyw3ICs1Nyw3IEBAIHN0YXRpYyB2b2lk IGRlY2lkZVBvbGljeUZvck5ld1dpbmRvd0FjdGlvbkNhbGxiYWNrKFdLUGFnZVJlZiBwYWdlLCBX S0ZyYW1lUmVmIGZyCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBXRUJLSVRf UE9MSUNZX0RFQ0lTSU9OKGRlY2lzaW9uLmdldCgpKSk7CiB9CiAKLXN0YXRpYyB2b2lkIGRlY2lk ZVBvbGljeUZvclJlc3BvbnNlQ2FsbGJhY2soV0tQYWdlUmVmIHBhZ2UsIFdLRnJhbWVSZWYgZnJh bWUsIFdLVVJMUmVzcG9uc2VSZWYgcmVzcG9uc2UsIFdLVVJMUmVxdWVzdFJlZiByZXF1ZXN0LCBX S0ZyYW1lUG9saWN5TGlzdGVuZXJSZWYgbGlzdGVuZXIsIFdLVHlwZVJlZiB1c2VyRGF0YSwgY29u c3Qgdm9pZCogY2xpZW50SW5mbykKK3N0YXRpYyB2b2lkIGRlY2lkZVBvbGljeUZvclJlc3BvbnNl KFdLUGFnZVJlZiBwYWdlLCBXS0ZyYW1lUmVmIGZyYW1lLCBXS1VSTFJlc3BvbnNlUmVmIHJlc3Bv bnNlLCBXS1VSTFJlcXVlc3RSZWYgcmVxdWVzdCwgYm9vbCBjYW5TaG93TUlNRVR5cGUsIFdLRnJh bWVQb2xpY3lMaXN0ZW5lclJlZiBsaXN0ZW5lciwgV0tUeXBlUmVmIHVzZXJEYXRhLCBjb25zdCB2 b2lkKiBjbGllbnRJbmZvKQogewogICAgIEdSZWZQdHI8V2ViS2l0UmVzcG9uc2VQb2xpY3lEZWNp c2lvbj4gZGVjaXNpb24gPQogICAgICAgICBhZG9wdEdSZWYod2Via2l0UmVzcG9uc2VQb2xpY3lE ZWNpc2lvbkNyZWF0ZSh0b0ltcGwocmVxdWVzdCksIHRvSW1wbChyZXNwb25zZSksIHRvSW1wbChs aXN0ZW5lcikpKTsKQEAgLTcxLDEwICs3MSwxMiBAQCB2b2lkIGF0dGFjaFBvbGljeUNsaWVudFRv VmlldyhXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3KQogICAgIFdLUGFnZVBvbGljeUNsaWVudCBwb2xp Y3lDbGllbnQgPSB7CiAgICAgICAgIGtXS1BhZ2VQb2xpY3lDbGllbnRDdXJyZW50VmVyc2lvbiwK ICAgICAgICAgd2ViVmlldywgLy8gY2xpZW50SW5mbwotICAgICAgICBkZWNpZGVQb2xpY3lGb3JO YXZpZ2F0aW9uQWN0aW9uQ2FsbGJhY2ssCi0gICAgICAgIGRlY2lkZVBvbGljeUZvck5ld1dpbmRv d0FjdGlvbkNhbGxiYWNrLAotICAgICAgICBkZWNpZGVQb2xpY3lGb3JSZXNwb25zZUNhbGxiYWNr LAorICAgICAgICAwLCAvLyBkZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uX2RlcHJlY2F0 ZWRGb3JVc2VXaXRoVjAKKyAgICAgICAgZGVjaWRlUG9saWN5Rm9yTmV3V2luZG93QWN0aW9uLAor ICAgICAgICAwLCAvLyBkZWNpZGVQb2xpY3lGb3JSZXNwb25zZV9kZXByZWNhdGVkRm9yVXNlV2l0 aFYwCiAgICAgICAgIDAsIC8vIHVuYWJsZVRvSW1wbGVtZW50UG9saWN5CisgICAgICAgIGRlY2lk ZVBvbGljeUZvck5hdmlnYXRpb25BY3Rpb24sCisgICAgICAgIGRlY2lkZVBvbGljeUZvclJlc3Bv bnNlCiAgICAgfTsKICAgICBXS1BhZ2VTZXRQYWdlUG9saWN5Q2xpZW50KHRvQVBJKHdlYmtpdFdl YlZpZXdCYXNlR2V0UGFnZShXRUJLSVRfV0VCX1ZJRVdfQkFTRSh3ZWJWaWV3KSkpLCAmcG9saWN5 Q2xpZW50KTsKIH0K