124638 2013-11-19 22:47:01 -0800 [Shapes] Caching loop iteration number 2015-11-12 21:03:12 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 130740 P2 Normal --- 1 p.szymanski3 webkit-unassigned commit-queue esprehn+autocc glenn joepeck kondapallykalyan oldest_to_newest 952440 0 p.szymanski3 2013-11-19 22:47:01 -0800 We can cache loop iteration number in firstIncludedIntervalY method. We can't be sure that every compiler do this for us, and it does not cause any overhead. 952442 1 217388 p.szymanski3 2013-11-19 22:50:28 -0800 Created attachment 217388 Loop iteration cache 952443 2 217389 p.szymanski3 2013-11-19 22:54:39 -0800 Created attachment 217389 Loop iteration cache changelog update 952478 3 217389 thorton 2013-11-20 00:50:42 -0800 Comment on attachment 217389 Loop iteration cache View in context: https://bugs.webkit.org/attachment.cgi?id=217389&action=review > Source/WebCore/ChangeLog:11 > + No functionality is changed in this patch. > + > + No new tests. Covered by existing ones. No tests, no functionality change, no performance numbers, no indication that this is a bottleneck or at all interesting to optimize, and no mention of which compiler doesn't do this hoisting (though, just the same, I have no idea which of them do...). Have you seen this show up in a profiler? 1141744 4 217389 joepeck 2015-11-12 21:02:59 -0800 Comment on attachment 217389 Loop iteration cache Clearing review flags. This patch is stale as this code was deleted in bug 130740 so duping this to that and closing. 1141745 5 joepeck 2015-11-12 21:03:12 -0800 *** This bug has been marked as a duplicate of bug 130740 *** 217388 2013-11-19 22:50:28 -0800 2013-11-19 22:53:46 -0800 Loop iteration cache master_rasterShape.patch text/plain 1595 p.szymanski3 ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyNGVlZDQ2Li42YzcxYzU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTMtMTEtMTggIFByemVteXNsYXcgU3p5bWFuc2tpICA8cC5zenltYW5za2kzQHNhbXN1 bmcuY29tPgorCisgICAgICAgIFtTaGFwZXNdIFVzZSBvZiBwcmVjYWxjdWxhdGVkIGxvb3AgaXRl cmF0aW9uIG51bWJlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTI0NjM4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVXNpbmcgb2YgcHJlY2FsY3VsYXRlZCBsb29wIGl0ZXJhdGlvbiBudW1iZXIuCisgICAg ICAgIE5vIGZ1bmN0aW9uYWxpdHkgaXMgY2hhbmdlZCBpbiB0aGlzIHBhdGNoLgorCisgICAgICAg IE5vIG5ldyB0ZXN0cy4gQ292ZXJlZCBieSBleGlzdGluZyBvbmVzLgorCisgICAgICAgICogcmVu ZGVyaW5nL3NoYXBlcy9SYXN0ZXJTaGFwZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSYXN0ZXJT aGFwZUludGVydmFsczo6Zmlyc3RJbmNsdWRlZEludGVydmFsWSk6CisKIDIwMTMtMTEtMTggIFNh bXVlbCBXaGl0ZSAgPHNhbXVlbF93aGl0ZUBhcHBsZS5jb20+CiAKICAgICAgICAgQVg6IGFyaWEt bGFiZWxsZWRieSBzaG91bGQgYmUgdXNlZCBpbiBwcmVmZXJlbmNlIHRvIGFyaWEtbGFiZWxlZGJ5 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc2hhcGVzL1Jhc3RlclNoYXBl LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zaGFwZXMvUmFzdGVyU2hhcGUuY3BwCmlu ZGV4IGI3ZmVmZGYuLjhiYzhlNDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9zaGFwZXMvUmFzdGVyU2hhcGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9z aGFwZXMvUmFzdGVyU2hhcGUuY3BwCkBAIC0xNTQsNyArMTU0LDggQEAgYm9vbCBSYXN0ZXJTaGFw ZUludGVydmFsczo6Zmlyc3RJbmNsdWRlZEludGVydmFsWShpbnQgbWluWSwgY29uc3QgSW50U2l6 ZSYgbWluU2kKICAgICBpZiAobWluU2l6ZS5pc0VtcHR5KCkgfHwgbWluU2l6ZS53aWR0aCgpID4g Ym91bmRzKCkud2lkdGgoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgZm9yIChpbnQg bGluZVkgPSBtaW5ZOyBsaW5lWSA8PSBib3VuZHMoKS5tYXhZKCkgLSBtaW5TaXplLmhlaWdodCgp OyBsaW5lWSsrKSB7CisgICAgaW50IHNpemUgPSBib3VuZHMoKS5tYXhZKCkgLSBtaW5TaXplLmhl aWdodCgpOworICAgIGZvciAoaW50IGxpbmVZID0gbWluWTsgbGluZVkgPD0gc2l6ZTsgbGluZVkr KykgewogICAgICAgICBWZWN0b3I8aW50PiBpbnRlcnZhbFgxVmFsdWVzOwogICAgICAgICBpZiAo IWdldEludGVydmFsWDFWYWx1ZXMobGluZVksIGxpbmVZICsgbWluU2l6ZS5oZWlnaHQoKSwgbWlu U2l6ZS53aWR0aCgpLCBpbnRlcnZhbFgxVmFsdWVzKSkKICAgICAgICAgICAgIGNvbnRpbnVlOwo= 217389 2013-11-19 22:54:39 -0800 2015-11-12 21:02:59 -0800 Loop iteration cache rasterShape.patch text/plain 1595 p.szymanski3 ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1OGI2YjE2Li5jMTYzMmQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTMtMTEtMTkgIFByemVteXNsYXcgU3p5bWFuc2tpICA8cC5zenltYW5za2kzQHNhbXN1 bmcuY29tPgorCisgICAgICAgIFtTaGFwZXNdIFVzZSBvZiBwcmVjYWxjdWxhdGVkIGxvb3AgaXRl cmF0aW9uIG51bWJlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTI0NjM4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVXNpbmcgb2YgcHJlY2FsY3VsYXRlZCBsb29wIGl0ZXJhdGlvbiBudW1iZXIuCisgICAg ICAgIE5vIGZ1bmN0aW9uYWxpdHkgaXMgY2hhbmdlZCBpbiB0aGlzIHBhdGNoLgorCisgICAgICAg IE5vIG5ldyB0ZXN0cy4gQ292ZXJlZCBieSBleGlzdGluZyBvbmVzLgorCisgICAgICAgICogcmVu ZGVyaW5nL3NoYXBlcy9SYXN0ZXJTaGFwZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSYXN0ZXJT aGFwZUludGVydmFsczo6Zmlyc3RJbmNsdWRlZEludGVydmFsWSk6CisKIDIwMTMtMTEtMTkgIEpp bndvbyBTb25nICA8amlud29vNy5zb25nQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFJlbW92ZSB1 bnVzZWQgbWVtYmVyIGZ1bmN0aW9uIGRlY2xhcmF0aW9uIGluIERvY3VtZW50T3JkZXJlZE1hcC5o CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc2hhcGVzL1Jhc3RlclNoYXBl LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zaGFwZXMvUmFzdGVyU2hhcGUuY3BwCmlu ZGV4IGI3ZmVmZGYuLjhiYzhlNDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9zaGFwZXMvUmFzdGVyU2hhcGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9z aGFwZXMvUmFzdGVyU2hhcGUuY3BwCkBAIC0xNTQsNyArMTU0LDggQEAgYm9vbCBSYXN0ZXJTaGFw ZUludGVydmFsczo6Zmlyc3RJbmNsdWRlZEludGVydmFsWShpbnQgbWluWSwgY29uc3QgSW50U2l6 ZSYgbWluU2kKICAgICBpZiAobWluU2l6ZS5pc0VtcHR5KCkgfHwgbWluU2l6ZS53aWR0aCgpID4g Ym91bmRzKCkud2lkdGgoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgZm9yIChpbnQg bGluZVkgPSBtaW5ZOyBsaW5lWSA8PSBib3VuZHMoKS5tYXhZKCkgLSBtaW5TaXplLmhlaWdodCgp OyBsaW5lWSsrKSB7CisgICAgaW50IHNpemUgPSBib3VuZHMoKS5tYXhZKCkgLSBtaW5TaXplLmhl aWdodCgpOworICAgIGZvciAoaW50IGxpbmVZID0gbWluWTsgbGluZVkgPD0gc2l6ZTsgbGluZVkr KykgewogICAgICAgICBWZWN0b3I8aW50PiBpbnRlcnZhbFgxVmFsdWVzOwogICAgICAgICBpZiAo IWdldEludGVydmFsWDFWYWx1ZXMobGluZVksIGxpbmVZICsgbWluU2l6ZS5oZWlnaHQoKSwgbWlu U2l6ZS53aWR0aCgpLCBpbnRlcnZhbFgxVmFsdWVzKSkKICAgICAgICAgICAgIGNvbnRpbnVlOwo=