124636 2013-11-19 22:22:49 -0800 [EFL] Activate keyboard homepage shortcut on efl Minibrowser 2013-12-25 19:02:39 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jw0330.choi webkit-unassigned commit-queue hurnjoo.lee lucas.de.marchi oldest_to_newest 952432 0 jw0330.choi 2013-11-19 22:22:49 -0800 Activate keyboard homepage shortcut on efl minibrowser using Alt+Home key like other browsers. 952435 1 217385 jw0330.choi 2013-11-19 22:26:52 -0800 Created attachment 217385 Patch 957158 2 217385 gyuyoung.kim 2013-12-05 21:51:27 -0800 Comment on attachment 217385 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217385&action=review LGTM > Tools/ChangeLog:8 > + * MiniBrowser/efl/main.c: I prefer to add any description even though it is very small. 957161 3 218571 jw0330.choi 2013-12-05 22:34:50 -0800 Created attachment 218571 Patch 957163 4 jw0330.choi 2013-12-05 22:36:39 -0800 Add description after function name in changelog. 962945 5 218571 commit-queue 2013-12-25 19:02:35 -0800 Comment on attachment 218571 Patch Clearing flags on attachment: 218571 Committed r161082: <http://trac.webkit.org/changeset/161082> 962946 6 commit-queue 2013-12-25 19:02:39 -0800 All reviewed patches have been landed. Closing bug. 217385 2013-11-19 22:26:52 -0800 2013-12-05 22:34:43 -0800 Patch bug-124636-20131120152650.patch text/plain 1496 jw0330.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5MzI3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzYwYzI5NWZjZWRmNjM3N2IzMGViYjYyZDkxZjE4NjQ0 OWJjMTBhMi4uODI0NDY2YmMxYWQ4OTZmOGM2NjgwYmU4ZDg0ZjYzMTc3NWNlOGQxNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDEzLTExLTE5ICBKb25nd29vIENob2kgIDxqdzAzMzAuY2hvaUBzYW1zdW5nLmNvbT4K KworICAgICAgICBbRUZMXSBBY3RpdmF0ZSBrZXlib2FyZCBob21lcGFnZSBzaG9ydGN1dCBvbiBl ZmwgbWluaWJyb3dzZXIsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMjQ2MzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIE1pbmlCcm93c2VyL2VmbC9tYWluLmM6CisgICAgICAgIChvbl9rZXlfZG93bik6 CisKIDIwMTMtMTEtMTQgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAg ICBNYWtlIENMb29wIGVhc2llciB0byBidWlsZCwgYW5kIG1ha2UgaXQgd29yawpkaWZmIC0tZ2l0 IGEvVG9vbHMvTWluaUJyb3dzZXIvZWZsL21haW4uYyBiL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9t YWluLmMKaW5kZXggZjdlYTlhMjVhMmIwYTY2NDg2N2VlMWI0YmE1MDBhNmM1ZDVmOThkMy4uYzFm Mjc3MjUyNDRkYjcxZWFjOGYyNGZhN2IyYWU2YTdhNGZhZDUzMSAxMDA2NDQKLS0tIGEvVG9vbHMv TWluaUJyb3dzZXIvZWZsL21haW4uYworKysgYi9Ub29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5j CkBAIC00MDMsNiArNDAzLDkgQEAgb25fa2V5X2Rvd24odm9pZCAqdXNlcl9kYXRhLCBFdmFzICpl LCBFdmFzX09iamVjdCAqZXdrX3ZpZXcsIHZvaWQgKmV2ZW50X2luZm8pCiAgICAgICAgIGluZm8o IkZvcndhcmQgKEFsdCtSaWdodCkgd2FzIHByZXNzZWQiKTsKICAgICAgICAgaWYgKCFld2tfdmll d19mb3J3YXJkKGV3a192aWV3KSkKICAgICAgICAgICAgIGluZm8oIkZvcndhcmQgaWdub3JlZDog Tm8gZm9yd2FyZCBoaXN0b3J5Iik7CisgICAgfSBlbHNlIGlmICghc3RyY21wKGV2LT5rZXksICJI b21lIikgJiYgYWx0UHJlc3NlZCkgeworICAgICAgICBpbmZvKCJIb21lIChBbHQrSG9tZSkgd2Fz IHByZXNzZWQiKTsKKyAgICAgICAgZXdrX3ZpZXdfdXJsX3NldCh3aW5kb3ctPmV3a192aWV3LCBE RUZBVUxUX1VSTCk7CiAgICAgfSBlbHNlIGlmICghc3RyY21wKGV2LT5rZXksICJGMyIpKSB7CiAg ICAgICAgIGN1cnJlbnRFbmNvZGluZyA9IChjdXJyZW50RW5jb2RpbmcgKyAxKSAlIChzaXplb2Yo ZW5jb2RpbmdzKSAvIHNpemVvZihlbmNvZGluZ3NbMF0pKTsKICAgICAgICAgaW5mbygiU2V0IGVu Y29kaW5nIChGMykgcHJlc3NlZC4gTmV3IGVuY29kaW5nIHRvICVzIiwgZW5jb2RpbmdzW2N1cnJl bnRFbmNvZGluZ10pOwo= 218571 2013-12-05 22:34:50 -0800 2013-12-25 19:02:35 -0800 Patch bug-124636-20131206153448.patch text/plain 1557 jw0330.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwMjEzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjlkMDcyYTVlZWFmNjc0ZmRlZjBkYTM2YmEwYzE1N2Q0 NWI0YjA1OS4uZWIwODdkNGYwYjBiM2U3NTI1ZTZmZWQ2ZDMwZGVlMDc0ZThjMmI2NyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDEzLTEyLTA1ICBKb25nd29vIENob2kgIDxqdzAzMzAuY2hvaUBzYW1zdW5nLmNvbT4K KworICAgICAgICBbRUZMXSBBY3RpdmF0ZSBrZXlib2FyZCBob21lcGFnZSBzaG9ydGN1dCBvbiBl ZmwgbWluaWJyb3dzZXIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMjQ2MzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIE1pbmlCcm93c2VyL2VmbC9tYWluLmM6IEFkZGVkLgorICAgICAgICAob25fa2V5 X2Rvd24pOiBBZGQgYSBob21lcGFnZSBzaG9ydGN1dCB1c2luZyBBbHQgKyBIb21lIGtleS4gCisK IDIwMTMtMTItMDUgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAg ICAgICBEaXNhYmxlIFdlYktpdDIgd2Via2l0cHkgdW5pdHRlc3RzIG9uIFdpbmRvd3MKZGlmZiAt LWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMgYi9Ub29scy9NaW5pQnJvd3Nlci9l ZmwvbWFpbi5jCmluZGV4IGY3ZWE5YTI1YTJiMGE2NjQ4NjdlZTFiNGJhNTAwYTZjNWQ1Zjk4ZDMu LmMxZjI3NzI1MjQ0ZGI3MWVhYzhmMjRmYTdiMmFlNmE3YTRmYWQ1MzEgMTAwNjQ0Ci0tLSBhL1Rv b2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMKKysrIGIvVG9vbHMvTWluaUJyb3dzZXIvZWZsL21h aW4uYwpAQCAtNDAzLDYgKzQwMyw5IEBAIG9uX2tleV9kb3duKHZvaWQgKnVzZXJfZGF0YSwgRXZh cyAqZSwgRXZhc19PYmplY3QgKmV3a192aWV3LCB2b2lkICpldmVudF9pbmZvKQogICAgICAgICBp bmZvKCJGb3J3YXJkIChBbHQrUmlnaHQpIHdhcyBwcmVzc2VkIik7CiAgICAgICAgIGlmICghZXdr X3ZpZXdfZm9yd2FyZChld2tfdmlldykpCiAgICAgICAgICAgICBpbmZvKCJGb3J3YXJkIGlnbm9y ZWQ6IE5vIGZvcndhcmQgaGlzdG9yeSIpOworICAgIH0gZWxzZSBpZiAoIXN0cmNtcChldi0+a2V5 LCAiSG9tZSIpICYmIGFsdFByZXNzZWQpIHsKKyAgICAgICAgaW5mbygiSG9tZSAoQWx0K0hvbWUp IHdhcyBwcmVzc2VkIik7CisgICAgICAgIGV3a192aWV3X3VybF9zZXQod2luZG93LT5ld2tfdmll dywgREVGQVVMVF9VUkwpOwogICAgIH0gZWxzZSBpZiAoIXN0cmNtcChldi0+a2V5LCAiRjMiKSkg ewogICAgICAgICBjdXJyZW50RW5jb2RpbmcgPSAoY3VycmVudEVuY29kaW5nICsgMSkgJSAoc2l6 ZW9mKGVuY29kaW5ncykgLyBzaXplb2YoZW5jb2RpbmdzWzBdKSk7CiAgICAgICAgIGluZm8oIlNl dCBlbmNvZGluZyAoRjMpIHByZXNzZWQuIE5ldyBlbmNvZGluZyB0byAlcyIsIGVuY29kaW5nc1tj dXJyZW50RW5jb2RpbmddKTsK