124612 2013-11-19 15:19:15 -0800 REGRESSION(158384) ARMv7 pointer checks too restrictive for native calls to traditional ARM code 2013-11-19 16:32:43 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 952264 0 msaboff 2013-11-19 15:19:15 -0800 The DFG JIT calls out to math library functions like sin(). Those functions might be implemented as traditional ARM functions and therefore fail the ASSERT(reinterpret_cast<intptr_t>(ptr) & 1) test in ASSERT_VALID_CODE_POINTER(). 952284 1 msaboff 2013-11-19 15:47:51 -0800 There are other checks like ASSERT(reinterpret_cast<intptr_t>(to) & 1) in ARMv7Assembler::linkCall(). 952289 2 217349 msaboff 2013-11-19 16:04:34 -0800 Created attachment 217349 Patch 952290 3 217349 ggaren 2013-11-19 16:15:47 -0800 Comment on attachment 217349 Patch r=me 952295 4 217349 mark.lam 2013-11-19 16:20:00 -0800 Comment on attachment 217349 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217349&action=review > Source/JavaScriptCore/assembler/MacroAssemblerCodeRef.h:43 > +// decorated and undectorated null. Should fix the pre-existing typo: "undectorated" ==> "undecorated". 952309 5 msaboff 2013-11-19 16:29:11 -0800 (In reply to comment #4) > (From update of attachment 217349 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=217349&action=review > > > Source/JavaScriptCore/assembler/MacroAssemblerCodeRef.h:43 > > +// decorated and undectorated null. > > Should fix the pre-existing typo: "undectorated" ==> "undecorated". I made this change. 952317 6 msaboff 2013-11-19 16:32:43 -0800 Committed r159532: <http://trac.webkit.org/changeset/159532> 217349 2013-11-19 16:04:34 -0800 2013-11-19 16:20:00 -0800 Patch 124612.patch text/plain 3309 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU5NTMwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDEzLTExLTE5ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFJFR1JFU1NJT04oMTU4Mzg0KSBBUk12NyBwb2ludCBjaGVja3MgdG9vIHJlc3RyaWN0aXZl IGZvciBuYXRpdmUgY2FsbHMgdG8gdHJhZGl0aW9uYWwgQVJNIGNvZGUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDYxMgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZWQgQVNTRVJUIGNoZWNrcyAo aS5lLiBsb3dlciBiaXQgc2V0KSBmb3IgQVJNIFRodW1iMiBkZXN0aW5hdGlvbiBhZGRyZXNzZXMg cmVsYXRlZCB0bworICAgICAgICBjYWxscyBzaW5jZSB3ZSBhcmUgY2FsbGluZyBuYXRpdmUgQVJN IHRyYWRpdGlvbmFsIGZ1bmN0aW9ucyBsaWtlIHNpbigpIGFuZCBjb3MoKS4KKworICAgICAgICAq IGFzc2VtYmxlci9BUk12N0Fzc2VtYmxlci5oOgorICAgICAgICAoSlNDOjpBUk12N0Fzc2VtYmxl cjo6bGlua0NhbGwpOgorICAgICAgICAoSlNDOjpBUk12N0Fzc2VtYmxlcjo6cmVsaW5rQ2FsbCk6 CisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQ29kZVJlZi5oOgorCiAyMDEzLTEx LTE5ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVuYW1lIFdh dGNocG9pbnRTZXQ6Om5vdGlmeVdyaXRlKCkgc2hvdWxkIGJlIHJlbmFtZWQgdG8gV2F0Y2hwb2lu dFNldDo6ZmlyZUFsbCgpCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0FS TXY3QXNzZW1ibGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2Vt Ymxlci9BUk12N0Fzc2VtYmxlci5oCShyZXZpc2lvbiAxNTk1MjIpCisrKyBTb3VyY2UvSmF2YVNj cmlwdENvcmUvYXNzZW1ibGVyL0FSTXY3QXNzZW1ibGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTIx ODUsNyArMjE4NSw2IEBAIHB1YmxpYzoKICAgICB7CiAgICAgICAgIEFTU0VSVCghKHJlaW50ZXJw cmV0X2Nhc3Q8aW50cHRyX3Q+KGNvZGUpICYgMSkpOwogICAgICAgICBBU1NFUlQoZnJvbS5pc1Nl dCgpKTsKLSAgICAgICAgQVNTRVJUKHJlaW50ZXJwcmV0X2Nhc3Q8aW50cHRyX3Q+KHRvKSAmIDEp OwogCiAgICAgICAgIHNldFBvaW50ZXIocmVpbnRlcnByZXRfY2FzdDx1aW50MTZfdCo+KHJlaW50 ZXJwcmV0X2Nhc3Q8aW50cHRyX3Q+KGNvZGUpICsgZnJvbS5tX29mZnNldCkgLSAxLCB0bywgZmFs c2UpOwogICAgIH0KQEAgLTIyMDgsNyArMjIwNyw2IEBAIHB1YmxpYzoKICAgICBzdGF0aWMgdm9p ZCByZWxpbmtDYWxsKHZvaWQqIGZyb20sIHZvaWQqIHRvKQogICAgIHsKICAgICAgICAgQVNTRVJU KCEocmVpbnRlcnByZXRfY2FzdDxpbnRwdHJfdD4oZnJvbSkgJiAxKSk7Ci0gICAgICAgIEFTU0VS VChyZWludGVycHJldF9jYXN0PGludHB0cl90Pih0bykgJiAxKTsKIAogICAgICAgICBzZXRQb2lu dGVyKHJlaW50ZXJwcmV0X2Nhc3Q8dWludDE2X3QqPihmcm9tKSAtIDEsIHRvLCB0cnVlKTsKICAg ICB9CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVy Q29kZVJlZi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIv TWFjcm9Bc3NlbWJsZXJDb2RlUmVmLmgJKHJldmlzaW9uIDE1OTUyMikKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJDb2RlUmVmLmgJKHdvcmtpbmcgY29w eSkKQEAgLTM3LDE0ICszNywxMiBAQAogLy8gQVNTRVJUX1ZBTElEX0NPREVfUE9JTlRFUiBjaGVj a3MgdGhhdCBwdHIgaXMgYSBub24tbnVsbCBwb2ludGVyLCBhbmQgdGhhdCBpdCBpcyBhIHZhbGlk CiAvLyBpbnN0cnVjdGlvbiBhZGRyZXNzIG9uIHRoZSBwbGF0Zm9ybSAoZm9yIGV4YW1wbGUsIGNo ZWNrIGFueSBhbGlnbm1lbnQgcmVxdWlyZW1lbnRzKS4KICNpZiBDUFUoQVJNX1RIVU1CMikgJiYg IUVOQUJMRShMTElOVF9DX0xPT1ApCi0vLyBBUk0vdGh1bWIgaW5zdHJ1Y3Rpb25zIG11c3QgYmUg MTYtYml0IGFsaWduZWQsIGJ1dCBhbGwgY29kZSBwb2ludGVycyB0byBiZSBsb2FkZWQKLS8vIGlu dG8gdGhlIHByb2Nlc3NvciBhcmUgZGVjb3JhdGVkIHdpdGggdGhlIGJvdHRvbSBiaXQgc2V0LCBp bmRpY2F0aW5nIHRoYXQgdGhpcyBpcwotLy8gdGh1bWIgY29kZSAoYXMgb3Bvc2VkIHRvIDMyLWJp dCB0cmFkaXRpb25hbCBBUk0pLiAgVGhlIGZpcnN0IHRlc3QgY2hlY2tzIGZvciBib3RoCi0vLyBk ZWNvcmF0ZWQgYW5kIHVuZGVjdG9yYXRlZCBudWxsLCBhbmQgdGhlIHNlY29uZCB0ZXN0IGVuc3Vy ZXMgdGhhdCB0aGUgcG9pbnRlciBpcwotLy8gZGVjb3JhdGVkLgorLy8gQVJNIGluc3RydWN0aW9u cyBtdXN0IGJlIDE2LWJpdCBhbGlnbmVkLiBUaHVtYjIgY29kZSBwb2ludGVycyB0byBiZSBsb2Fk ZWQgaW50bworLy8gaW50byB0aGUgcHJvY2Vzc29yIGFyZSBkZWNvcmF0ZWQgd2l0aCB0aGUgYm90 dG9tIGJpdCBzZXQsIHdoaWxlIHRyYWRpdGlvbmFsIEFSTSBoYXMKKy8vIHRoZSBsb3dlciBiaXQg Y2xlYXIuIFNpbmNlIHdlIGRvbid0IGtub3cgd2hhdCBraW5kIG9mIHBvaW50ZXIsIHdlIGNoZWNr IGZvciBib3RoCisvLyBkZWNvcmF0ZWQgYW5kIHVuZGVjdG9yYXRlZCBudWxsLgogI2RlZmluZSBB U1NFUlRfVkFMSURfQ09ERV9QT0lOVEVSKHB0cikgXAotICAgIEFTU0VSVChyZWludGVycHJldF9j YXN0PGludHB0cl90PihwdHIpICYgfjEpOyBcCi0gICAgQVNTRVJUKHJlaW50ZXJwcmV0X2Nhc3Q8 aW50cHRyX3Q+KHB0cikgJiAxKQorICAgIEFTU0VSVChyZWludGVycHJldF9jYXN0PGludHB0cl90 PihwdHIpICYgfjEpCiAjZGVmaW5lIEFTU0VSVF9WQUxJRF9DT0RFX09GRlNFVChvZmZzZXQpIFwK ICAgICBBU1NFUlQoIShvZmZzZXQgJiAxKSkgLy8gTXVzdCBiZSBtdWx0aXBsZSBvZiAyLgogI2Vs c2UK