124570 2013-11-19 01:32:24 -0800 Web Inspector: layer info sidebar should convert to MB for very large layers 2013-11-19 12:32:30 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 952000 0 217278 graouts 2013-11-19 01:32:24 -0800 Created attachment 217278 testcase Really big layers can overflow the width of the 'memory' column. Really, we should probably convert to MB for layers >= 10MB or so. 952001 1 graouts 2013-11-19 01:32:34 -0800 <rdar://problem/15432691> 952006 2 217280 graouts 2013-11-19 02:12:21 -0800 Created attachment 217280 Patch 952133 3 217280 joepeck 2013-11-19 10:28:13 -0800 Comment on attachment 217280 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217280&action=review > Source/WebInspectorUI/ChangeLog:8 > + Setting higherResolution to true (its default value if ommitted) when calling Typo: "ommitted" => "omitted" 952162 4 217314 graouts 2013-11-19 12:00:01 -0800 Created attachment 217314 Patch for landing 952184 5 217314 commit-queue 2013-11-19 12:32:29 -0800 Comment on attachment 217314 Patch for landing Clearing flags on attachment: 217314 Committed r159514: <http://trac.webkit.org/changeset/159514> 952185 6 commit-queue 2013-11-19 12:32:30 -0800 All reviewed patches have been landed. Closing bug. 217278 2013-11-19 01:32:24 -0800 2013-11-19 01:32:24 -0800 testcase large-layer.html text/html 84 graouts PGRpdiBzdHlsZT0id2lkdGg6IDUwMHB4OyBoZWlnaHQ6IDYwMHB4OyAtd2Via2l0LXRyYW5zZm9y bTogdHJhbnNsYXRlWigwKSI+Rm9vPC9kaXY+ 217280 2013-11-19 02:12:21 -0800 2013-11-19 11:59:57 -0800 Patch bug-124570-20131119111220.patch text/plain 1788 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5NDg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBj MzY1MTY1OGUxNDlkYzExOGI5ZjY4NDhjZmZhZTkwMGVlNmU0YzcyLi5kOWE5ZDc1NGQxYWFjNGZi OGQ0MzVkM2Q2YWYzYmU3OGIyODIxZGJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxMy0xMS0xOSAgQW50b2luZSBRdWludCAgPGdyYW91dHNAYXBwbGUuY29t PgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IGxheWVyIGluZm8gc2lkZWJhciBzaG91bGQgY29u dmVydCB0byBNQiBmb3IgdmVyeSBsYXJnZSBsYXllcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDU3MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFNldHRpbmcgaGlnaGVyUmVzb2x1dGlvbiB0byB0cnVl IChpdHMgZGVmYXVsdCB2YWx1ZSBpZiBvbW1pdHRlZCkgd2hlbiBjYWxsaW5nCisgICAgICAgIE51 bWJlci5ieXRlc1RvU3RyaW5nKCkgd291bGQgYWx3YXlzIHJlc3VsdCBpbiBhIEtCLWZvcm1hdHRl ZCBzdHJpbmcgaW5zdGVhZAorICAgICAgICBzaW5jZSBpdCBkaWRuJ3QgY2hlY2sgZm9yIGEgPCAx MDI0IHZhbHVlIGFzIHdlbGwuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1V0aWxpdGllcy5q czoKKyAgICAgICAgKE51bWJlci5ieXRlc1RvU3RyaW5nKToKKwogMjAxMy0xMS0xOCAgQWxleGFu ZHJ1IENoaWN1bGl0YSAgPGFjaGljdUBhZG9iZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rv cjogVXBkYXRlIFdlYkluc3BlY3RvclVJIHRvIHVzZSB0aGUgbmV3ICJub2RlSWRzIiBwYXJhbWV0 ZXIgZm9yIERPTS5wZXJmb3JtU2VhcmNoCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9VdGlsaXRpZXMuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9VdGlsaXRpZXMuanMKaW5kZXggNmU4N2M1ODU1NDk0OTNkZWE2OWExYTcxYmZi NzRlMzQzMGVhMGE1Mi4uZjE1YmYyOTdmZjA3MjY1MDYzMzQ2NTBlMWE3MjM4ZmQ5NmM2YmQ1NyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVXRpbGl0aWVz LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1V0aWxpdGllcy5q cwpAQCAtOTEwLDcgKzkxMCw3IEBAIE9iamVjdC5kZWZpbmVQcm9wZXJ0eShOdW1iZXIsICJieXRl c1RvU3RyaW5nIiwKICAgICAgICAgICAgIHJldHVybiBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIiUu MGYgQiIpLmZvcm1hdChieXRlcyk7CiAKICAgICAgICAgdmFyIGtpbG9ieXRlcyA9IGJ5dGVzIC8g MTAyNDsKLSAgICAgICAgaWYgKGhpZ2hlclJlc29sdXRpb24gfHwga2lsb2J5dGVzIDwgMTApCisg ICAgICAgIGlmIChraWxvYnl0ZXMgPCAxMCB8fCAoaGlnaGVyUmVzb2x1dGlvbiAmJiBraWxvYnl0 ZXMgPCAxMDI0KSkKICAgICAgICAgICAgIHJldHVybiBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIiUu MmYgS0IiKS5mb3JtYXQoa2lsb2J5dGVzKTsKICAgICAgICAgZWxzZSBpZiAoa2lsb2J5dGVzIDwg MTAyNCkKICAgICAgICAgICAgIHJldHVybiBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIiUuMWYgS0Ii KS5mb3JtYXQoa2lsb2J5dGVzKTsK 217314 2013-11-19 12:00:01 -0800 2013-11-19 12:32:29 -0800 Patch for landing bug-124570-20131119210000.patch text/plain 1788 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5NDg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBj MzY1MTY1OGUxNDlkYzExOGI5ZjY4NDhjZmZhZTkwMGVlNmU0YzcyLi43NzFmNTU3ZDgxZWM4YjBk ZjM3N2QwZTVmMmMzMDIyMzk5ZGQ4YjVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxMy0xMS0xOSAgQW50b2luZSBRdWludCAgPGdyYW91dHNAYXBwbGUuY29t PgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IGxheWVyIGluZm8gc2lkZWJhciBzaG91bGQgY29u dmVydCB0byBNQiBmb3IgdmVyeSBsYXJnZSBsYXllcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDU3MAorCisgICAgICAgIFJldmlld2VkIGJ5IFRp bW90aHkgSGF0Y2hlci4KKworICAgICAgICBTZXR0aW5nIGhpZ2hlclJlc29sdXRpb24gdG8gdHJ1 ZSAoaXRzIGRlZmF1bHQgdmFsdWUgaWYgb21pdHRlZCkgd2hlbiBjYWxsaW5nCisgICAgICAgIE51 bWJlci5ieXRlc1RvU3RyaW5nKCkgd291bGQgYWx3YXlzIHJlc3VsdCBpbiBhIEtCLWZvcm1hdHRl ZCBzdHJpbmcgaW5zdGVhZAorICAgICAgICBzaW5jZSBpdCBkaWRuJ3QgY2hlY2sgZm9yIGEgPCAx MDI0IHZhbHVlIGFzIHdlbGwuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1V0aWxpdGllcy5q czoKKyAgICAgICAgKE51bWJlci5ieXRlc1RvU3RyaW5nKToKKwogMjAxMy0xMS0xOCAgQWxleGFu ZHJ1IENoaWN1bGl0YSAgPGFjaGljdUBhZG9iZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rv cjogVXBkYXRlIFdlYkluc3BlY3RvclVJIHRvIHVzZSB0aGUgbmV3ICJub2RlSWRzIiBwYXJhbWV0 ZXIgZm9yIERPTS5wZXJmb3JtU2VhcmNoCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9VdGlsaXRpZXMuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9VdGlsaXRpZXMuanMKaW5kZXggNmU4N2M1ODU1NDk0OTNkZWE2OWExYTcxYmZi NzRlMzQzMGVhMGE1Mi4uZjE1YmYyOTdmZjA3MjY1MDYzMzQ2NTBlMWE3MjM4ZmQ5NmM2YmQ1NyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVXRpbGl0aWVz LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1V0aWxpdGllcy5q cwpAQCAtOTEwLDcgKzkxMCw3IEBAIE9iamVjdC5kZWZpbmVQcm9wZXJ0eShOdW1iZXIsICJieXRl c1RvU3RyaW5nIiwKICAgICAgICAgICAgIHJldHVybiBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIiUu MGYgQiIpLmZvcm1hdChieXRlcyk7CiAKICAgICAgICAgdmFyIGtpbG9ieXRlcyA9IGJ5dGVzIC8g MTAyNDsKLSAgICAgICAgaWYgKGhpZ2hlclJlc29sdXRpb24gfHwga2lsb2J5dGVzIDwgMTApCisg ICAgICAgIGlmIChraWxvYnl0ZXMgPCAxMCB8fCAoaGlnaGVyUmVzb2x1dGlvbiAmJiBraWxvYnl0 ZXMgPCAxMDI0KSkKICAgICAgICAgICAgIHJldHVybiBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIiUu MmYgS0IiKS5mb3JtYXQoa2lsb2J5dGVzKTsKICAgICAgICAgZWxzZSBpZiAoa2lsb2J5dGVzIDwg MTAyNCkKICAgICAgICAgICAgIHJldHVybiBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIiUuMWYgS0Ii KS5mb3JtYXQoa2lsb2J5dGVzKTsK