124563 2013-11-18 22:21:53 -0800 Removal of redundant function call in Editor::insertTextWithoutSendingTextEvent 2013-11-19 21:16:43 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 seokju seokju bfulgham commit-queue oldest_to_newest 951965 0 seokju 2013-11-18 22:21:53 -0800 'text' can never be empty as it's already been checked. 951966 1 217273 seokju 2013-11-18 22:24:25 -0800 Created attachment 217273 Patch 952323 2 bfulgham 2013-11-19 16:58:43 -0800 (In reply to comment #0) > 'text' can never be empty as it's already been checked. Where does the check happen? It looks like "shouldInsertText" is effectively a delegate, and we have no specific say over what it does. Do you mean that the "text.isEmpty()" test always happens before Editor::insertTextWithoutSendingTextEvent? 952330 3 seokju 2013-11-19 17:04:56 -0800 (In reply to comment #2) > (In reply to comment #0) > > 'text' can never be empty as it's already been checked. > > Where does the check happen? It looks like "shouldInsertText" is effectively a delegate, and we have no specific say over what it does. > > Do you mean that the "text.isEmpty()" test always happens before Editor::insertTextWithoutSendingTextEvent? It's been checked at top of Editor::insertTextWithoutSendingTextEvent(). (See : http://trac.webkit.org/browser/trunk/Source/WebCore/editing/Editor.cpp#L958 ) 952398 4 bfulgham 2013-11-19 20:52:28 -0800 (In reply to comment #3) > (In reply to comment #2) > > (In reply to comment #0) > > > 'text' can never be empty as it's already been checked. > > > > Where does the check happen? It looks like "shouldInsertText" is effectively a delegate, and we have no specific say over what it does. > > > > Do you mean that the "text.isEmpty()" test always happens before Editor::insertTextWithoutSendingTextEvent? > > > It's been checked at top of Editor::insertTextWithoutSendingTextEvent(). > (See : http://trac.webkit.org/browser/trunk/Source/WebCore/editing/Editor.cpp#L958 ) Got it. I had to look outside the patch to see that. r=me. 952411 5 217273 commit-queue 2013-11-19 21:16:41 -0800 Comment on attachment 217273 Patch Clearing flags on attachment: 217273 Committed r159544: <http://trac.webkit.org/changeset/159544> 952412 6 commit-queue 2013-11-19 21:16:43 -0800 All reviewed patches have been landed. Closing bug. 217273 2013-11-18 22:24:25 -0800 2013-11-19 21:16:41 -0800 Patch bug-124563-20131119152424.patch text/plain 1493 seokju U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5NDYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjgwYWNjYjBlZmQ1OTUw NWYxZTFkMTQzOGZjOTc0MTkyNDczYzBkYS4uMzM2NTY2MjFjYmU0MjE3ODQxZjNjNDJmNjk3YWM4 NTkxNjYzN2ViOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTExLTE4ICBTZW9r anUgS3dvbiAgPHNlb2tqdUB3ZWJraXQub3JnPgorCisgICAgICAgIFJlbW92YWwgb2YgcmVkdW5k YW50IGZ1bmN0aW9uIGNhbGwgaW4gRWRpdG9yOjppbnNlcnRUZXh0V2l0aG91dFNlbmRpbmdUZXh0 RXZlbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy NDU2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5v IG5ldyB0ZXN0cyBuZWVkZWQsIG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIGVkaXRp bmcvRWRpdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVkaXRvcjo6aW5zZXJ0VGV4dFdpdGhv dXRTZW5kaW5nVGV4dEV2ZW50KToKKwogMjAxMy0xMS0xOCAgRGF2aWQgSHlhdHQgIDxoeWF0dEBh cHBsZS5jb20+CiAKICAgICAgICAgQWRkIGEgcXVpcmsgdG8gbm90IHJlc3BlY3QgY2VudGVyIHRl eHQtYWxpZ24gd2hlbiBwb3NpdGlvbmluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZWRp dGluZy9FZGl0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCmluZGV4 IGFkNjZhOWRjMGIyNTVkZTYxMjg3NzgyMzEwYzUyOTY2M2RkZDM4NjUuLjRjY2EzYzU3MDlhYjNl YWExNjRlYjc3ODZhZmQyYjVlYmY1M2Q2MjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Vk aXRpbmcvRWRpdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAK QEAgLTk2Niw4ICs5NjYsNyBAQCBib29sIEVkaXRvcjo6aW5zZXJ0VGV4dFdpdGhvdXRTZW5kaW5n VGV4dEV2ZW50KGNvbnN0IFN0cmluZyYgdGV4dCwgYm9vbCBzZWxlY3RJbgogICAgIGlmICghc2hv dWxkSW5zZXJ0VGV4dCh0ZXh0LCByYW5nZS5nZXQoKSwgRWRpdG9ySW5zZXJ0QWN0aW9uVHlwZWQp KQogICAgICAgICByZXR1cm4gdHJ1ZTsKIAotICAgIGlmICghdGV4dC5pc0VtcHR5KCkpCi0gICAg ICAgIHVwZGF0ZU1hcmtlcnNGb3JXb3Jkc0FmZmVjdGVkQnlFZGl0aW5nKGlzU3BhY2VPck5ld2xp bmUodGV4dFswXSkpOworICAgIHVwZGF0ZU1hcmtlcnNGb3JXb3Jkc0FmZmVjdGVkQnlFZGl0aW5n KGlzU3BhY2VPck5ld2xpbmUodGV4dFswXSkpOwogCiAgICAgYm9vbCBzaG91bGRDb25zaWRlckFw cGx5aW5nQXV0b2NvcnJlY3Rpb24gPSBmYWxzZTsKICAgICBpZiAodGV4dCA9PSAiICIgfHwgdGV4 dCA9PSAiXHQiKQo=