124560 2013-11-18 21:39:49 -0800 [EFL] Initialize efreet before getting directories 2013-11-18 23:50:43 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi cdumez commit-queue gyuyoung.kim lucas.de.marchi rakuco oldest_to_newest 951948 0 ryuan.choi 2013-11-18 21:39:49 -0800 WebKit/Efl use efreet to get several directories including home dierectory since r123731. But it does not call efreet_init/efreet_shutdown explicitly. If it is not called, we will get below error(I reproduced it on EFL 1.8) ERROR: Failed to create database file '/WebKitEfl/LocalStorage/StorageTracker.db' /workspace/project/webkit/efl-webkit/Source/WebCore/storage/StorageTracker.cpp(144) : void WebCore::StorageTracker::openTrackerDatabase(bool) 951950 1 217270 ryuan.choi 2013-11-18 21:53:26 -0800 Created attachment 217270 Patch 951979 2 217270 gyuyoung.kim 2013-11-18 23:12:04 -0800 Comment on attachment 217270 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217270&action=review Looks good except for a log. > Source/WebKit2/UIProcess/API/efl/ewk_main.cpp:83 > + CRITICAL("could not init ecore_imf."); ecore imf ? Isn't it correct "init efreet ? 951980 3 217270 ryuan.choi 2013-11-18 23:15:01 -0800 Comment on attachment 217270 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217270&action=review >> Source/WebKit2/UIProcess/API/efl/ewk_main.cpp:83 >> + CRITICAL("could not init ecore_imf."); > > ecore imf ? Isn't it correct "init efreet ? Oops, c&p mistake. I will fix it. Thanks. 951992 4 ryuan.choi 2013-11-18 23:50:21 -0800 Committed r159486: <http://trac.webkit.org/changeset/159486> 951993 5 217270 ryuan.choi 2013-11-18 23:50:43 -0800 Comment on attachment 217270 Patch Clearing flags. 217270 2013-11-18 21:53:26 -0800 2013-11-18 23:50:43 -0800 Patch bug-124560-20131119145324.patch text/plain 3927 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5NDgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggYjZmYmQ1NzJl MDg2OGNmMjE1NjZhODFmMjZhYWI2NTA1ZTY2MTA1NC4uZmQ5ODQzNjE1N2NhMWQwZTgzNjQwNTZj YTJlNGI2YjFiNTg3OWU5ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEz LTExLTE4ICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KIAorICAgICAgICBb RUZMXSBJbml0aWFsaXplIGVmcmVldCBiZWZvcmUgZ2V0dGluZyBkaXJlY3RvcmllcworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI0NTYwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgZWZyZWV0IGlzIHVzZWQg dG8gZ2V0IHNldmVyYWwgZGlyZWN0b3JpZXMgaW5jbHVkaW5nIGhvbWUgZGllcmVjdG9yeSBzaW5j ZQorICAgICAgICByMTIzNzMxLCBidXQgaXQgZG9lcyBub3QgY2FsbCBlZnJlZXRfaW5pdC9lZnJl ZXRfc2h1dGRvd24gZXhwbGljaXRseS4KKworICAgICAgICAqIGV3ay9ld2tfbWFpbi5jcHA6IENh bGwgZWZyZWV0X2luaXQoKS9lZnJlZXRfc2h1dGRvd24oKSBleHBsaWNpdGx5LgorICAgICAgICAo ZXdrX2luaXQpOgorICAgICAgICAoZXdrX3NodXRkb3duKToKKworMjAxMy0xMS0xOCAgUnl1YW4g Q2hvaSAgPHJ5dWFuLmNob2lAc2Ftc3VuZy5jb20+CisKICAgICAgICAgW0VGTF0gQWRkIEVXZWJL aXRDb25maWcuY21ha2UgYW5kIEVXZWJLaXQyQ29uZmlnLmNtYWtlCiAgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQ0NzgKIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IDgy NTc5Y2NhN2UzNzJlM2NkY2E5MTg2ODdkZWZlODQyNjFjOGJhZjguLjE5MzhmZDJhNWE5ZGUyN2Nl ODY5NDNhZTE0NDUyYmRlYzBlZmY4NTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAx My0xMS0xOCAgUnl1YW4gQ2hvaSAgPHJ5dWFuLmNob2lAc2Ftc3VuZy5jb20+CisKKyAgICAgICAg W0VGTF0gSW5pdGlhbGl6ZSBlZnJlZXQgYmVmb3JlIGdldHRpbmcgZGlyZWN0b3JpZXMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDU2MAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGVmcmVldCBpcyB1c2Vk IHRvIGdldCBzZXZlcmFsIGRpcmVjdG9yaWVzIGluY2x1ZGluZyBob21lIGRpZXJlY3Rvcnkgc2lu Y2UKKyAgICAgICAgcjEyMzczMSwgYnV0IGl0IGRvZXMgbm90IGNhbGwgZWZyZWV0X2luaXQvZWZy ZWV0X3NodXRkb3duIGV4cGxpY2l0bHkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9l d2tfbWFpbi5jcHA6IENhbGwgZWZyZWV0X2luaXQoKS9lZnJlZXRfc2h1dGRvd24oKSBleHBsaWNp dGx5LgorICAgICAgICAoZXdrX2luaXQpOgorICAgICAgICAoZXdrX3NodXRkb3duKToKKwogMjAx My0xMS0xOCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAg IExldCdzIHRyeSB0aGlzIGFnYWluLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdr L2V3a19tYWluLmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfbWFpbi5jcHAKaW5kZXgg ZWQxOWVmMzc5ZDkxYjA2YTBjYTczYTA0MDExYzNhZjRmNDdlYTIyNy4uZDcxNjc3NzljZTczYTI3 NzMyOTRjNWNkMWExNzJiZGM1ZGQxNzNmZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwv ZXdrL2V3a19tYWluLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX21haW4uY3Bw CkBAIC05NCw2ICs5NCwxMSBAQCBpbnQgZXdrX2luaXQodm9pZCkKICAgICAgICAgZ290byBlcnJv cl9lY29yZV9ldmFzOwogICAgIH0KIAorICAgIGlmICghZWZyZWV0X2luaXQoKSkgeworICAgICAg ICBDUklUSUNBTCgiY291bGQgbm90IGluaXQgZWZyZWV0LiIpOworICAgICAgICBnb3RvIGVycm9y X2VmcmVldDsKKyAgICB9CisKICAgICBpZiAoIWVkamVfaW5pdCgpKSB7CiAgICAgICAgIENSSVRJ Q0FMKCJjb3VsZCBub3QgaW5pdCBlZGplLiIpOwogICAgICAgICBnb3RvIGVycm9yX2VkamU7CkBA IC0xMTgsNiArMTIzLDggQEAgZXJyb3JfZWNvcmVfeDoKICAgICBlZGplX3NodXRkb3duKCk7CiAj ZW5kaWYKIGVycm9yX2VkamU6CisgICAgZWZyZWV0X3NodXRkb3duKCk7CitlcnJvcl9lZnJlZXQ6 CiAgICAgZWNvcmVfZXZhc19zaHV0ZG93bigpOwogZXJyb3JfZWNvcmVfZXZhczoKICAgICBlY29y ZV9zaHV0ZG93bigpOwpAQCAtMTQyLDYgKzE0OSw3IEBAIGludCBld2tfc2h1dGRvd24odm9pZCkK ICAgICBlY29yZV94X3NodXRkb3duKCk7CiAjZW5kaWYKICAgICBlZGplX3NodXRkb3duKCk7Cisg ICAgZWZyZWV0X3NodXRkb3duKCk7CiAgICAgZWNvcmVfZXZhc19zaHV0ZG93bigpOwogICAgIGVj b3JlX3NodXRkb3duKCk7CiAgICAgZXZhc19zaHV0ZG93bigpOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX21haW4uY3BwIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9lZmwvZXdrX21haW4uY3BwCmluZGV4IDdjMTkyNWNiOGZkNDg4ZDJjZWQw MzFhYWYxMDVlNDc0ZjNmZWZkYjYuLmVjYmNkNjAxNGE0MTAwYjNmY2Y1YTdmMjBkNjY0MzEwNmJi ODg2NmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19t YWluLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfbWFpbi5j cHAKQEAgLTI3LDYgKzI3LDcgQEAKICNpbmNsdWRlIDxFY29yZV9FdmFzLmg+CiAjaW5jbHVkZSA8 RWNvcmVfSU1GLmg+CiAjaW5jbHVkZSA8RWRqZS5oPgorI2luY2x1ZGUgPEVmcmVldC5oPgogI2lu Y2x1ZGUgPEVpbmEuaD4KICNpbmNsdWRlIDxFdmFzLmg+CiAjaW5jbHVkZSA8Z2xpYi1vYmplY3Qu aD4KQEAgLTc4LDYgKzc5LDExIEBAIGludCBld2tfaW5pdCh2b2lkKQogICAgICAgICBnb3RvIGVy cm9yX2Vjb3JlX2ltZjsKICAgICB9CiAKKyAgICBpZiAoIWVmcmVldF9pbml0KCkpIHsKKyAgICAg ICAgQ1JJVElDQUwoImNvdWxkIG5vdCBpbml0IGVjb3JlX2ltZi4iKTsKKyAgICAgICAgZ290byBl cnJvcl9lZnJlZXQ7CisgICAgfQorCiAjaWZkZWYgSEFWRV9FQ09SRV9YCiAgICAgaWYgKCFlY29y ZV94X2luaXQoMCkpIHsKICAgICAgICAgQ1JJVElDQUwoImNvdWxkIG5vdCBpbml0IGVjb3JlX3gu Iik7CkBAIC0xMDYsOCArMTEyLDEwIEBAIGVycm9yX2VkamU6CiAgICAgZWNvcmVfeF9zaHV0ZG93 bigpOwogZXJyb3JfZWNvcmVfeDoKICNlbHNlCi0gICAgZWNvcmVfaW1mX3NodXRkb3duKCk7Cisg ICAgZWZyZWV0X3NodXRkb3duKCk7CiAjZW5kaWYKK2Vycm9yX2VmcmVldDoKKyAgICBlY29yZV9p bWZfc2h1dGRvd24oKTsKIGVycm9yX2Vjb3JlX2ltZjoKICAgICBlY29yZV9ldmFzX3NodXRkb3du KCk7CiBlcnJvcl9lY29yZV9ldmFzOgpAQCAtMTMyLDYgKzE0MCw3IEBAIGludCBld2tfc2h1dGRv d24odm9pZCkKICNpZmRlZiBIQVZFX0VDT1JFX1gKICAgICBlY29yZV94X3NodXRkb3duKCk7CiAj ZW5kaWYKKyAgICBlZnJlZXRfc2h1dGRvd24oKTsKICAgICBlY29yZV9pbWZfc2h1dGRvd24oKTsK ICAgICBlY29yZV9ldmFzX3NodXRkb3duKCk7CiAgICAgZWNvcmVfc2h1dGRvd24oKTsK