124553 2013-11-18 18:05:44 -0800 build.webkit.org/dashboard builder headers should link to the builder page 2013-11-18 22:45:34 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton ap commit-queue timothy oldest_to_newest 951912 0 thorton 2013-11-18 18:05:44 -0800 For quick access to historical results per builder. I have a patch. 951917 1 217261 thorton 2013-11-18 18:24:13 -0800 Created attachment 217261 patch It's not totally clear to me why we support multiple queues for queue view, and it's not something that comes up at all with the current configuration, but it seemed appropriate to have one header per queue if that is the case (so that the links are all accessible). Maybe xenon knows? 951970 2 217261 commit-queue 2013-11-18 22:45:33 -0800 Comment on attachment 217261 patch Clearing flags on attachment: 217261 Committed r159484: <http://trac.webkit.org/changeset/159484> 951971 3 commit-queue 2013-11-18 22:45:34 -0800 All reviewed patches have been landed. Closing bug. 217261 2013-11-18 18:24:13 -0800 2013-11-18 22:45:33 -0800 patch header.diff text/plain 6633 thorton ZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u ZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL0J1aWxkYm90QnVpbGRlclF1ZXVlVmll dy5qcyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1 YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL0J1aWxkYm90QnVpbGRlclF1ZXVlVmlldy5qcwpp bmRleCA0MGMyMmNhLi45YWU1MzdhIDEwMDY0NAotLS0gYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9y dC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9C dWlsZGJvdEJ1aWxkZXJRdWV1ZVZpZXcuanMKKysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQv YnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvQnVp bGRib3RCdWlsZGVyUXVldWVWaWV3LmpzCkBAIC05NiwxNCArOTYsMTYgQEAgQnVpbGRib3RCdWls ZGVyUXVldWVWaWV3LnByb3RvdHlwZSA9IHsKIAogICAgICAgICBmdW5jdGlvbiBhcHBlbmRCdWls ZEFyY2hpdGVjdHVyZShxdWV1ZXMsIGxhYmVsKQogICAgICAgICB7Ci0gICAgICAgICAgICBpZiAo IXF1ZXVlcy5sZW5ndGgpCi0gICAgICAgICAgICAgICAgcmV0dXJuOwotCi0gICAgICAgICAgICB2 YXIgcmVsZWFzZUxhYmVsID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgibGFiZWwiKTsKLSAgICAg ICAgICAgIHJlbGVhc2VMYWJlbC50ZXh0Q29udGVudCA9IGxhYmVsOwotICAgICAgICAgICAgdGhp cy5lbGVtZW50LmFwcGVuZENoaWxkKHJlbGVhc2VMYWJlbCk7Ci0KLSAgICAgICAgICAgIHF1ZXVl cy5mb3JFYWNoKGFwcGVuZEJ1aWxkZXJRdWV1ZVN0YXR1cy5iaW5kKHRoaXMpKTsKKyAgICAgICAg ICAgIHF1ZXVlcy5mb3JFYWNoKGZ1bmN0aW9uKHF1ZXVlKSB7CisgICAgICAgICAgICAgICAgdmFy IHJlbGVhc2VMYWJlbCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImEiKTsKKyAgICAgICAgICAg ICAgICByZWxlYXNlTGFiZWwuY2xhc3NMaXN0LmFkZCgicXVldWVMYWJlbCIpOworICAgICAgICAg ICAgICAgIHJlbGVhc2VMYWJlbC50ZXh0Q29udGVudCA9IGxhYmVsOworICAgICAgICAgICAgICAg IHJlbGVhc2VMYWJlbC5ocmVmID0gcXVldWUub3ZlcnZpZXdVUkw7CisgICAgICAgICAgICAgICAg cmVsZWFzZUxhYmVsLnRhcmdldCA9ICJfYmxhbmsiOworICAgICAgICAgICAgICAgIHRoaXMuZWxl bWVudC5hcHBlbmRDaGlsZChyZWxlYXNlTGFiZWwpOworCisgICAgICAgICAgICAgICAgYXBwZW5k QnVpbGRlclF1ZXVlU3RhdHVzLmNhbGwodGhpcywgcXVldWUpOworICAgICAgICAgICAgfS5iaW5k KHRoaXMpKTsKICAgICAgICAgfQogCiAgICAgICAgIGFwcGVuZEJ1aWxkQXJjaGl0ZWN0dXJlLmNh bGwodGhpcywgdGhpcy51bml2ZXJzYWxSZWxlYXNlUXVldWVzLCB0aGlzLmhhc011bHRpcGxlUmVs ZWFzZUJ1aWxkcyA/ICJSZWxlYXNlIChVbml2ZXJzYWwpIiA6ICJSZWxlYXNlIik7CmRpZmYgLS1n aXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJs aWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9CdWlsZGJvdFF1ZXVlLmpzIGIvVG9vbHMvQnVpbGRT bGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJk L1NjcmlwdHMvQnVpbGRib3RRdWV1ZS5qcwppbmRleCAzNDJiMzM4Li4zNjAzOGIzIDEwMDY0NAot LS0gYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJs aWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9CdWlsZGJvdFF1ZXVlLmpzCisrKyBiL1Rvb2xzL0J1 aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hi b2FyZC9TY3JpcHRzL0J1aWxkYm90UXVldWUuanMKQEAgLTYzLDYgKzYzLDExIEBAIEJ1aWxkYm90 UXVldWUucHJvdG90eXBlID0gewogICAgICAgICByZXR1cm4gdGhpcy5idWlsZGJvdC5iYXNlVVJM ICsgImpzb24vYnVpbGRlcnMvIiArIGVuY29kZVVSSUNvbXBvbmVudCh0aGlzLmlkKTsKICAgICB9 LAogCisgICAgZ2V0IG92ZXJ2aWV3VVJMKCkKKyAgICB7CisgICAgICAgIHJldHVybiB0aGlzLmJ1 aWxkYm90LmJhc2VVUkwgKyAiYnVpbGRlcnMvIiArIGVuY29kZVVSSUNvbXBvbmVudCh0aGlzLmlk KSArICI/bnVtYnVpbGRzPTUwIjsKKyAgICB9LAorCiAgICAgZ2V0IHBlbmRpbmdJdGVyYXRpb25z Q291bnQoKQogICAgIHsKICAgICAgICAgdmFyIGZpcnN0RmluaXNoZWRJdGVyYXRpb24gPSB0aGlz Lm1vc3RSZWNlbnRGaW5pc2hlZEl0ZXJhdGlvbjsKZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xh dmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9T Y3JpcHRzL0J1aWxkYm90VGVzdGVyUXVldWVWaWV3LmpzIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBv cnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMv QnVpbGRib3RUZXN0ZXJRdWV1ZVZpZXcuanMKaW5kZXggYjdkNzE2Yy4uYTBjYTI5NiAxMDA2NDQK LS0tIGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVi bGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvQnVpbGRib3RUZXN0ZXJRdWV1ZVZpZXcuanMKKysr IGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGlj X2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvQnVpbGRib3RUZXN0ZXJRdWV1ZVZpZXcuanMKQEAgLTEw NiwyMSArMTA2LDIzIEBAIEJ1aWxkYm90VGVzdGVyUXVldWVWaWV3LnByb3RvdHlwZSA9IHsKICAg ICAgICAgICAgIH0KIAogICAgICAgICAgICAgaWYgKCFhcHBlbmRlZFN0YXR1cykgewotICAgICAg ICAgICAgICAgIHZhciBzdGF0dXMgPSBuZXcgU3RhdHVzTGluZVZpZXcoInVua25vd24iLCBTdGF0 dXNMaW5lVmlldy5TdGF0dXMuTmV1dHJhbCwgImxhc3QgcGFzc2luZyBidWlsZCIpOyAgICAgICAg ICAgIAorICAgICAgICAgICAgICAgIHZhciBzdGF0dXMgPSBuZXcgU3RhdHVzTGluZVZpZXcoInVu a25vd24iLCBTdGF0dXNMaW5lVmlldy5TdGF0dXMuTmV1dHJhbCwgImxhc3QgcGFzc2luZyBidWls ZCIpOwogICAgICAgICAgICAgICAgIHRoaXMuZWxlbWVudC5hcHBlbmRDaGlsZChzdGF0dXMuZWxl bWVudCk7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KIAogICAgICAgICBmdW5jdGlvbiBhcHBl bmRCdWlsZChxdWV1ZXMsIGxhYmVsKQogICAgICAgICB7Ci0gICAgICAgICAgICBpZiAoIXF1ZXVl cy5sZW5ndGgpCi0gICAgICAgICAgICAgICAgcmV0dXJuOwotCi0gICAgICAgICAgICB2YXIgcmVs ZWFzZUxhYmVsID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgibGFiZWwiKTsKLSAgICAgICAgICAg IHJlbGVhc2VMYWJlbC50ZXh0Q29udGVudCA9IGxhYmVsOwotICAgICAgICAgICAgdGhpcy5lbGVt ZW50LmFwcGVuZENoaWxkKHJlbGVhc2VMYWJlbCk7Ci0KLSAgICAgICAgICAgIHF1ZXVlcy5mb3JF YWNoKGFwcGVuZEJ1aWxkZXJRdWV1ZVN0YXR1cy5iaW5kKHRoaXMpKTsKKyAgICAgICAgICAgIHF1 ZXVlcy5mb3JFYWNoKGZ1bmN0aW9uKHF1ZXVlKSB7CisgICAgICAgICAgICAgICAgdmFyIHJlbGVh c2VMYWJlbCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImEiKTsKKyAgICAgICAgICAgICAgICBy ZWxlYXNlTGFiZWwuY2xhc3NMaXN0LmFkZCgicXVldWVMYWJlbCIpOworICAgICAgICAgICAgICAg IHJlbGVhc2VMYWJlbC50ZXh0Q29udGVudCA9IGxhYmVsOworICAgICAgICAgICAgICAgIHJlbGVh c2VMYWJlbC5ocmVmID0gcXVldWUub3ZlcnZpZXdVUkw7CisgICAgICAgICAgICAgICAgcmVsZWFz ZUxhYmVsLnRhcmdldCA9ICJfYmxhbmsiOworICAgICAgICAgICAgICAgIHRoaXMuZWxlbWVudC5h cHBlbmRDaGlsZChyZWxlYXNlTGFiZWwpOworCisgICAgICAgICAgICAgICAgYXBwZW5kQnVpbGRl clF1ZXVlU3RhdHVzLmNhbGwodGhpcywgcXVldWUpOworICAgICAgICAgICAgfS5iaW5kKHRoaXMp KTsKICAgICAgICAgfQogCiAgICAgICAgIGFwcGVuZEJ1aWxkLmNhbGwodGhpcywgdGhpcy5yZWxl YXNlUXVldWVzLCAiUmVsZWFzZSIpOwpkaWZmIC0tZ2l0IGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBv cnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1N0eWxlcy9C dWlsZGJvdFF1ZXVlVmlldy5jc3MgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJr aXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU3R5bGVzL0J1aWxkYm90UXVldWVW aWV3LmNzcwppbmRleCA0NTBmN2Q2Li4xNDlhMzhlIDEwMDY0NAotLS0gYS9Ub29scy9CdWlsZFNs YXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQv U3R5bGVzL0J1aWxkYm90UXVldWVWaWV3LmNzcworKysgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9y dC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU3R5bGVzL0J1 aWxkYm90UXVldWVWaWV3LmNzcwpAQCAtMjksMTMgKzI5LDE0IEBACiAgICAgcGFkZGluZzogMTBw eCAyMHB4OwogfQogCi0ucXVldWUtdmlldyBsYWJlbCB7CisucXVldWUtdmlldyAucXVldWVMYWJl bCB7CiAgICAgZGlzcGxheTogYmxvY2s7CiAgICAgZm9udC1mYW1pbHk6ICJIZWx2ZXRpY2FOZXVl LUxpZ2h0IiwgIkhlbHZldGljYSBOZXVlIiwgc2Fucy1zZXJpZjsKICAgICBjb2xvcjogcmdiKDE0 NSwgMTM1LCA5NSk7CiAgICAgdGV4dC1hbGlnbjogbGVmdDsKKyAgICB0ZXh0LWRlY29yYXRpb246 IG5vbmU7CiB9CiAKLS5xdWV1ZS12aWV3IGxhYmVsOm5vdCg6Zmlyc3QtY2hpbGQpIHsKKy5xdWV1 ZS12aWV3IC5xdWV1ZUxhYmVsOm5vdCg6Zmlyc3QtY2hpbGQpIHsKICAgICBtYXJnaW4tdG9wOiAx MHB4OwogfQpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmlu ZGV4IDg1ODEyYmEuLmQ3YjNlNzEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNiBAQAorMjAxMy0xMS0xOCAgVGltIEhvcnRvbiAg PHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KKworICAgICAgICBidWlsZC53ZWJraXQub3JnL2Rh c2hib2FyZCBidWlsZGVyIGhlYWRlcnMgc2hvdWxkIGxpbmsgdG8gdGhlIGJ1aWxkZXIgcGFnZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI0NTUzCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNs YXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQv U2NyaXB0cy9CdWlsZGJvdFF1ZXVlLmpzOgorICAgICAgICAoQnVpbGRib3RRdWV1ZS5wcm90b3R5 cGUuZ2V0IG92ZXJ2aWV3VVJMKToKKyAgICAgICAgQWRkIG92ZXJ2aWV3VVJMKCksIHdoaWNoIHJl dHVybnMgdGhlIFVSTCB0byB0aGUgYnVpbGRlciBvdmVydmlldyBwYWdlLCB3aXRoIHRoZSBsYXN0 IDUwIGJ1aWxkcyBzaG93bi4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndl YmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL0J1aWxkYm90QnVp bGRlclF1ZXVlVmlldy5qczoKKyAgICAgICAgKEJ1aWxkYm90QnVpbGRlclF1ZXVlVmlldy5wcm90 b3R5cGUudXBkYXRlLmFwcGVuZEJ1aWxkQXJjaGl0ZWN0dXJlKToKKyAgICAgICAgKEJ1aWxkYm90 QnVpbGRlclF1ZXVlVmlldy5wcm90b3R5cGUudXBkYXRlKToKKyAgICAgICAgKiBCdWlsZFNsYXZl U3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2Ny aXB0cy9CdWlsZGJvdFRlc3RlclF1ZXVlVmlldy5qczoKKyAgICAgICAgKEJ1aWxkYm90VGVzdGVy UXVldWVWaWV3LnByb3RvdHlwZS51cGRhdGUuYXBwZW5kQnVpbGRlclF1ZXVlU3RhdHVzKToKKyAg ICAgICAgKEJ1aWxkYm90VGVzdGVyUXVldWVWaWV3LnByb3RvdHlwZS51cGRhdGUuYXBwZW5kQnVp bGQpOgorICAgICAgICAoQnVpbGRib3RUZXN0ZXJRdWV1ZVZpZXcucHJvdG90eXBlLnVwZGF0ZSk6 CisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVi bGljX2h0bWwvZGFzaGJvYXJkL1N0eWxlcy9CdWlsZGJvdFF1ZXVlVmlldy5jc3M6CisgICAgICAg ICgucXVldWUtdmlldyAucXVldWVMYWJlbCk6CisgICAgICAgICgucXVldWUtdmlldyAucXVldWVM YWJlbDpub3QoOmZpcnN0LWNoaWxkKSk6CisgICAgICAgIE1ha2UgdGhlIGhlYWRlciBhIGxpbmsg aW5zdGVhZCBvZiBhIGxhYmVsLCBhbmQgd2lyZSBpdCB1cCB0byBvdmVydmlld1VSTC4KKwogMjAx My0xMS0xNiAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIE5vIHdh eSBmb3IgcG9saWN5IGNsaWVudCB0byBkZXRlcm1pbmUgaWYgYSB0aGUgcmVzcG9uc2XigJlzIE1J TUUgdHlwZSBjYW4gYmUgc2hvd24K