124545 2013-11-18 16:09:23 -0800 ARM64 CRASH: Debug builds crash in emitPointerValidation() 2013-11-18 16:33:01 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff aestes commit-queue oldest_to_newest 951854 0 msaboff 2013-11-18 16:09:23 -0800 The function emitPointerValidation() uses push()/pop() in debug builds. These aren't implemented in the ARM64 macro assembler. 951859 1 217246 msaboff 2013-11-18 16:25:06 -0800 Created attachment 217246 Patch 951860 2 commit-queue 2013-11-18 16:26:56 -0800 Attachment 217246 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/jit/ThunkGenerators.cpp']" exit_code: 1 Source/JavaScriptCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Source/JavaScriptCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 951861 3 217246 ggaren 2013-11-18 16:27:45 -0800 Comment on attachment 217246 Patch > Source/JavaScriptCore/ChangeLog:10 > + Reviewed by NOBODY (OOPS!). > + > + Changed emitPointerValidation() to use pushToSave() and popToRestore() as > + all macro assemblers have an implementation of these functions. > + Please fix indentation. 951864 4 msaboff 2013-11-18 16:29:04 -0800 (In reply to comment #3) > (From update of attachment 217246 [details]) > > Source/JavaScriptCore/ChangeLog:10 > > + Reviewed by NOBODY (OOPS!). > > + > > + Changed emitPointerValidation() to use pushToSave() and popToRestore() as > > + all macro assemblers have an implementation of these functions. > > + > > Please fix indentation. Done. Still setting up a new machine. 951870 5 msaboff 2013-11-18 16:33:01 -0800 Committed r159469: <http://trac.webkit.org/changeset/159469> 217246 2013-11-18 16:25:06 -0800 2013-11-18 16:27:45 -0800 Patch 124545.patch text/plain 1483 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU5NDY2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEzLTExLTE4ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIEFSTTY0IENSQVNIOiBEZWJ1ZyBidWlsZHMgY3Jhc2ggaW4gZW1pdFBvaW50ZXJWYWxpZGF0 aW9uKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy NDU0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisJQ2hhbmdlZCBl bWl0UG9pbnRlclZhbGlkYXRpb24oKSB0byB1c2UgcHVzaFRvU2F2ZSgpIGFuZCBwb3BUb1Jlc3Rv cmUoKSBhcworCWFsbCBtYWNybyBhc3NlbWJsZXJzIGhhdmUgYW4gaW1wbGVtZW50YXRpb24gb2Yg dGhlc2UgZnVuY3Rpb25zLgorCisgICAgICAgICogaml0L1RodW5rR2VuZXJhdG9ycy5jcHA6Cisg ICAgICAgIChKU0M6OmVtaXRQb2ludGVyVmFsaWRhdGlvbik6CisKIDIwMTMtMTEtMTggIE1pY2hh ZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CiAKICAgICAgICAgQVJNNjQ6IFVwZGF0ZSBn ZXRIb3N0Q2FsbFJldHVyblZhbHVlKCkgdG8gdXNlIGFyY2hpdGVjdGVkIGZyYW1lIHBvaW50ZXIg cmVnaXN0ZXIKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvVGh1bmtHZW5lcmF0b3Jz LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L1RodW5rR2VuZXJh dG9ycy5jcHAJKHJldmlzaW9uIDE1OTQzNCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQv VGh1bmtHZW5lcmF0b3JzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDcsOSArNDcsOSBAQCBpbmxp bmUgdm9pZCBlbWl0UG9pbnRlclZhbGlkYXRpb24oQ0NhbGxICiAgICAgQ0NhbGxIZWxwZXJzOjpK dW1wIGlzTm9uWmVybyA9IGppdC5icmFuY2hUZXN0UHRyKENDYWxsSGVscGVyczo6Tm9uWmVybywg cG9pbnRlckdQUik7CiAgICAgaml0LmJyZWFrcG9pbnQoKTsKICAgICBpc05vblplcm8ubGluaygm aml0KTsKLSAgICBqaXQucHVzaChwb2ludGVyR1BSKTsKKyAgICBqaXQucHVzaFRvU2F2ZShwb2lu dGVyR1BSKTsKICAgICBqaXQubG9hZDgocG9pbnRlckdQUiwgcG9pbnRlckdQUik7Ci0gICAgaml0 LnBvcChwb2ludGVyR1BSKTsKKyAgICBqaXQucG9wVG9SZXN0b3JlKHBvaW50ZXJHUFIpOwogI2Vs c2UKICAgICBVTlVTRURfUEFSQU0oaml0KTsKICAgICBVTlVTRURfUEFSQU0ocG9pbnRlckdQUik7 Cg==