124532 2013-11-18 12:30:21 -0800 [ASAN] Building with trunk clang corrupts sandbox profile with comment from Compiler.h 2019-05-02 16:23:35 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Mac All RESOLVED FIXED P2 Normal --- 1 dfarler dfarler andersca ap benjamin cmarcelo commit-queue ddkilzer lisacarlon25 marshalblake parkermark330 sam oldest_to_newest 951747 0 dfarler 2013-11-18 12:30:21 -0800 In https://bugs.webkit.org/show_bug.cgi?id=119165, A preprocessor check of __clang_major__ and __clang_minor__ was added to Source/WTF/wtf/Compiler.h because of a bug with the "final" keyword. 59 /* Disable final on versions of Apple clang earlier than 4.2 to avoid bugs like http://webkit.org/b/119165 */ 60 #if defined(__APPLE__) && (__clang_major__ < 4 || (__clang_major__ == 4 && __clang_minor__ < 2)) 61 #define WTF_COMPILER_QUIRK_FINAL_IS_BUGGY 1 62 // #error "Please use a newer version of Xcode, this version has code generation bugs when using 'final' in C++ code" 63 #endif This inserts a comment into code that includes Compiler.h. However, this comment also makes its way into the WebKit2 separate process targets' sandbox profiles, for which // is syntactically invalid and causes the binaries to get killed on launch with something like this: Nov 18 11:53:20 dmf1 com.apple.launchd[1] (com.apple.WebKit.Networking.Development.41C1A105-0D6B-49FE-8642-88B8537ECD26[93304]): Exited with code: 77 Nov 18 11:53:20 dmf1 com.apple.launchd[1] (com.apple.WebKit.WebContent.Development.F1A8659F-2388-4B1A-ADAF-26C815F35877[93305]): Exited with code: 77 Nov 18 11:57:06 dmf1.apple.com com.apple.WebKit.WebContent.Development[93637]: com.apple.WebKit.WebContent.Development: Couldn't initialize sandbox profile [/Volumes/Data/Users/davidfarler/Downloads/WebKit 2.app/Contents/Frameworks/10.9/WebKit2.framework/Resources/com.apple.WebProcess.sb], error 'line 1: unbound variable: // ' Trunk clang still identifies itself as clang 3.4: $ xcrun clang --version clang version 3.4 (trunk 194422) Target: x86_64-apple-darwin13.0.0 Thread model: posix So we need to find a proper way to identify trunk clang as well as Apple-built clang. 951777 1 ap 2013-11-18 13:59:28 -0800 Compiler.h should obviously use c-style comments. I'm a bit confused though. Is it even intentional that the #error is commented out? It got commented out without any explanation in <http://trac.webkit.org/changeset/157044>. 951783 2 dfarler 2013-11-18 14:07:48 -0800 (In reply to comment #1) > Compiler.h should obviously use c-style comments. This isn't obvious to me – what would that do in this case? ";;" are used to denote comments in sandbox profiles; would using C-style comments prevent this from getting printed to the profile or something? 951792 3 ap 2013-11-18 14:14:01 -0800 .sb.in files are processed with a C preprocessor, which removes /**/ comments. There are lots more in Compiler.h, so this C++ one is a mistake. 951795 4 andersca 2013-11-18 14:16:04 -0800 (In reply to comment #1) > Compiler.h should obviously use c-style comments. > > I'm a bit confused though. Is it even intentional that the #error is commented out? It got commented out without any explanation in <http://trac.webkit.org/changeset/157044>. It was unintentional. I was using a trunk build of clang and probably ran into the same error as David’s seeing now. Since we only build on Xcode 5 now we can probably remove the quirk altogether. 965112 5 220539 dfarler 2014-01-07 12:28:05 -0800 Created attachment 220539 Patch 965113 6 220539 ddkilzer 2014-01-07 12:29:38 -0800 Comment on attachment 220539 Patch r=me 965130 7 220539 commit-queue 2014-01-07 13:03:08 -0800 Comment on attachment 220539 Patch Clearing flags on attachment: 220539 Committed r161451: <http://trac.webkit.org/changeset/161451> 965131 8 commit-queue 2014-01-07 13:03:11 -0800 All reviewed patches have been landed. Closing bug. 220539 2014-01-07 12:28:05 -0800 2014-01-07 13:03:08 -0800 Patch bug-124532-20140107122804.patch text/plain 1550 dfarler U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxNDQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGNiMTQzMjA1ZWJiMjI0OTM2NzAzMTRh ZTYwZTM0OTlmNGJiZWY1NzIuLjM5NWRiODQwY2Q4OGYxMmQzMWQzMzA5MzBlOWE0NjUyYTVkN2Y4 Y2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTQtMDEtMDcgIERhdmlkIEZhcmxlciAgPGRmYXJs ZXJAYXBwbGUuY29tPgorCisgICAgICAgIFtBU0FOXSBCdWlsZGluZyB3aXRoIHRydW5rIGNsYW5n IGNvcnJ1cHRzIHNhbmRib3ggcHJvZmlsZSB3aXRoIGNvbW1lbnQgZnJvbSBDb21waWxlci5oCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQ1MzIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9Db21w aWxlci5oOgorICAgICAgICBSZW1vdmUgdGhpcyBxdWlyayAtIGl0IGRvZXMgbm90aGluZy4KKwog MjAxNC0wMS0wNiAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIEdl dCByaWQgb2YgRU5BQkxFKFZBTFVFX1BST0ZJTEVSKS4gSXQncyBvbiBhbGwgdGhlIHRpbWUgbm93 LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvQ29tcGlsZXIuaCBiL1NvdXJjZS9XVEYvd3Rm L0NvbXBpbGVyLmgKaW5kZXggYTI4NDk4YmZjMmM0ZTQ3NDM3OTg3NTdhNzQzMDBlNDYxOTFiNDBh Zi4uZDdiOTU4YTU4MzhlNzFhODU0MGRmNDk4MTY1YzMwMTM0ODZhMzk5ZiAxMDA2NDQKLS0tIGEv U291cmNlL1dURi93dGYvQ29tcGlsZXIuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9Db21waWxlci5o CkBAIC01NiwxMiArNTYsNiBAQAogI2RlZmluZSBXVEZfQ09NUElMRVJfU1VQUE9SVFNfQ1hYX0FV VE9fVFlQRSBfX2hhc19mZWF0dXJlKGN4eF9hdXRvX3R5cGUpCiAjZGVmaW5lIFdURl9DT01QSUxF Ul9TVVBQT1JUU19DWFhfR0VORVJBTElaRURfSU5JVElBTElaRVJTIF9faGFzX2ZlYXR1cmUoY3h4 X2dlbmVyYWxpemVkX2luaXRpYWxpemVycykKIAotLyogRGlzYWJsZSBmaW5hbCBvbiB2ZXJzaW9u cyBvZiBBcHBsZSBjbGFuZyBlYXJsaWVyIHRoYW4gNC4yIHRvIGF2b2lkIGJ1Z3MgbGlrZSBodHRw Oi8vd2Via2l0Lm9yZy9iLzExOTE2NSAqLwotI2lmIGRlZmluZWQoX19BUFBMRV9fKSAmJiAoX19j bGFuZ19tYWpvcl9fIDwgNCB8fCAoX19jbGFuZ19tYWpvcl9fID09IDQgJiYgX19jbGFuZ19taW5v cl9fIDwgMikpCi0jZGVmaW5lIFdURl9DT01QSUxFUl9RVUlSS19GSU5BTF9JU19CVUdHWSAxCi0v LyAjZXJyb3IgIlBsZWFzZSB1c2UgYSBuZXdlciB2ZXJzaW9uIG9mIFhjb2RlLCB0aGlzIHZlcnNp b24gaGFzIGNvZGUgZ2VuZXJhdGlvbiBidWdzIHdoZW4gdXNpbmcgJ2ZpbmFsJyBpbiBDKysgY29k ZSIKLSNlbmRpZgotCiAjZW5kaWYKIAogLyogQ09NUElMRVIoTVNWQykgLSBNaWNyb3NvZnQgVmlz dWFsIEMrKyAqLwo=