12453 2007-01-28 12:41:39 -0800 REGRESSION(r19197): Tabbing into web page requires two key presses 2007-01-28 19:41:44 -0800 1 1 1 Unclassified WebKit Forms 420+ Mac OS X 10.4 RESOLVED FIXED data:text/html,<input type="text"> Regression P1 Normal --- 1 ddkilzer webkit-unassigned aroben oldest_to_newest 31445 0 ddkilzer 2007-01-28 12:41:39 -0800 Summary: When tabbing into a web page, it requires two key presses (two tabs) instead of just one. If a text field already has focus after the page loads, the first tab moves off the page, then the second moves to the next form element. Steps to reproduce: 1. Open Safari/WebKit. 2. Open URL: data:text/html,<input type="text"> 3. Hit tab key once. Expected results: Text field should be highlighted. Actual results: Text field is not highlighted until tab key is hit a second time. Regression: Works with WebKit nightly r19193. Does not work with a locally-built debug build of WebKit r19197 with Safari 2.0.4 (419.3) on Mac OS X 10.4.8 (8N1037). 31431 1 ddkilzer 2007-01-28 12:47:32 -0800 Rolled back to r19196 fixes this issue. Confirmed it's an issue with r19197, which fixed this Radar issue: <rdar://problem/4957184> REGRESSION: After creating a new mail message, the caret is automatically in message body 31352 2 12732 aroben 2007-01-28 15:25:31 -0800 Created attachment 12732 Patch with changelog 31222 3 aroben 2007-01-28 19:41:44 -0800 Landed as r19207. 12732 2007-01-28 15:25:31 -0800 2007-01-28 15:28:31 -0800 Patch with changelog bugzilla-12453.diff.txt text/plain 2012 aroben SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxOTIwMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDctMDEtMjggIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBo dHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQ1MworICAgICAgICBSRUdS RVNTSU9OKHIxOTE5Nyk6IFRhYmJpbmcgaW50byB3ZWIgcGFnZSByZXF1aXJlcyB0d28ga2V5IHBy ZXNzZXMKKworICAgICAgICBBbGwgbGF5b3V0IHRlc3RzIHBhc3MuCisKKyAgICAgICAgKiBwYWdl L0ZvY3VzQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGb2N1c0NvbnRyb2xsZXI6 OmFkdmFuY2VGb2N1cyk6IElmIHRoZXJlJ3Mgbm8gZm9jdXNlZCBmcmFtZSwKKyAgICAgICAgYWN0 dWFsbHkgZ28gYWhlYWQgYW5kIGZpbmQgYSBmb2N1c2FibGUgbm9kZSBpbnN0ZWFkIG9mIGp1c3Qg Zm9jdXNpbmcKKyAgICAgICAgdGhlIG1haW4gZnJhbWUgYW5kIHF1aXR0aW5nLiBUaGlzIGJlaGF2 aW9yIHdhcyBhIGhvbGRvdmVyIGZyb20gYQorICAgICAgICBwcmV2aW91cyBkZXNpcmVkIHRhYmJp bmcgYmVoYXZpb3Igd2l0aCByZXNwZWN0IHRvIGZyYW1lcy4KKwogMjAwNy0wMS0yNyAgQWRhbSBS b2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhLgpJbmRl eDogV2ViQ29yZS9wYWdlL0ZvY3VzQ29udHJvbGxlci5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29y ZS9wYWdlL0ZvY3VzQ29udHJvbGxlci5jcHAJKHJldmlzaW9uIDE5MjAxKQorKysgV2ViQ29yZS9w YWdlL0ZvY3VzQ29udHJvbGxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExMywxNiArMTEzLDkg QEAgYm9vbCBGb2N1c0NvbnRyb2xsZXI6OmFkdmFuY2VGb2N1cyhLZXlibwogewogICAgIEFTU0VS VChldmVudCk7CiAgICAgCi0gICAgaWYgKCFmb2N1c2VkRnJhbWUoKSkgewotICAgICAgICBzZXRG b2N1c2VkRnJhbWUobV9wYWdlLT5tYWluRnJhbWUoKSk7Ci0gICAgICAgIGlmIChEb2N1bWVudCog ZG9jdW1lbnQgPSBmb2N1c2VkRnJhbWUoKS0+ZG9jdW1lbnQoKSkKLSAgICAgICAgICAgIGRvY3Vt ZW50LT5zZXRGb2N1c2VkTm9kZSgwKTsKLQotICAgICAgICByZXR1cm4gdHJ1ZTsKLSAgICB9Ci0K LSAgICBGcmFtZSogZm9jdXNlZEZyYW1lID0gdGhpcy0+Zm9jdXNlZEZyYW1lKCk7Ci0gICAgRG9j dW1lbnQqIGRvY3VtZW50ID0gZm9jdXNlZEZyYW1lLT5kb2N1bWVudCgpOworICAgIEZyYW1lKiBm cmFtZSA9IGZvY3VzZWRPck1haW5GcmFtZSgpOworICAgIEFTU0VSVChmcmFtZSk7CisgICAgRG9j dW1lbnQqIGRvY3VtZW50ID0gZnJhbWUtPmRvY3VtZW50KCk7CiAgICAgaWYgKCFkb2N1bWVudCkK ICAgICAgICAgcmV0dXJuIGZhbHNlOwogCkBAIC0xMzMsNyArMTI2LDYgQEAgYm9vbCBGb2N1c0Nv bnRyb2xsZXI6OmFkdmFuY2VGb2N1cyhLZXlibwogICAgICAgICA6IGRvY3VtZW50LT5wcmV2aW91 c0ZvY3VzYWJsZU5vZGUoZG9jdW1lbnQtPmZvY3VzZWROb2RlKCksIGV2ZW50KTsKICAgICAgICAg ICAgIAogICAgIC8vIElmIHRoZXJlJ3Mgbm8gZm9jdXNhYmxlIG5vZGUgdG8gYWR2YW5jZSB0bywg bW92ZSB1cCB0aGUgZnJhbWUgdHJlZSB1bnRpbCB3ZSBmaW5kIG9uZS4KLSAgICBGcmFtZSogZnJh bWUgPSBmb2N1c2VkRnJhbWU7CiAgICAgd2hpbGUgKCFub2RlICYmIGZyYW1lKSB7CiAgICAgICAg IEZyYW1lKiBwYXJlbnRGcmFtZSA9IGZyYW1lLT50cmVlKCktPnBhcmVudCgpOwogICAgICAgICBp ZiAoIXBhcmVudEZyYW1lKQo=