<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>124525</bug_id>
          
          <creation_ts>2013-11-18 11:08:01 -0800</creation_ts>
          <short_desc>[GStreamer] Crash when using media source</short_desc>
          <delta_ts>2013-11-18 13:46:45 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Media</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Brendan Long">b.long</reporter>
          <assigned_to name="Brendan Long">b.long</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>eric.carlson</cc>
    
    <cc>glenn</cc>
    
    <cc>gustavo</cc>
    
    <cc>jer.noble</cc>
    
    <cc>menard</cc>
    
    <cc>mrobinson</cc>
    
    <cc>pnormand</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>951702</commentid>
    <comment_count>0</comment_count>
    <who name="Brendan Long">b.long</who>
    <bug_when>2013-11-18 11:08:01 -0800</bug_when>
    <thetext>To reproduce, build WebKitGTK, go to this page, and click load:

http://dashif.org/reference/players/javascript/0.2.5/index.html

I get this output:

ASSERTION FAILED: !m_adoptionIsRequired
../../Source/WTF/wtf/RefCounted.h(59) : void WTF::RefCountedBase::ref()
1   0x7f141b2cc48e /home/blong/workspace/webkit/WebKitBuild/Debug/.libs/libjavascriptcoregtk-3.0.so.0(WTFCrash+0x1e) [0x7f141b2cc48e]
2   0x7f141ccdca19 /home/blong/workspace/webkit/WebKitBuild/Debug/.libs/libwebkitgtk-3.0.so.0(+0x135ea19) [0x7f141ccdca19]
3   0x7f141df50f5f /home/blong/workspace/webkit/WebKitBuild/Debug/.libs/libwebkitgtk-3.0.so.0(+0x25d2f5f) [0x7f141df50f5f]
4   0x7f141df50dad /home/blong/workspace/webkit/WebKitBuild/Debug/.libs/libwebkitgtk-3.0.so.0(+0x25d2dad) [0x7f141df50dad]
5   0x7f141df509e2 /home/blong/workspace/webkit/WebKitBuild/Debug/.libs/libwebkitgtk-3.0.so.0(_ZN7WebCore20MediaSourceGStreamerC1EP15_WebKitMediaSrc+0x5e) [0x7f141df509e2]
6   0x7f141df50932 /home/blong/workspace/webkit/WebKitBuild/Debug/.libs/libwebkitgtk-3.0.so.0(_ZN7WebCore20MediaSourceGStreamer4openEN3WTF10PassRefPtrINS_15HTMLMediaSourceEEEP15_WebKitMediaSrc+0x4a) [0x7f141df50932]
7   0x7f141e19716c /home/blong/workspace/webkit/WebKitBuild/Debug/.libs/libwebkitgtk-3.0.so.0(_ZN7WebCore27MediaPlayerPrivateGStreamer13sourceChangedEv+0x20a) [0x7f141e19716c]
8   0x7f141e190eff /home/blong/workspace/webkit/WebKitBuild/Debug/.libs/libwebkitgtk-3.0.so.0(+0x2812eff) [0x7f141e190eff]
9   0x301000fa28 /lib64/libgobject-2.0.so.0(g_closure_invoke+0x138) [0x301000fa28]
10  0x3010020a3d /lib64/libgobject-2.0.so.0() [0x3010020a3d]
11  0x3010028829 /lib64/libgobject-2.0.so.0(g_signal_emit_valist+0xef9) [0x3010028829]
12  0x3010028a72 /lib64/libgobject-2.0.so.0(g_signal_emit+0x82) [0x3010028a72]
13  0x3010013da5 /lib64/libgobject-2.0.so.0() [0x3010013da5]
14  0x7f141a3f0394 /home/blong/gst/git/gstreamer/gst/.libs/libgstreamer-1.0.so.0(+0x2a394) [0x7f141a3f0394]
15  0x30100156db /lib64/libgobject-2.0.so.0(g_object_notify+0x16b) [0x30100156db]
16  0x7f13aee76762 /home/blong/gst/git/gst-plugins-base/gst/playback/.libs/libgstplayback.so(+0x1e762) [0x7f13aee76762]
17  0x301000fa28 /lib64/libgobject-2.0.so.0(g_closure_invoke+0x138) [0x301000fa28]
18  0x3010020a3d /lib64/libgobject-2.0.so.0() [0x3010020a3d]
19  0x3010028829 /lib64/libgobject-2.0.so.0(g_signal_emit_valist+0xef9) [0x3010028829]
20  0x3010028a72 /lib64/libgobject-2.0.so.0(g_signal_emit+0x82) [0x3010028a72]
21  0x3010013da5 /lib64/libgobject-2.0.so.0() [0x3010013da5]
22  0x7f141a3f0394 /home/blong/gst/git/gstreamer/gst/.libs/libgstreamer-1.0.so.0(+0x2a394) [0x7f141a3f0394]
23  0x30100156db /lib64/libgobject-2.0.so.0(g_object_notify+0x16b) [0x30100156db]
24  0x7f13aee70e7c /home/blong/gst/git/gst-plugins-base/gst/playback/.libs/libgstplayback.so(+0x18e7c) [0x7f13aee70e7c]
25  0x7f141a413d52 /home/blong/gst/git/gstreamer/gst/.libs/libgstreamer-1.0.so.0(gst_element_change_state+0x22) [0x7f141a413d52]
26  0x7f141a41442c /home/blong/gst/git/gstreamer/gst/.libs/libgstreamer-1.0.so.0(+0x4e42c) [0x7f141a41442c]
27  0x7f141a3f9e46 /home/blong/gst/git/gstreamer/gst/.libs/libgstreamer-1.0.so.0(+0x33e46) [0x7f141a3f9e46]
28  0x7f141a431df4 /home/blong/gst/git/gstreamer/gst/.libs/libgstreamer-1.0.so.0(+0x6bdf4) [0x7f141a431df4]
29  0x7f13aee794a7 /home/blong/gst/git/gst-plugins-base/gst/playback/.libs/libgstplayback.so(+0x214a7) [0x7f13aee794a7]
30  0x7f141a413d52 /home/blong/gst/git/gstreamer/gst/.libs/libgstreamer-1.0.so.0(gst_element_change_state+0x22) [0x7f141a413d52]
31  0x7f141a413f4a /home/blong/gst/git/gstreamer/gst/.libs/libgstreamer-1.0.so.0(gst_element_change_state+0x21a) [0x7f141a413f4a]</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>951718</commentid>
    <comment_count>1</comment_count>
      <attachid>217217</attachid>
    <who name="Brendan Long">b.long</who>
    <bug_when>2013-11-18 11:37:34 -0800</bug_when>
    <thetext>Created attachment 217217
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>951770</commentid>
    <comment_count>2</comment_count>
      <attachid>217217</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2013-11-18 13:21:15 -0800</bug_when>
    <thetext>Comment on attachment 217217
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217217&amp;action=review

Oh, good catch, Brendan!

&gt; Source/WebCore/ChangeLog:8
&gt; +        No new tests because this is already covered by tests in media/media-source (which aren&apos;t enabled because the feature isn&apos;t done).

Some tests are actually enabled I think. But far from the majority.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>951775</commentid>
    <comment_count>3</comment_count>
      <attachid>217217</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2013-11-18 13:46:43 -0800</bug_when>
    <thetext>Comment on attachment 217217
Patch

Clearing flags on attachment: 217217

Committed r159454: &lt;http://trac.webkit.org/changeset/159454&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>951776</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2013-11-18 13:46:45 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>217217</attachid>
            <date>2013-11-18 11:37:34 -0800</date>
            <delta_ts>2013-11-18 13:46:43 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-124525-20131118133733.patch</filename>
            <type>text/plain</type>
            <size>1622</size>
            <attacher name="Brendan Long">b.long</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5NDM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGM2NTU4ODNlN2YzYjk3
N2ZlZTJlYTJhNDU4OTJmOTNjMDMwNTg0YS4uYjU5YzBiNmIyNjFiNDU0Yzc0MWY3M2Y3NDUwYWJk
NWYwM2RmZmFjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEzLTExLTE4ICBCcmVu
ZGFuIExvbmcgIDxiLmxvbmdAY2FibGVsYWJzLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVyXSBD
cmFzaCB3aGVuIHVzaW5nIG1lZGlhIHNvdXJjZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI0NTI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGJlY2F1c2UgdGhpcyBpcyBhbHJlYWR5
IGNvdmVyZWQgYnkgdGVzdHMgaW4gbWVkaWEvbWVkaWEtc291cmNlICh3aGljaCBhcmVuJ3QgZW5h
YmxlZCBiZWNhdXNlIHRoZSBmZWF0dXJlIGlzbid0IGRvbmUpLgorCisgICAgICAgICogcGxhdGZv
cm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhU291cmNlR1N0cmVhbWVyLmNwcDoKKyAgICAgICAg
KFdlYkNvcmU6Ok1lZGlhU291cmNlR1N0cmVhbWVyOjpNZWRpYVNvdXJjZUdTdHJlYW1lcik6IEFk
ZCBtaXNzaW5nIGFkb3B0UmVmKCkKKwogMjAxMy0xMS0xOCAgcGVhdm9Ab3V0bG9vay5jb20gIDxw
ZWF2b0BvdXRsb29rLmNvbT4KIAogICAgICAgICBbQ3VybF0gQmFzaWMgYXV0aGVudGljYXRpb24g
aXMgbm90IHJldXNlZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo
aWNzL2dzdHJlYW1lci9NZWRpYVNvdXJjZUdTdHJlYW1lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w
bGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFTb3VyY2VHU3RyZWFtZXIuY3BwCmluZGV4
IGViN2MwYjM3MGE4ZjQ2ZmM3OThlMzAwNzVhYmI0YWVjY2M0NjFlNTMuLjU5ODJmODBiOTY2MjMy
NmQzYWIxYTFlOWI4MDI0OTQ4OTY2M2M5MDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs
YXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVNvdXJjZUdTdHJlYW1lci5jcHAKKysrIGIv
U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhU291cmNlR1N0
cmVhbWVyLmNwcApAQCAtNDYsNyArNDYsNyBAQCB2b2lkIE1lZGlhU291cmNlR1N0cmVhbWVyOjpv
cGVuKFBhc3NSZWZQdHI8SFRNTE1lZGlhU291cmNlPiBtZWRpYVNvdXJjZSwgV2ViS2l0TQogfQog
CiBNZWRpYVNvdXJjZUdTdHJlYW1lcjo6TWVkaWFTb3VyY2VHU3RyZWFtZXIoV2ViS2l0TWVkaWFT
cmMqIHNyYykKLSAgICA6IG1fY2xpZW50KG5ldyBNZWRpYVNvdXJjZUNsaWVudEdzdHJlYW1lcihz
cmMpKQorICAgIDogbV9jbGllbnQoYWRvcHRSZWYobmV3IE1lZGlhU291cmNlQ2xpZW50R3N0cmVh
bWVyKHNyYykpKQogICAgICwgbV9kdXJhdGlvbigwLjApCiAgICAgLCBtX3JlYWR5U3RhdGUoTWVk
aWFQbGF5ZXI6OkhhdmVOb3RoaW5nKQogewo=
</data>

          </attachment>
      

    </bug>

</bugzilla>