124520 2013-11-18 10:27:49 -0800 ARM64: Update getHostCallReturnValue() to use architected frame pointer register 2013-11-18 16:06:48 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff commit-queue oldest_to_newest 951665 0 msaboff 2013-11-18 10:27:49 -0800 The ARM64 changes for getHostCallReturnValue() as part of https://bugs.webkit.org/show_bug.cgi?id=123956 - "Change CallFrameRegister to architected frame pointer register" were not done. 951675 1 217208 msaboff 2013-11-18 10:35:35 -0800 Created attachment 217208 Patch 951677 2 commit-queue 2013-11-18 10:37:51 -0800 Attachment 217208 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/jit/JITOperations.cpp']" exit_code: 1 Source/JavaScriptCore/jit/JITOperations.cpp:1770: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 951851 3 msaboff 2013-11-18 16:05:41 -0800 Committed r159466: <http://trac.webkit.org/changeset/159466> 951853 4 217208 msaboff 2013-11-18 16:06:48 -0800 Comment on attachment 217208 Patch Reviewed in person. 217208 2013-11-18 10:35:35 -0800 2013-11-18 16:06:47 -0800 Patch 124520.patch text/plain 1449 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU5NDMxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEzLTExLTE4ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIEFSTTY0OiBVcGRhdGUgZ2V0SG9zdENhbGxSZXR1cm5WYWx1ZSgpIHRvIHVzZSBhcmNoaXRl Y3RlZCBmcmFtZSBwb2ludGVyIHJlZ2lzdGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQ1MjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBDaGFuZ2VkIGZyb20gdXNpbmcgdGhlIHByaW9yIEpTQyBzcGVj aWZpYyB4MjUgY2FsbGZyYW1lIHJlZ2lzdGVyIHRvIHRoZSBBUk02NAorICAgICAgICBhcmNoaXRl Y3RlZCB4MjkgKGZwKSByZWdpc3Rlci4gIFRoaXMgY2hhbmdlIHNob3VsZCBoYXZlIGJlZW4gZG9u ZSBhcyBwYXJ0IG9mCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMjM5NTYuCisKKyAgICAgICAgKiBqaXQvSklUT3BlcmF0aW9ucy5jcHA6CisKIDIwMTMt MTEtMTggIHBlYXZvQG91dGxvb2suY29tICA8cGVhdm9Ab3V0bG9vay5jb20+CiAKICAgICAgICAg W1dpbl0gTGluayBmYWlscyB3aGVuIERGRyBKSVQgaXMgZW5hYmxlZC4KSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9qaXQvSklUT3BlcmF0aW9ucy5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGVyYXRpb25zLmNwcAkocmV2aXNpb24gMTU5NDI4KQor KysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGVyYXRpb25zLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMTc2Niw4ICsxNzY2LDggQEAgYXNtICgKICIuZ2xvYmwgIiBTWU1CT0xfU1RSSU5H KGdldEhvc3RDYWxsUmV0dXJuVmFsdWUpICJcbiIKIEhJREVfU1lNQk9MKGdldEhvc3RDYWxsUmV0 dXJuVmFsdWUpICJcbiIKIFNZTUJPTF9TVFJJTkcoZ2V0SG9zdENhbGxSZXR1cm5WYWx1ZSkgIjoi ICJcbiIKLSAgICAibGR1ciB4MjUsIFt4MjUsICMwXSIgIlxuIgotICAgICAibW92IHgwLCB4MjUi ICJcbiIKKyAgICAibGR1ciB4MjksIFt4MjksICMwXSIgIlxuIgorICAgICAibW92IHgwLCB4Mjki ICJcbiIKICAgICAgImIgIiBMT0NBTF9SRUZFUkVOQ0UoZ2V0SG9zdENhbGxSZXR1cm5WYWx1ZVdp dGhFeGVjU3RhdGUpICJcbiIKICk7CiAK