124506 2013-11-18 08:21:59 -0800 REGRESSION(r159166?): fast/block/float/float-with-fractional-height-vertical-lr.html, fast/block/float/float-with-fractional-height.html are failing 2022-12-21 22:28:10 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=125831 Gtk, LayoutTestFailure, Regression P2 Normal --- 1 zan bjonesbe bjonesbe cdumez commit-queue esprehn+autocc glenn gyuyoung.kim kondapallykalyan mpakulavelrutka rakuco oldest_to_newest 951611 0 zan 2013-11-18 08:21:59 -0800 The following reftests are failing after (most likely) changes in r159166: fast/block/float/float-with-fractional-height-vertical-lr.html fast/block/float/float-with-fractional-height.html http://trac.webkit.org/changeset/159166 http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fblock%2Ffloat%2Ffloat-with-fractional-height-vertical-lr.html%20fast%2Fblock%2Ffloat%2Ffloat-with-fractional-height.html The GTK port enables subpixel layout. EFL does as well though, and there's no regression there AFAIK. 952579 1 mpakulavelrutka 2013-11-20 07:45:05 -0800 Both tests are failing on EFL too - EFL bot does not show results when 'Show all runs' is enabled http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fblock%2Ffloat%2Ffloat-with-fractional-height-vertical-lr.html%20fast%2Fblock%2Ffloat%2Ffloat-with-fractional-height.html Failures are the same as on GTK: http://build.webkit.org/results/EFL%20Linux%2064-bit%20Release%20WK2/r159559%20%2811520%29/fast/block/float/float-with-fractional-height-vertical-lr-diffs.html http://build.webkit.org/results/EFL%20Linux%2064-bit%20Release%20WK2/r159559%20%2811520%29/fast/block/float/float-with-fractional-height-diffs.html 952703 2 bjonesbe 2013-11-20 11:31:19 -0800 That's unfortunate. I'll get a GTK or EFL build working and look into it. 956935 3 bjonesbe 2013-12-05 09:46:37 -0800 As far as I can tell, this is happening because the test is running afoul of IEEE floating point being imprecise. It is expecting 1.2 + 1.2 + 1.2 to be >= 3.6, but that isn't happening in practice, so the last line of the test is seen as overlapping the float. I'll see if I can come up with some numbers that always add up correctly to change the test to fix the issue. 957096 4 bjonesbe 2013-12-05 17:11:35 -0800 (In reply to comment #3) > As far as I can tell, this is happening because the test is running afoul of IEEE floating point being imprecise. It is expecting 1.2 + 1.2 + 1.2 to be >= 3.6, but that isn't happening in practice, so the last line of the test is seen as overlapping the float. I'll see if I can come up with some numbers that always add up correctly to change the test to fix the issue. I take that back, that's not what's happening. It looks like converting to layout units broke the fix for bug 112744, so I'm looking for another solution, if I don't find one, I guess I'll just have to put the placed floats tree back as ints, or truncate the layout units coming in. 960525 5 219424 bjonesbe 2013-12-17 09:04:01 -0800 Created attachment 219424 Patch 960526 6 bjonesbe 2013-12-17 09:06:06 -0800 (In reply to comment #5) > Created an attachment (id=219424) [details] > Patch This patch fixes the issue by flooring the floating object interval endpoints to revert to the old behavior. I have filed bug 125831 to track coming up with a better fix. 960535 7 219424 krit 2013-12-17 09:17:31 -0800 Comment on attachment 219424 Patch Not great to have a hack for that :/ 960568 8 219424 commit-queue 2013-12-17 10:35:31 -0800 Comment on attachment 219424 Patch Clearing flags on attachment: 219424 Committed r160715: <http://trac.webkit.org/changeset/160715> 960569 9 commit-queue 2013-12-17 10:35:34 -0800 All reviewed patches have been landed. Closing bug. 219424 2013-12-17 09:04:01 -0800 2013-12-17 10:35:31 -0800 Patch bug-124506-20131217090400.patch text/plain 5037 bjonesbe U3VidmVyc2lvbiBSZXZpc2lvbjogMTYwNjQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjVjMWMxNmE2NDUzYzNk M2QwYTc3MDk0NjI0MjNiYzUyOGZlMDBlMC4uMTE2MWFhMDMyNjBhNDdiMzc3M2I0NjgwMTRjZTVj NzY3NDdmYWY0ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTEyLTE3ICBCZW0g Sm9uZXMtQmV5ICA8YmpvbmVzYmVAYWRvYmUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjE1 OTE2Nj8pOiBmYXN0L2Jsb2NrL2Zsb2F0L2Zsb2F0LXdpdGgtZnJhY3Rpb25hbC1oZWlnaHQtdmVy dGljYWwtbHIuaHRtbCwgZmFzdC9ibG9jay9mbG9hdC9mbG9hdC13aXRoLWZyYWN0aW9uYWwtaGVp Z2h0Lmh0bWwgYXJlIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyNDUwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEZsb29yIHRoZSBlbmRwb2ludHMgb2YgdGhlIGZsb2F0aW5nIG9iamVjdCBp bnRlcnZhbCB0byBrZWVwIHRoZSBvbGQKKyAgICAgICAgYmVoYXZpb3IgdW50aWwgYSBiZXR0ZXIg Zml4IGNhbiBiZSBjcmVhdGVkLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgZml4ZXMgcmVncmVz c2lvbiBpbiBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIHJlbmRlcmluZy9GbG9hdGluZ09i amVjdHMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RmxvYXRpbmdPYmplY3RzOjppbnRlcnZhbEZv ckZsb2F0aW5nT2JqZWN0KToKKwogMjAxMy0xMi0xNiAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1h cmlvLnByYWRhQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtBVEtdIEV4cG9zZSBhY2Nlc3NpYmls aXR5IG9iamVjdHMgZm9yIG1vcmUgV0FJLUFSSUEgcm9sZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9GbG9hdGluZ09iamVjdHMuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL0Zsb2F0aW5nT2JqZWN0cy5jcHAKaW5kZXggMzRlMGUyZmE5NTdmZjQ3NTM0ZTJhOGY4 MjNjMjY4NWI3MGYwNjA4YS4uOWJmNDdjYTdmM2I1NDQ4Zjc5MzAwNzUzNmM4MWQ0M2NhOGE0MWQ3 NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0Zsb2F0aW5nT2JqZWN0cy5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0Zsb2F0aW5nT2JqZWN0cy5jcHAKQEAg LTI4MCw5ICsyODAsMTEgQEAgdm9pZCBGbG9hdGluZ09iamVjdHM6OmRlY3JlYXNlT2JqZWN0c0Nv dW50KEZsb2F0aW5nT2JqZWN0OjpUeXBlIHR5cGUpCiAKIEZsb2F0aW5nT2JqZWN0SW50ZXJ2YWwg RmxvYXRpbmdPYmplY3RzOjppbnRlcnZhbEZvckZsb2F0aW5nT2JqZWN0KEZsb2F0aW5nT2JqZWN0 KiBmbG9hdGluZ09iamVjdCkKIHsKKyAgICAvLyBGSVhNRSBUaGUgZW5kcG9pbnRzIG9mIHRoZSBm bG9hdGluZyBvYmplY3QgaW50ZXJ2YWwgc2hvdWxkbid0IG5lZWQgdG8gYmUKKyAgICAvLyBmbG9v cmVkLiBTZWUgaHR0cDovL3drYi51Zy8xMjU4MzEgZm9yIG1vcmUgZGV0YWlscy4KICAgICBpZiAo bV9ob3Jpem9udGFsV3JpdGluZ01vZGUpCi0gICAgICAgIHJldHVybiBGbG9hdGluZ09iamVjdElu dGVydmFsKGZsb2F0aW5nT2JqZWN0LT5mcmFtZVJlY3QoKS55KCksIGZsb2F0aW5nT2JqZWN0LT5m cmFtZVJlY3QoKS5tYXhZKCksIGZsb2F0aW5nT2JqZWN0KTsKLSAgICByZXR1cm4gRmxvYXRpbmdP YmplY3RJbnRlcnZhbChmbG9hdGluZ09iamVjdC0+ZnJhbWVSZWN0KCkueCgpLCBmbG9hdGluZ09i amVjdC0+ZnJhbWVSZWN0KCkubWF4WCgpLCBmbG9hdGluZ09iamVjdCk7CisgICAgICAgIHJldHVy biBGbG9hdGluZ09iamVjdEludGVydmFsKGZsb2F0aW5nT2JqZWN0LT5mcmFtZVJlY3QoKS55KCku Zmxvb3IoKSwgZmxvYXRpbmdPYmplY3QtPmZyYW1lUmVjdCgpLm1heFkoKS5mbG9vcigpLCBmbG9h dGluZ09iamVjdCk7CisgICAgcmV0dXJuIEZsb2F0aW5nT2JqZWN0SW50ZXJ2YWwoZmxvYXRpbmdP YmplY3QtPmZyYW1lUmVjdCgpLngoKS5mbG9vcigpLCBmbG9hdGluZ09iamVjdC0+ZnJhbWVSZWN0 KCkubWF4WCgpLmZsb29yKCksIGZsb2F0aW5nT2JqZWN0KTsKIH0KIAogdm9pZCBGbG9hdGluZ09i amVjdHM6OmFkZFBsYWNlZE9iamVjdChGbG9hdGluZ09iamVjdCogZmxvYXRpbmdPYmplY3QpCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK aW5kZXggNTA5YjkyM2NmNzNmY2NmYWYzM2U0NDk0YTJmZWJmZmViODczZDYxOC4uNWNlMjkwM2M3 OGZhYjE0ZmNjYmFkNmE0NjkwZjhjNDc4MzljYjEzMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisy MDEzLTEyLTE3ICBCZW0gSm9uZXMtQmV5ICA8YmpvbmVzYmVAYWRvYmUuY29tPgorCisgICAgICAg IFJFR1JFU1NJT04ocjE1OTE2Nj8pOiBmYXN0L2Jsb2NrL2Zsb2F0L2Zsb2F0LXdpdGgtZnJhY3Rp b25hbC1oZWlnaHQtdmVydGljYWwtbHIuaHRtbCwgZmFzdC9ibG9jay9mbG9hdC9mbG9hdC13aXRo LWZyYWN0aW9uYWwtaGVpZ2h0Lmh0bWwgYXJlIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDUwNgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBsaW5lcyBmb3IgdGVzdHMgdGhhdCBo YXZlIGJlZW4gZml4ZWQgYnkgdGhpcyBwYXRjaC4KKworICAgICAgICAqIHBsYXRmb3JtL2VmbC9U ZXN0RXhwZWN0YXRpb25zOgorICAgICAgICAqIHBsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25z OgorCiAyMDEzLTEyLTE2ICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bWFyaW8ucHJhZGFAc2Ftc3Vu Zy5jb20+CiAKICAgICAgICAgW0FUS10gRXhwb3NlIGFjY2Vzc2liaWxpdHkgb2JqZWN0cyBmb3Ig bW9yZSBXQUktQVJJQSByb2xlcwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZs L1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0 aW9ucwppbmRleCA0OGFlYWMyM2Y0M2I4ZTc5NDU0MjM4ZGZhYmM4MzUwNDUzN2RmZTI5Li5kNWVi YmJkYTdkZjM0OGQ4MjU2ZTg1MmY0MTdkZTRkYTg1N2YzNTcxIDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTczMCw5ICsxNzMwLDYgQEAgd2Via2l0Lm9y Zy9iLzEyNDU4OSBodHRwL3Rlc3RzL2NhY2hlL3BhcnRpdGlvbmVkLWNhY2hlLmh0bWwgWyBGYWls dXJlIF0KIHdlYmtpdC5vcmcvYi8xMTgxMjYgY3NzMy9mbGV4Ym94L2ltYWdlLXBlcmNlbnQtbWF4 LWhlaWdodC5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTE4MTI2IGZh c3QvZmxleGJveC9pbWFnZS1wZXJjZW50LW1heC1oZWlnaHQuaHRtbCBbIEltYWdlT25seUZhaWx1 cmUgXQogCi13ZWJraXQub3JnL2IvMTI0NTA2IGZhc3QvYmxvY2svZmxvYXQvZmxvYXQtd2l0aC1m cmFjdGlvbmFsLWhlaWdodC12ZXJ0aWNhbC1sci5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCi13 ZWJraXQub3JnL2IvMTI0NTA2IGZhc3QvYmxvY2svZmxvYXQvZmxvYXQtd2l0aC1mcmFjdGlvbmFs LWhlaWdodC5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCi0KIHdlYmtpdC5vcmcvYi8xMjQ2NTYg ZmFzdC9jc3MzLXRleHQvY3NzMy10ZXh0LWRlY29yYXRpb24vdGV4dC1kZWNvcmF0aW9uLXNraXAv dGV4dC1kZWNvcmF0aW9uLXNraXAtaW5rLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KIAogd2Vi a2l0Lm9yZy9iLzEyNDY1NyBmYXN0L2RvbS9TZWxlY3RvckFQSS9yZXNpZy1TZWxlY3RvcnNBUEkt dGVzdC54aHRtbCBbIEZhaWx1cmUgXQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0v Z3RrL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVj dGF0aW9ucwppbmRleCAxMmE0ZmQzNDEwNDRmYzEwYzZiZjllMDA2OGZmOTljMDNkMDBmMDVlLi5l NzAzYTUwY2U0MDBiYWNjOTU3NWU3NjZmZGJjM2RjOWJlMGE2ZDAwIDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTQ5MCw5ICsxNDkwLDYgQEAgd2Via2l0 Lm9yZy9iLzEyNDUwNyBmYXN0L2NzczMtdGV4dC9jc3MzLXRleHQtZGVjb3JhdGlvbi90ZXh0LWRl Y29yYXRpb24tc2tpcC90ZXgKIHdlYmtpdC5vcmcvYi8xMjQ1MDkgbWVkaWEvdmlkZW8tY29udHJv bHMtY2FwdGlvbnMtdHJhY2ttZW51LWhpZGUtb24tY2xpY2stb3V0c2lkZS5odG1sIFsgRmFpbHVy ZSBdCiB3ZWJraXQub3JnL2IvMTI0NTA5IG1lZGlhL3ZpZGVvLWNvbnRyb2xzLWNhcHRpb25zLXRy YWNrbWVudS1oaWRlLW9uLWNsaWNrLmh0bWwgWyBGYWlsdXJlIF0KIAotd2Via2l0Lm9yZy9iLzEy NDUwNiBmYXN0L2Jsb2NrL2Zsb2F0L2Zsb2F0LXdpdGgtZnJhY3Rpb25hbC1oZWlnaHQtdmVydGlj YWwtbHIuaHRtbCBbIEltYWdlT25seUZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzEyNDUwNiBmYXN0 L2Jsb2NrL2Zsb2F0L2Zsb2F0LXdpdGgtZnJhY3Rpb25hbC1oZWlnaHQuaHRtbCBbIEltYWdlT25s eUZhaWx1cmUgXQotCiB3ZWJraXQub3JnL2IvMTI0NTY1IGZhc3QvbXVsdGljb2wvc2VhbWxlc3Mt Zmxvd2VkLXRocm91Z2gtY29sdW1ucy5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiAKIHdlYmtp dC5vcmcvYi8xMjQ1NjYgZmFzdC9kb20vU2VsZWN0b3JBUEkvcmVzaWctU2VsZWN0b3JzQVBJLXRl c3QueGh0bWwgWyBGYWlsdXJlIF0K