124501 2013-11-18 07:17:19 -0800 Architecure specific code in LowLevelInterpreter asm files could be reduced 2013-11-18 07:59:00 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jbriance webkit-unassigned commit-queue fpizlo ggaren msaboff oliver oldest_to_newest 951596 0 jbriance 2013-11-18 07:17:19 -0800 - sh4 specific code in preserveReturnAddressAfterCall and restoreReturnAddressBeforeReturn macros should be lowered into sh4.rb to avoid specific code in LowLevelInterpreter.asm - sh4/mips specific code in nativeCallTrampoline macro could be merged with the arm/armv7/armv7_traditional specific code in LowLevelInterpreter32_64.asm 951597 1 217196 jbriance 2013-11-18 07:19:01 -0800 Created attachment 217196 Remove architecture specific code in LowLevelInterpreter. 951604 2 217196 commit-queue 2013-11-18 07:58:58 -0800 Comment on attachment 217196 Remove architecture specific code in LowLevelInterpreter. Clearing flags on attachment: 217196 Committed r159422: <http://trac.webkit.org/changeset/159422> 951605 3 commit-queue 2013-11-18 07:59:00 -0800 All reviewed patches have been landed. Closing bug. 217196 2013-11-18 07:19:01 -0800 2013-11-18 07:58:58 -0800 Remove architecture specific code in LowLevelInterpreter. bug-124501.patch text/plain 4967 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU5NDE3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEzLTExLTE4ICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgorCisg ICAgICAgIFJlbW92ZSBhcmNoaXRlY3R1cmUgc3BlY2lmaWMgY29kZSBpbiBMb3dMZXZlbEludGVy cHJldGVyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTI0NTAxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBsbGludC9Mb3dMZXZlbEludGVycHJldGVyLmFzbTogVXNlIGdlbmVyaWMgcGF0aCBpbnN0ZWFk IG9mIHNoNCBzcGVjaWZpYyBjb2RlLgorICAgICAgICAqIGxsaW50L0xvd0xldmVsSW50ZXJwcmV0 ZXIzMl82NC5hc206IE1lcmdlIHNoNC9taXBzIHBhdGggd2l0aCBhcm0gcGF0aC4gVGhlCisgICAg ICAgICJtb3ZlIHQwLCBhMCIgaXMgbm90IG5lZWRlZCBmb3IgYXJtIGJlY2F1c2UgdDAgPT0gYTAg d2l0aCB0aGlzIGFyY2hpdGVjdHVyZS4KKyAgICAgICAgKiBvZmZsaW5lYXNtL3NoNC5yYjogSGFu ZGxlIG1vdmUgb3Bjb2RlIHdpdGggcHIgcmVnaXN0ZXIuCisKIDIwMTMtMTEtMTggIEp1bGllbiBC cmlhbmNlYXUgIDxqYnJpYW5jZUBjaXNjby5jb20+CiAKICAgICAgICAgW2FybV0gQWRkIG1pc3Np bmcgaW1wbGVtZW50YXRpb24gaW4gTWFjcm9Bc3NlbWJsZXIgdG8gZml4IGJ1aWxkIChicm9rZW4g c2luY2UgcjE1OTM5NSkuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2 ZWxJbnRlcnByZXRlcjMyXzY0LmFzbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENv cmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjMyXzY0LmFzbQkocmV2aXNpb24gMTU5NDAwKQor KysgU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5h c20JKHdvcmtpbmcgY29weSkKQEAgLTE5MTAsNyArMTkxMCw3IEBAIG1hY3JvIG5hdGl2ZUNhbGxU cmFtcG9saW5lKGV4ZWN1dGFibGVPZmYKICAgICAgICAgbG9hZHAgU2NvcGVDaGFpbltjZnJdLCB0 MwogICAgICAgICBhbmRwIE1hcmtlZEJsb2NrTWFzaywgdDMKICAgICAgICAgbG9hZHAgTWFya2Vk QmxvY2s6Om1fd2Vha1NldCArIFdlYWtTZXQ6Om1fdm1bdDNdLCB0MwotICAgIGVsc2lmIEFSTSBv ciBBUk12NyBvciBBUk12N19UUkFESVRJT05BTAorICAgIGVsc2lmIEFSTSBvciBBUk12NyBvciBB Uk12N19UUkFESVRJT05BTCBvciBNSVBTIG9yIFNINAogICAgICAgICBsb2FkcCBTY29wZUNoYWlu W2Nmcl0sIHQzCiAgICAgICAgIGFuZHAgTWFya2VkQmxvY2tNYXNrLCB0MwogICAgICAgICBsb2Fk cCBNYXJrZWRCbG9jazo6bV93ZWFrU2V0ICsgV2Vha1NldDo6bV92bVt0M10sIHQzCkBAIC0xOTIy LDI0ICsxOTIyLDkgQEAgbWFjcm8gbmF0aXZlQ2FsbFRyYW1wb2xpbmUoZXhlY3V0YWJsZU9mZgog ICAgICAgICBsb2FkaSBDYWxsZWUgKyBQYXlsb2FkT2Zmc2V0W2Nmcl0sIHQxCiAgICAgICAgIGxv YWRwIEpTRnVuY3Rpb246Om1fZXhlY3V0YWJsZVt0MV0sIHQxCiAgICAgICAgIG1vdmUgdDIsIGNm cgotICAgICAgICBjYWxsIGV4ZWN1dGFibGVPZmZzZXRUb0Z1bmN0aW9uW3QxXQotICAgICAgICBy ZXN0b3JlUmV0dXJuQWRkcmVzc0JlZm9yZVJldHVybih0MykKLSAgICAgICAgbG9hZHAgU2NvcGVD aGFpbltjZnJdLCB0MwotICAgICAgICBhbmRwIE1hcmtlZEJsb2NrTWFzaywgdDMKLSAgICAgICAg bG9hZHAgTWFya2VkQmxvY2s6Om1fd2Vha1NldCArIFdlYWtTZXQ6Om1fdm1bdDNdLCB0MwotICAg IGVsc2lmIE1JUFMgb3IgU0g0Ci0gICAgICAgIGxvYWRwIFNjb3BlQ2hhaW5bY2ZyXSwgdDMKLSAg ICAgICAgYW5kcCBNYXJrZWRCbG9ja01hc2ssIHQzCi0gICAgICAgIGxvYWRwIE1hcmtlZEJsb2Nr OjptX3dlYWtTZXQgKyBXZWFrU2V0OjptX3ZtW3QzXSwgdDMKLSAgICAgICAgc3RvcmVwIGNmciwg Vk06OnRvcENhbGxGcmFtZVt0M10KLSAgICAgICAgbW92ZSB0MCwgdDIKLSAgICAgICAgcHJlc2Vy dmVSZXR1cm5BZGRyZXNzQWZ0ZXJDYWxsKHQzKQotICAgICAgICBzdG9yZXAgdDMsIFJldHVyblBD W2Nmcl0KLSAgICAgICAgbW92ZSBjZnIsIHQwCi0gICAgICAgIGxvYWRpIENhbGxlZSArIFBheWxv YWRPZmZzZXRbY2ZyXSwgdDEKLSAgICAgICAgbG9hZHAgSlNGdW5jdGlvbjo6bV9leGVjdXRhYmxl W3QxXSwgdDEKLSAgICAgICAgbW92ZSB0MiwgY2ZyCi0gICAgICAgIG1vdmUgdDAsIGEwCisgICAg ICAgIGlmIE1JUFMgb3IgU0g0CisgICAgICAgICAgICBtb3ZlIHQwLCBhMAorICAgICAgICBlbmQK ICAgICAgICAgY2FsbCBleGVjdXRhYmxlT2Zmc2V0VG9GdW5jdGlvblt0MV0KICAgICAgICAgcmVz dG9yZVJldHVybkFkZHJlc3NCZWZvcmVSZXR1cm4odDMpCiAgICAgICAgIGxvYWRwIFNjb3BlQ2hh aW5bY2ZyXSwgdDMKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbElu dGVycHJldGVyLmFzbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQv TG93TGV2ZWxJbnRlcnByZXRlci5hc20JKHJldmlzaW9uIDE1OTQwMCkKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyLmFzbQkod29ya2luZyBjb3B5KQpA QCAtMjA3LDExICsyMDcsOSBAQCBtYWNybyBhc3NlcnQoYXNzZXJ0aW9uKQogZW5kCiAKIG1hY3Jv IHByZXNlcnZlUmV0dXJuQWRkcmVzc0FmdGVyQ2FsbChkZXN0aW5hdGlvblJlZ2lzdGVyKQotICAg IGlmIENfTE9PUCBvciBBUk0gb3IgQVJNdjcgb3IgQVJNdjdfVFJBRElUSU9OQUwgb3IgQVJNNjQg b3IgTUlQUworICAgIGlmIENfTE9PUCBvciBBUk0gb3IgQVJNdjcgb3IgQVJNdjdfVFJBRElUSU9O QUwgb3IgQVJNNjQgb3IgTUlQUyBvciBTSDQKICAgICAgICAgIyBJbiBDX0xPT1AgY2FzZSwgd2Un cmUgb25seSBwcmVzZXJ2aW5nIHRoZSBieXRlY29kZSB2UEMuCiAgICAgICAgIG1vdmUgbHIsIGRl c3RpbmF0aW9uUmVnaXN0ZXIKLSAgICBlbHNpZiBTSDQKLSAgICAgICAgc3RzcHIgZGVzdGluYXRp b25SZWdpc3RlcgogICAgIGVsc2lmIFg4NiBvciBYODZfNjQKICAgICAgICAgcG9wIGRlc3RpbmF0 aW9uUmVnaXN0ZXIKICAgICBlbHNlCkBAIC0yMjAsMTEgKzIxOCw5IEBAIG1hY3JvIHByZXNlcnZl UmV0dXJuQWRkcmVzc0FmdGVyQ2FsbChkZXMKIGVuZAogCiBtYWNybyByZXN0b3JlUmV0dXJuQWRk cmVzc0JlZm9yZVJldHVybihzb3VyY2VSZWdpc3RlcikKLSAgICBpZiBDX0xPT1Agb3IgQVJNIG9y IEFSTXY3IG9yIEFSTXY3X1RSQURJVElPTkFMIG9yIEFSTTY0IG9yIE1JUFMKKyAgICBpZiBDX0xP T1Agb3IgQVJNIG9yIEFSTXY3IG9yIEFSTXY3X1RSQURJVElPTkFMIG9yIEFSTTY0IG9yIE1JUFMg b3IgU0g0CiAgICAgICAgICMgSW4gQ19MT09QIGNhc2UsIHdlJ3JlIG9ubHkgcmVzdG9yaW5nIHRo ZSBieXRlY29kZSB2UEMuCiAgICAgICAgIG1vdmUgc291cmNlUmVnaXN0ZXIsIGxyCi0gICAgZWxz aWYgU0g0Ci0gICAgICAgIGxkc3ByIHNvdXJjZVJlZ2lzdGVyCiAgICAgZWxzaWYgWDg2IG9yIFg4 Nl82NAogICAgICAgICBwdXNoIHNvdXJjZVJlZ2lzdGVyCiAgICAgZWxzZQpJbmRleDogU291cmNl L0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vc2g0LnJiCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL3NoNC5yYgkocmV2aXNpb24gMTU5NDAwKQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vc2g0LnJiCSh3b3JraW5nIGNvcHkpCkBAIC00 ODksNiArNDg5LDE0IEBAIGRlZiBzaDRMb3dlck1pc3BsYWNlZFNwZWNpYWxSZWdpc3RlcnMobGkK ICAgICAgICAgfCBub2RlIHwKICAgICAgICAgaWYgbm9kZS5pc19hPyBJbnN0cnVjdGlvbgogICAg ICAgICAgICAgY2FzZSBub2RlLm9wY29kZQorICAgICAgICAgICAgd2hlbiAibW92ZSIKKyAgICAg ICAgICAgICAgICBpZiBub2RlLm9wZXJhbmRzWzBdLmlzX2E/IFJlZ2lzdGVySUQgYW5kIG5vZGUu b3BlcmFuZHNbMF0uc2g0T3BlcmFuZCA9PSAicHIiCisgICAgICAgICAgICAgICAgICAgIG5ld0xp c3QgPDwgSW5zdHJ1Y3Rpb24ubmV3KGNvZGVPcmlnaW4sICJzdHNwciIsIFtub2RlLm9wZXJhbmRz WzFdXSkKKyAgICAgICAgICAgICAgICBlbHNpZiBub2RlLm9wZXJhbmRzWzFdLmlzX2E/IFJlZ2lz dGVySUQgYW5kIG5vZGUub3BlcmFuZHNbMV0uc2g0T3BlcmFuZCA9PSAicHIiCisgICAgICAgICAg ICAgICAgICAgIG5ld0xpc3QgPDwgSW5zdHJ1Y3Rpb24ubmV3KGNvZGVPcmlnaW4sICJsZHNwciIs IFtub2RlLm9wZXJhbmRzWzBdXSkKKyAgICAgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAg ICAgICAgIG5ld0xpc3QgPDwgbm9kZQorICAgICAgICAgICAgICAgIGVuZAogICAgICAgICAgICAg d2hlbiAibG9hZGkiLCAibG9hZGlzIiwgImxvYWRwIgogICAgICAgICAgICAgICAgIGlmIG5vZGUu b3BlcmFuZHNbMV0uaXNfYT8gUmVnaXN0ZXJJRCBhbmQgbm9kZS5vcGVyYW5kc1sxXS5zaDRPcGVy YW5kID09ICJwciIKICAgICAgICAgICAgICAgICAgICAgdG1wID0gVG1wLm5ldyhjb2RlT3JpZ2lu LCA6Z3ByKQo=