124495 2013-11-18 04:55:59 -0800 [Performance tests] Interactive/SelectAll.html throws an exception 2013-11-18 07:26:30 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 124496 1 rniwa rniwa andersca benjamin commit-queue kling koivisto oldest_to_newest 951577 0 rniwa 2013-11-18 04:55:59 -0800 Interactive/SelectAll.html throws an exception because runTest doesn't stop gracefully after reaching 20 iterations. Return a boolean indicating whether more values are needed or not in PerfTestRunner.measureValueAsync to fix this bug. 951578 1 217190 rniwa 2013-11-18 05:00:51 -0800 Created attachment 217190 Fixes the bug 951579 2 217191 rniwa 2013-11-18 05:02:44 -0800 Created attachment 217191 Added Reviewed by line 951598 3 217191 commit-queue 2013-11-18 07:26:28 -0800 Comment on attachment 217191 Added Reviewed by line Clearing flags on attachment: 217191 Committed r159421: <http://trac.webkit.org/changeset/159421> 951599 4 commit-queue 2013-11-18 07:26:30 -0800 All reviewed patches have been landed. Closing bug. 217190 2013-11-18 05:00:51 -0800 2013-11-18 05:02:39 -0800 Fixes the bug bug-124495-20131118220049.patch text/plain 2657 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMTU4OTAxCmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCmluZGV4IGVmMzZlOGNkMGMy ZDhjZDMwODgxYWY0NGU3MjQzYWJmMGM2MTEwMTguLjY0OGQwMGZlYTFiYmRiZmMzZTdhOTczYmVj Y2Q4M2I0MjVlYWFmNWUgMTAwNjQ0Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCisr KyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTMtMTEt MTggIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1BlcmZvcm1h bmNlIHRlc3RzXSBJbnRlcmFjdGl2ZS9TZWxlY3RBbGwuaHRtbCB0aHJvd3MgYW4gZXhjZXB0aW9u CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQ0OTUK KworICAgICAgICBSZXR1cm4gYSBib29sZWFuIGluZGljYXRpbmcgd2hldGhlciBtb3JlIHZhbHVl cyBhcmUgbmVlZGVkIG9yIG5vdCBpbgorICAgICAgICBQZXJmVGVzdFJ1bm5lci5tZWFzdXJlVmFs dWVBc3luYyBzbyB0aGF0IHJ1blRlc3QgY2FuIHRlcm1pbmF0ZSBncmFjZWZ1bGx5LgorCisgICAg ICAgICogSW50ZXJhY3RpdmUvU2VsZWN0QWxsLmh0bWw6CisgICAgICAgIChydW5UZXN0KTogRG9u J3Qgc2NoZWR1bGUgYSB0aW1lciBmb3IgcnVuVGVzdCBpZiB3ZSd2ZSBnb3QgZW5vdWdoIHZhbHVl cy4KKyAgICAgICAgKiByZXNvdXJjZXMvcnVubmVyLmpzOgorICAgICAgICAoUGVyZlRlc3RSdW5u ZXIubWVhc3VyZVZhbHVlQXN5bmMpOiBSZXR1cm5zIHRydWUgaWZmIG1vcmUgdmFsdWVzIGFyZSBu ZWVkZWQuCisKIDIwMTMtMTAtMjUgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxp YS5jb20+CiAKICAgICAgICAgVXNlIGEgVmVjdG9yIGluc3RlYWQgb2YgSGFzaFNldCB0byBjb21w dXRlZCB0aGUgb3JkZXJWYWx1ZXMgaW4gUmVuZGVyRmxleGlibGVCb3gKZGlmZiAtLWdpdCBhL1Bl cmZvcm1hbmNlVGVzdHMvSW50ZXJhY3RpdmUvU2VsZWN0QWxsLmh0bWwgYi9QZXJmb3JtYW5jZVRl c3RzL0ludGVyYWN0aXZlL1NlbGVjdEFsbC5odG1sCmluZGV4IDFlODlhYjk0Yzk0N2E1OTkxNTE3 NzdmYzEyOWI4ZDA1NzVkMmI1ODUuLjNkNmQ3ZWNkN2E3YmYyYjZiNTkxMDYwYmY4YWMzOGNmYzhj NjZmMDUgMTAwNjQ0Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvSW50ZXJhY3RpdmUvU2VsZWN0QWxs Lmh0bWwKKysrIGIvUGVyZm9ybWFuY2VUZXN0cy9JbnRlcmFjdGl2ZS9TZWxlY3RBbGwuaHRtbApA QCAtMjIsMTAgKzIyLDExIEBAIGZ1bmN0aW9uIHJ1blRlc3QoKSB7CiAgICAgICAgIGlmcmFtZS5j b250ZW50RG9jdW1lbnQuZXhlY0NvbW1hbmQoJ1NlbGVjdEFsbCcpOwogICAgICAgICBpZnJhbWUu Y29udGVudERvY3VtZW50LmJvZHkub2Zmc2V0VG9wOwogICAgICAgICBzZXRUaW1lb3V0KGZ1bmN0 aW9uICgpIHsKLSAgICAgICAgICAgIFBlcmZUZXN0UnVubmVyLm1lYXN1cmVWYWx1ZUFzeW5jKFBl cmZUZXN0UnVubmVyLm5vdygpIC0gc3RhcnRUaW1lKTsKKyAgICAgICAgICAgIGlmICghUGVyZlRl c3RSdW5uZXIubWVhc3VyZVZhbHVlQXN5bmMoUGVyZlRlc3RSdW5uZXIubm93KCkgLSBzdGFydFRp bWUpKQorICAgICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAgIFBlcmZUZXN0UnVubmVy LmdjKCk7CiAgICAgICAgICAgICBzZXRUaW1lb3V0KHJ1blRlc3QsIDApOwotICAgICAgICB9LCAw KTsgICAgICAgIAorICAgICAgICB9LCAwKTsKICAgICB9LCAwKTsKIH0KIApkaWZmIC0tZ2l0IGEv UGVyZm9ybWFuY2VUZXN0cy9yZXNvdXJjZXMvcnVubmVyLmpzIGIvUGVyZm9ybWFuY2VUZXN0cy9y ZXNvdXJjZXMvcnVubmVyLmpzCmluZGV4IDU3NmYxZDEzZThkMTNlOTViZWM5YjVhZTBmZWM0ZDVh ZjcwMmI0ZjguLmM3YWExMTZkZTY3OGRhYTAxNTMzOGU0Njc5Y2Y1NmIwYTgyMDFhZmEgMTAwNzU1 Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvcmVzb3VyY2VzL3J1bm5lci5qcworKysgYi9QZXJmb3Jt YW5jZVRlc3RzL3Jlc291cmNlcy9ydW5uZXIuanMKQEAgLTIzNiwxMSArMjM2LDE1IEBAIGlmICh3 aW5kb3cudGVzdFJ1bm5lcikgewogICAgICAgICAgICAgaWdub3JlV2FybVVwQW5kTG9nKG1lYXN1 cmVkVmFsdWUpOwogICAgICAgICB9IGNhdGNoIChleGNlcHRpb24pIHsKICAgICAgICAgICAgIGxv Z0ZhdGFsRXJyb3IoIkdvdCBhbiBleGNlcHRpb24gd2hpbGUgbG9nZ2luZyB0aGUgcmVzdWx0IHdp dGggbmFtZT0iICsgZXhjZXB0aW9uLm5hbWUgKyAiLCBtZXNzYWdlPSIgKyBleGNlcHRpb24ubWVz c2FnZSk7Ci0gICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAg ICAgICAgIH0KIAotICAgICAgICBpZiAoY29tcGxldGVkSXRlcmF0aW9ucyA+PSBpdGVyYXRpb25D b3VudCkKKyAgICAgICAgaWYgKGNvbXBsZXRlZEl0ZXJhdGlvbnMgPj0gaXRlcmF0aW9uQ291bnQp IHsKICAgICAgICAgICAgIGZpbmlzaCgpOworICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAg ICAgICB9CisKKyAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfQogCiAgICAgUGVyZlRlc3RSdW5u ZXIubWVhc3VyZVRpbWUgPSBmdW5jdGlvbiAodGVzdCkgewo= 217191 2013-11-18 05:02:44 -0800 2013-11-18 07:26:28 -0800 Added Reviewed by line bug-124495-20131118220243.patch text/plain 2695 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMTU4OTAxCmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCmluZGV4IGVmMzZlOGNkMGMy ZDhjZDMwODgxYWY0NGU3MjQzYWJmMGM2MTEwMTguLjExMmE3OWI3MjI5NDY0Yzg5MjExYWVlMTk3 MGYyYzM3YTc2NTU1N2MgMTAwNjQ0Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCisr KyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTMtMTEt MTggIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1BlcmZvcm1h bmNlIHRlc3RzXSBJbnRlcmFjdGl2ZS9TZWxlY3RBbGwuaHRtbCB0aHJvd3MgYW4gZXhjZXB0aW9u CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQ0OTUK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKQorCisgICAgICAgIFJldHVybiBh IGJvb2xlYW4gaW5kaWNhdGluZyB3aGV0aGVyIG1vcmUgdmFsdWVzIGFyZSBuZWVkZWQgb3Igbm90 IGluCisgICAgICAgIFBlcmZUZXN0UnVubmVyLm1lYXN1cmVWYWx1ZUFzeW5jIHNvIHRoYXQgcnVu VGVzdCBjYW4gdGVybWluYXRlIGdyYWNlZnVsbHkuCisKKyAgICAgICAgKiBJbnRlcmFjdGl2ZS9T ZWxlY3RBbGwuaHRtbDoKKyAgICAgICAgKHJ1blRlc3QpOiBEb24ndCBzY2hlZHVsZSBhIHRpbWVy IGZvciBydW5UZXN0IGlmIHdlJ3ZlIGdvdCBlbm91Z2ggdmFsdWVzLgorICAgICAgICAqIHJlc291 cmNlcy9ydW5uZXIuanM6CisgICAgICAgIChQZXJmVGVzdFJ1bm5lci5tZWFzdXJlVmFsdWVBc3lu Yyk6IFJldHVybnMgdHJ1ZSBpZmYgbW9yZSB2YWx1ZXMgYXJlIG5lZWRlZC4KKwogMjAxMy0xMC0y NSAgU2VyZ2lvIFZpbGxhciBTZW5pbiAgPHN2aWxsYXJAaWdhbGlhLmNvbT4KIAogICAgICAgICBV c2UgYSBWZWN0b3IgaW5zdGVhZCBvZiBIYXNoU2V0IHRvIGNvbXB1dGVkIHRoZSBvcmRlclZhbHVl cyBpbiBSZW5kZXJGbGV4aWJsZUJveApkaWZmIC0tZ2l0IGEvUGVyZm9ybWFuY2VUZXN0cy9JbnRl cmFjdGl2ZS9TZWxlY3RBbGwuaHRtbCBiL1BlcmZvcm1hbmNlVGVzdHMvSW50ZXJhY3RpdmUvU2Vs ZWN0QWxsLmh0bWwKaW5kZXggMWU4OWFiOTRjOTQ3YTU5OTE1MTc3N2ZjMTI5YjhkMDU3NWQyYjU4 NS4uM2Q2ZDdlY2Q3YTdiZjJiNmI1OTEwNjBiZjhhYzM4Y2ZjOGM2NmYwNSAxMDA2NDQKLS0tIGEv UGVyZm9ybWFuY2VUZXN0cy9JbnRlcmFjdGl2ZS9TZWxlY3RBbGwuaHRtbAorKysgYi9QZXJmb3Jt YW5jZVRlc3RzL0ludGVyYWN0aXZlL1NlbGVjdEFsbC5odG1sCkBAIC0yMiwxMCArMjIsMTEgQEAg ZnVuY3Rpb24gcnVuVGVzdCgpIHsKICAgICAgICAgaWZyYW1lLmNvbnRlbnREb2N1bWVudC5leGVj Q29tbWFuZCgnU2VsZWN0QWxsJyk7CiAgICAgICAgIGlmcmFtZS5jb250ZW50RG9jdW1lbnQuYm9k eS5vZmZzZXRUb3A7CiAgICAgICAgIHNldFRpbWVvdXQoZnVuY3Rpb24gKCkgewotICAgICAgICAg ICAgUGVyZlRlc3RSdW5uZXIubWVhc3VyZVZhbHVlQXN5bmMoUGVyZlRlc3RSdW5uZXIubm93KCkg LSBzdGFydFRpbWUpOworICAgICAgICAgICAgaWYgKCFQZXJmVGVzdFJ1bm5lci5tZWFzdXJlVmFs dWVBc3luYyhQZXJmVGVzdFJ1bm5lci5ub3coKSAtIHN0YXJ0VGltZSkpCisgICAgICAgICAgICAg ICAgcmV0dXJuOwogICAgICAgICAgICAgUGVyZlRlc3RSdW5uZXIuZ2MoKTsKICAgICAgICAgICAg IHNldFRpbWVvdXQocnVuVGVzdCwgMCk7Ci0gICAgICAgIH0sIDApOyAgICAgICAgCisgICAgICAg IH0sIDApOwogICAgIH0sIDApOwogfQogCmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3RzL3Jl c291cmNlcy9ydW5uZXIuanMgYi9QZXJmb3JtYW5jZVRlc3RzL3Jlc291cmNlcy9ydW5uZXIuanMK aW5kZXggNTc2ZjFkMTNlOGQxM2U5NWJlYzliNWFlMGZlYzRkNWFmNzAyYjRmOC4uYzdhYTExNmRl Njc4ZGFhMDE1MzM4ZTQ2NzljZjU2YjBhODIwMWFmYSAxMDA3NTUKLS0tIGEvUGVyZm9ybWFuY2VU ZXN0cy9yZXNvdXJjZXMvcnVubmVyLmpzCisrKyBiL1BlcmZvcm1hbmNlVGVzdHMvcmVzb3VyY2Vz L3J1bm5lci5qcwpAQCAtMjM2LDExICsyMzYsMTUgQEAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7 CiAgICAgICAgICAgICBpZ25vcmVXYXJtVXBBbmRMb2cobWVhc3VyZWRWYWx1ZSk7CiAgICAgICAg IH0gY2F0Y2ggKGV4Y2VwdGlvbikgewogICAgICAgICAgICAgbG9nRmF0YWxFcnJvcigiR290IGFu IGV4Y2VwdGlvbiB3aGlsZSBsb2dnaW5nIHRoZSByZXN1bHQgd2l0aCBuYW1lPSIgKyBleGNlcHRp b24ubmFtZSArICIsIG1lc3NhZ2U9IiArIGV4Y2VwdGlvbi5tZXNzYWdlKTsKLSAgICAgICAgICAg IHJldHVybjsKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAgICAgfQogCi0gICAgICAg IGlmIChjb21wbGV0ZWRJdGVyYXRpb25zID49IGl0ZXJhdGlvbkNvdW50KQorICAgICAgICBpZiAo Y29tcGxldGVkSXRlcmF0aW9ucyA+PSBpdGVyYXRpb25Db3VudCkgewogICAgICAgICAgICAgZmlu aXNoKCk7CisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgIH0KKworICAgICAgICBy ZXR1cm4gdHJ1ZTsKICAgICB9CiAKICAgICBQZXJmVGVzdFJ1bm5lci5tZWFzdXJlVGltZSA9IGZ1 bmN0aW9uICh0ZXN0KSB7Cg==