124488 2013-11-18 02:18:07 -0800 [arm] Build fails since r159395. 2013-11-18 03:35:05 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 108645 1 jbriance webkit-unassigned commit-queue ossy rgabor zherczeg oldest_to_newest 951542 0 jbriance 2013-11-18 02:18:07 -0800 Build fails for CPU(ARM_TRADITIONAL) since http://trac.webkit.org/changeset/159395 because the following function is missing from MacroAssembler: Jump branch8(RelationalCondition cond, AbsoluteAddress left, TrustedImm32 right) 951543 1 217183 jbriance 2013-11-18 02:19:40 -0800 Created attachment 217183 Add missing branch8(RelationalCondition, AbsoluteAddress, TrustedImm32) implementation in arm MacroAssembler. 951554 2 217183 zherczeg 2013-11-18 03:10:16 -0800 Comment on attachment 217183 Add missing branch8(RelationalCondition, AbsoluteAddress, TrustedImm32) implementation in arm MacroAssembler. Patch looks good. 951563 3 217183 commit-queue 2013-11-18 03:35:03 -0800 Comment on attachment 217183 Add missing branch8(RelationalCondition, AbsoluteAddress, TrustedImm32) implementation in arm MacroAssembler. Clearing flags on attachment: 217183 Committed r159415: <http://trac.webkit.org/changeset/159415> 951564 4 commit-queue 2013-11-18 03:35:05 -0800 All reviewed patches have been landed. Closing bug. 217183 2013-11-18 02:19:40 -0800 2013-11-18 03:35:03 -0800 Add missing branch8(RelationalCondition, AbsoluteAddress, TrustedImm32) implementation in arm MacroAssembler. bug-124488.patch text/plain 1497 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU5NDA5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDEzLTExLTE4ICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgorCisg ICAgICAgIFthcm1dIEFkZCBtaXNzaW5nIGltcGxlbWVudGF0aW9uIGluIE1hY3JvQXNzZW1ibGVy IHRvIGZpeCBidWlsZCAoYnJva2VuIHNpbmNlIHIxNTkzOTUpLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI0NDg4CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJB Uk0uaDoKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJBUk06OmJyYW5jaDgpOgorCiAyMDEz LTExLTE3ICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgogCiAgICAgICAg IFtzaDRdIEZpeCByZXZlcnRKdW1wUmVwbGFjZW1lbnRUb0JyYW5jaFB0cldpdGhQYXRjaCBpbiBN YWNyb0Fzc2VtYmxlci4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFj cm9Bc3NlbWJsZXJBUk0uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNz ZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmgJKHJldmlzaW9uIDE1OTQwNykKKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaAkod29ya2luZyBjb3B5 KQpAQCAtNTcwLDYgKzU3MCwxMyBAQCBwdWJsaWM6CiAgICAgICAgIHJldHVybiBicmFuY2gzMihj b25kLCBBUk1SZWdpc3RlcnM6OlMxLCByaWdodCk7CiAgICAgfQogCisgICAgSnVtcCBicmFuY2g4 KFJlbGF0aW9uYWxDb25kaXRpb24gY29uZCwgQWJzb2x1dGVBZGRyZXNzIGxlZnQsIFRydXN0ZWRJ bW0zMiByaWdodCkKKyAgICB7CisgICAgICAgIG1vdmUoVHJ1c3RlZEltbVB0cihsZWZ0Lm1fcHRy KSwgQVJNUmVnaXN0ZXJzOjpTMSk7CisgICAgICAgIGxvYWQ4KEFkZHJlc3MoQVJNUmVnaXN0ZXJz OjpTMSksIEFSTVJlZ2lzdGVyczo6UzEpOworICAgICAgICByZXR1cm4gYnJhbmNoMzIoY29uZCwg QVJNUmVnaXN0ZXJzOjpTMSwgcmlnaHQpOworICAgIH0KKwogICAgIEp1bXAgYnJhbmNoMzIoUmVs YXRpb25hbENvbmRpdGlvbiBjb25kLCBSZWdpc3RlcklEIGxlZnQsIFJlZ2lzdGVySUQgcmlnaHQs IGludCB1c2VDb25zdGFudFBvb2wgPSAwKQogICAgIHsKICAgICAgICAgbV9hc3NlbWJsZXIuY21w KGxlZnQsIHJpZ2h0KTsK