124485 2013-11-18 01:35:56 -0800 REGRESSION(r159363): [GTK] API break in webkit_dom_html_media_element_set_current_time 2013-11-18 01:49:55 -0800 1 1 1 Unclassified WebKit Bindings 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned cdumez commit-queue gustavo pnormand oldest_to_newest 951532 0 cgarcia 2013-11-18 01:35:56 -0800 In r159363 currentTime attribute was changed to not raise exceptions. This breaks the API of GObject DOM bindings because we use a GError parameter for exceptions that has been removed. 951533 1 217179 cgarcia 2013-11-18 01:38:53 -0800 Created attachment 217179 Patch 951535 2 cgarcia 2013-11-18 01:49:55 -0800 Committed r159406: <http://trac.webkit.org/changeset/159406> 217179 2013-11-18 01:38:53 -0800 2013-11-18 01:46:12 -0800 Patch wkdom-api-break.diff text/plain 5110 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4MWUyNDc0Li5lMGQxYzYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYg QEAKKzIwMTMtMTEtMTggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFJFR1JFU1NJT04ocjE1OTM2Myk6IFtHVEtdIEFQSSBicmVhayBpbiB3ZWJr aXRfZG9tX2h0bWxfbWVkaWFfZWxlbWVudF9zZXRfY3VycmVudF90aW1lCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQ0ODUKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiByMTU5MzYzIGN1cnJlbnRUaW1l IGF0dHJpYnV0ZSB3YXMgY2hhbmdlZCB0byBub3QgcmFpc2UKKyAgICAgICAgZXhjZXB0aW9ucy4g VGhpcyBicmVha3MgdGhlIEFQSSBvZiBHT2JqZWN0IERPTSBiaW5kaW5ncyBiZWNhdXNlIHdlCisg ICAgICAgIHVzZSBhIEdFcnJvciBwYXJhbWV0ZXIgZm9yIGV4Y2VwdGlvbnMgdGhhdCBoYXMgYmVl biByZW1vdmVkLgorCisgICAgICAgICogYmluZGluZ3MvZ29iamVjdC9XZWJLaXRET01DdXN0b20u Y3BwOgorICAgICAgICAod2Via2l0X2RvbV9odG1sX21lZGlhX2VsZW1lbnRfc2V0X2N1cnJlbnRf dGltZSk6IEN1c3RvbQorICAgICAgICBpbXBsZW1lbnRhdGlvbiB0aGF0IHJlY2VpdmVzIGEgR0Vy cm9yIGZvciBiYWNrd2FyZHMKKyAgICAgICAgY29tcGF0aWJpbGl0eS4KKyAgICAgICAgKiBiaW5k aW5ncy9nb2JqZWN0L1dlYktpdERPTUN1c3RvbS5oOgorICAgICAgICAqIGJpbmRpbmdzL2dvYmpl Y3QvV2ViS2l0RE9NQ3VzdG9tLnN5bWJvbHM6IEFkZAorICAgICAgICB3ZWJraXRfZG9tX2h0bWxf bWVkaWFfZWxlbWVudF9zZXRfY3VycmVudF90aW1lIHByb3RvdHlwZS4KKyAgICAgICAgKiBiaW5k aW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBtOgorICAgICAgICAoU2tpcEZ1bmN0 aW9uKTogU2tpcAorICAgICAgICB3ZWJraXRfZG9tX2h0bWxfbWVkaWFfZWxlbWVudF9zZXRfY3Vy cmVudF90aW1lIHNpbmNlIHdlIGFyZSBhZGRpbmcKKyAgICAgICAgYSBjdXN0b20gaW1wbGVtZW50 YXRpb24uCisKIDIwMTMtMTEtMTcgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+ CiAKICAgICAgICAgUlNBU1NBLVBLQ1MxLXYxXzUgSldLIGltcG9ydCBkb2Vzbid0IGNoZWNrIGtl eSBzaXplCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0L1dlYktp dERPTUN1c3RvbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0L1dlYktpdERP TUN1c3RvbS5jcHAKaW5kZXggM2Q3M2Y3MC4uYmQ3ODNkYSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvZ29iamVjdC9XZWJLaXRET01DdXN0b20uY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL2dvYmplY3QvV2ViS2l0RE9NQ3VzdG9tLmNwcApAQCAtMTksNiArMTks NyBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIldlYktpdERPTUN1c3RvbS5oIgog CisjaW5jbHVkZSAiSlNNYWluVGhyZWFkRXhlY1N0YXRlLmgiCiAjaW5jbHVkZSAiV2ViS2l0RE9N QmxvYi5oIgogI2luY2x1ZGUgIldlYktpdERPTURPTVN0cmluZ0xpc3QuaCIKICNpbmNsdWRlICJX ZWJLaXRET01IVE1MQ29sbGVjdGlvbi5oIgpAQCAtMjYsNiArMjcsNyBAQAogI2luY2x1ZGUgIldl YktpdERPTUhUTUxIZWFkRWxlbWVudC5oIgogI2luY2x1ZGUgIldlYktpdERPTUhUTUxJbnB1dEVs ZW1lbnQuaCIKICNpbmNsdWRlICJXZWJLaXRET01IVE1MSW5wdXRFbGVtZW50UHJpdmF0ZS5oIgor I2luY2x1ZGUgIldlYktpdERPTUhUTUxNZWRpYUVsZW1lbnRQcml2YXRlLmgiCiAjaW5jbHVkZSAi V2ViS2l0RE9NSFRNTFRleHRBcmVhRWxlbWVudC5oIgogI2luY2x1ZGUgIldlYktpdERPTUhUTUxU ZXh0QXJlYUVsZW1lbnRQcml2YXRlLmgiCiAjaW5jbHVkZSAiV2ViS2l0RE9NTm9kZUxpc3QuaCIK QEAgLTUwLDYgKzUyLDE4IEBAIGdib29sZWFuIHdlYmtpdF9kb21faHRtbF9pbnB1dF9lbGVtZW50 X2lzX2VkaXRlZChXZWJLaXRET01IVE1MSW5wdXRFbGVtZW50KiBpbnB1CiAgICAgcmV0dXJuIGNv cmUoaW5wdXQpLT5sYXN0Q2hhbmdlV2FzVXNlckVkaXQoKTsKIH0KIAordm9pZCB3ZWJraXRfZG9t X2h0bWxfbWVkaWFfZWxlbWVudF9zZXRfY3VycmVudF90aW1lKFdlYktpdERPTUhUTUxNZWRpYUVs ZW1lbnQqIHNlbGYsIGdkb3VibGUgdmFsdWUsIEdFcnJvcioqKQoreworI2lmIEVOQUJMRShWSURF TykKKyAgICBXZWJDb3JlOjpKU01haW5UaHJlYWROdWxsU3RhdGUgc3RhdGU7CisgICAgZ19yZXR1 cm5faWZfZmFpbChXRUJLSVRfRE9NX0lTX0hUTUxfTUVESUFfRUxFTUVOVChzZWxmKSk7CisgICAg V2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudCogaXRlbSA9IFdlYktpdDo6Y29yZShzZWxmKTsKKyAg ICBpdGVtLT5zZXRDdXJyZW50VGltZSh2YWx1ZSk7CisjZWxzZQorICAgIFdFQktJVF9XQVJOX0ZF QVRVUkVfTk9UX1BSRVNFTlQoIlZpZGVvIikKKyNlbmRpZiAvKiBFTkFCTEUoVklERU8pICovCit9 CisKIC8qIENvbXBhdGliaWxpdHkgKi8KIFdlYktpdERPTUJsb2IqIHdlYmtpdF9kb21fYmxvYl93 ZWJraXRfc2xpY2UoV2ViS2l0RE9NQmxvYiogc2VsZiwgZ2ludDY0IHN0YXJ0LCBnaW50NjQgZW5k LCBjb25zdCBnY2hhciogY29udGVudF90eXBlKQogewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvZ29iamVjdC9XZWJLaXRET01DdXN0b20uaCBiL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL2dvYmplY3QvV2ViS2l0RE9NQ3VzdG9tLmgKaW5kZXggYzAyY2U2OS4uNGYwY2JhZSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ29iamVjdC9XZWJLaXRET01DdXN0 b20uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0L1dlYktpdERPTUN1c3Rv bS5oCkBAIC0zNCw2ICszNCwxNSBAQCBHX0JFR0lOX0RFQ0xTCiBXRUJLSVRfQVBJIGdib29sZWFu IHdlYmtpdF9kb21faHRtbF90ZXh0X2FyZWFfZWxlbWVudF9pc19lZGl0ZWQoV2ViS2l0RE9NSFRN TFRleHRBcmVhRWxlbWVudCogaW5wdXQpOwogCiAvKioKKyAqIHdlYmtpdF9kb21faHRtbF9tZWRp YV9lbGVtZW50X3NldF9jdXJyZW50X3RpbWU6CisgKiBAc2VsZjogQSAjV2ViS2l0RE9NSFRNTE1l ZGlhRWxlbWVudAorICogQHZhbHVlOiBBICNnZG91YmxlCisgKiBAZXJyb3I6ICNHRXJyb3IKKyAq CisgKi8KK1dFQktJVF9BUEkgdm9pZCB3ZWJraXRfZG9tX2h0bWxfbWVkaWFfZWxlbWVudF9zZXRf Y3VycmVudF90aW1lKFdlYktpdERPTUhUTUxNZWRpYUVsZW1lbnQqIHNlbGYsIGdkb3VibGUgdmFs dWUsIEdFcnJvcioqIGVycm9yKTsKKworLyoqCiAgKiB3ZWJraXRfZG9tX2h0bWxfaW5wdXRfZWxl bWVudF9pc19lZGl0ZWQ6CiAgKiBAaW5wdXQ6IEEgI1dlYktpdERPTUhUTUxJbnB1dEVsZW1lbnQK ICAqCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0L1dlYktpdERP TUN1c3RvbS5zeW1ib2xzIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ29iamVjdC9XZWJLaXRE T01DdXN0b20uc3ltYm9scwppbmRleCBhMzI2MjQ4Li5iYzI4MWUwIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0L1dlYktpdERPTUN1c3RvbS5zeW1ib2xzCisrKyBi L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dvYmplY3QvV2ViS2l0RE9NQ3VzdG9tLnN5bWJvbHMK QEAgLTEsNSArMSw2IEBACiBnYm9vbGVhbiB3ZWJraXRfZG9tX2h0bWxfdGV4dF9hcmVhX2VsZW1l bnRfaXNfZWRpdGVkKFdlYktpdERPTUhUTUxUZXh0QXJlYUVsZW1lbnQqKQogZ2Jvb2xlYW4gd2Vi a2l0X2RvbV9odG1sX2lucHV0X2VsZW1lbnRfaXNfZWRpdGVkKFdlYktpdERPTUhUTUxJbnB1dEVs ZW1lbnQqKQordm9pZCB3ZWJraXRfZG9tX2h0bWxfbWVkaWFfZWxlbWVudF9zZXRfY3VycmVudF90 aW1lKFdlYktpdERPTUhUTUxNZWRpYUVsZW1lbnQqLCBnZG91YmxlLCBHRXJyb3IqKikKIFdlYktp dERPTUJsb2IqIHdlYmtpdF9kb21fYmxvYl93ZWJraXRfc2xpY2UoV2ViS2l0RE9NQmxvYiosIGdp bnQ2NCwgZ2ludDY0LCBjb25zdCBnY2hhciopCiBnY2hhciogd2Via2l0X2RvbV9odG1sX2VsZW1l bnRfZ2V0X2NsYXNzX25hbWUoV2ViS2l0RE9NSFRNTEVsZW1lbnQqKQogdm9pZCB3ZWJraXRfZG9t X2h0bWxfZWxlbWVudF9zZXRfY2xhc3NfbmFtZShXZWJLaXRET01IVE1MRWxlbWVudCosIGNvbnN0 IGdjaGFyKikKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29k ZUdlbmVyYXRvckdPYmplY3QucG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0Nv ZGVHZW5lcmF0b3JHT2JqZWN0LnBtCmluZGV4IDg2NTkyNDAuLjYyNGFhMDEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3QucG0K KysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVj dC5wbQpAQCAtMjc4LDYgKzI3OCwxMSBAQCBzdWIgU2tpcEZ1bmN0aW9uIHsKICAgICAgICAgfQog ICAgIH0KIAorICAgICMgU2tpcCBmdW5jdGlvbnMgZm9yIHdoaWNoIHdlIGhhdmUgYSBjdXN0b20g aW1wbGVtZW50YXRpb24gZHVlIHRvIEFQSSBicmVha3MKKyAgICBpZiAoJGZ1bmN0aW9uTmFtZSBl cSAid2Via2l0X2RvbV9odG1sX21lZGlhX2VsZW1lbnRfc2V0X2N1cnJlbnRfdGltZSIpIHsKKyAg ICAgICAgcmV0dXJuIDE7CisgICAgfQorCiAgICAgIyBUaGlzIGlzIGZvciBEYXRhVHJhbnNmZXJJ dGVtTGlzdC5pZGwgYWRkKEZpbGUpIG1ldGhvZAogICAgIGlmICgkZnVuY3Rpb25OYW1lIGVxICJ3 ZWJraXRfZG9tX2RhdGFfdHJhbnNmZXJfaXRlbV9saXN0X2FkZCIgJiYgQHskZnVuY3Rpb24tPnBh cmFtZXRlcnN9ID09IDEpIHsKICAgICAgICAgcmV0dXJuIDE7Cg==