124455 2013-11-16 09:08:30 -0800 [sh4] Build is broken since r159346 2013-11-16 14:26:13 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jbriance webkit-unassigned commit-queue fpizlo msaboff oliver yannick.poirier oldest_to_newest 951362 0 jbriance 2013-11-16 09:08:30 -0800 r159346 introduced the following instruciton in LowLevelInterpreter32_64.asm storep previousPC, 4[newCallFrame] which is translated into the following invalid assembly for sh4: mov.l pr, @(4, r5) 951364 1 217126 jbriance 2013-11-16 09:24:45 -0800 Created attachment 217126 Handle load and store operations with pr register in sh4 LLINT. This patch fixes the build. The above code is now generated using a temp register: sts pr, r13 mov.l r13, @(4, r5) 951386 2 217126 commit-queue 2013-11-16 14:26:11 -0800 Comment on attachment 217126 Handle load and store operations with pr register in sh4 LLINT. Clearing flags on attachment: 217126 Committed r159381: <http://trac.webkit.org/changeset/159381> 951387 3 commit-queue 2013-11-16 14:26:13 -0800 All reviewed patches have been landed. Closing bug. 217126 2013-11-16 09:24:45 -0800 2013-11-16 14:26:11 -0800 Handle load and store operations with pr register in sh4 LLINT. bug-124455.patch text/plain 2883 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU5Mzc4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDEzLTExLTE2ICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgorCisg ICAgICAgIFtzaDRdIEZpeCBidWlsZCAoYnJva2VuIHNpbmNlIHIxNTkzNDYpLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI0NDU1CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IExMSU5UIGltcGxlbWVu dGF0aW9uIGZvciBzaDQgYXJjaGl0ZWN0dXJlIHRvIGhhbmRsZSBwcm9wZXJseSBsb2FkIGFuZCBz dG9yZSBvcGVyYXRpb25zIHdpdGggcHIgcmVnaXN0ZXIuCisKKyAgICAgICAgKiBvZmZsaW5lYXNt L3NoNC5yYjoKKwogMjAxMy0xMS0xNSAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNv bT4KIAogICAgICAgICBTdXBwb3J0IGV4cG9ydGluZyBzeW1tZXRyaWMga2V5cyBhcyBKV0sKSW5k ZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL3NoNC5yYgo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9zaDQucmIJKHJldmlzaW9uIDE1OTM3 OCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL3NoNC5yYgkod29ya2luZyBj b3B5KQpAQCAtNDczLDYgKzQ3Myw1MCBAQCBlbmQKIAogCiAjCisjIExvd2VyaW5nIG9mIG1pc3Bs YWNlZCBzcGVjaWFsIHJlZ2lzdGVycyBmb3IgU0g0LiBGb3IgZXhhbXBsZToKKyMKKyMgc3RvcmVw IHByLCBmb28KKyMKKyMgYmVjb21lczoKKyMKKyMgc3RzcHIgdG1wCisjIHN0b3JlcCB0bXAsIGZv bworIworCitkZWYgc2g0TG93ZXJNaXNwbGFjZWRTcGVjaWFsUmVnaXN0ZXJzKGxpc3QpCisgICAg bmV3TGlzdCA9IFtdCisgICAgbGlzdC5lYWNoIHsKKyAgICAgICAgfCBub2RlIHwKKyAgICAgICAg aWYgbm9kZS5pc19hPyBJbnN0cnVjdGlvbgorICAgICAgICAgICAgY2FzZSBub2RlLm9wY29kZQor ICAgICAgICAgICAgd2hlbiAibG9hZGkiLCAibG9hZGlzIiwgImxvYWRwIgorICAgICAgICAgICAg ICAgIGlmIG5vZGUub3BlcmFuZHNbMV0uaXNfYT8gUmVnaXN0ZXJJRCBhbmQgbm9kZS5vcGVyYW5k c1sxXS5zaDRPcGVyYW5kID09ICJwciIKKyAgICAgICAgICAgICAgICAgICAgdG1wID0gVG1wLm5l dyhjb2RlT3JpZ2luLCA6Z3ByKQorICAgICAgICAgICAgICAgICAgICBuZXdMaXN0IDw8IEluc3Ry dWN0aW9uLm5ldyhjb2RlT3JpZ2luLCBub2RlLm9wY29kZSwgW25vZGUub3BlcmFuZHNbMF0sIHRt cF0pCisgICAgICAgICAgICAgICAgICAgIG5ld0xpc3QgPDwgSW5zdHJ1Y3Rpb24ubmV3KGNvZGVP cmlnaW4sICJsZHNwciIsIFt0bXBdKQorICAgICAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAg ICAgICAgICAgbmV3TGlzdCA8PCBub2RlCisgICAgICAgICAgICAgICAgZW5kCisgICAgICAgICAg ICB3aGVuICJzdG9yZWkiLCAic3RvcmVwIgorICAgICAgICAgICAgICAgIGlmIG5vZGUub3BlcmFu ZHNbMF0uaXNfYT8gUmVnaXN0ZXJJRCBhbmQgbm9kZS5vcGVyYW5kc1swXS5zaDRPcGVyYW5kID09 ICJwciIKKyAgICAgICAgICAgICAgICAgICAgdG1wID0gVG1wLm5ldyhjb2RlT3JpZ2luLCA6Z3By KQorICAgICAgICAgICAgICAgICAgICBuZXdMaXN0IDw8IEluc3RydWN0aW9uLm5ldyhjb2RlT3Jp Z2luLCAic3RzcHIiLCBbdG1wXSkKKyAgICAgICAgICAgICAgICAgICAgbmV3TGlzdCA8PCBJbnN0 cnVjdGlvbi5uZXcoY29kZU9yaWdpbiwgbm9kZS5vcGNvZGUsIFt0bXAsIG5vZGUub3BlcmFuZHNb MV1dKQorICAgICAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICAgICAgbmV3TGlzdCA8 PCBub2RlCisgICAgICAgICAgICAgICAgZW5kCisgICAgICAgICAgICBlbHNlCisgICAgICAgICAg ICAgICAgbmV3TGlzdCA8PCBub2RlCisgICAgICAgICAgICBlbmQKKyAgICAgICAgZWxzZQorICAg ICAgICAgICAgbmV3TGlzdCA8PCBub2RlCisgICAgICAgIGVuZAorICAgIH0KKyAgICBuZXdMaXN0 CitlbmQKKworCisjCiAjIEdyb3VwIGltbWVkaWF0ZSB2YWx1ZXMgb3V0c2lkZSAtMTI4Li4xMjcg cmFuZ2UgaW50byBjb25zdGFudCBwb29scyBmb3IgU0g0LgogIyBUaGVzZSBjb25zdGFudCBwb29s cyB3aWxsIGJlIHBsYWNlZCBiZWhpbmQgbm9uLXJldHVybiBvcGNvZGVzIGptcCBhbmQgcmV0LCBm b3IgZXhhbXBsZToKICMKQEAgLTY4MCw2ICs3MjQsNyBAQCBjbGFzcyBTZXF1ZW5jZQogICAgICAg ICByZXN1bHQgPSByaXNjTG93ZXJNYWxmb3JtZWRJbW1lZGlhdGVzKHJlc3VsdCwgLTEyOC4uMTI3 KQogICAgICAgICByZXN1bHQgPSBzaDRMb3dlck1pc3BsYWNlZExhYmVscyhyZXN1bHQpCiAgICAg ICAgIHJlc3VsdCA9IHJpc2NMb3dlck1pc3BsYWNlZEFkZHJlc3NlcyhyZXN1bHQpCisgICAgICAg IHJlc3VsdCA9IHNoNExvd2VyTWlzcGxhY2VkU3BlY2lhbFJlZ2lzdGVycyhyZXN1bHQpCiAKICAg ICAgICAgcmVzdWx0ID0gYXNzaWduUmVnaXN0ZXJzVG9UZW1wb3JhcmllcyhyZXN1bHQsIDpncHIs IFNINF9UTVBfR1BSUykKICAgICAgICAgcmVzdWx0ID0gYXNzaWduUmVnaXN0ZXJzVG9UZW1wb3Jh cmllcyhyZXN1bHQsIDpncHIsIFNINF9UTVBfRlBSUykK