124452 2013-11-16 02:27:30 -0800 [Curl] Basic authentication is not reused. 2013-11-18 11:02:27 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned bfulgham commit-queue galpeter oldest_to_newest 951352 0 peavo 2013-11-16 02:27:30 -0800 After I've made a successful basic authentication, the credentials are not reused for later requests. In the CFNetwork port, this is solved by first checking if credentials exists for a given url in a new request. If credentials are found, basic authentication is tried first. Also, when a 401 response is received, the first thing the CFNetwork port does, is to check if m_user/m_pass is set (which means no authentication method is given in the request). If so, the m_user/m_pass credential is sent in the request to the server. This can be done in the same way for the Curl version. 951354 1 217123 peavo 2013-11-16 02:38:34 -0800 Created attachment 217123 Patch 951652 2 217123 bfulgham 2013-11-18 10:17:42 -0800 Comment on attachment 217123 Patch r=me 951684 3 217123 commit-queue 2013-11-18 10:42:56 -0800 Comment on attachment 217123 Patch Clearing flags on attachment: 217123 Committed r159435: <http://trac.webkit.org/changeset/159435> 951685 4 commit-queue 2013-11-18 10:42:58 -0800 All reviewed patches have been landed. Closing bug. 951700 5 peavo 2013-11-18 11:02:27 -0800 (In reply to comment #2) > (From update of attachment 217123 [details]) > r=me Thanks! 217123 2013-11-16 02:38:34 -0800 2013-11-18 10:42:56 -0800 Patch bug-124452-20131116113647.patch text/plain 3484 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1OTM3OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEzLTExLTE2ICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtDdXJsXSBCYXNpYyBh dXRoZW50aWNhdGlvbiBpcyBub3QgcmV1c2VkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI0NDUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQWZ0ZXIgYSBzdWNjZXNzZnVsIGJhc2ljIGF1dGhlbnRpY2F0 aW9uLCB0aGUgY3JlZGVudGlhbHMgYXJlIG5vdCByZXVzZWQgZm9yIGxhdGVyIHJlcXVlc3RzLgor ICAgICAgICBJbiB0aGUgQ0ZOZXR3b3JrIHBvcnQsIHRoaXMgaXMgc29sdmVkIGJ5IHRyeWluZyBi YXNpYyBhdXRoZW50aWNhdGlvbiBmaXJzdCwgaWYgY3JlZGVudGlhbHMgZXhpc3RzLgorICAgICAg ICBBbHNvLCB3aGVuIGEgNDAxIHJlc3BvbnNlIGlzIHJlY2VpdmVkLCB0aGUgZmlyc3QgdGhpbmcg dGhlIENGTmV0d29yayBwb3J0IGRvZXMsIGlzIHRvIHVzZQorICAgICAgICBtX3VzZXIvbV9wYXNz IGFzIGNyZWRlbnRpYWxzIGluIHRoZSBmb2xsb3dpbmcgcmVxdWVzdCBpZiB0aGV5IGFyZSBzZXQu CisgICAgICAgIFRoaXMgY2FuIGJlIGRvbmUgdGhlIHNhbWUgd2F5IGZvciB0aGUgQ3VybCB2ZXJz aW9uLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jdXJsL1Jlc291cmNlSGFuZGxlQ3Vy bC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZTo6ZGlkUmVjZWl2ZUF1dGhl bnRpY2F0aW9uQ2hhbGxlbmdlKTogVHJ5IHVzaW5nIG1fdXNlci9tX3Bhc3MgYXMgY3JlZGVudGlh bHMgZmlyc3QsIGlmIHRoZXkgYXJlIHNldC4KKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2N1 cmwvUmVzb3VyY2VIYW5kbGVNYW5hZ2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNl SGFuZGxlTWFuYWdlcjo6YXBwbHlBdXRoZW50aWNhdGlvblRvUmVxdWVzdCk6IFRyeSBiYXNpYyBh dXRoZW50aWNhdGlvbiBmaXJzdCwgaWYgY3JlZGVudGlhbHMgZXhpc3RzLgorCiAyMDEzLTExLTE2 ICBab2x0YW4gSG9ydmF0aCAgPHpvbHRhbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFJlbW92ZSB0 aGUgaW5jbHVkZSBvZiBMaW5lV2lkdGguaCBmcm9tIFNpbXBsZUxpbmVMYXlvdXRGdW5jdGlvbnMu Y3BwCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUmVzb3VyY2VI YW5kbGVDdXJsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3 b3JrL2N1cmwvUmVzb3VyY2VIYW5kbGVDdXJsLmNwcAkocmV2aXNpb24gMTU5Mzc4KQorKysgU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL1Jlc291cmNlSGFuZGxlQ3VybC5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTE4OSw2ICsxODksMjMgQEAgdm9pZCBSZXNvdXJjZUhhbmRsZTo6 cGxhdGZvcm1Mb2FkUmVzb3VyYwogCiB2b2lkIFJlc291cmNlSGFuZGxlOjpkaWRSZWNlaXZlQXV0 aGVudGljYXRpb25DaGFsbGVuZ2UoY29uc3QgQXV0aGVudGljYXRpb25DaGFsbGVuZ2UmIGNoYWxs ZW5nZSkKIHsKKyAgICBpZiAoIWQtPm1fdXNlci5pc051bGwoKSAmJiAhZC0+bV9wYXNzLmlzTnVs bCgpKSB7CisgICAgICAgIENyZWRlbnRpYWwgY3JlZGVudGlhbChkLT5tX3VzZXIsIGQtPm1fcGFz cywgQ3JlZGVudGlhbFBlcnNpc3RlbmNlTm9uZSk7CisKKyAgICAgICAgVVJMIHVybFRvU3RvcmU7 CisgICAgICAgIGlmIChjaGFsbGVuZ2UuZmFpbHVyZVJlc3BvbnNlKCkuaHR0cFN0YXR1c0NvZGUo KSA9PSA0MDEpCisgICAgICAgICAgICB1cmxUb1N0b3JlID0gY2hhbGxlbmdlLmZhaWx1cmVSZXNw b25zZSgpLnVybCgpOworICAgICAgICBDcmVkZW50aWFsU3RvcmFnZTo6c2V0KGNyZWRlbnRpYWws IGNoYWxsZW5nZS5wcm90ZWN0aW9uU3BhY2UoKSwgdXJsVG9TdG9yZSk7CisgICAgICAgIAorICAg ICAgICBTdHJpbmcgdXNlcnBhc3MgPSBjcmVkZW50aWFsLnVzZXIoKSArICI6IiArIGNyZWRlbnRp YWwucGFzc3dvcmQoKTsKKyAgICAgICAgY3VybF9lYXN5X3NldG9wdChkLT5tX2hhbmRsZSwgQ1VS TE9QVF9VU0VSUFdELCB1c2VycGFzcy51dGY4KCkuZGF0YSgpKTsKKworICAgICAgICBkLT5tX3Vz ZXIgPSBTdHJpbmcoKTsKKyAgICAgICAgZC0+bV9wYXNzID0gU3RyaW5nKCk7CisgICAgICAgIC8v IEZJWE1FOiBQZXIgdGhlIHNwZWNpZmljYXRpb24sIHRoZSB1c2VyIHNob3VsZG4ndCBiZSBhc2tl ZCBmb3IgY3JlZGVudGlhbHMgaWYgdGhlcmUgd2VyZSBpbmNvcnJlY3Qgb25lcyBwcm92aWRlZCBl eHBsaWNpdGx5LgorICAgICAgICByZXR1cm47CisgICAgfQorCiAgICAgaWYgKHNob3VsZFVzZUNy ZWRlbnRpYWxTdG9yYWdlKCkpIHsKICAgICAgICAgaWYgKCFkLT5tX2luaXRpYWxDcmVkZW50aWFs LmlzRW1wdHkoKSB8fCBjaGFsbGVuZ2UucHJldmlvdXNGYWlsdXJlQ291bnQoKSkgewogICAgICAg ICAgICAgLy8gVGhlIHN0b3JlZCBjcmVkZW50aWFsIHdhc24ndCBhY2NlcHRlZCwgc3RvcCB1c2lu ZyBpdC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJj ZUhhbmRsZU1hbmFnZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvY3VybC9SZXNvdXJjZUhhbmRsZU1hbmFnZXIuY3BwCShyZXZpc2lvbiAxNTkzNzgp CisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUmVzb3VyY2VIYW5kbGVN YW5hZ2VyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODg3LDYgKzg4Nyw3IEBAIHZvaWQgUmVzb3Vy Y2VIYW5kbGVNYW5hZ2VyOjphcHBseUF1dGhlbnQKICAgICBpZiAoIWQtPm1faW5pdGlhbENyZWRl bnRpYWwuaXNFbXB0eSgpKSB7CiAgICAgICAgIHVzZXIgPSBkLT5tX2luaXRpYWxDcmVkZW50aWFs LnVzZXIoKTsKICAgICAgICAgcGFzc3dvcmQgPSBkLT5tX2luaXRpYWxDcmVkZW50aWFsLnBhc3N3 b3JkKCk7CisgICAgICAgIGN1cmxfZWFzeV9zZXRvcHQoZC0+bV9oYW5kbGUsIENVUkxPUFRfSFRU UEFVVEgsIENVUkxBVVRIX0JBU0lDKTsKICAgICB9CiAKICAgICAvLyBJdCBzZWVtcyB3ZSBuZWVk IHRvIHNldCBDVVJMT1BUX1VTRVJQV0QgZXZlbiBpZiB1c2VybmFtZSBhbmQgcGFzc3dvcmQgaXMg ZW1wdHkuCg==