124420 2013-11-15 10:08:28 -0800 REGRESSION (r158586): callToJavaScript needs to save return PC to Sentinel frame 2013-11-15 11:04:52 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 116888 1 msaboff msaboff oldest_to_newest 951106 0 msaboff 2013-11-15 10:08:28 -0800 The sentinel frame added in r158586 sets the return PC in the sentinel frame to 0. The sentinel frame is effectively the call frame for callToJavaScript and therefore should have the return PC set to its caller. 951116 1 217063 msaboff 2013-11-15 10:42:11 -0800 Created attachment 217063 Patch 951125 2 msaboff 2013-11-15 11:04:52 -0800 Committed r159346: <http://trac.webkit.org/changeset/159346> 217063 2013-11-15 10:42:11 -0800 2013-11-15 10:55:06 -0800 Patch 124420.patch text/plain 5068 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU5MzQ0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDEzLTExLTE1ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFJFR1JFU1NJT04gKHIxNTg1ODYpOiBjYWxsVG9KYXZhU2NyaXB0IG5lZWRzIHRvIHNhdmUg cmV0dXJuIFBDIHRvIFNlbnRpbmVsIGZyYW1lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQ0MjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBTYXZlIHRoZSByZXR1cm4gUEMgaW50byB0aGUgc2VudGluZWwg ZnJhbWUuCisKKyAgICAgICAgKiBqaXQvSklUU3R1YnNNU1ZDNjQuYXNtOgorICAgICAgICAqIGpp dC9KSVRTdHVic1g4Ni5oOgorICAgICAgICAqIGxsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82 NC5hc206CisgICAgICAgICogbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjY0LmFzbToKKwogMjAx My0xMS0xNCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2Ug Q0xvb3AgZWFzaWVyIHRvIGJ1aWxkLCBhbmQgbWFrZSBpdCB3b3JrCkluZGV4OiBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvaml0L0pJVFN0dWJzTVNWQzY0LmFzbQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvaml0L0pJVFN0dWJzTVNWQzY0LmFzbQkocmV2aXNpb24gMTU5MzQyKQor KysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRTdHVic01TVkM2NC5hc20JKHdvcmtpbmcg Y29weSkKQEAgLTMyLDYgKzMyLDcgQEAgUFVCTElDIGdldEhvc3RDYWxsUmV0dXJuVmFsdWUKIF9U RVhUICAgU0VHTUVOVAogCiBjYWxsVG9KYXZhU2NyaXB0IFBST0MKKyAgICBtb3YgcjEwLCBxd29y ZCBwdHJbc3BdCiAgICAgcHVzaCByYnAKICAgICBtb3YgcmF4LCByYnAgOyBTYXZlIHByZXZpb3Vz IGZyYW1lIHBvaW50ZXIKICAgICBtb3YgcmJwLCByc3AKQEAgLTQ5LDYgKzUwLDcgQEAgY2FsbFRv SmF2YVNjcmlwdCBQUk9DCiAgICAgbW92IHJicCwgcmR4CiAgICAgbW92IHIxMSwgcXdvcmQgcHRy W3JicF0gOyBQdXQgdGhlIHByZXZpb3VzIGZyYW1lIHBvaW50ZXIgaW4gdGhlIHNlbnRpbmVsIGNh bGwgZnJhbWUgYWJvdmUgdXMKICAgICBtb3YgcXdvcmQgcHRyW3IxMV0sIHJheAorICAgIG1vdiBx d29yZCBwdHJbcjExICsgOF0sIHIxMAogICAgIG1vdiByMTQsIDBGRkZGMDAwMDAwMDAwMDAwaAog ICAgIG1vdiByMTUsIDBGRkZGMDAwMDAwMDAwMDAyaAogICAgIGNhbGwgcmN4CkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFN0dWJzWDg2LmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL2ppdC9KSVRTdHVic1g4Ni5oCShyZXZpc2lvbiAxNTkzNDIpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFN0dWJzWDg2LmgJKHdvcmtpbmcgY29weSkKQEAg LTIwOSw2ICsyMDksNyBAQCBleHRlcm4gIkMiIHsKICAgICBfX2RlY2xzcGVjKG5ha2VkKSBFbmNv ZGVkSlNWYWx1ZSBjYWxsVG9KYXZhU2NyaXB0KHZvaWQqIGNvZGUsIEV4ZWNTdGF0ZSopCiAgICAg ewogICAgICAgICBfX2FzbSB7CisgICAgICAgICAgICBtb3YgZWR4LCBbZXNwXQogICAgICAgICAg ICAgcHVzaCBlYnA7CiAgICAgICAgICAgICBtb3YgZWF4LCBlYnA7CiAgICAgICAgICAgICBtb3Yg ZWJwLCBlc3A7CkBAIC0yMTksNiArMjIwLDcgQEAgZXh0ZXJuICJDIiB7CiAgICAgICAgICAgICBt b3YgZWJwLCBbZXNwICsgMHgzNF07CiAgICAgICAgICAgICBtb3YgZWJ4LCBbZWJwXTsKICAgICAg ICAgICAgIG1vdiBbZWJ4XSwgZWF4OworICAgICAgICAgICAgbW92IDRbZWJ4XSwgZWR4CiAgICAg ICAgICAgICBjYWxsIFtlc3AgKyAweDMwXTsKICAgICAgICAgICAgIGFkZCBlc3AsIDB4MWM7CiAg ICAgICAgICAgICBwb3AgZWJ4OwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xv d0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc20KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3Jp cHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc20JKHJldmlzaW9uIDE1OTM0 MikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyMzJf NjQuYXNtCSh3b3JraW5nIGNvcHkpCkBAIC0xNzQsMzEgKzE3NCwzNyBAQCBtYWNybyBkb0NhbGxU b0phdmFTY3JpcHQoKQogICAgIGlmIFg4NgogICAgICAgICBjb25zdCBleHRyYVN0YWNrU3BhY2Ug PSAyOAogICAgICAgICBjb25zdCBwcmV2aW91c0NGUiA9IHQwCisgICAgICAgIGNvbnN0IHByZXZp b3VzUEMgPSB0MQogICAgICAgICBjb25zdCBlbnRyeSA9IHQ1CiAgICAgICAgIGNvbnN0IG5ld0Nh bGxGcmFtZSA9IHQ0CiAgICAgZWxzaWYgQVJNIG9yIEFSTXY3X1RSQURJVElPTkFMCiAgICAgICAg IGNvbnN0IGV4dHJhU3RhY2tTcGFjZSA9IDE2CiAgICAgICAgIGNvbnN0IHByZXZpb3VzQ0ZSID0g dDMgIAorICAgICAgICBjb25zdCBwcmV2aW91c1BDID0gbHIKICAgICAgICAgY29uc3QgZW50cnkg PSBhMAogICAgICAgICBjb25zdCBuZXdDYWxsRnJhbWUgPSBhMQogICAgIGVsc2lmIEFSTXY3CiAg ICAgICAgIGNvbnN0IGV4dHJhU3RhY2tTcGFjZSA9IDI4CiAgICAgICAgIGNvbnN0IHByZXZpb3Vz Q0ZSID0gdDMgIAorICAgICAgICBjb25zdCBwcmV2aW91c1BDID0gbHIKICAgICAgICAgY29uc3Qg ZW50cnkgPSBhMAogICAgICAgICBjb25zdCBuZXdDYWxsRnJhbWUgPSBhMQogICAgIGVsc2lmIE1J UFMKICAgICAgICAgY29uc3QgZXh0cmFTdGFja1NwYWNlID0gMjAKICAgICAgICAgY29uc3QgcHJl dmlvdXNDRlIgPSB0MiAgCisgICAgICAgIGNvbnN0IHByZXZpb3VzUEMgPSBscgogICAgICAgICBj b25zdCBlbnRyeSA9IGEwCiAgICAgICAgIGNvbnN0IG5ld0NhbGxGcmFtZSA9IGExCiAgICAgZWxz aWYgU0g0CiAgICAgICAgIGNvbnN0IGV4dHJhU3RhY2tTcGFjZSA9IDIwCiAgICAgICAgIGNvbnN0 IHByZXZpb3VzQ0ZSID0gdDMgIAorICAgICAgICBjb25zdCBwcmV2aW91c1BDID0gbHIKICAgICAg ICAgY29uc3QgZW50cnkgPSBhMAogICAgICAgICBjb25zdCBuZXdDYWxsRnJhbWUgPSBhMQogICAg IGVuZAogCiAgICAgaWYgWDg2CisgICAgICAgIGxvYWRwIFtzcF0sIHByZXZpb3VzUEMKICAgICAg ICAgbW92ZSBjZnIsIHByZXZpb3VzQ0ZSCiAgICAgZW5kCiAgICAgZnVuY3Rpb25Qcm9sb2d1ZShl eHRyYVN0YWNrU3BhY2UpCkBAIC0yMTIsNiArMjE4LDcgQEAgbWFjcm8gZG9DYWxsVG9KYXZhU2Ny aXB0KCkKICAgICBtb3ZlIG5ld0NhbGxGcmFtZSwgY2ZyCiAgICAgbG9hZHAgW2Nmcl0sIG5ld0Nh bGxGcmFtZQogICAgIHN0b3JlcCBwcmV2aW91c0NGUiwgW25ld0NhbGxGcmFtZV0KKyAgICBzdG9y ZXAgcHJldmlvdXNQQywgNFtuZXdDYWxsRnJhbWVdCiAgICAgY2FsbCBlbnRyeQogCiBfcmV0dXJu RnJvbUphdmFTY3JpcHQ6CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2 ZWxJbnRlcnByZXRlcjY0LmFzbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUv bGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjY0LmFzbQkocmV2aXNpb24gMTU5MzQyKQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXI2NC5hc20JKHdvcmtp bmcgY29weSkKQEAgLTExOSwyNiArMTE5LDMzIEBAIG1hY3JvIGRvQ2FsbFRvSmF2YVNjcmlwdCgp CiAgICAgaWYgWDg2XzY0CiAgICAgICAgIGNvbnN0IGV4dHJhU3RhY2tTcGFjZSA9IDgKICAgICAg ICAgY29uc3QgcHJldmlvdXNDRlIgPSB0MAorICAgICAgICBjb25zdCBwcmV2aW91c1BDID0gdDYK ICAgICAgICAgY29uc3QgZW50cnkgPSB0NQogICAgICAgICBjb25zdCBuZXdDYWxsRnJhbWUgPSB0 NAogICAgIGVsc2lmIEFSTTY0CiAgICAgICAgIGNvbnN0IGV4dHJhU3RhY2tTcGFjZSA9IDAKLSAg ICAgICAgY29uc3QgcHJldmlvdXNDRlIgPSB0NCAgCisgICAgICAgIGNvbnN0IHByZXZpb3VzQ0ZS ID0gdDQKKyAgICAgICAgY29uc3QgcHJldmlvdXNQQyA9IGxyCiAgICAgICAgIGNvbnN0IGVudHJ5 ID0gYTAKICAgICAgICAgY29uc3QgbmV3Q2FsbEZyYW1lID0gYTEKICAgICBlbHNpZiBDX0xPT1AK ICAgICAgICAgY29uc3QgZXh0cmFTdGFja1NwYWNlID0gMAogICAgICAgICBjb25zdCBwcmV2aW91 c0NGUiA9IHQ0ICAKKyAgICAgICAgY29uc3QgcHJldmlvdXNQQyA9IGxyCiAgICAgICAgIGNvbnN0 IGVudHJ5ID0gYTAKICAgICAgICAgY29uc3QgbmV3Q2FsbEZyYW1lID0gYTEKICAgICBlbmQKIAor ICAgIGlmIFg4Nl82NAorICAgICAgICBsb2FkcCBbc3BdLCBwcmV2aW91c1BDCisgICAgZW5kCiAg ICAgbW92ZSBjZnIsIHByZXZpb3VzQ0ZSCiAgICAgZnVuY3Rpb25Qcm9sb2d1ZShleHRyYVN0YWNr U3BhY2UpCiAKICAgICBtb3ZlIG5ld0NhbGxGcmFtZSwgY2ZyCiAgICAgbG9hZHAgW2Nmcl0sIG5l d0NhbGxGcmFtZQogICAgIHN0b3JlcCBwcmV2aW91c0NGUiwgW25ld0NhbGxGcmFtZV0KKyAgICBz dG9yZXAgcHJldmlvdXNQQywgOFtuZXdDYWxsRnJhbWVdCiAgICAgbW92ZSAweGZmZmYwMDAwMDAw MDAwMDAsIGNzcjEKICAgICBhZGRwIDIsIGNzcjEsIGNzcjIKICAgICBjYWxsIGVudHJ5Cg==