124404 2013-11-15 03:56:57 -0800 [AX] Use std::unique_ptr to manage AXComputedObjectAttributeCache 2013-11-19 06:53:14 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 k.czech webkit-unassigned aboxhall apinheiro cfleizach commit-queue dmazzoni jcraig jdiggs mario samuel_white webkit-bug-importer oldest_to_newest 951020 0 k.czech 2013-11-15 03:56:57 -0800 Convert OwnPtr/PassOwnPtr to std::unique_ptr. 951021 1 webkit-bug-importer 2013-11-15 03:57:13 -0800 <rdar://problem/15479102> 951023 2 217040 k.czech 2013-11-15 03:59:23 -0800 Created attachment 217040 proposed patch 951560 3 217040 mario 2013-11-18 03:25:54 -0800 Comment on attachment 217040 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=217040&action=review > Source/WebCore/accessibility/AXObjectCache.h:-64 > - AXComputedObjectAttributeCache() { } > - Instead of just removing the constructor from the private section to make it public (so you can use it with make_unique), I think you'd better move this constructor to the public section and add the explicit keyword there to make it, well, explicit :) 951612 4 k.czech 2013-11-18 08:23:34 -0800 (In reply to comment #3) > (From update of attachment 217040 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=217040&action=review > > > Source/WebCore/accessibility/AXObjectCache.h:-64 > > - AXComputedObjectAttributeCache() { } > > - > > Instead of just removing the constructor from the private section to make it public (so you can use it with make_unique), I think you'd better move this constructor to the public section and add the explicit keyword there to make it, well, explicit :) I'm thinking about any benefits of moving to public and declaring AXComputedObjectAttributeCache() { } as a explicit. I guess there won't be any implicit conversions. It's a constructor without parameters. 952046 5 k.czech 2013-11-19 05:59:39 -0800 Any more comments on this ? 952054 6 217040 mario 2013-11-19 06:28:32 -0800 Comment on attachment 217040 proposed patch (In reply to comment #5) > Any more comments on this ? Nope. I think it's ok like it is then, unless I'm missing something. 952057 7 217040 commit-queue 2013-11-19 06:53:12 -0800 Comment on attachment 217040 proposed patch Clearing flags on attachment: 217040 Committed r159500: <http://trac.webkit.org/changeset/159500> 952058 8 commit-queue 2013-11-19 06:53:14 -0800 All reviewed patches have been landed. Closing bug. 217040 2013-11-15 03:59:23 -0800 2013-11-19 06:53:11 -0800 proposed patch a11y-unique-ptr.patch text/plain 3026 k.czech ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyMDRjYWZhLi4yNWYwMDk0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTMtMTEtMTUgIEtyenlzenRvZiBDemVjaCAgPGsuY3plY2hAc2Ftc3VuZy5jb20+CisK KyAgICAgICAgW0FYXSBVc2Ugc3RkOjp1bmlxdWVfcHRyIHRvIG1hbmFnZSBBWENvbXB1dGVkT2Jq ZWN0QXR0cmlidXRlQ2FjaGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEyNDQwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIENvbnZlcnQgT3duUHRyL1Bhc3NPd25QdHIgdG8gc3RkOjp1bmlxdWVfcHRyLgor CisgICAgICAgICogYWNjZXNzaWJpbGl0eS9BWE9iamVjdENhY2hlLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkFYT2JqZWN0Q2FjaGU6OnN0YXJ0Q2FjaGluZ0NvbXB1dGVkT2JqZWN0QXR0cmlidXRl c1VudGlsVHJlZU11dGF0ZXMpOgorICAgICAgICAoV2ViQ29yZTo6QVhPYmplY3RDYWNoZTo6c3Rv cENhY2hpbmdDb21wdXRlZE9iamVjdEF0dHJpYnV0ZXMpOgorICAgICAgICAqIGFjY2Vzc2liaWxp dHkvQVhPYmplY3RDYWNoZS5oOgorICAgICAgICAoV2ViQ29yZTo6QVhDb21wdXRlZE9iamVjdEF0 dHJpYnV0ZUNhY2hlOjpBWENvbXB1dGVkT2JqZWN0QXR0cmlidXRlQ2FjaGUpOgorCiAyMDEzLTEx LTE0ICBWaWN0b3IgQ29zdGFuICA8Y29zdGFuQGdtYWlsLmNvbT4KIAogICAgICAgICBYTUxTZXJp YWxpemVyIGVzY2FwZXMgPCA+ICYgY29ycmVjdGx5IGluc2lkZSA8c2NyaXB0PiBhbmQgPHN0eWxl PiB0YWdzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BWE9iamVj dENhY2hlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5j cHAKaW5kZXggMDgwZWExYS4uM2M0YzU5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNj ZXNzaWJpbGl0eS9BWE9iamVjdENhY2hlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3Np YmlsaXR5L0FYT2JqZWN0Q2FjaGUuY3BwCkBAIC04NjYsMTMgKzg2NiwxMiBAQCB2b2lkIEFYT2Jq ZWN0Q2FjaGU6OnJlY29tcHV0ZUlzSWdub3JlZChSZW5kZXJPYmplY3QqIHJlbmRlcmVyKQogdm9p ZCBBWE9iamVjdENhY2hlOjpzdGFydENhY2hpbmdDb21wdXRlZE9iamVjdEF0dHJpYnV0ZXNVbnRp bFRyZWVNdXRhdGVzKCkKIHsKICAgICBpZiAoIW1fY29tcHV0ZWRPYmplY3RBdHRyaWJ1dGVDYWNo ZSkKLSAgICAgICAgbV9jb21wdXRlZE9iamVjdEF0dHJpYnV0ZUNhY2hlID0gQVhDb21wdXRlZE9i amVjdEF0dHJpYnV0ZUNhY2hlOjpjcmVhdGUoKTsKKyAgICAgICAgbV9jb21wdXRlZE9iamVjdEF0 dHJpYnV0ZUNhY2hlID0gc3RkOjptYWtlX3VuaXF1ZTxBWENvbXB1dGVkT2JqZWN0QXR0cmlidXRl Q2FjaGU+KCk7CiB9CiAKIHZvaWQgQVhPYmplY3RDYWNoZTo6c3RvcENhY2hpbmdDb21wdXRlZE9i amVjdEF0dHJpYnV0ZXMoKQogewotICAgIGlmIChtX2NvbXB1dGVkT2JqZWN0QXR0cmlidXRlQ2Fj aGUpCi0gICAgICAgIG1fY29tcHV0ZWRPYmplY3RBdHRyaWJ1dGVDYWNoZS5jbGVhcigpOworICAg IG1fY29tcHV0ZWRPYmplY3RBdHRyaWJ1dGVDYWNoZSA9IG51bGxwdHI7CiB9CiAKIFZpc2libGVQ b3NpdGlvbiBBWE9iamVjdENhY2hlOjp2aXNpYmxlUG9zaXRpb25Gb3JUZXh0TWFya2VyRGF0YShU ZXh0TWFya2VyRGF0YSYgdGV4dE1hcmtlckRhdGEpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuaCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2li aWxpdHkvQVhPYmplY3RDYWNoZS5oCmluZGV4IGIyMjdjNjguLmUyZTg5NzIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5oCkBAIC01NCwxNCArNTQsMTAg QEAgc3RydWN0IFRleHRNYXJrZXJEYXRhIHsKIAogY2xhc3MgQVhDb21wdXRlZE9iamVjdEF0dHJp YnV0ZUNhY2hlIHsKIHB1YmxpYzoKLSAgICBzdGF0aWMgUGFzc093blB0cjxBWENvbXB1dGVkT2Jq ZWN0QXR0cmlidXRlQ2FjaGU+IGNyZWF0ZSgpIHsgcmV0dXJuIGFkb3B0UHRyKG5ldyBBWENvbXB1 dGVkT2JqZWN0QXR0cmlidXRlQ2FjaGUoKSk7IH0KLQogICAgIEFjY2Vzc2liaWxpdHlPYmplY3RJ bmNsdXNpb24gZ2V0SWdub3JlZChBWElEKSBjb25zdDsKICAgICB2b2lkIHNldElnbm9yZWQoQVhJ RCwgQWNjZXNzaWJpbGl0eU9iamVjdEluY2x1c2lvbik7CiAKIHByaXZhdGU6Ci0gICAgQVhDb21w dXRlZE9iamVjdEF0dHJpYnV0ZUNhY2hlKCkgeyB9Ci0KICAgICBzdHJ1Y3QgQ2FjaGVkQVhPYmpl Y3RBdHRyaWJ1dGVzIHsKICAgICAgICAgQ2FjaGVkQVhPYmplY3RBdHRyaWJ1dGVzKCkgOiBpZ25v cmVkKERlZmF1bHRCZWhhdmlvcikgeyB9CiAKQEAgLTIyOSw3ICsyMjUsNyBAQCBwcml2YXRlOgog ICAgIEhhc2hNYXA8V2lkZ2V0KiwgQVhJRD4gbV93aWRnZXRPYmplY3RNYXBwaW5nOwogICAgIEhh c2hNYXA8Tm9kZSosIEFYSUQ+IG1fbm9kZU9iamVjdE1hcHBpbmc7CiAgICAgSGFzaFNldDxOb2Rl Kj4gbV90ZXh0TWFya2VyTm9kZXM7Ci0gICAgT3duUHRyPEFYQ29tcHV0ZWRPYmplY3RBdHRyaWJ1 dGVDYWNoZT4gbV9jb21wdXRlZE9iamVjdEF0dHJpYnV0ZUNhY2hlOworICAgIHN0ZDo6dW5pcXVl X3B0cjxBWENvbXB1dGVkT2JqZWN0QXR0cmlidXRlQ2FjaGU+IG1fY29tcHV0ZWRPYmplY3RBdHRy aWJ1dGVDYWNoZTsKICAgICBzdGF0aWMgYm9vbCBnQWNjZXNzaWJpbGl0eUVuYWJsZWQ7CiAgICAg c3RhdGljIGJvb2wgZ0FjY2Vzc2liaWxpdHlFbmhhbmNlZFVzZXJJbnRlcmZhY2VFbmFibGVkOwog ICAgIAo=