124401 2013-11-15 02:17:52 -0800 [EFL] Leak in ewk_frame_certificate_status_get() 2013-11-15 06:05:55 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 berto webkit-unassigned cdumez cgarcia commit-queue eflews.bot gyuyoung.kim lucas.de.marchi rakuco oldest_to_newest 950997 0 berto 2013-11-15 02:17:52 -0800 I just stumbled upon this piece of code in ewk_frame.cpp: SoupMessage* soupMessage = documentLoader->request().toSoupMessage(); That object is not being freed. 950998 1 217030 berto 2013-11-15 02:20:03 -0800 Created attachment 217030 Patch Here's the patch, it should work fine but note that I don't have a working WebKitEFL environment here to test it. 951001 2 217030 eflews.bot 2013-11-15 02:23:07 -0800 Comment on attachment 217030 Patch Attachment 217030 did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/23968033 951006 3 217033 berto 2013-11-15 02:46:27 -0800 Created attachment 217033 Patch Right, here's a new version. 951031 4 217033 cgarcia 2013-11-15 04:51:40 -0800 Comment on attachment 217033 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217033&action=review > Source/WebKit/efl/ewk/ewk_frame.cpp:1705 > - SoupMessage* soupMessage = documentLoader->request().toSoupMessage(); > + GRefPtr<SoupMessage> soupMessage(adoptGRef(documentLoader->request().toSoupMessage())); > > - if (soupMessage && (soup_message_get_flags(soupMessage) & SOUP_MESSAGE_CERTIFICATE_TRUSTED)) > + if (soupMessage && (soup_message_get_flags(soupMessage.get()) & SOUP_MESSAGE_CERTIFICATE_TRUSTED)) I think you could even avoid to create the soup message object by simply using if (documentLoader->request().soupMessageFlags() & SOUP_MESSAGE_CERTIFICATE_TRUSTED) 951036 5 217043 berto 2013-11-15 05:17:35 -0800 Created attachment 217043 Patch (In reply to comment #4) > I think you could even avoid to create the soup message object by simply using > > if (documentLoader->request().soupMessageFlags() & SOUP_MESSAGE_CERTIFICATE_TRUSTED) Good point, here's the new patch. 951037 6 217043 cdumez 2013-11-15 05:19:46 -0800 Comment on attachment 217043 Patch LGTM 951040 7 berto 2013-11-15 06:05:55 -0800 Committed r159334: <http://trac.webkit.org/changeset/159334> 217030 2013-11-15 02:20:03 -0800 2013-11-15 02:46:27 -0800 Patch 124401.diff text/plain 1570 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBkMTQ0M2FkLi40MTk0ZGJmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTMtMTEtMTUgIEFsYmVydG8gR2FyY2lhICA8YmVydG9AaWdhbGlh LmNvbT4KKworICAgICAgICBbRUZMXSBMZWFrIGluIGV3a19mcmFtZV9jZXJ0aWZpY2F0ZV9zdGF0 dXNfZ2V0KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEyNDQwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IERvbid0IGxlYWsgdGhlIFNvdXBNZXNzYWdlIG9iamVjdC4KKworICAgICAgICAqIGV3ay9ld2tf ZnJhbWUuY3BwOgorICAgICAgICAoZXdrX2ZyYW1lX2NlcnRpZmljYXRlX3N0YXR1c19nZXQpOgor CiAyMDEzLTExLTEwICBUaWJvciBNZXN6YXJvcyAgPG10aWJvckBpbmYudS1zemVnZWQuaHU+CiAK ICAgICAgICAgQ2xlYW51cCB0aGUgRUZMIC0tbWluaW1hbCBidWlsZCBmcm9tIHVudXNlZCBwYXJh bWV0ZXJzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2ZyYW1lLmNwcCBi L1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfZnJhbWUuY3BwCmluZGV4IDYwMGIwMGMuLjkzODlk ODcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfZnJhbWUuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfZnJhbWUuY3BwCkBAIC03MCw2ICs3MCw3IEBACiAj aW5jbHVkZSA8d3RmL1Bhc3NSZWZQdHIuaD4KICNpbmNsdWRlIDx3dGYvUmVmUHRyLmg+CiAjaW5j bHVkZSA8d3RmL1ZlY3Rvci5oPgorI2luY2x1ZGUgPHd0Zi9nb2JqZWN0L0dSZWZQdHIuaD4KICNp bmNsdWRlIDx3dGYvdGV4dC9DU3RyaW5nLmg+CiAKIHN0YXRpYyBjb25zdCBjaGFyIEVXS19GUkFN RV9UWVBFX1NUUltdID0gIkVXS19GcmFtZSI7CkBAIC0xNjk5LDcgKzE3MDAsNyBAQCBFd2tfQ2Vy dGlmaWNhdGVfU3RhdHVzIGV3a19mcmFtZV9jZXJ0aWZpY2F0ZV9zdGF0dXNfZ2V0KEV2YXNfT2Jq ZWN0KiBld2tGcmFtZSkKICAgICBpZiAoZnJhbWVMb2FkZXIuc3ViZnJhbWVJc0xvYWRpbmcoKSkK ICAgICAgICAgcmV0dXJuIEVXS19DRVJUSUZJQ0FURV9TVEFUVVNfTk9fQ0VSVElGSUNBVEU7CiAK LSAgICBTb3VwTWVzc2FnZSogc291cE1lc3NhZ2UgPSBkb2N1bWVudExvYWRlci0+cmVxdWVzdCgp LnRvU291cE1lc3NhZ2UoKTsKKyAgICBHUmVmUHRyPFNvdXBNZXNzYWdlPiBzb3VwTWVzc2FnZShh ZG9wdEdSZWYoZG9jdW1lbnRMb2FkZXItPnJlcXVlc3QoKS50b1NvdXBNZXNzYWdlKCkpKTsKIAog ICAgIGlmIChzb3VwTWVzc2FnZSAmJiAoc291cF9tZXNzYWdlX2dldF9mbGFncyhzb3VwTWVzc2Fn ZSkgJiBTT1VQX01FU1NBR0VfQ0VSVElGSUNBVEVfVFJVU1RFRCkpCiAgICAgICAgIHJldHVybiBF V0tfQ0VSVElGSUNBVEVfU1RBVFVTX1RSVVNURUQ7Cg== 217033 2013-11-15 02:46:27 -0800 2013-11-15 05:17:35 -0800 Patch 124401.diff text/plain 1722 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBkMTQ0M2FkLi40MTk0ZGJmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTMtMTEtMTUgIEFsYmVydG8gR2FyY2lhICA8YmVydG9AaWdhbGlh LmNvbT4KKworICAgICAgICBbRUZMXSBMZWFrIGluIGV3a19mcmFtZV9jZXJ0aWZpY2F0ZV9zdGF0 dXNfZ2V0KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEyNDQwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IERvbid0IGxlYWsgdGhlIFNvdXBNZXNzYWdlIG9iamVjdC4KKworICAgICAgICAqIGV3ay9ld2tf ZnJhbWUuY3BwOgorICAgICAgICAoZXdrX2ZyYW1lX2NlcnRpZmljYXRlX3N0YXR1c19nZXQpOgor CiAyMDEzLTExLTEwICBUaWJvciBNZXN6YXJvcyAgPG10aWJvckBpbmYudS1zemVnZWQuaHU+CiAK ICAgICAgICAgQ2xlYW51cCB0aGUgRUZMIC0tbWluaW1hbCBidWlsZCBmcm9tIHVudXNlZCBwYXJh bWV0ZXJzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2ZyYW1lLmNwcCBi L1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfZnJhbWUuY3BwCmluZGV4IDYwMGIwMGMuLmZlYTEx MDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfZnJhbWUuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfZnJhbWUuY3BwCkBAIC03MCw2ICs3MCw3IEBACiAj aW5jbHVkZSA8d3RmL1Bhc3NSZWZQdHIuaD4KICNpbmNsdWRlIDx3dGYvUmVmUHRyLmg+CiAjaW5j bHVkZSA8d3RmL1ZlY3Rvci5oPgorI2luY2x1ZGUgPHd0Zi9nb2JqZWN0L0dSZWZQdHIuaD4KICNp bmNsdWRlIDx3dGYvdGV4dC9DU3RyaW5nLmg+CiAKIHN0YXRpYyBjb25zdCBjaGFyIEVXS19GUkFN RV9UWVBFX1NUUltdID0gIkVXS19GcmFtZSI7CkBAIC0xNjk5LDkgKzE3MDAsOSBAQCBFd2tfQ2Vy dGlmaWNhdGVfU3RhdHVzIGV3a19mcmFtZV9jZXJ0aWZpY2F0ZV9zdGF0dXNfZ2V0KEV2YXNfT2Jq ZWN0KiBld2tGcmFtZSkKICAgICBpZiAoZnJhbWVMb2FkZXIuc3ViZnJhbWVJc0xvYWRpbmcoKSkK ICAgICAgICAgcmV0dXJuIEVXS19DRVJUSUZJQ0FURV9TVEFUVVNfTk9fQ0VSVElGSUNBVEU7CiAK LSAgICBTb3VwTWVzc2FnZSogc291cE1lc3NhZ2UgPSBkb2N1bWVudExvYWRlci0+cmVxdWVzdCgp LnRvU291cE1lc3NhZ2UoKTsKKyAgICBHUmVmUHRyPFNvdXBNZXNzYWdlPiBzb3VwTWVzc2FnZShh ZG9wdEdSZWYoZG9jdW1lbnRMb2FkZXItPnJlcXVlc3QoKS50b1NvdXBNZXNzYWdlKCkpKTsKIAot ICAgIGlmIChzb3VwTWVzc2FnZSAmJiAoc291cF9tZXNzYWdlX2dldF9mbGFncyhzb3VwTWVzc2Fn ZSkgJiBTT1VQX01FU1NBR0VfQ0VSVElGSUNBVEVfVFJVU1RFRCkpCisgICAgaWYgKHNvdXBNZXNz YWdlICYmIChzb3VwX21lc3NhZ2VfZ2V0X2ZsYWdzKHNvdXBNZXNzYWdlLmdldCgpKSAmIFNPVVBf TUVTU0FHRV9DRVJUSUZJQ0FURV9UUlVTVEVEKSkKICAgICAgICAgcmV0dXJuIEVXS19DRVJUSUZJ Q0FURV9TVEFUVVNfVFJVU1RFRDsKIAogICAgIHJldHVybiBFV0tfQ0VSVElGSUNBVEVfU1RBVFVT X1VOVFJVU1RFRDsK 217043 2013-11-15 05:17:35 -0800 2013-11-15 06:03:04 -0800 Patch 124401.diff text/plain 1546 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCBkMTQ0M2FkLi44ODQ2MjY2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTMtMTEtMTUgIEFsYmVydG8gR2FyY2lhICA8YmVydG9AaWdhbGlh LmNvbT4KKworICAgICAgICBbRUZMXSBMZWFrIGluIGV3a19mcmFtZV9jZXJ0aWZpY2F0ZV9zdGF0 dXNfZ2V0KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEyNDQwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFRoZSBTb3VwTWVzc2FnZSBvYmplY3QgaXMgYmVpbmcgbGVha2VkLiBJbiBpbiB0aGlzIGNhc2Ug dGhhdAorICAgICAgICBvYmplY3QgaXMgbm90IGV2ZW4gbmVjZXNzYXJ5IHNpbmNlIFJlc291cmNl UmVxdWVzdCBhbHJlYWR5CisgICAgICAgIHByb3ZpZGVzIGEgd2F5IHRvIGdldCB0aGUgc291cCBm bGFncyBkaXJlY3RseS4KKworICAgICAgICAqIGV3ay9ld2tfZnJhbWUuY3BwOgorICAgICAgICAo ZXdrX2ZyYW1lX2NlcnRpZmljYXRlX3N0YXR1c19nZXQpOgorCiAyMDEzLTExLTEwICBUaWJvciBN ZXN6YXJvcyAgPG10aWJvckBpbmYudS1zemVnZWQuaHU+CiAKICAgICAgICAgQ2xlYW51cCB0aGUg RUZMIC0tbWluaW1hbCBidWlsZCBmcm9tIHVudXNlZCBwYXJhbWV0ZXJzCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2ZyYW1lLmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3 ay9ld2tfZnJhbWUuY3BwCmluZGV4IDYwMGIwMGMuLmYyYTIwYzMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvZWZsL2V3ay9ld2tfZnJhbWUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3 ay9ld2tfZnJhbWUuY3BwCkBAIC0xNjk5LDkgKzE2OTksNyBAQCBFd2tfQ2VydGlmaWNhdGVfU3Rh dHVzIGV3a19mcmFtZV9jZXJ0aWZpY2F0ZV9zdGF0dXNfZ2V0KEV2YXNfT2JqZWN0KiBld2tGcmFt ZSkKICAgICBpZiAoZnJhbWVMb2FkZXIuc3ViZnJhbWVJc0xvYWRpbmcoKSkKICAgICAgICAgcmV0 dXJuIEVXS19DRVJUSUZJQ0FURV9TVEFUVVNfTk9fQ0VSVElGSUNBVEU7CiAKLSAgICBTb3VwTWVz c2FnZSogc291cE1lc3NhZ2UgPSBkb2N1bWVudExvYWRlci0+cmVxdWVzdCgpLnRvU291cE1lc3Nh Z2UoKTsKLQotICAgIGlmIChzb3VwTWVzc2FnZSAmJiAoc291cF9tZXNzYWdlX2dldF9mbGFncyhz b3VwTWVzc2FnZSkgJiBTT1VQX01FU1NBR0VfQ0VSVElGSUNBVEVfVFJVU1RFRCkpCisgICAgaWYg KGRvY3VtZW50TG9hZGVyLT5yZXF1ZXN0KCkuc291cE1lc3NhZ2VGbGFncygpICYgU09VUF9NRVNT QUdFX0NFUlRJRklDQVRFX1RSVVNURUQpCiAgICAgICAgIHJldHVybiBFV0tfQ0VSVElGSUNBVEVf U1RBVFVTX1RSVVNURUQ7CiAKICAgICByZXR1cm4gRVdLX0NFUlRJRklDQVRFX1NUQVRVU19VTlRS VVNURUQ7Cg==