124400 2013-11-15 02:10:08 -0800 Make it possible to select revision numbers on build.webkit.org/dashboard 2013-12-25 15:40:55 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton webkit-unassigned rniwa timothy oldest_to_newest 950995 0 thorton 2013-11-15 02:10:08 -0800 The dashboard uses user-select: none on everything. Let's override it with user-select: all on revision numbers, so that they can be selected as a unit, making it possible (and trivial) to select them. 950996 1 217029 thorton 2013-11-15 02:11:56 -0800 Created attachment 217029 patch 951081 2 217029 timothy 2013-11-15 08:56:51 -0800 Comment on attachment 217029 patch View in context: https://bugs.webkit.org/attachment.cgi?id=217029&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:37 > +span.selectable { No need for span. The class should be useable on any type of element. 951097 3 thorton 2013-11-15 09:45:37 -0800 http://trac.webkit.org/changeset/159342 962885 4 ap 2013-12-25 15:40:55 -0800 I'm proposing some tweaks for this behavior in bug 126235. 217029 2013-11-15 02:11:56 -0800 2013-11-15 08:56:51 -0800 patch 0002-Make-it-possible-to-select-revision-numbers-on-build.patch text/plain 3333 thorton RnJvbSAwZjQ3NzFiNTE3MjhjZmViMjBjYzkxNDQ1MzMwZTZiMTk3YTQ4MzBhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaW0gSG9ydG9uIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+ CkRhdGU6IEZyaSwgMTUgTm92IDIwMTMgMDA6MzA6MjEgLTA4MDAKU3ViamVjdDogW1BBVENIIDIv M10gTWFrZSBpdCBwb3NzaWJsZSB0byBzZWxlY3QgcmV2aXNpb24gbnVtYmVycyBvbgogYnVpbGQu d2Via2l0Lm9yZy9kYXNoYm9hcmQKCi0tLQogLi4uL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3Jp cHRzL0J1aWxkYm90UXVldWVWaWV3LmpzICAgIHwgIDggKysrKysrKy0KIC4uLi9wdWJsaWNfaHRt bC9kYXNoYm9hcmQvU3R5bGVzL01haW4uY3NzICAgICAgICAgICAgICAgICB8ICA0ICsrKysKIFRv b2xzL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8 IDE1ICsrKysrKysrKysrKysrKwogMyBmaWxlcyBjaGFuZ2VkLCAyNiBpbnNlcnRpb25zKCspLCAx IGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQu d2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvQnVpbGRib3RR dWV1ZVZpZXcuanMgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNv bmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9CdWlsZGJvdFF1ZXVlVmlldy5qcwpp bmRleCA2NDRiMjZhLi43MDEzZTRkIDEwMDY0NAotLS0gYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9y dC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9C dWlsZGJvdFF1ZXVlVmlldy5qcworKysgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53 ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9CdWlsZGJvdFF1 ZXVlVmlldy5qcwpAQCAtNzcsOCArNzcsMTQgQEAgQnVpbGRib3RRdWV1ZVZpZXcucHJvdG90eXBl ID0gewogICAgICAgICB7CiAgICAgICAgICAgICB2YXIgbGlua0VsZW1lbnQgPSBkb2N1bWVudC5j cmVhdGVFbGVtZW50KCJhIik7CiAgICAgICAgICAgICBsaW5rRWxlbWVudC5ocmVmID0gaXRlcmF0 aW9uLnF1ZXVlLmJ1aWxkYm90LnRyYWNSZXZpc2lvblVSTChyZXZpc2lvbiwgaW50ZXJuYWwpOwot ICAgICAgICAgICAgbGlua0VsZW1lbnQudGV4dENvbnRlbnQgPSAiciIgKyByZXZpc2lvbjsKICAg ICAgICAgICAgIGxpbmtFbGVtZW50LnRhcmdldCA9ICJfYmxhbmsiOworICAgICAgICAgICAgbGlu a0VsZW1lbnQudGV4dENvbnRlbnQgPSAiciI7CisKKyAgICAgICAgICAgIHZhciByZXZpc2lvbkxh YmVsID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgic3BhbiIpOworICAgICAgICAgICAgcmV2aXNp b25MYWJlbC5jbGFzc0xpc3QuYWRkKCJzZWxlY3RhYmxlIik7CisgICAgICAgICAgICByZXZpc2lv bkxhYmVsLnRleHRDb250ZW50ID0gcmV2aXNpb247CisgICAgICAgICAgICBsaW5rRWxlbWVudC5h cHBlbmRDaGlsZChyZXZpc2lvbkxhYmVsKTsKKwogICAgICAgICAgICAgcmV0dXJuIGxpbmtFbGVt ZW50OwogICAgICAgICB9CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1 aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TdHlsZXMvTWFpbi5j c3MgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJs aWNfaHRtbC9kYXNoYm9hcmQvU3R5bGVzL01haW4uY3NzCmluZGV4IDA3OGZmZTAuLjQ4ZGQxN2Ig MTAwNjQ0Ci0tLSBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u ZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TdHlsZXMvTWFpbi5jc3MKKysrIGIvVG9vbHMvQnVp bGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJv YXJkL1N0eWxlcy9NYWluLmNzcwpAQCAtMzQsNiArMzQsMTAgQEAgYTpsaW5rIHsKICAgICBjdXJz b3I6IHBvaW50ZXI7CiB9CiAKK3NwYW4uc2VsZWN0YWJsZSB7CisgICAgLXdlYmtpdC11c2VyLXNl bGVjdDogYWxsOworfQorCiBib2R5IHsKICAgICBiYWNrZ3JvdW5kLWNvbG9yOiByZ2IoMjMzLCAy MzEsIDIyMyk7CiAgICAgdGV4dC1hbGlnbjogY2VudGVyOwpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hh bmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDNjOWYwMzIuLjliNGQxY2IgMTAwNjQ0Ci0t LSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMCBA QAogMjAxMy0xMS0xNSAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAor ICAgICAgICBNYWtlIGl0IHBvc3NpYmxlIHRvIHNlbGVjdCByZXZpc2lvbiBudW1iZXJzIG9uIGJ1 aWxkLndlYmtpdC5vcmcvZGFzaGJvYXJkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMjQ0MDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u ZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL0J1aWxkYm90UXVldWVWaWV3LmpzOgor ICAgICAgICAoQnVpbGRib3RRdWV1ZVZpZXcucHJvdG90eXBlLnJldmlzaW9uTGlua3NGb3JJdGVy YXRpb24pOgorICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u ZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TdHlsZXMvTWFpbi5jc3M6CisgICAgICAgIChzcGFu LnNlbGVjdGFibGUpOgorICAgICAgICBBZGQgYSBjaGlsZCBzcGFuIHRvIHRoZSB0cmFjIGxpbmss IHdoaWNoIGhhcyAnLXdlYmtpdC11c2VyLXNlbGVjdDogYWxsJyBvbiBpdC4KKyAgICAgICAgVGhp cyB3YXksIGEgRGFzaGJvYXJkIHVzZXIgY2FuIGhpZ2hsaWdodCByZXZpc2lvbiBudW1iZXJzIGZv ciBlYXN5IGNvcHlpbmcsCisgICAgICAgIGFuZCBkb2Vzbid0IGV2ZW4gaGF2ZSB0byBiZSBwcmVj aXNlIGFib3V0IHRoZSBzZWxlY3Rpb24uCisKKzIwMTMtMTEtMTUgIFRpbSBIb3J0b24gIDx0aW1v dGh5X2hvcnRvbkBhcHBsZS5jb20+CisKICAgICAgICAgQWRqdXN0IGFuZCBhZGQgcmV0aW5hIHZl cnNpb25zIG9mIEVGTCBhbmQgR1RLIGJ1aWxkLndlYmtpdC5vcmcvZGFzaGJvYXJkIGljb25zCiAg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQzOTkKIAot LSAKMS44LjMuMSAoQXBwbGUgR2l0LTQ2KQoK