124379 2013-11-14 13:31:54 -0800 Reimplement getDayBoundaries using NSCalendar 2013-11-14 14:00:55 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 950821 0 andersca 2013-11-14 13:31:54 -0800 Reimplement getDayBoundaries using NSCalendar on 10.9 950822 1 216973 andersca 2013-11-14 13:32:46 -0800 Created attachment 216973 Patch 950824 2 216973 mitz 2013-11-14 13:37:05 -0800 Comment on attachment 216973 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216973&action=review > Source/WebKit/mac/History/WebHistory.mm:164 > + NSDate *beginningOfDayDate = [calendar startOfDayForDate:date]; > + beginningOfDay = beginningOfDayDate.timeIntervalSinceReferenceDate; > + > + NSDate *beginningOfNextDayDate = [calendar dateByAddingUnit:NSCalendarUnitDay value:1 toDate:beginningOfDayDate options:0]; I believe you can do this with a single method call to -[NSCalendar rangeOfUnit:startDate:interval:forDate:]. Seems wasteful to do two. 950829 3 216975 andersca 2013-11-14 13:46:50 -0800 Created attachment 216975 Patch 950830 4 216975 mitz 2013-11-14 13:50:22 -0800 Comment on attachment 216975 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216975&action=review > Source/WebKit/mac/History/WebHistory.mm:158 > + NSCalendar *calendar = [NSCalendar calendarWithIdentifier:NSCalendarIdentifierGregorian]; I believe NSCalendarIdentifierGregorian and NSCalendarUnitDay aren’t available in some of the SDKs we target. You may need to add #ifdefs around some things here. 950832 5 216977 andersca 2013-11-14 13:55:41 -0800 Created attachment 216977 Patch 950836 6 andersca 2013-11-14 14:00:55 -0800 Committed r159311: <http://trac.webkit.org/changeset/159311> 216973 2013-11-14 13:32:46 -0800 2013-11-14 13:46:47 -0800 Patch bug-124379-20131114133246.patch text/plain 2219 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5MzA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggNDU4MjE1NTQ5 NjI3OWFmMjYyOGFiOGFmNjlmMjg5M2U2ODcyOTFmYy4uMGY3YWExYWUyMjcxMDRlMDQ0MjUzZDQw ZDA4NWM0YjY3MWM4NWQ4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDEz LTExLTE0ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAg UmVpbXBsZW1lbnQgZ2V0RGF5Qm91bmRhcmllcyB1c2luZyBOU0NhbGVuZGFyIG9uIDEwLjkKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDM3OQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogSGlzdG9yeS9X ZWJIaXN0b3J5Lm1tOgorICAgICAgICAoZ2V0RGF5Qm91bmRhcmllcyk6CisKKzIwMTMtMTEtMTQg IEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKwogICAgICAgICBTdG9wIHVz aW5nIGRlcHJlY2F0ZWQgTlNQcm9wZXJ0eUxpc3RTZXJpYWxpemF0aW9uIG1ldGhvZHMKICAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDM3NwogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L21hYy9IaXN0b3J5L1dlYkhpc3RvcnkubW0gYi9Tb3VyY2Uv V2ViS2l0L21hYy9IaXN0b3J5L1dlYkhpc3RvcnkubW0KaW5kZXggMmQzMThhYzBlMDRmY2I0NTQz ZWI0NWI4MzFhNWQ2NGUyNjg3ZmZlZS4uY2VlODBmNjFkOTUzYmQxYzgwNDEwMzlhMDM0ZWNlNDE4 YmNjZTU1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvSGlzdG9yeS9XZWJIaXN0b3J5 Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0hpc3RvcnkvV2ViSGlzdG9yeS5tbQpAQCAtMTUz LDYgKzE1MywxNyBAQCBwcml2YXRlOgogCiBzdGF0aWMgdm9pZCBnZXREYXlCb3VuZGFyaWVzKE5T VGltZUludGVydmFsIGludGVydmFsLCBOU1RpbWVJbnRlcnZhbCYgYmVnaW5uaW5nT2ZEYXksIE5T VGltZUludGVydmFsJiBiZWdpbm5pbmdPZk5leHREYXkpCiB7CisjaWYgX19NQUNfT1NfWF9WRVJT SU9OX01JTl9SRVFVSVJFRCA+PSAxMDkwCisgICAgTlNEYXRlICpkYXRlID0gW05TRGF0ZSBkYXRl V2l0aFRpbWVJbnRlcnZhbFNpbmNlUmVmZXJlbmNlRGF0ZTppbnRlcnZhbF07CisgICAgCisgICAg TlNDYWxlbmRhciAqY2FsZW5kYXIgPSBbTlNDYWxlbmRhciBjYWxlbmRhcldpdGhJZGVudGlmaWVy Ok5TQ2FsZW5kYXJJZGVudGlmaWVyR3JlZ29yaWFuXTsKKworICAgIE5TRGF0ZSAqYmVnaW5uaW5n T2ZEYXlEYXRlID0gW2NhbGVuZGFyIHN0YXJ0T2ZEYXlGb3JEYXRlOmRhdGVdOworICAgIGJlZ2lu bmluZ09mRGF5ID0gYmVnaW5uaW5nT2ZEYXlEYXRlLnRpbWVJbnRlcnZhbFNpbmNlUmVmZXJlbmNl RGF0ZTsKKworICAgIE5TRGF0ZSAqYmVnaW5uaW5nT2ZOZXh0RGF5RGF0ZSA9IFtjYWxlbmRhciBk YXRlQnlBZGRpbmdVbml0Ok5TQ2FsZW5kYXJVbml0RGF5IHZhbHVlOjEgdG9EYXRlOmJlZ2lubmlu Z09mRGF5RGF0ZSBvcHRpb25zOjBdOworICAgIGJlZ2lubmluZ09mTmV4dERheSA9IGJlZ2lubmlu Z09mTmV4dERheURhdGUudGltZUludGVydmFsU2luY2VSZWZlcmVuY2VEYXRlOworI2Vsc2UKICAg ICBDRlRpbWVab25lUmVmIHRpbWVab25lID0gQ0ZUaW1lWm9uZUNvcHlEZWZhdWx0KCk7CiAgICAg Q0ZHcmVnb3JpYW5EYXRlIGRhdGUgPSBDRkFic29sdXRlVGltZUdldEdyZWdvcmlhbkRhdGUoaW50 ZXJ2YWwsIHRpbWVab25lKTsKICAgICBkYXRlLmhvdXIgPSAwOwpAQCAtMTYyLDYgKzE3Myw3IEBA IHN0YXRpYyB2b2lkIGdldERheUJvdW5kYXJpZXMoTlNUaW1lSW50ZXJ2YWwgaW50ZXJ2YWwsIE5T VGltZUludGVydmFsJiBiZWdpbm5pbmdPCiAgICAgZGF0ZS5kYXkgKz0gMTsKICAgICBiZWdpbm5p bmdPZk5leHREYXkgPSBDRkdyZWdvcmlhbkRhdGVHZXRBYnNvbHV0ZVRpbWUoZGF0ZSwgdGltZVpv bmUpOwogICAgIENGUmVsZWFzZSh0aW1lWm9uZSk7CisjZW5kaWYKIH0KIAogc3RhdGljIGlubGlu ZSBOU1RpbWVJbnRlcnZhbCBiZWdpbm5pbmdPZkRheShOU1RpbWVJbnRlcnZhbCBkYXRlKQo= 216975 2013-11-14 13:46:50 -0800 2013-11-14 13:55:40 -0800 Patch bug-124379-20131114134649.patch text/plain 2128 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5MzA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggNDU4MjE1NTQ5 NjI3OWFmMjYyOGFiOGFmNjlmMjg5M2U2ODcyOTFmYy4uMGY3YWExYWUyMjcxMDRlMDQ0MjUzZDQw ZDA4NWM0YjY3MWM4NWQ4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDEz LTExLTE0ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAg UmVpbXBsZW1lbnQgZ2V0RGF5Qm91bmRhcmllcyB1c2luZyBOU0NhbGVuZGFyIG9uIDEwLjkKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDM3OQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogSGlzdG9yeS9X ZWJIaXN0b3J5Lm1tOgorICAgICAgICAoZ2V0RGF5Qm91bmRhcmllcyk6CisKKzIwMTMtMTEtMTQg IEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKwogICAgICAgICBTdG9wIHVz aW5nIGRlcHJlY2F0ZWQgTlNQcm9wZXJ0eUxpc3RTZXJpYWxpemF0aW9uIG1ldGhvZHMKICAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDM3NwogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L21hYy9IaXN0b3J5L1dlYkhpc3RvcnkubW0gYi9Tb3VyY2Uv V2ViS2l0L21hYy9IaXN0b3J5L1dlYkhpc3RvcnkubW0KaW5kZXggMmQzMThhYzBlMDRmY2I0NTQz ZWI0NWI4MzFhNWQ2NGUyNjg3ZmZlZS4uODI2ZTU0NWM4ZDQyOWU1ODJlNTAwY2RjYWU5NWZmOTQx OTA5OGE1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvSGlzdG9yeS9XZWJIaXN0b3J5 Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0hpc3RvcnkvV2ViSGlzdG9yeS5tbQpAQCAtMTUz LDE1ICsxNTMsMTYgQEAgcHJpdmF0ZToKIAogc3RhdGljIHZvaWQgZ2V0RGF5Qm91bmRhcmllcyhO U1RpbWVJbnRlcnZhbCBpbnRlcnZhbCwgTlNUaW1lSW50ZXJ2YWwmIGJlZ2lubmluZ09mRGF5LCBO U1RpbWVJbnRlcnZhbCYgYmVnaW5uaW5nT2ZOZXh0RGF5KQogewotICAgIENGVGltZVpvbmVSZWYg dGltZVpvbmUgPSBDRlRpbWVab25lQ29weURlZmF1bHQoKTsKLSAgICBDRkdyZWdvcmlhbkRhdGUg ZGF0ZSA9IENGQWJzb2x1dGVUaW1lR2V0R3JlZ29yaWFuRGF0ZShpbnRlcnZhbCwgdGltZVpvbmUp OwotICAgIGRhdGUuaG91ciA9IDA7Ci0gICAgZGF0ZS5taW51dGUgPSAwOwotICAgIGRhdGUuc2Vj b25kID0gMDsKLSAgICBiZWdpbm5pbmdPZkRheSA9IENGR3JlZ29yaWFuRGF0ZUdldEFic29sdXRl VGltZShkYXRlLCB0aW1lWm9uZSk7Ci0gICAgZGF0ZS5kYXkgKz0gMTsKLSAgICBiZWdpbm5pbmdP Zk5leHREYXkgPSBDRkdyZWdvcmlhbkRhdGVHZXRBYnNvbHV0ZVRpbWUoZGF0ZSwgdGltZVpvbmUp OwotICAgIENGUmVsZWFzZSh0aW1lWm9uZSk7CisgICAgTlNEYXRlICpkYXRlID0gW05TRGF0ZSBk YXRlV2l0aFRpbWVJbnRlcnZhbFNpbmNlUmVmZXJlbmNlRGF0ZTppbnRlcnZhbF07CisgICAgCisg ICAgTlNDYWxlbmRhciAqY2FsZW5kYXIgPSBbTlNDYWxlbmRhciBjYWxlbmRhcldpdGhJZGVudGlm aWVyOk5TQ2FsZW5kYXJJZGVudGlmaWVyR3JlZ29yaWFuXTsKKworICAgIE5TRGF0ZSAqYmVnaW5u aW5nT2ZEYXlEYXRlID0gbmlsOworICAgIE5TVGltZUludGVydmFsIGRheUxlbmd0aDsKKyAgICBb Y2FsZW5kYXIgcmFuZ2VPZlVuaXQ6TlNDYWxlbmRhclVuaXREYXkgc3RhcnREYXRlOiZiZWdpbm5p bmdPZkRheURhdGUgaW50ZXJ2YWw6JmRheUxlbmd0aCBmb3JEYXRlOmRhdGVdOworCisgICAgYmVn aW5uaW5nT2ZEYXkgPSBiZWdpbm5pbmdPZkRheURhdGUudGltZUludGVydmFsU2luY2VSZWZlcmVu Y2VEYXRlOworICAgIGJlZ2lubmluZ09mTmV4dERheSA9IGJlZ2lubmluZ09mRGF5ICsgZGF5TGVu Z3RoOwogfQogCiBzdGF0aWMgaW5saW5lIE5TVGltZUludGVydmFsIGJlZ2lubmluZ09mRGF5KE5T VGltZUludGVydmFsIGRhdGUpCg== 216977 2013-11-14 13:55:41 -0800 2013-11-14 13:59:22 -0800 Patch bug-124379-20131114135541.patch text/plain 2182 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5MzA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggNDU4MjE1NTQ5 NjI3OWFmMjYyOGFiOGFmNjlmMjg5M2U2ODcyOTFmYy4uMGY3YWExYWUyMjcxMDRlMDQ0MjUzZDQw ZDA4NWM0YjY3MWM4NWQ4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDEz LTExLTE0ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAg UmVpbXBsZW1lbnQgZ2V0RGF5Qm91bmRhcmllcyB1c2luZyBOU0NhbGVuZGFyIG9uIDEwLjkKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDM3OQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogSGlzdG9yeS9X ZWJIaXN0b3J5Lm1tOgorICAgICAgICAoZ2V0RGF5Qm91bmRhcmllcyk6CisKKzIwMTMtMTEtMTQg IEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKwogICAgICAgICBTdG9wIHVz aW5nIGRlcHJlY2F0ZWQgTlNQcm9wZXJ0eUxpc3RTZXJpYWxpemF0aW9uIG1ldGhvZHMKICAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDM3NwogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L21hYy9IaXN0b3J5L1dlYkhpc3RvcnkubW0gYi9Tb3VyY2Uv V2ViS2l0L21hYy9IaXN0b3J5L1dlYkhpc3RvcnkubW0KaW5kZXggMmQzMThhYzBlMDRmY2I0NTQz ZWI0NWI4MzFhNWQ2NGUyNjg3ZmZlZS4uNWJiYWQ5MWE5MDc2MDg5YzViZjkzYTk1MTE3ODA5YTQx ZDdmZmZjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvSGlzdG9yeS9XZWJIaXN0b3J5 Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0hpc3RvcnkvV2ViSGlzdG9yeS5tbQpAQCAtMTUz LDYgKzE1MywxOCBAQCBwcml2YXRlOgogCiBzdGF0aWMgdm9pZCBnZXREYXlCb3VuZGFyaWVzKE5T VGltZUludGVydmFsIGludGVydmFsLCBOU1RpbWVJbnRlcnZhbCYgYmVnaW5uaW5nT2ZEYXksIE5T VGltZUludGVydmFsJiBiZWdpbm5pbmdPZk5leHREYXkpCiB7CisjaWYgX19NQUNfT1NfWF9WRVJT SU9OX01JTl9SRVFVSVJFRCA+PSAxMDkwCisgICAgTlNEYXRlICpkYXRlID0gW05TRGF0ZSBkYXRl V2l0aFRpbWVJbnRlcnZhbFNpbmNlUmVmZXJlbmNlRGF0ZTppbnRlcnZhbF07CisgICAgCisgICAg TlNDYWxlbmRhciAqY2FsZW5kYXIgPSBbTlNDYWxlbmRhciBjYWxlbmRhcldpdGhJZGVudGlmaWVy Ok5TQ2FsZW5kYXJJZGVudGlmaWVyR3JlZ29yaWFuXTsKKyAgICAKKyAgICBOU0RhdGUgKmJlZ2lu bmluZ09mRGF5RGF0ZSA9IG5pbDsKKyAgICBOU1RpbWVJbnRlcnZhbCBkYXlMZW5ndGg7CisgICAg W2NhbGVuZGFyIHJhbmdlT2ZVbml0Ok5TQ2FsZW5kYXJVbml0RGF5IHN0YXJ0RGF0ZTomYmVnaW5u aW5nT2ZEYXlEYXRlIGludGVydmFsOiZkYXlMZW5ndGggZm9yRGF0ZTpkYXRlXTsKKyAgICAKKyAg ICBiZWdpbm5pbmdPZkRheSA9IGJlZ2lubmluZ09mRGF5RGF0ZS50aW1lSW50ZXJ2YWxTaW5jZVJl ZmVyZW5jZURhdGU7CisgICAgYmVnaW5uaW5nT2ZOZXh0RGF5ID0gYmVnaW5uaW5nT2ZEYXkgKyBk YXlMZW5ndGg7CisjZWxzZQogICAgIENGVGltZVpvbmVSZWYgdGltZVpvbmUgPSBDRlRpbWVab25l Q29weURlZmF1bHQoKTsKICAgICBDRkdyZWdvcmlhbkRhdGUgZGF0ZSA9IENGQWJzb2x1dGVUaW1l R2V0R3JlZ29yaWFuRGF0ZShpbnRlcnZhbCwgdGltZVpvbmUpOwogICAgIGRhdGUuaG91ciA9IDA7 CkBAIC0xNjIsNiArMTc0LDcgQEAgc3RhdGljIHZvaWQgZ2V0RGF5Qm91bmRhcmllcyhOU1RpbWVJ bnRlcnZhbCBpbnRlcnZhbCwgTlNUaW1lSW50ZXJ2YWwmIGJlZ2lubmluZ08KICAgICBkYXRlLmRh eSArPSAxOwogICAgIGJlZ2lubmluZ09mTmV4dERheSA9IENGR3JlZ29yaWFuRGF0ZUdldEFic29s dXRlVGltZShkYXRlLCB0aW1lWm9uZSk7CiAgICAgQ0ZSZWxlYXNlKHRpbWVab25lKTsKKyNlbmRp ZgogfQogCiBzdGF0aWMgaW5saW5lIE5TVGltZUludGVydmFsIGJlZ2lubmluZ09mRGF5KE5TVGlt ZUludGVydmFsIGRhdGUpCg==