124378 2013-11-14 13:25:40 -0800 [Cocoa] WKAction keys are not exported 2013-11-14 13:38:47 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz commit-queue oldest_to_newest 950815 0 mitz 2013-11-14 13:25:40 -0800 [Cocoa] WKAction keys are not exported 950818 1 216972 mitz 2013-11-14 13:28:41 -0800 Created attachment 216972 Export the keys 950820 2 commit-queue 2013-11-14 13:31:18 -0800 Attachment 216972 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm', u'Source/WebKit2/UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h']" exit_code: 1 Source/WebKit2/UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h:31: One space before end of line comments [whitespace/comments] [5] Source/WebKit2/UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h:33: One space before end of line comments [whitespace/comments] [5] Source/WebKit2/UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h:34: One space before end of line comments [whitespace/comments] [5] Source/WebKit2/UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h:35: One space before end of line comments [whitespace/comments] [5] Source/WebKit2/UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h:36: One space before end of line comments [whitespace/comments] [5] Source/WebKit2/UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h:37: One space before end of line comments [whitespace/comments] [5] Total errors found: 6 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 950825 3 mitz 2013-11-14 13:38:47 -0800 Fixed in <http://trac.webkit.org/r159309>. 216972 2013-11-14 13:28:41 -0800 2013-11-14 13:32:14 -0800 Export the keys bug-124378-20131114132840.patch text/plain 3841 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1OTMwNykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEzLTExLTE0ICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBXS0FjdGlvbiBrZXlz IGFyZSBub3QgZXhwb3J0ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEyNDM3OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9tYWMvV0tCcm93c2luZ0NvbnRleHRDb250cm9sbGVy Lm1tOiBNYWRlIHRoZSBrZXlzIGNvbnN0YW50IHBvaW50ZXJzLgorICAgICAgICAqIFVJUHJvY2Vz cy9BUEkvbWFjL1dLQnJvd3NpbmdDb250ZXh0UG9saWN5RGVsZWdhdGUuaDogRXhwb3J0ZWQgdGhl IGtleXMuCisKIDIwMTMtMTEtMTQgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29t PgogCiAgICAgICAgIFtXSzJdIE1vdmUgQ29vcmRpbmF0ZWQgR3JhcGhpY3MgcmVsYXRlZCBjb2Rl IG91dCBvZiBEcmF3aW5nQXJlYVByb3h5CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL21hYy9XS0Jyb3dzaW5nQ29udGV4dENvbnRyb2xsZXIubW0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tCcm93c2luZ0NvbnRleHRDb250cm9sbGVy Lm1tCShyZXZpc2lvbiAxNTkzMDYpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21h Yy9XS0Jyb3dzaW5nQ29udGV4dENvbnRyb2xsZXIubW0JKHdvcmtpbmcgY29weSkKQEAgLTc0LDEz ICs3NCwxMyBAQCBzdGF0aWMgaW5saW5lIE5TVVJMUmVzcG9uc2UgKmF1dG9yZWxlYXNlCiAgICAg cmV0dXJuIHVybFJlc3BvbnNlID8gQ0ZCcmlkZ2luZ1JlbGVhc2UoV0tVUkxSZXNwb25zZUNvcHlO U1VSTFJlc3BvbnNlKGFkb3B0V0sodXJsUmVzcG9uc2UpLmdldCgpKSkgOiBuaWw7CiB9CiAKLU5T U3RyaW5nICpXS0FjdGlvbklzTWFpbkZyYW1lS2V5ID0gQCJXS0FjdGlvbklzTWFpbkZyYW1lS2V5 IjsKLU5TU3RyaW5nICpXS0FjdGlvbk5hdmlnYXRpb25UeXBlS2V5ID0gQCJXS0FjdGlvbk5hdmln YXRpb25UeXBlS2V5IjsKLU5TU3RyaW5nICpXS0FjdGlvbk1vdXNlQnV0dG9uS2V5ID0gQCJXS0Fj dGlvbk1vdXNlQnV0dG9uS2V5IjsKLU5TU3RyaW5nICpXS0FjdGlvbk1vZGlmaWVyRmxhZ3NLZXkg PSBAIldLQWN0aW9uTW9kaWZpZXJGbGFnc0tleSI7Ci1OU1N0cmluZyAqV0tBY3Rpb25VUkxSZXF1 ZXN0S2V5ID0gQCJXS0FjdGlvblVSTFJlcXVlc3RLZXkiOwotTlNTdHJpbmcgKldLQWN0aW9uVVJM UmVzcG9uc2VLZXkgPSBAIldLQWN0aW9uVVJMUmVzcG9uc2VLZXkiOwotTlNTdHJpbmcgKldLQWN0 aW9uRnJhbWVOYW1lS2V5ID0gQCJXS0FjdGlvbkZyYW1lTmFtZUtleSI7CitOU1N0cmluZyAqIGNv bnN0IFdLQWN0aW9uSXNNYWluRnJhbWVLZXkgPSBAIldLQWN0aW9uSXNNYWluRnJhbWVLZXkiOwor TlNTdHJpbmcgKiBjb25zdCBXS0FjdGlvbk5hdmlnYXRpb25UeXBlS2V5ID0gQCJXS0FjdGlvbk5h dmlnYXRpb25UeXBlS2V5IjsKK05TU3RyaW5nICogY29uc3QgV0tBY3Rpb25Nb3VzZUJ1dHRvbktl eSA9IEAiV0tBY3Rpb25Nb3VzZUJ1dHRvbktleSI7CitOU1N0cmluZyAqIGNvbnN0IFdLQWN0aW9u TW9kaWZpZXJGbGFnc0tleSA9IEAiV0tBY3Rpb25Nb2RpZmllckZsYWdzS2V5IjsKK05TU3RyaW5n ICogY29uc3QgV0tBY3Rpb25VUkxSZXF1ZXN0S2V5ID0gQCJXS0FjdGlvblVSTFJlcXVlc3RLZXki OworTlNTdHJpbmcgKiBjb25zdCBXS0FjdGlvblVSTFJlc3BvbnNlS2V5ID0gQCJXS0FjdGlvblVS TFJlc3BvbnNlS2V5IjsKK05TU3RyaW5nICogY29uc3QgV0tBY3Rpb25GcmFtZU5hbWVLZXkgPSBA IldLQWN0aW9uRnJhbWVOYW1lS2V5IjsKIAogQGludGVyZmFjZSBXS0Jyb3dzaW5nQ29udGV4dENv bnRyb2xsZXJEYXRhIDogTlNPYmplY3QgewogQHB1YmxpYwpJbmRleDogU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9tYWMvV0tCcm93c2luZ0NvbnRleHRQb2xpY3lEZWxlZ2F0ZS5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLQnJvd3NpbmdDb250 ZXh0UG9saWN5RGVsZWdhdGUuaAkocmV2aXNpb24gMTU5MzA2KQorKysgU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9tYWMvV0tCcm93c2luZ0NvbnRleHRQb2xpY3lEZWxlZ2F0ZS5oCSh3b3Jr aW5nIGNvcHkpCkBAIC0yOCwxMyArMjgsMTMgQEAKIEBjbGFzcyBXS0Jyb3dzaW5nQ29udGV4dENv bnRyb2xsZXI7CiAKIC8qIENvbnN0YW50cyBmb3IgcG9saWN5IGFjdGlvbiBkaWN0aW9uYXJpZXMg Ki8KLWV4dGVybiBOU1N0cmluZyAqV0tBY3Rpb25Jc01haW5GcmFtZUtleTsgICAgLy8gTlNOdW1i ZXIgKEJPT0wpCi1leHRlcm4gTlNTdHJpbmcgKldLQWN0aW9uTmF2aWdhdGlvblR5cGVLZXk7IC8v IE5TTnVtYmVyIChXS05hdmlnYXRpb25UeXBlKQotZXh0ZXJuIE5TU3RyaW5nICpXS0FjdGlvbk1v dXNlQnV0dG9uS2V5OyAgICAvLyBOU051bWJlciAoMCBmb3IgbGVmdCBidXR0b24sIDEgZm9yIG1p ZGRsZSBidXR0b24sIDIgZm9yIHJpZ2h0IGJ1dHRvbikKLWV4dGVybiBOU1N0cmluZyAqV0tBY3Rp b25Nb2RpZmllckZsYWdzS2V5OyAgLy8gTlNOdW1iZXIgKHVuc2lnbmVkKQotZXh0ZXJuIE5TU3Ry aW5nICpXS0FjdGlvblVSTFJlcXVlc3RLZXk7ICAgICAvLyBOU1VSTFJlcXVlc3QKLWV4dGVybiBO U1N0cmluZyAqV0tBY3Rpb25VUkxSZXNwb25zZUtleTsgICAgLy8gTlNVUkxSZXNwb25zZQotZXh0 ZXJuIE5TU3RyaW5nICpXS0FjdGlvbkZyYW1lTmFtZUtleTsgICAgICAvLyBOU1N0cmluZworV0tf RVhQT1JUIGV4dGVybiBOU1N0cmluZyAqIGNvbnN0IFdLQWN0aW9uSXNNYWluRnJhbWVLZXk7ICAg IC8vIE5TTnVtYmVyIChCT09MKQorV0tfRVhQT1JUIGV4dGVybiBOU1N0cmluZyAqIGNvbnN0IFdL QWN0aW9uTmF2aWdhdGlvblR5cGVLZXk7IC8vIE5TTnVtYmVyIChXS05hdmlnYXRpb25UeXBlKQor V0tfRVhQT1JUIGV4dGVybiBOU1N0cmluZyAqIGNvbnN0IFdLQWN0aW9uTW91c2VCdXR0b25LZXk7 ICAgIC8vIE5TTnVtYmVyICgwIGZvciBsZWZ0IGJ1dHRvbiwgMSBmb3IgbWlkZGxlIGJ1dHRvbiwg MiBmb3IgcmlnaHQgYnV0dG9uKQorV0tfRVhQT1JUIGV4dGVybiBOU1N0cmluZyAqIGNvbnN0IFdL QWN0aW9uTW9kaWZpZXJGbGFnc0tleTsgIC8vIE5TTnVtYmVyICh1bnNpZ25lZCkKK1dLX0VYUE9S VCBleHRlcm4gTlNTdHJpbmcgKiBjb25zdCBXS0FjdGlvblVSTFJlcXVlc3RLZXk7ICAgICAvLyBO U1VSTFJlcXVlc3QKK1dLX0VYUE9SVCBleHRlcm4gTlNTdHJpbmcgKiBjb25zdCBXS0FjdGlvblVS TFJlc3BvbnNlS2V5OyAgICAvLyBOU1VSTFJlc3BvbnNlCitXS19FWFBPUlQgZXh0ZXJuIE5TU3Ry aW5nICogY29uc3QgV0tBY3Rpb25GcmFtZU5hbWVLZXk7ICAgICAgLy8gTlNTdHJpbmcKIAogdHlw ZWRlZiBOU19FTlVNKE5TVUludGVnZXIsIFdLTmF2aWdhdGlvblR5cGUpIHsKICAgICBXS05hdmln YXRpb25UeXBlTGlua0NsaWNrZWQsCg==