124375 2013-11-14 12:16:43 -0800 ASSERTION FAILED: rangesIntersect(m_renderer.pixelSnappedLogicalTopForFloat(floatingObject), m_renderer.pixelSnappedLogicalBottomForFloat(floatingObject), m_lineTop, m_lineBottom) ../../Source/WebCore/rendering/FloatingObjects.cpp(463) 2014-05-08 19:24:55 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bjonesbe bjonesbe commit-queue esprehn+autocc glenn kondapallykalyan simon.fraser svillar oldest_to_newest 950795 0 bjonesbe 2013-11-14 12:16:43 -0800 From Sergio Villar Senin: I'm constantly hitting this in debug builds (I'm running webkitgtk r159276). Just opening http://www.igalia.com makes the webprocess crash ASSERTION FAILED: rangesIntersect(m_renderer.pixelSnappedLogicalTopForFloat(floatingObject), m_renderer.pixelSnappedLogicalBottomForFloat(floatingObject), m_lineTop, m_lineBottom) ../../Source/WebCore/rendering/FloatingObjects.cpp(463) : void WebCore::ComputeFloatOffsetAdapter<FloatTypeValue>::collectIfNeeded(const IntervalType&) [with WebCore::FloatingObject::Type FloatTypeValue = (WebCore::FloatingObject::Type)1u; WebCore::ComputeFloatOffsetAdapter<FloatTypeValue>::IntervalType = WebCore::PODInterval<WebCore::LayoutUnit, WebCore::FloatingObject*>] 1 0x7f624149365e /opt/WebKit/WebKitBuild/Debug/.libs/libjavascriptcoregtk-3.0.so.0(WTFCrash+0x1e) [0x7f624149365e] 2 0x7f623d1af414 /opt/WebKit/WebKitBuild/Debug/.libs/libwebkit2gtk-3.0.so.25(+0x2428414) [0x7f623d1af414] 3 0x7f623d1ad116 /opt/WebKit/WebKitBuild/Debug/.libs/libwebkit2gtk-3.0.so.25(+0x2426116) [0x7f623d1ad116] 4 0x7f623d1ad174 /opt/WebKit/WebKitBuild/Debug/.libs/libwebkit2gtk-3.0.so.25(+0x2426174) [0x7f623d1ad174] 5 0x7f623d1ab50a /opt/WebKit/WebKitBuild/Debug/.libs/libwebkit2gtk-3.0.so.25(+0x242450a) [0x7f623d1ab50a] 6 0x7f623d1a9881 /opt/WebKit/WebKitBuild/Debug/.libs/libwebkit2gtk-3.0.so.25(_ZN7WebCore15FloatingObjects36logicalLeftOffsetForPositioningFloatENS_10LayoutUnitES1_PS1_+0x51) [0x7f623d1a9881] 7 0x7f623d21fb89 /opt/WebKit/WebKitBuild/Debug/.libs/libwebkit2gtk-3.0.so.25(_ZNK7WebCore15RenderBlockFlow36logicalLeftOffsetForPositioningFloatENS_10LayoutUnitES1_bPS1_+0x8b) [0x7f623d21fb89] 8 0x7f623d21ffad /opt/WebKit/WebKitBuild/Debug/.libs/libwebkit2gtk-3.0.so.25(_ZNK7WebCore15RenderBlockFlow30computeLogicalLocationForFloatEPKNS_14FloatingObjectENS_10LayoutUnitE+0x363) [0x7f623d21ffad] 9 0x7f623d2206f6 /opt/WebKit/WebKitBuild/Debug/.libs/libwebkit2gtk-3.0.so.25(_ZN7WebCore15RenderBlockFlow17positionNewFloatsEv+0x370) [0x7f623d2206f6] 10 0x7f623d239b15 /opt/WebKit/WebKitBuild/Debug/.libs/libwebkit2gtk-3.0.so.25(_ZN7WebCore15RenderBlockFlow22positionNewFloatOnLineEPNS_14FloatingObjectES2_RNS_8LineInfoERNS_9LineWidthE+0x3d) [0x7f623d239b15] 11 0x7f623d237111 /opt/WebKit/WebKitBuild/Debug/.libs/libwebkit2gtk-3.0.so.25(_ZN7WebCore11LineBreaker21skipLeadingWhitespaceERNS_12BidiResolverINS_14InlineIteratorENS_7BidiRunEEERNS_8LineInfoEPNS_14FloatingObjectERNS_9LineWidthE+0x22d) [0x7f623d237111] 12 0x7f623d238c2d /opt/WebKit/WebKitBuild/Debug/.libs/libwebkit2gtk-3.0.so.25(_ZN7WebCore11LineBreaker16nextSegmentBreakERNS_12BidiResolverINS_14InlineIteratorENS_7BidiRunEEERNS_8LineInfoERNS_14RenderTextInfoEPNS_14FloatingObjectEjRN3WTF6VectorINS_15WordMeasurementELm64ENSC_15CrashOnOverflowEEE+0x14d) [0x7f623d238c2d] 13 0x7f623d237eab /opt/WebKit/WebKitBuild/Debug/.libs/libwebkit2gtk-3.0.so.25(_ZN7WebCore11LineBreaker13nextLineBreakERNS_12BidiResolverINS_14InlineIteratorENS_7BidiRunEEERNS_8LineInfoERNS_14RenderTextInfoEPNS_14FloatingObjectEjRN3WTF6VectorINS_15WordMeasurementELm64ENSC_15CrashOnOverflowEEE+0xb7) [0x7f623d237eab] 14 0x7f623d232cb7 /opt/WebKit/WebKitBuild/Debug/.libs/libwebkit2gtk-3.0.so.25(_ZN7WebCore15RenderBlockFlow26layoutRunsAndFloatsInRangeERNS_15LineLayoutStateERNS_12BidiResolverINS_14InlineIteratorENS_7BidiRunEEERKS4_RKNS_10BidiStatusEj+0x553) [0x7f623d232cb7] 15 0x7f623d23164e /opt/WebKit/WebKitBuild/Debug/.libs/libwebkit2gtk-3.0.so.25(_ZN7WebCore15RenderBlockFlow19layoutRunsAndFloatsERNS_15LineLayoutStateEb+0x40e) [0x7f623d23164e] 16 0x7f623d234c94 /opt/WebKit/WebKitBuild/Debug/.libs/libwebkit2gtk-3.0.so.25(_ZN7WebCore15RenderBlockFlow15layoutLineBoxesEbRNS_10LayoutUnitES2_+0x676) [0x7f623d234c94] 17 0x7f623d218ba8 /opt/WebKit/WebKitBuild/Debug/.libs/libwebkit2gtk-3.0.so.25(_ZN7WebCore15RenderBlockFlow20layoutInlineChildrenEbRNS_10LayoutUnitES2_+0xc8) [0x7f623d218ba8] 18 0x7f623d217ef9 /opt/WebKit/WebKitBuild/Debug/.libs/libwebkit2gtk-3.0.so.25(_ZN7WebCore15RenderBlockFlow11layoutBlockEbNS_10LayoutUnitE+0x401) [0x7f623d217ef9] 19 0x7f623d1e70ed /opt/WebKit/WebKitBuild/Debug/.libs/libwebkit2gtk-3.0.so.25(_ZN7WebCore11RenderBlock6layoutEv+0x77) [0x7f623d1e70ed] 20 0x7f623d1b3b2b /opt/WebKit/WebKitBuild/Debug/.libs/libwebkit2gtk-3.0.so.25(+0x242cb2b) [0x7f623d1b3b2b] 21 0x7f623d21f5c0 /opt/WebKit/WebKitBuild/Debug/.libs/libwebkit2gtk-3.0.so.25(_ZN7WebCore15RenderBlockFlow20insertFloatingObjectERNS_9RenderBoxE+0x216) [0x7f623d21f5c0] 22 0x7f623d2370f0 /opt/WebKit/WebKitBuild/Debug/.libs/libwebkit2gtk-3.0.so.25(_ZN7WebCore11LineBreaker21skipLeadingWhitespaceERNS_12BidiResolverINS_14InlineIteratorENS_7BidiRunEEERNS_8LineInfoEPNS_14FloatingObjectERNS_9LineWidthE+0x20c) [0x7f623d2370f0] 23 0x7f623d238c2d /opt/WebKit/WebKitBuild/Debug/.libs/libwebkit2gtk-3.0.so.25(_ZN7WebCore11LineBreaker16nextSegmentBreakERNS_12BidiResolverINS_14InlineIteratorENS_7BidiRunEEERNS_8LineInfoERNS_14RenderTextInfoEPNS_14FloatingObjectEjRN3WTF6VectorINS_15WordMeasurementELm64ENSC_15CrashOnOverflowEEE+0x14d) [0x7f623d238c2d] 24 0x7f623d237eab /opt/WebKit/WebKitBuild/Debug/.libs/libwebkit2gtk-3.0.so.25(_ZN7WebCore11LineBreaker13nextLineBreakERNS_12BidiResolverINS_14InlineIteratorENS_7BidiRunEEERNS_8LineInfoERNS_14RenderTextInfoEPNS_14FloatingObjectEjRN3WTF6VectorINS_15WordMeasurementELm64ENSC_15CrashOnOverflowEEE+0xb7) [0x7f623d237eab] 25 0x7f623d232cb7 /opt/WebKit/WebKitBuild/Debug/.libs/libwebkit2gtk-3.0.so.25(_ZN7WebCore15RenderBlockFlow26layoutRunsAndFloatsInRangeERNS_15LineLayoutStateERNS_12BidiResolverINS_14InlineIteratorENS_7BidiRunEEERKS4_RKNS_10BidiStatusEj+0x553) [0x7f623d232cb7] 26 0x7f623d23164e /opt/WebKit/WebKitBuild/Debug/.libs/libwebkit2gtk-3.0.so.25(_ZN7WebCore15RenderBlockFlow19layoutRunsAndFloatsERNS_15LineLayoutStateEb+0x40e) [0x7f623d23164e] 27 0x7f623d234c94 /opt/WebKit/WebKitBuild/Debug/.libs/libwebkit2gtk-3.0.so.25(_ZN7WebCore15RenderBlockFlow15layoutLineBoxesEbRNS_10LayoutUnitES2_+0x676) [0x7f623d234c94] 28 0x7f623d218ba8 /opt/WebKit/WebKitBuild/Debug/.libs/libwebkit2gtk-3.0.so.25(_ZN7WebCore15RenderBlockFlow20layoutInlineChildrenEbRNS_10LayoutUnitES2_+0xc8) [0x7f623d218ba8] 29 0x7f623d217ef9 /opt/WebKit/WebKitBuild/Debug/.libs/libwebkit2gtk-3.0.so.25(_ZN7WebCore15RenderBlockFlow11layoutBlockEbNS_10LayoutUnitE+0x401) [0x7f623d217ef9] 30 0x7f623d1e70ed /opt/WebKit/WebKitBuild/Debug/.libs/libwebkit2gtk-3.0.so.25(_ZN7WebCore11RenderBlock6layoutEv+0x77) [0x7f623d1e70ed] 31 0x7f623d218f7b /opt/WebKit/WebKitBuild/Debug/.libs/libwebkit2gtk-3.0.so.25(_ZN7WebCore15RenderBlockFlow16layoutBlockChildERNS_9RenderBoxERNS0_10MarginInfoERNS_10LayoutUnitES6_+0x3d1) [0x7f623d218f7b] 950798 1 bjonesbe 2013-11-14 12:18:26 -0800 This was caused by my patch for bug 124207, I missed changing this assert, it shouldn't be using the pixel snapped coordinates anymore. Fix forthcoming. 950804 2 216968 bjonesbe 2013-11-14 12:49:05 -0800 Created attachment 216968 Patch 950908 3 216968 achicu 2013-11-14 17:08:49 -0800 Comment on attachment 216968 Patch r=me 950912 4 216968 commit-queue 2013-11-14 17:32:38 -0800 Comment on attachment 216968 Patch Clearing flags on attachment: 216968 Committed r159324: <http://trac.webkit.org/changeset/159324> 950913 5 commit-queue 2013-11-14 17:32:40 -0800 All reviewed patches have been landed. Closing bug. 1007864 6 simon.fraser 2014-05-08 19:24:55 -0700 Still seeing assertions here: bug 132725. 216968 2013-11-14 12:49:05 -0800 2013-11-14 17:32:38 -0800 Patch bug-124375-20131114124904.patch text/plain 2803 bjonesbe U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5Mjk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmJiM2M3N2Q4ZWNjNDY4 ZTMxNWM5YjcxMmE3YTc0OWE5MTVlZGRmMy4uOGFlNDJjNjZmMTFkZDk0MmY5YjUwYTY3NWY3NDhl NmVhMDVhODMwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTExLTE0ICBCZW0g Sm9uZXMtQmV5ICA8YmpvbmVzYmVAYWRvYmUuY29tPgorCisgICAgICAgIEFTU0VSVElPTiBGQUlM RUQ6IHJhbmdlc0ludGVyc2VjdChtX3JlbmRlcmVyLnBpeGVsU25hcHBlZExvZ2ljYWxUb3BGb3JG bG9hdChmbG9hdGluZ09iamVjdCksIG1fcmVuZGVyZXIucGl4ZWxTbmFwcGVkTG9naWNhbEJvdHRv bUZvckZsb2F0KGZsb2F0aW5nT2JqZWN0KSwgbV9saW5lVG9wLCBtX2xpbmVCb3R0b20pIC4uLy4u L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9GbG9hdGluZ09iamVjdHMuY3BwKDQ2MykKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDM3NQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gbW92aW5nIHRo ZSBwbGFjZWQgZmxvYXRzIHRyZWUgb3ZlciB0byBMYXlvdXRVbml0LCBJIGZvcmdvdCB0bworICAg ICAgICB1cGRhdGUgdGhlc2UgYXNzZXJ0cywgd2hpY2ggY2F1c2VzIGlzc3VlcyBvbiBwb3J0cyB3 aXRoIHN1YnBpeGVsCisgICAgICAgIGxheW91dCBlbmFibGVkLiAKKworICAgICAgICBObyBuZXcg dGVzdHMsIG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIHJlbmRlcmluZy9GbG9hdGlu Z09iamVjdHMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RmluZE5leHRGbG9hdExvZ2ljYWxCb3R0 b21BZGFwdGVyOjpjb2xsZWN0SWZOZWVkZWQpOgorICAgICAgICAoV2ViQ29yZTo6Ojpjb2xsZWN0 SWZOZWVkZWQpOgorCiAyMDEzLTExLTE0ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUu Y29tPgogCiAgICAgICAgIFtNYWNdIEhNQUMgc2lnbi92ZXJpZnkgY3Jhc2hlcyB3aGVuIGtleSBp cyBlbXB0eQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0Zsb2F0aW5nT2Jq ZWN0cy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvRmxvYXRpbmdPYmplY3RzLmNwcApp bmRleCAxMjU1NmE0YWRlMGIzNTc3Y2M4NWQ2NjVmOWQ2NGMyOWVmZDY3Y2FkLi44NjcxZWY0MDky NGFlMmM3ZDQ1NmNiMDhjM2UxNGExOGVmZWE3ZGNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvRmxvYXRpbmdPYmplY3RzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvRmxvYXRpbmdPYmplY3RzLmNwcApAQCAtMTg3LDcgKzE4Nyw3IEBAIGlubGluZSB2b2lk IEZpbmROZXh0RmxvYXRMb2dpY2FsQm90dG9tQWRhcHRlcjo6Y29sbGVjdElmTmVlZGVkKGNvbnN0 IEludGVydmFsVHlwCiAKICAgICAvLyBBbGwgdGhlIG9iamVjdHMgcmV0dXJuZWQgZnJvbSB0aGUg dHJlZSBzaG91bGQgYmUgYWxyZWFkeSBwbGFjZWQuCiAgICAgQVNTRVJUKGZsb2F0aW5nT2JqZWN0 LT5pc1BsYWNlZCgpKTsKLSAgICBBU1NFUlQocmFuZ2VzSW50ZXJzZWN0KG1fcmVuZGVyZXIucGl4 ZWxTbmFwcGVkTG9naWNhbFRvcEZvckZsb2F0KGZsb2F0aW5nT2JqZWN0KSwgbV9yZW5kZXJlci5w aXhlbFNuYXBwZWRMb2dpY2FsQm90dG9tRm9yRmxvYXQoZmxvYXRpbmdPYmplY3QpLCBtX2JlbG93 TG9naWNhbEhlaWdodCwgbV9hYm92ZUxvZ2ljYWxIZWlnaHQpKTsKKyAgICBBU1NFUlQocmFuZ2Vz SW50ZXJzZWN0KG1fcmVuZGVyZXIubG9naWNhbFRvcEZvckZsb2F0KGZsb2F0aW5nT2JqZWN0KSwg bV9yZW5kZXJlci5sb2dpY2FsQm90dG9tRm9yRmxvYXQoZmxvYXRpbmdPYmplY3QpLCBtX2JlbG93 TG9naWNhbEhlaWdodCwgbV9hYm92ZUxvZ2ljYWxIZWlnaHQpKTsKIAogICAgIExheW91dFVuaXQg ZmxvYXRCb3R0b20gPSBtX3JlbmRlcmVyLmxvZ2ljYWxCb3R0b21Gb3JGbG9hdChmbG9hdGluZ09i amVjdCk7CiAgICAgaWYgKG1fbmV4dExvZ2ljYWxCb3R0b20gPCBmbG9hdEJvdHRvbSkKQEAgLTQ2 MCw3ICs0NjAsNyBAQCBpbmxpbmUgdm9pZCBDb21wdXRlRmxvYXRPZmZzZXRBZGFwdGVyPEZsb2F0 VHlwZVZhbHVlPjo6Y29sbGVjdElmTmVlZGVkKGNvbnN0IEludAogCiAgICAgLy8gQWxsIHRoZSBv YmplY3RzIHJldHVybmVkIGZyb20gdGhlIHRyZWUgc2hvdWxkIGJlIGFscmVhZHkgcGxhY2VkLgog ICAgIEFTU0VSVChmbG9hdGluZ09iamVjdC0+aXNQbGFjZWQoKSk7Ci0gICAgQVNTRVJUKHJhbmdl c0ludGVyc2VjdChtX3JlbmRlcmVyLnBpeGVsU25hcHBlZExvZ2ljYWxUb3BGb3JGbG9hdChmbG9h dGluZ09iamVjdCksIG1fcmVuZGVyZXIucGl4ZWxTbmFwcGVkTG9naWNhbEJvdHRvbUZvckZsb2F0 KGZsb2F0aW5nT2JqZWN0KSwgbV9saW5lVG9wLCBtX2xpbmVCb3R0b20pKTsKKyAgICBBU1NFUlQo cmFuZ2VzSW50ZXJzZWN0KG1fcmVuZGVyZXIubG9naWNhbFRvcEZvckZsb2F0KGZsb2F0aW5nT2Jq ZWN0KSwgbV9yZW5kZXJlci5sb2dpY2FsQm90dG9tRm9yRmxvYXQoZmxvYXRpbmdPYmplY3QpLCBt X2xpbmVUb3AsIG1fbGluZUJvdHRvbSkpOwogCiAgICAgYm9vbCBmbG9hdElzTmV3RXh0cmVtZSA9 IHVwZGF0ZU9mZnNldElmTmVlZGVkKGZsb2F0aW5nT2JqZWN0KTsKICAgICBpZiAoZmxvYXRJc05l d0V4dHJlbWUpCg==