124362 2013-11-14 09:01:27 -0800 Copy ASAN flag settings to WebCore and JavaScriptCore intermediate build tools 2013-11-15 16:08:56 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac All RESOLVED FIXED P2 Normal --- 1 dfarler dfarler ddkilzer mrowe oldest_to_newest 950692 0 dfarler 2013-11-14 09:01:27 -0800 There is an outstanding bug when using trunk clang that operators new, new[], delete, and delete[] cannot be declared inline. This only shows up when USE_SYSTEM_MALLOC==0 and FastMalloc.h is included. ASAN builds with -DUSE_SYSTEM_MALLOC, so this problem doesn’t normally crop up. Up to now, the intermediate build tools weren’t built with ASAN because there isn’t a pressing need and it may kill the build. However, ASAN_OPTIONS is set to extremely lenient settings during the build and there haven’t been any false positives in these tools. For better uniformity of the xcconfigs and to avoid any special logic to build some projects without ASAN yet with USE_SYSTEM_MALLOC, I’d like to just use the same C*FLAGS = $(ASAN_C*FLAGS) options that all of the other targets are using to keep the ASAN builds going. 950704 1 216947 dfarler 2013-11-14 09:20:11 -0800 Created attachment 216947 Patch 951002 2 216947 ddkilzer 2013-11-15 02:27:53 -0800 Comment on attachment 216947 Patch r=me 951253 3 dfarler 2013-11-15 16:08:56 -0800 Committed r159369: <http://trac.webkit.org/changeset/159369> 216947 2013-11-14 09:20:11 -0800 2013-11-15 02:27:53 -0800 Patch bug-124362-20131114092010.patch text/plain 3337 dfarler U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5Mjg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl MWJiNjYyN2U1YzJmMTg1NjVkMDdkYTBjZTFiZTRkYWVlMTRmNmY4Li42NmIyMTA4NGVmNWYxZjdk ZjllNTA3YTI1NGE5MThlNzhhNWFjNmY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxMy0xMS0xNCAgRGF2aWQgRmFybGVyICA8ZGZhcmxlckBhcHBsZS5jb20+ CisKKyAgICAgICAgQ29weSBBU0FOIGZsYWcgc2V0dGluZ3MgdG8gV2ViQ29yZSBhbmQgSmF2YVNj cmlwdENvcmUgaW50ZXJtZWRpYXRlIGJ1aWxkIHRvb2xzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQzNjIKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIENvbmZpZ3VyYXRpb25zL1Rvb2xFeGVjdXRhYmxl LnhjY29uZmlnOgorICAgICAgICBVc2UgQVNBTl9DKkZMQUdTLgorCiAyMDEzLTExLTE0ICBKdWxp ZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04g KHIxNTkyNzYpOiBGaXggbG90cyBvZiBjcmFzaGVzIGZvciBzaDQgYXJjaGl0ZWN0dXJlLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCmluZGV4IDgzYmQwMGQ5YzdiMTI1NGIzYTM1MjY3NDBlOTA3MDMzOTJmZTY3YmUuLmVjMWI4 M2IxZWNhYjVhZDFlNjNjNDI4YWViNGI0MDQxNDM0MGVkYjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNSBAQAorMjAxMy0xMS0xNCAgRGF2aWQgRmFybGVyICA8ZGZhcmxlckBhcHBsZS5jb20+CisK KyAgICAgICAgQ29weSBBU0FOIGZsYWcgc2V0dGluZ3MgdG8gV2ViQ29yZSBhbmQgSmF2YVNjcmlw dENvcmUgaW50ZXJtZWRpYXRlIGJ1aWxkIHRvb2xzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQzNjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgbmVlZGVkLgorCisgICAgICAgICog V2ViQ29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qOgorICAgICAgICBVc2UgQVNBTl9DKkZM QUdTIGZvciBXZWJDb3JlRXhwb3J0RmlsZUdlbmVyYXRvci4KKwogMjAxMy0xMS0xNCAgU2Vva2p1 IEt3b24gIDxzZW9ranVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVc2UgW0ltcGxlbWVudGVkQXM9 ZGVmYXVsdFN0YXR1c10gZm9yIFdpbmRvdy5kZWZhdWx0c3RhdHVzCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvQ29uZmlndXJhdGlvbnMvVG9vbEV4ZWN1dGFibGUueGNjb25maWcg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ29uZmlndXJhdGlvbnMvVG9vbEV4ZWN1dGFibGUueGNj b25maWcKaW5kZXggZjE5YmJjYWUxOWYwNjQ4MDlhOTFiNTEwMzQzZjIwZWQ1NWU0ZTQwZC4uMWFk NDEzMjU1YjYyZjI1NjEyYWNhYzFmNzM5M2QwY2ZiODU5ZTkwZiAxMDA2NDQKLS0tIGEvU291cmNl L0phdmFTY3JpcHRDb3JlL0NvbmZpZ3VyYXRpb25zL1Rvb2xFeGVjdXRhYmxlLnhjY29uZmlnCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9Db25maWd1cmF0aW9ucy9Ub29sRXhlY3V0YWJsZS54 Y2NvbmZpZwpAQCAtNDMsNiArNDMsNiBAQCBDTEFOR19FTkFCTEVfT0JKQ19BUkNfYXJtNjQgPSBZ RVM7CiBDTEFOR19FTkFCTEVfT0JKQ19BUkNfYXJtdjcgPSBZRVM7CiBDTEFOR19FTkFCTEVfT0JK Q19BUkNfYXJtdjdzID0gWUVTOwogCi1PVEhFUl9DRkxBR1MgPSA7Ci1PVEhFUl9DUExVU1BMVVNG TEFHUyA9IDsKLU9USEVSX0xERkxBR1MgPSA7CitPVEhFUl9DRkxBR1MgPSAkKEFTQU5fT1RIRVJf Q0ZMQUdTKTsKK09USEVSX0NQTFVTUExVU0ZMQUdTID0gJChBU0FOX09USEVSX0NQTFVTUExVU0ZM QUdTKTsKK09USEVSX0xERkxBR1MgPSAkKEFTQU5fT1RIRVJfTERGTEFHUyk7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2ogYi9Tb3Vy Y2UvV2ViQ29yZS9XZWJDb3JlLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oKaW5kZXggMTMzMGJk ODk1NjUwNjFhMTdlYmI2YWM1NTBkNjNkMTE4Zjg3NWQ2Ny4uZGEwY2I4ZDczMzJhMjBjYmY1OTE5 MGFmNjUwNWI3YzY1OWFjZTYyZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS54 Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCisrKyBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUueGNv ZGVwcm9qL3Byb2plY3QucGJ4cHJvagpAQCAtMjg0MzIsOSArMjg0MzIsOSBAQAogCQkJCUVYUE9S VEVEX1NZTUJPTFNfRklMRSA9ICIiOwogCQkJCUdDQ19PUFRJTUlaQVRJT05fTEVWRUwgPSAwOwog CQkJCUlOU1RBTExfUEFUSCA9IC91c3IvbG9jYWwvYmluOwotCQkJCU9USEVSX0NGTEFHUyA9ICIi OwotCQkJCU9USEVSX0NQTFVTUExVU0ZMQUdTID0gIiI7Ci0JCQkJT1RIRVJfTERGTEFHUyA9ICIi OworCQkJCU9USEVSX0NGTEFHUyA9ICIkKEFTQU5fT1RIRVJfQ0ZMQUdTKSI7CisJCQkJT1RIRVJf Q1BMVVNQTFVTRkxBR1MgPSAiJChBU0FOX09USEVSX0NQTFVTUExVU0ZMQUdTKSI7CisJCQkJT1RI RVJfTERGTEFHUyA9ICIkKEFTQU5fT1RIRVJfTERGTEFHUykiOwogCQkJCVBST0RVQ1RfTkFNRSA9 IFdlYkNvcmVFeHBvcnRGaWxlR2VuZXJhdG9yOwogCQkJCVNLSVBfSU5TVEFMTCA9IFlFUzsKIAkJ CX07CkBAIC0yODQ0Niw5ICsyODQ0Niw5IEBACiAJCQlidWlsZFNldHRpbmdzID0gewogCQkJCUVY UE9SVEVEX1NZTUJPTFNfRklMRSA9ICIiOwogCQkJCUlOU1RBTExfUEFUSCA9IC91c3IvbG9jYWwv YmluOwotCQkJCU9USEVSX0NGTEFHUyA9ICIiOwotCQkJCU9USEVSX0NQTFVTUExVU0ZMQUdTID0g IiI7Ci0JCQkJT1RIRVJfTERGTEFHUyA9ICIiOworCQkJCU9USEVSX0NGTEFHUyA9ICIkKEFTQU5f T1RIRVJfQ0ZMQUdTKSI7CisJCQkJT1RIRVJfQ1BMVVNQTFVTRkxBR1MgPSAiJChBU0FOX09USEVS X0NQTFVTUExVU0ZMQUdTKSI7CisJCQkJT1RIRVJfTERGTEFHUyA9ICIkKEFTQU5fT1RIRVJfTERG TEFHUykiOwogCQkJCVBST0RVQ1RfTkFNRSA9IFdlYkNvcmVFeHBvcnRGaWxlR2VuZXJhdG9yOwog CQkJCVNLSVBfSU5TVEFMTCA9IFlFUzsKIAkJCX07Cg==