124361 2013-11-14 08:52:35 -0800 REGRESSION (r159276): rbp register overwritten in Win 64 version of callToJavascript stub 2013-11-14 10:11:15 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other Windows 7 RESOLVED FIXED P2 Normal --- 116888 1 msaboff msaboff oldest_to_newest 950689 0 msaboff 2013-11-14 08:52:35 -0800 In the inline assembly stub for MSVC X86_64, there is an error in the instruction to save RBP: push rbp => mov rbp, rax ; Save previous frame pointer mov rbp, rsp MS inline assembly is Intel format (i.e. <opcode> <dest>, <src>, ...) The rbp and tax need to be swapped. 950691 1 216944 msaboff 2013-11-14 09:01:18 -0800 Created attachment 216944 Patch 950740 2 msaboff 2013-11-14 10:11:15 -0800 Committed r159290: <http://trac.webkit.org/changeset/159290> 216944 2013-11-14 09:01:18 -0800 2013-11-14 10:08:34 -0800 Patch 124361.patch text/plain 1151 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU5Mjg2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDEzLTExLTE0ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFJFR1JFU1NJT04gKHIxNTkyNzYpOiByYnAgcmVnaXN0ZXIgb3ZlcndyaXR0ZW4gaW4gV2lu IDY0IHZlcnNpb24gb2YgY2FsbFRvSmF2YXNjcmlwdCBzdHViCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQzNjEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTd2FwcGVkIG9wZXJhbmQgb3JkZXJpbmcgdG86 IG1vdiByYXgsIHJicAorCisgICAgICAgICogaml0L0pJVFN0dWJzTVNWQzY0LmFzbToKKwogMjAx My0xMS0xNCAgSnVsaWVuIEJyaWFuY2VhdSAgPGpicmlhbmNlQGNpc2NvLmNvbT4KIAogICAgICAg ICBGaXggYnVpbGQgZm9yIHNoNCBhcmNoaXRlY3R1cmVzIChicm9rZW4gc2luY2UgcjE1OTI3Niku CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFN0dWJzTVNWQzY0LmFzbQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVFN0dWJzTVNWQzY0LmFzbQko cmV2aXNpb24gMTU5Mjg2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRTdHVic01T VkM2NC5hc20JKHdvcmtpbmcgY29weSkKQEAgLTMzLDcgKzMzLDcgQEAgX1RFWFQgICBTRUdNRU5U CiAKIGNhbGxUb0phdmFTY3JpcHQgUFJPQwogICAgIHB1c2ggcmJwCi0gICAgbW92IHJicCwgcmF4 IDsgU2F2ZSBwcmV2aW91cyBmcmFtZSBwb2ludGVyCisgICAgbW92IHJheCwgcmJwIDsgU2F2ZSBw cmV2aW91cyBmcmFtZSBwb2ludGVyCiAgICAgbW92IHJicCwgcnNwCiAgICAgcHVzaCByMTIKICAg ICBwdXNoIHIxMwo=