124350 2013-11-14 06:56:54 -0800 Web Inspector: Popovers may shrink unnecessarily 2013-12-02 03:00:29 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 950630 0 graouts 2013-11-14 06:56:54 -0800 Because we always get the intersection of the preferred frame and the container frame to ensure the popover fits within its container based on a preferred frame that would place the arrow within the center of the attachment edge, we get in situations where we may shrink the popover instead of shifting it to fit within the container frame. 950631 1 webkit-bug-importer 2013-11-14 06:57:06 -0800 <rdar://problem/15469207> 950632 2 216930 graouts 2013-11-14 06:59:01 -0800 Created attachment 216930 Patch 950639 3 216930 timothy 2013-11-14 07:19:41 -0800 Comment on attachment 216930 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216930&action=review > Source/WebInspectorUI/UserInterface/Popover.js:402 > + x += containerFrame.maxX() - (x + width); += does not sound right. Should this just be =? > Source/WebInspectorUI/UserInterface/Popover.js:404 > + y += containerFrame.maxY() - (y + height); Ditto. 950642 4 216930 timothy 2013-11-14 07:26:26 -0800 Comment on attachment 216930 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216930&action=review >> Source/WebInspectorUI/UserInterface/Popover.js:402 >> + x += containerFrame.maxX() - (x + width); > > += does not sound right. Should this just be =? Never mind. It will always be negative. 950656 5 216930 commit-queue 2013-11-14 08:01:20 -0800 Comment on attachment 216930 Patch Clearing flags on attachment: 216930 Committed r159286: <http://trac.webkit.org/changeset/159286> 950657 6 commit-queue 2013-11-14 08:01:26 -0800 All reviewed patches have been landed. Closing bug. 955311 7 graouts 2013-12-02 03:00:29 -0800 This caused a regression, see https://bugs.webkit.org/show_bug.cgi?id=125069. 216930 2013-11-14 06:59:01 -0800 2013-11-14 08:01:19 -0800 Patch bug-124350-20131114155901.patch text/plain 2174 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMTU4NTc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA4 Y2NlNjM4ODlhNjkwMThhMzdlODA2YjAyOTE4NGM5MWZkZjkzN2VmLi4yZDg1MWIyMzBlY2VjZTM5 MTljNTJkMjA3ZGRjMDBkZWZjNDI2ZTdkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxMy0xMS0xNCAgQW50b2luZSBRdWludCAgPGdyYW91dHNAYXBwbGUuY29t PgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFBvcG92ZXJzIG1heSBzaHJpbmsgdW5uZWNlc3Nh cmlseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI0 MzUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQmVj YXVzZSB3ZSBhbHdheXMgZ2V0IHRoZSBpbnRlcnNlY3Rpb24gb2YgdGhlIHByZWZlcnJlZCBmcmFt ZSBhbmQgdGhlIGNvbnRhaW5lciBmcmFtZSB0bworICAgICAgICBlbnN1cmUgdGhlIHBvcG92ZXIg Zml0cyB3aXRoaW4gaXRzIGNvbnRhaW5lciBiYXNlZCBvbiBhIHByZWZlcnJlZCBmcmFtZSB0aGF0 IHdvdWxkIHBsYWNlCisgICAgICAgIHRoZSBhcnJvdyB3aXRoaW4gdGhlIGNlbnRlciBvZiB0aGUg YXR0YWNobWVudCBlZGdlLCB3ZSBnZXQgaW4gc2l0dWF0aW9ucyB3aGVyZSB3ZSBtYXkKKyAgICAg ICAgc2hyaW5rIHRoZSBwb3BvdmVyIGluc3RlYWQgb2Ygc2hpZnRpbmcgaXQgdG8gZml0IHdpdGhp biB0aGUgY29udGFpbmVyIGZyYW1lLiBXZSBub3cgZmlyc3QKKyAgICAgICAgc2hpZnQgdGhlIHBy ZWZlcnJlZCBmcmFtZSBiZWZvcmUgZ2V0dGluZyBpdHMgaW50ZXJzZWN0aW9uIHdpdGggdGhlIGNv bnRhaW5lciBmcmFtZSB0bworICAgICAgICBhdm9pZCBzdWNoIHNpdHVhdGlvbnMuIAorCisgICAg ICAgICogVXNlckludGVyZmFjZS9Qb3BvdmVyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlBv cG92ZXIucHJvdG90eXBlLl9iZXN0TWV0cmljc0ZvckVkZ2UpOgorCiAyMDEzLTExLTAxICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIGN1c3RvbSBG dW5jdGlvbi5wcm90b3R5cGUuYmluZCgpIGluIGZhdm9yIG9mIG5hdGl2ZSB2ZXJzaW9uCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Qb3BvdmVyLmpzIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvUG9wb3Zlci5qcwppbmRleCA4NDkw ODQ4ZTFlODY1NGFjNjE3Njg4OWJkMjI1OWIzZDM4MTgwYzJlLi5hNDYyN2U2Yzk2MzFkYjkzOWM2 M2VlOGM3NjBjZWZlOTU5MjUzZmY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9Qb3BvdmVyLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1BvcG92ZXIuanMKQEAgLTM5NCw2ICszOTQsMTUgQEAgV2ViSW5zcGVjdG9yLlBv cG92ZXIucHJvdG90eXBlID0gewogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KIAorICAg ICAgICBpZiAoeCA8IGNvbnRhaW5lckZyYW1lLm1pblgoKSkKKyAgICAgICAgICAgIHggPSBjb250 YWluZXJGcmFtZS5taW5YKCk7IAorICAgICAgICBpZiAoeSA8IGNvbnRhaW5lckZyYW1lLm1pblko KSkKKyAgICAgICAgICAgIHkgPSBjb250YWluZXJGcmFtZS5taW5ZKCk7CisgICAgICAgIGlmICh4 ICsgd2lkdGggPiBjb250YWluZXJGcmFtZS5tYXhYKCkpCisgICAgICAgICAgICB4ICs9IGNvbnRh aW5lckZyYW1lLm1heFgoKSAtICh4ICsgd2lkdGgpOworICAgICAgICBpZiAoeSArIGhlaWdodCA+ IGNvbnRhaW5lckZyYW1lLm1heFkoKSkKKyAgICAgICAgICAgIHkgKz0gY29udGFpbmVyRnJhbWUu bWF4WSgpIC0gKHkgKyBoZWlnaHQpOworCiAgICAgICAgIHZhciBwcmVmZXJyZWRGcmFtZSA9IG5l dyBXZWJJbnNwZWN0b3IuUmVjdCh4LCB5LCB3aWR0aCwgaGVpZ2h0KTsKICAgICAgICAgdmFyIGJl c3RGcmFtZSA9IHByZWZlcnJlZEZyYW1lLmludGVyc2VjdGlvbldpdGhSZWN0KGNvbnRhaW5lckZy YW1lKTsKIAo=