124347 2013-11-14 05:18:20 -0800 REGRESSION(r159276): Lots of crashes for sh4 arch 2013-11-14 08:50:39 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 124344 1 jbriance webkit-unassigned commit-queue ggaren msaboff yannick.poirier oldest_to_newest 950613 0 jbriance 2013-11-14 05:18:20 -0800 Lots of crashes appeared for sh4 architecture since http://trac.webkit.org/changeset/159276 The issue is identified and I'll submit a patch soon 950649 1 216933 jbriance 2013-11-14 07:40:51 -0800 Created attachment 216933 Prevent argument register trampling in cCallX macros of LLINT for sh4. This patch fixes the crashes. If I have time and if you think it's worth, I could move this "setargs" from SH4_INSTRUCTIONS to RISC_INSTRUCTIONS later, as I think this issue could also occur with ARM & MIPS architectures. 950686 2 216933 commit-queue 2013-11-14 08:50:37 -0800 Comment on attachment 216933 Prevent argument register trampling in cCallX macros of LLINT for sh4. Clearing flags on attachment: 216933 Committed r159288: <http://trac.webkit.org/changeset/159288> 950687 3 commit-queue 2013-11-14 08:50:39 -0800 All reviewed patches have been landed. Closing bug. 216933 2013-11-14 07:40:51 -0800 2013-11-14 08:50:37 -0800 Prevent argument register trampling in cCallX macros of LLINT for sh4. bug-124347.patch text/plain 6965 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTU5Mjg0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDEzLTExLTE0ICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgorCisg ICAgICAgIFJFR1JFU1NJT04gKHIxNTkyNzYpOiBGaXggbG90cyBvZiBjcmFzaGVzIGZvciBzaDQg YXJjaGl0ZWN0dXJlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTI0MzQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgU2luY2UgcjE1OTI3Niwgd2UgaGF2ZSAodDQgPT0gYTAgPT0gcjQpIGFuZCAodDUgPT0g YTEgPT0gcjUpIGluIExMSU5UIGZvciBzaDQuCisgICAgICAgIFRoaXMgbGVhZHMgdG8gYXJndW1l bnQgcmVnaXN0ZXIgdHJhbXBsaW5nIGluIGNDYWxsWCBtYWNyb3MsIGVzcGVjaWFsbHkgd2l0aCBj Q2FsbDIKKyAgICAgICAgbWFjcm8gd2hlbiBhcmcxID09IHQ0LgorCisgICAgICAgICogbGxpbnQv TG93TGV2ZWxJbnRlcnByZXRlcjMyXzY0LmFzbTogVXNlIGEgbmV3ICJzZXRhcmdzIiBwc2V1ZG8t b3AgdG8gc2V0dXAgYXJndW1lbnRzIGZvciBzaDQuCisgICAgICAgICogb2ZmbGluZWFzbS9pbnN0 cnVjdGlvbnMucmI6CisgICAgICAgICogb2ZmbGluZWFzbS9zaDQucmI6IExvd2VyICJzZXRhcmdz IiBwc2V1ZG8tb3AgdG8gc2V0dXAgYXJndW1lbnQgcmVnaXN0ZXJzIGFuZCBwcmV2ZW50IHJlZ2lz dGVyIHRyYW1wbGluZyBpc3N1ZXMuCisKIDIwMTMtMTEtMTQgIEp1bGllbiBCcmlhbmNlYXUgIDxq YnJpYW5jZUBjaXNjby5jb20+CiAKICAgICAgICAgRml4IGJ1aWxkIGZvciBzaDQgYXJjaGl0ZWN0 dXJlcyAoYnJva2VuIHNpbmNlIHIxNTkyNzYpLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc20KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc20JKHJldmlz aW9uIDE1OTI4MykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVy cHJldGVyMzJfNjQuYXNtCSh3b3JraW5nIGNvcHkpCkBAIC0xMDUsMTAgKzEwNSwxMyBAQCBtYWNy byBjQ2FsbDIoZnVuY3Rpb24sIGFyZzEsIGFyZzIpCiAgICAgICAgIHBva2UgYXJnMSwgMAogICAg ICAgICBwb2tlIGFyZzIsIDEKICAgICAgICAgY2FsbCBmdW5jdGlvbgotICAgIGVsc2lmIE1JUFMg b3IgU0g0CisgICAgZWxzaWYgTUlQUwogICAgICAgICBtb3ZlIGFyZzEsIGEwCiAgICAgICAgIG1v dmUgYXJnMiwgYTEKICAgICAgICAgY2FsbCBmdW5jdGlvbgorICAgIGVsc2lmIFNINAorICAgICAg ICBzZXRhcmdzIGFyZzEsIGFyZzIKKyAgICAgICAgY2FsbCBmdW5jdGlvbgogICAgIGVsc2lmIENf TE9PUAogICAgICAgICBjbG9vcENhbGxTbG93UGF0aCBmdW5jdGlvbiwgYXJnMSwgYXJnMgogICAg IGVsc2UKQEAgLTEzMCwxMiArMTMzLDE1IEBAIG1hY3JvIGNDYWxsNChmdW5jdGlvbiwgYXJnMSwg YXJnMiwgYXJnMywKICAgICAgICAgcG9rZSBhcmczLCAyCiAgICAgICAgIHBva2UgYXJnNCwgMwog ICAgICAgICBjYWxsIGZ1bmN0aW9uCi0gICAgZWxzaWYgTUlQUyBvciBTSDQKKyAgICBlbHNpZiBN SVBTCiAgICAgICAgIG1vdmUgYXJnMSwgYTAKICAgICAgICAgbW92ZSBhcmcyLCBhMQogICAgICAg ICBtb3ZlIGFyZzMsIGEyCiAgICAgICAgIG1vdmUgYXJnNCwgYTMKICAgICAgICAgY2FsbCBmdW5j dGlvbgorICAgIGVsc2lmIFNINAorICAgICAgICBzZXRhcmdzIGFyZzEsIGFyZzIsIGFyZzMsIGFy ZzQKKyAgICAgICAgY2FsbCBmdW5jdGlvbgogICAgIGVsc2lmIENfTE9PUAogICAgICAgICBlcnJv cgogICAgIGVsc2UKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2luc3Ry dWN0aW9ucy5yYgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFz bS9pbnN0cnVjdGlvbnMucmIJKHJldmlzaW9uIDE1OTI4MykKKysrIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9vZmZsaW5lYXNtL2luc3RydWN0aW9ucy5yYgkod29ya2luZyBjb3B5KQpAQCAtMjg4LDcg KzI4OCw4IEBAIFNINF9JTlNUUlVDVElPTlMgPQogICAgICJsb2FkZFJldmVyc2VkQW5kSW5jcmVt ZW50QWRkcmVzcyIsCiAgICAgInN0b3JlZFJldmVyc2VkQW5kRGVjcmVtZW50QWRkcmVzcyIsCiAg ICAgImxkc3ByIiwKLSAgICAic3RzcHIiCisgICAgInN0c3ByIiwKKyAgICAic2V0YXJncyIKICAg ICBdCiAKIENYWF9JTlNUUlVDVElPTlMgPQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL29m ZmxpbmVhc20vc2g0LnJiCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZs aW5lYXNtL3NoNC5yYgkocmV2aXNpb24gMTU5MjgzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L29mZmxpbmVhc20vc2g0LnJiCSh3b3JraW5nIGNvcHkpCkBAIC01NjMsNiArNTYzLDc4IEBAIGRl ZiBzaDRMb3dlckNvbnN0UG9vbChsaXN0KQogZW5kCiAKIAorIworIyBMb3dlcmluZyBvZiBhcmd1 bWVudCBzZXR1cCBmb3IgU0g0LgorIyBUaGlzIHBoYXNlIGF2b2lkcyBhcmd1bWVudCByZWdpc3Rl ciB0cmFtcGxpbmcuIEZvciBleGFtcGxlLCBpZiBhMCA9PSB0NDoKKyMKKyMgc2V0YXJncyB0MSwg dDQKKyMKKyMgYmVjb21lczoKKyMKKyMgbW92ZSB0NCwgYTEKKyMgbW92ZSB0MSwgYTAKKyMKKwor ZGVmIHNoNExvd2VyQXJndW1lbnRTZXR1cChsaXN0KQorICAgIGEwID0gUmVnaXN0ZXJJRC5mb3JO YW1lKGNvZGVPcmlnaW4sICJhMCIpCisgICAgYTEgPSBSZWdpc3RlcklELmZvck5hbWUoY29kZU9y aWdpbiwgImExIikKKyAgICBhMiA9IFJlZ2lzdGVySUQuZm9yTmFtZShjb2RlT3JpZ2luLCAiYTIi KQorICAgIGEzID0gUmVnaXN0ZXJJRC5mb3JOYW1lKGNvZGVPcmlnaW4sICJhMyIpCisgICAgbmV3 TGlzdCA9IFtdCisgICAgbGlzdC5lYWNoIHsKKyAgICAgICAgfCBub2RlIHwKKyAgICAgICAgaWYg bm9kZS5pc19hPyBJbnN0cnVjdGlvbgorICAgICAgICAgICAgY2FzZSBub2RlLm9wY29kZQorICAg ICAgICAgICAgd2hlbiAic2V0YXJncyIKKyAgICAgICAgICAgICAgICBpZiBub2RlLm9wZXJhbmRz LnNpemUgPT0gMgorICAgICAgICAgICAgICAgICAgICBpZiBub2RlLm9wZXJhbmRzWzFdLnNoNE9w ZXJhbmQgIT0gYTAuc2g0T3BlcmFuZAorICAgICAgICAgICAgICAgICAgICAgICAgbmV3TGlzdCA8 PCBJbnN0cnVjdGlvbi5uZXcoY29kZU9yaWdpbiwgIm1vdmUiLCBbbm9kZS5vcGVyYW5kc1swXSwg YTBdKQorICAgICAgICAgICAgICAgICAgICAgICAgbmV3TGlzdCA8PCBJbnN0cnVjdGlvbi5uZXco Y29kZU9yaWdpbiwgIm1vdmUiLCBbbm9kZS5vcGVyYW5kc1sxXSwgYTFdKQorICAgICAgICAgICAg ICAgICAgICBlbHNpZiBub2RlLm9wZXJhbmRzWzBdLnNoNE9wZXJhbmQgIT0gYTEuc2g0T3BlcmFu ZAorICAgICAgICAgICAgICAgICAgICAgICAgbmV3TGlzdCA8PCBJbnN0cnVjdGlvbi5uZXcoY29k ZU9yaWdpbiwgIm1vdmUiLCBbbm9kZS5vcGVyYW5kc1sxXSwgYTFdKQorICAgICAgICAgICAgICAg ICAgICAgICAgbmV3TGlzdCA8PCBJbnN0cnVjdGlvbi5uZXcoY29kZU9yaWdpbiwgIm1vdmUiLCBb bm9kZS5vcGVyYW5kc1swXSwgYTBdKQorICAgICAgICAgICAgICAgICAgICBlbHNlCisgICAgICAg ICAgICAgICAgICAgICAgICAjIEFzIChvcGVyYW5kc1swXSA9PSBhMSkgYW5kIChvcGVyYW5kc1sx XSA9PSBhMCksIHdlIGp1c3QgbmVlZCB0byBzd2FwIGEwIGFuZCBhMS4KKyAgICAgICAgICAgICAg ICAgICAgICAgIG5ld0xpc3QgPDwgSW5zdHJ1Y3Rpb24ubmV3KGNvZGVPcmlnaW4sICJ4b3JpIiwg W2EwLCBhMV0pCisgICAgICAgICAgICAgICAgICAgICAgICBuZXdMaXN0IDw8IEluc3RydWN0aW9u Lm5ldyhjb2RlT3JpZ2luLCAieG9yaSIsIFthMSwgYTBdKQorICAgICAgICAgICAgICAgICAgICAg ICAgbmV3TGlzdCA8PCBJbnN0cnVjdGlvbi5uZXcoY29kZU9yaWdpbiwgInhvcmkiLCBbYTAsIGEx XSkKKyAgICAgICAgICAgICAgICAgICAgZW5kCisgICAgICAgICAgICAgICAgZWxzaWYgbm9kZS5v cGVyYW5kcy5zaXplID09IDQKKyAgICAgICAgICAgICAgICAgICAgIyBGSVhNRTogV2UganVzdCBy YWlzZSBhbiBlcnJvciBpZiBzb21ldGhpbmcgaXMgbGlrZWx5IHRvIGdvIHdyb25nIGZvciBub3cu CisgICAgICAgICAgICAgICAgICAgICMgSXQgd291bGQgYmUgYmV0dGVyIHRvIGltcGxlbWVudCBh IHJlY292ZXJpbmcgYWxnb3JpdGhtLgorICAgICAgICAgICAgICAgICAgICBpZiAobm9kZS5vcGVy YW5kc1swXS5zaDRPcGVyYW5kID09IGExLnNoNE9wZXJhbmQpIG9yCisgICAgICAgICAgICAgICAg ICAgICAgICAobm9kZS5vcGVyYW5kc1swXS5zaDRPcGVyYW5kID09IGEyLnNoNE9wZXJhbmQpIG9y CisgICAgICAgICAgICAgICAgICAgICAgICAobm9kZS5vcGVyYW5kc1swXS5zaDRPcGVyYW5kID09 IGEzLnNoNE9wZXJhbmQpIG9yCisgICAgICAgICAgICAgICAgICAgICAgICAobm9kZS5vcGVyYW5k c1sxXS5zaDRPcGVyYW5kID09IGEwLnNoNE9wZXJhbmQpIG9yCisgICAgICAgICAgICAgICAgICAg ICAgICAobm9kZS5vcGVyYW5kc1sxXS5zaDRPcGVyYW5kID09IGEyLnNoNE9wZXJhbmQpIG9yCisg ICAgICAgICAgICAgICAgICAgICAgICAobm9kZS5vcGVyYW5kc1sxXS5zaDRPcGVyYW5kID09IGEz LnNoNE9wZXJhbmQpIG9yCisgICAgICAgICAgICAgICAgICAgICAgICAobm9kZS5vcGVyYW5kc1sy XS5zaDRPcGVyYW5kID09IGEwLnNoNE9wZXJhbmQpIG9yCisgICAgICAgICAgICAgICAgICAgICAg ICAobm9kZS5vcGVyYW5kc1syXS5zaDRPcGVyYW5kID09IGExLnNoNE9wZXJhbmQpIG9yCisgICAg ICAgICAgICAgICAgICAgICAgICAobm9kZS5vcGVyYW5kc1syXS5zaDRPcGVyYW5kID09IGEzLnNo NE9wZXJhbmQpIG9yCisgICAgICAgICAgICAgICAgICAgICAgICAobm9kZS5vcGVyYW5kc1szXS5z aDRPcGVyYW5kID09IGEwLnNoNE9wZXJhbmQpIG9yCisgICAgICAgICAgICAgICAgICAgICAgICAo bm9kZS5vcGVyYW5kc1szXS5zaDRPcGVyYW5kID09IGExLnNoNE9wZXJhbmQpIG9yCisgICAgICAg ICAgICAgICAgICAgICAgICAobm9kZS5vcGVyYW5kc1szXS5zaDRPcGVyYW5kID09IGEyLnNoNE9w ZXJhbmQpCisgICAgICAgICAgICAgICAgICAgICAgICByYWlzZSAiUG90ZW50aWFsIGFyZ3VtZW50 IHJlZ2lzdGVyIHRyYW1wbGluZyBkZXRlY3RlZC4iCisgICAgICAgICAgICAgICAgICAgIGVuZAor CisgICAgICAgICAgICAgICAgICAgIG5ld0xpc3QgPDwgSW5zdHJ1Y3Rpb24ubmV3KGNvZGVPcmln aW4sICJtb3ZlIiwgW25vZGUub3BlcmFuZHNbMF0sIGEwXSkKKyAgICAgICAgICAgICAgICAgICAg bmV3TGlzdCA8PCBJbnN0cnVjdGlvbi5uZXcoY29kZU9yaWdpbiwgIm1vdmUiLCBbbm9kZS5vcGVy YW5kc1sxXSwgYTFdKQorICAgICAgICAgICAgICAgICAgICBuZXdMaXN0IDw8IEluc3RydWN0aW9u Lm5ldyhjb2RlT3JpZ2luLCAibW92ZSIsIFtub2RlLm9wZXJhbmRzWzJdLCBhMl0pCisgICAgICAg ICAgICAgICAgICAgIG5ld0xpc3QgPDwgSW5zdHJ1Y3Rpb24ubmV3KGNvZGVPcmlnaW4sICJtb3Zl IiwgW25vZGUub3BlcmFuZHNbM10sIGEzXSkKKyAgICAgICAgICAgICAgICBlbHNlCisgICAgICAg ICAgICAgICAgICAgIHJhaXNlICJJbnZhbGlkIG9wZXJhbmRzIG51bWJlciAoI3tub2RlLm9wZXJh bmRzLnNpemV9KSBmb3Igc2V0YXJncyIKKyAgICAgICAgICAgICAgICBlbmQKKyAgICAgICAgICAg IGVsc2UKKyAgICAgICAgICAgICAgICBuZXdMaXN0IDw8IG5vZGUKKyAgICAgICAgICAgIGVuZAor ICAgICAgICBlbHNlCisgICAgICAgICAgICBuZXdMaXN0IDw8IG5vZGUKKyAgICAgICAgZW5kCisg ICAgfQorICAgIG5ld0xpc3QKK2VuZAorCisKIGNsYXNzIFNlcXVlbmNlCiAgICAgZGVmIGdldE1v ZGlmaWVkTGlzdFNINAogICAgICAgICByZXN1bHQgPSBAbGlzdApAQCAtNjEzLDYgKzY4NSw3IEBA IGNsYXNzIFNlcXVlbmNlCiAgICAgICAgIHJlc3VsdCA9IGFzc2lnblJlZ2lzdGVyc1RvVGVtcG9y YXJpZXMocmVzdWx0LCA6Z3ByLCBTSDRfVE1QX0ZQUlMpCiAKICAgICAgICAgcmVzdWx0ID0gc2g0 TG93ZXJDb25zdFBvb2wocmVzdWx0KQorICAgICAgICByZXN1bHQgPSBzaDRMb3dlckFyZ3VtZW50 U2V0dXAocmVzdWx0KQogCiAgICAgICAgIHJldHVybiByZXN1bHQKICAgICBlbmQKQEAgLTg4Myw3 ICs5NTYsNyBAQCBjbGFzcyBJbnN0cnVjdGlvbgogICAgICAgICAgICAgICAgIGVsc2UKICAgICAg ICAgICAgICAgICAgICAgJGFzbS5wdXRzICJtb3YubCAje29wZXJhbmRzWzBdLmxhYmVscmVmLmFz bUxhYmVsfSwgI3tvcGVyYW5kc1sxXS5zaDRPcGVyYW5kfSIKICAgICAgICAgICAgICAgICBlbmQK LSAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgIGVsc2lmIG9wZXJhbmRzWzBdLnNoNE9wZXJh bmQgIT0gb3BlcmFuZHNbMV0uc2g0T3BlcmFuZAogICAgICAgICAgICAgICAgICRhc20ucHV0cyAi bW92ICN7c2g0T3BlcmFuZHMob3BlcmFuZHMpfSIKICAgICAgICAgICAgIGVuZAogICAgICAgICB3 aGVuICJsZWFwIgo=