124343 2013-11-14 03:37:17 -0800 Clean up sequence handling in Blob constructor 2013-11-14 16:53:36 -0800 1 1 1 Unclassified WebKit Bindings 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 costan webkit-unassigned ap cdumez commit-queue oldest_to_newest 950587 0 costan 2013-11-14 03:37:17 -0800 This is a follow-up to Alexey Proskuryakov's feedback on https://bugs.webkit.org/show_bug.cgi?id=124175 950594 1 216917 costan 2013-11-14 04:11:28 -0800 Created attachment 216917 Patch 950608 2 costan 2013-11-14 05:04:41 -0800 The LayoutTest I added actually works without the new exception check. I think it's still valuable because it demonstrates correct behavior, and it uncovered a crashing bug in the Blink patch for the same feature. 950774 3 216917 cdumez 2013-11-14 11:19:04 -0800 Comment on attachment 216917 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216917&action=review > Source/WebCore/bindings/js/JSBlobCustom.cpp:124 > + blobBuilder.append(arrayBufferView); nit: We might want to arrayBufferView.release() to avoid some ref counting churn. 950879 4 216991 costan 2013-11-14 15:53:34 -0800 Created attachment 216991 Patch 950880 5 costan 2013-11-14 15:54:11 -0800 Thank you for catching that, Chris! Can you please take another look? 950889 6 cdumez 2013-11-14 16:12:08 -0800 (In reply to comment #5) > Thank you for catching that, Chris! Can you please take another look? No need for additional review, it was merely a nit. Just update the Changelog to indicate that it was reviewed by Alexey and reupload with the cq+ flag only. 950890 7 216995 costan 2013-11-14 16:16:11 -0800 Created attachment 216995 Patch 950891 8 216995 commit-queue 2013-11-14 16:16:56 -0800 Comment on attachment 216995 Patch Rejecting attachment 216995 from commit-queue. costan@gmail.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 950892 9 costan 2013-11-14 16:18:29 -0800 Chris, it seems like I'm not cool enough to use CQ directly. Sorry, it seems like you and/or Alexey will have to r+ the patch. 950894 10 cdumez 2013-11-14 16:22:24 -0800 (In reply to comment #9) > Chris, it seems like I'm not cool enough to use CQ directly. > > Sorry, it seems like you and/or Alexey will have to r+ the patch. Sorry I meant that you should set the cq? flag (not cq+ since you're not a committer). It is OK, I cq+ for you. 950897 11 costan 2013-11-14 16:24:16 -0800 Sorry to cause you extra work, Chris! I'll know better next time! :) Thanks!! 950905 12 216995 commit-queue 2013-11-14 16:53:33 -0800 Comment on attachment 216995 Patch Clearing flags on attachment: 216995 Committed r159323: <http://trac.webkit.org/changeset/159323> 950906 13 commit-queue 2013-11-14 16:53:36 -0800 All reviewed patches have been landed. Closing bug. 216917 2013-11-14 04:11:28 -0800 2013-11-14 15:53:29 -0800 Patch bug-124343-20131114071127.patch text/plain 4879 costan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1OTI4MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEzLTExLTE0ICBWaWN0b3Ig Q29zdGFuICA8Y29zdGFuQGdtYWlsLmNvbT4KKworICAgICAgICBDbGVhbiB1cCBzZXF1ZW5jZSBo YW5kbGluZyBpbiBCbG9iIGNvbnN0cnVjdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQzNDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBZGRlZCB0ZXN0IGNhc2UgdG8gTGF5b3V0VGVzdHMvZmFzdC9m aWxlcy9ibG9iLWNvbnN0cnVjdG9yLmh0bWwKKworICAgICAgICAqIGJpbmRpbmdzL2pzL0pTQmxv YkN1c3RvbS5jcHA6IAorICAgICAgICAoV2ViQ29yZTo6SlNCbG9iQ29uc3RydWN0b3I6OmNvbnN0 cnVjdEpTQmxvYik6CisgICAgICAgICAgICBIYW5kbGUgZXhjZXB0aW9ucyBpbiBzZXF1ZW5jZXMs IGVsaW1pbmF0ZSBkb3VibGUgdHlwZS1jaGVja2luZyBmb3IKKyAgICAgICAgICAgIEFycmF5QnVm ZmVyLCBBcnJheUJ1ZmZlclZpZXcgYW5kIEJsb2IgcGFydHMuCisKIDIwMTMtMTEtMTQgIEd5dXlv dW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBHZW5lcmF0ZSB0 b1NWR1BvbHlsaW5lfGdvbkVsZW1lbnQoKSB0byByZXBsYWNlIHN0YXRpY19jYXN0PD4KSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTQmxvYkN1c3RvbS5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNCbG9iQ3VzdG9tLmNwcAkocmV2aXNpb24g MTU5MjgxKQorKysgU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNCbG9iQ3VzdG9tLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMTE0LDE1ICsxMTQsMTggQEAgRW5jb2RlZEpTVmFsdWUgSlNDX0hP U1RfQ0FMTCBKU0Jsb2JDb25zdAogCiAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IGJsb2JQ YXJ0c0xlbmd0aDsgKytpKSB7CiAgICAgICAgIEpTVmFsdWUgaXRlbSA9IGJsb2JQYXJ0cy0+Z2V0 KGV4ZWMsIGkpOworICAgICAgICBpZiAoZXhlYy0+aGFkRXhjZXB0aW9uKCkpCisgICAgICAgICAg ICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGpzVW5kZWZpbmVkKCkpOworCiAjaWYgRU5BQkxFKEJM T0IpCi0gICAgICAgIGlmIChpdGVtLmluaGVyaXRzKEpTQXJyYXlCdWZmZXI6OmluZm8oKSkpCi0g ICAgICAgICAgICBibG9iQnVpbGRlci5hcHBlbmQodG9BcnJheUJ1ZmZlcihpdGVtKSk7Ci0gICAg ICAgIGVsc2UgaWYgKGl0ZW0uaW5oZXJpdHMoSlNBcnJheUJ1ZmZlclZpZXc6OmluZm8oKSkpCi0g ICAgICAgICAgICBibG9iQnVpbGRlci5hcHBlbmQodG9BcnJheUJ1ZmZlclZpZXcoaXRlbSkpOwor ICAgICAgICBpZiAoQXJyYXlCdWZmZXIqIGFycmF5QnVmZmVyID0gdG9BcnJheUJ1ZmZlcihpdGVt KSkKKyAgICAgICAgICAgIGJsb2JCdWlsZGVyLmFwcGVuZChhcnJheUJ1ZmZlcik7CisgICAgICAg IGVsc2UgaWYgKFJlZlB0cjxBcnJheUJ1ZmZlclZpZXc+IGFycmF5QnVmZmVyVmlldyA9IHRvQXJy YXlCdWZmZXJWaWV3KGl0ZW0pKQorICAgICAgICAgICAgYmxvYkJ1aWxkZXIuYXBwZW5kKGFycmF5 QnVmZmVyVmlldyk7CiAgICAgICAgIGVsc2UKICNlbmRpZgotICAgICAgICBpZiAoaXRlbS5pbmhl cml0cyhKU0Jsb2I6OmluZm8oKSkpCi0gICAgICAgICAgICBibG9iQnVpbGRlci5hcHBlbmQodG9C bG9iKGl0ZW0pKTsKKyAgICAgICAgaWYgKEJsb2IqIGJsb2IgPSB0b0Jsb2IoaXRlbSkpCisgICAg ICAgICAgICBibG9iQnVpbGRlci5hcHBlbmQoYmxvYik7CiAgICAgICAgIGVsc2UgewogICAgICAg ICAgICAgU3RyaW5nIHN0cmluZyA9IGl0ZW0udG9TdHJpbmcoZXhlYyktPnZhbHVlKGV4ZWMpOwog ICAgICAgICAgICAgaWYgKGV4ZWMtPmhhZEV4Y2VwdGlvbigpKQpJbmRleDogTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24g MTU5MjgxKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTMtMTEtMTQgIFZpY3RvciBDb3N0YW4gIDxjb3N0YW5AZ21haWwuY29tPgor CisgICAgICAgIENsZWFuIHVwIHNlcXVlbmNlIGhhbmRsaW5nIGluIEJsb2IgY29uc3RydWN0b3IK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDM0Mwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9m aWxlcy9ibG9iLWNvbnN0cnVjdG9yLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBmYXN0L2ZpbGVz L3NjcmlwdC10ZXN0cy9ibG9iLWNvbnN0cnVjdG9yLmpzOgorICAgICAgICAgICAgQWRkIHRlc3Qg d2l0aCBzZXF1ZW5jZSB0aGF0IHRocm93cyBhbiBlcnJvciBvbiBwcm9wZXJ0eSBhY2Nlc3MuCisg ICAgICAgIChnZXQgT2JqZWN0KToKKwogMjAxMy0xMS0xNCAgU3VuLXdvbyBOYW0gIDxzdW5ueS5u YW1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF0gTGF5b3V0IHRlc3RzIHdpdGggdGV4dCBh cmVhcyBuZWVkIHRvIGJlIHJlYmFzZWxpbmVkLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9maWxl cy9ibG9iLWNvbnN0cnVjdG9yLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9mYXN0L2ZpbGVzL2Jsb2ItY29uc3RydWN0b3ItZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAxNTky ODEpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2ZpbGVzL2Jsb2ItY29uc3RydWN0b3ItZXhwZWN0ZWQu dHh0CSh3b3JraW5nIGNvcHkpCkBAIC03OCw2ICs3OCw3IEBAIFBBU1MgbmV3IEJsb2Ioe2xlbmd0 aDogMSwgMDogJ3N0cmluZyd9KS4KIFBBU1MgbmV3IEJsb2Ioe2xlbmd0aDogMiwgMDogbmV3IFVp bnQ4QXJyYXkoMTAwKSwgMTogbmV3IEludDE2QXJyYXkoMTAwKX0pLnNpemUgaXMgMzAwCiBQQVNT IG5ldyBCbG9iKHtsZW5ndGg6IDEsIDA6ICdzdHJpbmcnfSwge3R5cGU6ICd0ZXh0L2h0bWwnfSku dHlwZSBpcyAndGV4dC9odG1sJwogUEFTUyBuZXcgQmxvYih7bGVuZ3RoOiAwfSwge2VuZGluZ3M6 J2lsbGVnYWwnfSkgdGhyZXcgZXhjZXB0aW9uIFR5cGVFcnJvcjogVGhlIGVuZGluZ3MgcHJvcGVy dHkgbXVzdCBiZSBlaXRoZXIgInRyYW5zcGFyZW50IiBvciAibmF0aXZlIi4KK1BBU1MgbmV3IEJs b2IodGhyb3dpbmdTZXF1ZW5jZSkgdGhyZXcgZXhjZXB0aW9uIEVycm9yOiBNaXNiZWhhdmluZyBw cm9wZXJ0eS4KIFBBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKIAogVEVTVCBDT01QTEVU RQpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9maWxlcy9zY3JpcHQtdGVzdHMvYmxvYi1jb25zdHJ1 Y3Rvci5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2ZpbGVzL3NjcmlwdC10ZXN0 cy9ibG9iLWNvbnN0cnVjdG9yLmpzCShyZXZpc2lvbiAxNTkyODEpCisrKyBMYXlvdXRUZXN0cy9m YXN0L2ZpbGVzL3NjcmlwdC10ZXN0cy9ibG9iLWNvbnN0cnVjdG9yLmpzCSh3b3JraW5nIGNvcHkp CkBAIC0xMDYsMyArMTA2LDE1IEBAIHNob3VsZEJlKCJuZXcgQmxvYih7bGVuZ3RoOiAxLCAwOiAn c3RyaW4KIHNob3VsZEJlKCJuZXcgQmxvYih7bGVuZ3RoOiAyLCAwOiBuZXcgVWludDhBcnJheSgx MDApLCAxOiBuZXcgSW50MTZBcnJheSgxMDApfSkuc2l6ZSIsICIzMDAiKTsKIHNob3VsZEJlKCJu ZXcgQmxvYih7bGVuZ3RoOiAxLCAwOiAnc3RyaW5nJ30sIHt0eXBlOiAndGV4dC9odG1sJ30pLnR5 cGUiLCAiJ3RleHQvaHRtbCciKTsKIHNob3VsZFRocm93KCJuZXcgQmxvYih7bGVuZ3RoOiAwfSwg e2VuZGluZ3M6J2lsbGVnYWwnfSkiLCAiJ1R5cGVFcnJvcjogVGhlIGVuZGluZ3MgcHJvcGVydHkg bXVzdCBiZSBlaXRoZXIgXCJ0cmFuc3BhcmVudFwiIG9yIFwibmF0aXZlXCInIik7CisKKy8vIFRl c3QgcGFzc2luZyBibG9nIHBhcnRzIGluIGEgc2VxdWVuY2UtbGlrZSBvYmplY3QgdGhhdCB0aHJv d3Mgb24gcHJvcGVydHkgYWNjZXNzLgordmFyIHRocm93aW5nU2VxdWVuY2UgPSB7bGVuZ3RoOiA0 LCAwOiAnaGVsbG8nLCAzOiAnd29ybGQnfTsKK09iamVjdC5kZWZpbmVQcm9wZXJ0eSh0aHJvd2lu Z1NlcXVlbmNlLCAiMSIsIHsKKyAgICBnZXQ6IGZ1bmN0aW9uKCkgeyB0aHJvdyBuZXcgRXJyb3Io Ik1pc2JlaGF2aW5nIHByb3BlcnR5Iik7IH0sCisgICAgZW51bWVyYWJsZTogdHJ1ZSwgY29uZmln dXJhYmxlOiB0cnVlCit9KTsKK09iamVjdC5kZWZpbmVQcm9wZXJ0eSh0aHJvd2luZ1NlcXVlbmNl LCAiMiIsIHsKKyAgICBnZXQ6IGZ1bmN0aW9uKCkgeyB0aHJvdyBuZXcgRXJyb3IoIlRoaXMgc2hv dWxkIG5vdCBiZSB0aHJvd24iKTsgfSwKKyAgICBlbnVtZXJhYmxlOiB0cnVlLCBjb25maWd1cmFi bGU6IHRydWUKK30pOworc2hvdWxkVGhyb3coIm5ldyBCbG9iKHRocm93aW5nU2VxdWVuY2UpIiwg IidFcnJvcjogTWlzYmVoYXZpbmcgcHJvcGVydHknIik7Cg== 216991 2013-11-14 15:53:34 -0800 2013-11-14 16:16:05 -0800 Patch bug-124343-20131114185333.patch text/plain 4854 costan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1OTMxMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEzLTExLTE0ICBWaWN0b3Ig Q29zdGFuICA8Y29zdGFuQGdtYWlsLmNvbT4KKworICAgICAgICBDbGVhbiB1cCBzZXF1ZW5jZSBo YW5kbGluZyBpbiBCbG9iIGNvbnN0cnVjdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQzNDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBZGRlZCB0ZXN0IGNhc2UgdG8gTGF5b3V0VGVzdHMvZmFzdC9m aWxlcy9ibG9iLWNvbnN0cnVjdG9yLmh0bWwKKworICAgICAgICAqIGJpbmRpbmdzL2pzL0pTQmxv YkN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpKU0Jsb2JDb25zdHJ1Y3Rvcjo6Y29uc3Ry dWN0SlNCbG9iKToKKyAgICAgICAgICAgIEhhbmRsZSBleGNlcHRpb25zIGluIHNlcXVlbmNlcywg ZWxpbWluYXRlIGRvdWJsZSB0eXBlLWNoZWNraW5nIGZvcgorICAgICAgICAgICAgQXJyYXlCdWZm ZXIsIEFycmF5QnVmZmVyVmlldyBhbmQgQmxvYiBwYXJ0cy4KKwogMjAxMy0xMS0xNCAgQWxleGV5 IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBJbXBsZW1lbnQgcmF3IGZv cm1hdCBmb3IgV2ViQ3J5cHRvIGtleSBleHBvcnQKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL2pzL0pTQmxvYkN1c3RvbS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvanMvSlNCbG9iQ3VzdG9tLmNwcAkocmV2aXNpb24gMTU5MzEwKQorKysgU291cmNlL1dl YkNvcmUvYmluZGluZ3MvanMvSlNCbG9iQ3VzdG9tLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTE0 LDE1ICsxMTQsMTggQEAgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBKU0Jsb2JDb25zdAog CiAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IGJsb2JQYXJ0c0xlbmd0aDsgKytpKSB7CiAg ICAgICAgIEpTVmFsdWUgaXRlbSA9IGJsb2JQYXJ0cy0+Z2V0KGV4ZWMsIGkpOworICAgICAgICBp ZiAoZXhlYy0+aGFkRXhjZXB0aW9uKCkpCisgICAgICAgICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5j b2RlKGpzVW5kZWZpbmVkKCkpOworCiAjaWYgRU5BQkxFKEJMT0IpCi0gICAgICAgIGlmIChpdGVt LmluaGVyaXRzKEpTQXJyYXlCdWZmZXI6OmluZm8oKSkpCi0gICAgICAgICAgICBibG9iQnVpbGRl ci5hcHBlbmQodG9BcnJheUJ1ZmZlcihpdGVtKSk7Ci0gICAgICAgIGVsc2UgaWYgKGl0ZW0uaW5o ZXJpdHMoSlNBcnJheUJ1ZmZlclZpZXc6OmluZm8oKSkpCi0gICAgICAgICAgICBibG9iQnVpbGRl ci5hcHBlbmQodG9BcnJheUJ1ZmZlclZpZXcoaXRlbSkpOworICAgICAgICBpZiAoQXJyYXlCdWZm ZXIqIGFycmF5QnVmZmVyID0gdG9BcnJheUJ1ZmZlcihpdGVtKSkKKyAgICAgICAgICAgIGJsb2JC dWlsZGVyLmFwcGVuZChhcnJheUJ1ZmZlcik7CisgICAgICAgIGVsc2UgaWYgKFJlZlB0cjxBcnJh eUJ1ZmZlclZpZXc+IGFycmF5QnVmZmVyVmlldyA9IHRvQXJyYXlCdWZmZXJWaWV3KGl0ZW0pKQor ICAgICAgICAgICAgYmxvYkJ1aWxkZXIuYXBwZW5kKGFycmF5QnVmZmVyVmlldy5yZWxlYXNlKCkp OwogICAgICAgICBlbHNlCiAjZW5kaWYKLSAgICAgICAgaWYgKGl0ZW0uaW5oZXJpdHMoSlNCbG9i OjppbmZvKCkpKQotICAgICAgICAgICAgYmxvYkJ1aWxkZXIuYXBwZW5kKHRvQmxvYihpdGVtKSk7 CisgICAgICAgIGlmIChCbG9iKiBibG9iID0gdG9CbG9iKGl0ZW0pKQorICAgICAgICAgICAgYmxv YkJ1aWxkZXIuYXBwZW5kKGJsb2IpOwogICAgICAgICBlbHNlIHsKICAgICAgICAgICAgIFN0cmlu ZyBzdHJpbmcgPSBpdGVtLnRvU3RyaW5nKGV4ZWMpLT52YWx1ZShleGVjKTsKICAgICAgICAgICAg IGlmIChleGVjLT5oYWRFeGNlcHRpb24oKSkKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1OTMxMCkKKysr IExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisy MDEzLTExLTE0ICBWaWN0b3IgQ29zdGFuICA8Y29zdGFuQGdtYWlsLmNvbT4KKworICAgICAgICBD bGVhbiB1cCBzZXF1ZW5jZSBoYW5kbGluZyBpbiBCbG9iIGNvbnN0cnVjdG9yCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQzNDMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvZmlsZXMvYmxvYi1j b25zdHJ1Y3Rvci1leHBlY3RlZC50eHQ6CisgICAgICAgICogZmFzdC9maWxlcy9zY3JpcHQtdGVz dHMvYmxvYi1jb25zdHJ1Y3Rvci5qczoKKyAgICAgICAgICAgIEFkZCB0ZXN0IHdpdGggc2VxdWVu Y2UgdGhhdCB0aHJvd3MgYW4gZXJyb3Igb24gcHJvcGVydHkgYWNjZXNzLgorICAgICAgICAoZ2V0 IE9iamVjdCk6CisKIDIwMTMtMTEtMTQgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5j b20+CiAKICAgICAgICAgSW1wbGVtZW50IHJhdyBmb3JtYXQgZm9yIFdlYkNyeXB0byBrZXkgZXhw b3J0CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2ZpbGVzL2Jsb2ItY29uc3RydWN0b3ItZXhwZWN0 ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZmlsZXMvYmxvYi1jb25zdHJ1 Y3Rvci1leHBlY3RlZC50eHQJKHJldmlzaW9uIDE1OTMxMCkKKysrIExheW91dFRlc3RzL2Zhc3Qv ZmlsZXMvYmxvYi1jb25zdHJ1Y3Rvci1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTc4 LDYgKzc4LDcgQEAgUEFTUyBuZXcgQmxvYih7bGVuZ3RoOiAxLCAwOiAnc3RyaW5nJ30pLgogUEFT UyBuZXcgQmxvYih7bGVuZ3RoOiAyLCAwOiBuZXcgVWludDhBcnJheSgxMDApLCAxOiBuZXcgSW50 MTZBcnJheSgxMDApfSkuc2l6ZSBpcyAzMDAKIFBBU1MgbmV3IEJsb2Ioe2xlbmd0aDogMSwgMDog J3N0cmluZyd9LCB7dHlwZTogJ3RleHQvaHRtbCd9KS50eXBlIGlzICd0ZXh0L2h0bWwnCiBQQVNT IG5ldyBCbG9iKHtsZW5ndGg6IDB9LCB7ZW5kaW5nczonaWxsZWdhbCd9KSB0aHJldyBleGNlcHRp b24gVHlwZUVycm9yOiBUaGUgZW5kaW5ncyBwcm9wZXJ0eSBtdXN0IGJlIGVpdGhlciAidHJhbnNw YXJlbnQiIG9yICJuYXRpdmUiLgorUEFTUyBuZXcgQmxvYih0aHJvd2luZ1NlcXVlbmNlKSB0aHJl dyBleGNlcHRpb24gRXJyb3I6IE1pc2JlaGF2aW5nIHByb3BlcnR5LgogUEFTUyBzdWNjZXNzZnVs bHlQYXJzZWQgaXMgdHJ1ZQogCiBURVNUIENPTVBMRVRFCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0 L2ZpbGVzL3NjcmlwdC10ZXN0cy9ibG9iLWNvbnN0cnVjdG9yLmpzCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL2Zhc3QvZmlsZXMvc2NyaXB0LXRlc3RzL2Jsb2ItY29uc3RydWN0b3IuanMJKHJl dmlzaW9uIDE1OTMxMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZmlsZXMvc2NyaXB0LXRlc3RzL2Js b2ItY29uc3RydWN0b3IuanMJKHdvcmtpbmcgY29weSkKQEAgLTEwNiwzICsxMDYsMTUgQEAgc2hv dWxkQmUoIm5ldyBCbG9iKHtsZW5ndGg6IDEsIDA6ICdzdHJpbgogc2hvdWxkQmUoIm5ldyBCbG9i KHtsZW5ndGg6IDIsIDA6IG5ldyBVaW50OEFycmF5KDEwMCksIDE6IG5ldyBJbnQxNkFycmF5KDEw MCl9KS5zaXplIiwgIjMwMCIpOwogc2hvdWxkQmUoIm5ldyBCbG9iKHtsZW5ndGg6IDEsIDA6ICdz dHJpbmcnfSwge3R5cGU6ICd0ZXh0L2h0bWwnfSkudHlwZSIsICIndGV4dC9odG1sJyIpOwogc2hv dWxkVGhyb3coIm5ldyBCbG9iKHtsZW5ndGg6IDB9LCB7ZW5kaW5nczonaWxsZWdhbCd9KSIsICIn VHlwZUVycm9yOiBUaGUgZW5kaW5ncyBwcm9wZXJ0eSBtdXN0IGJlIGVpdGhlciBcInRyYW5zcGFy ZW50XCIgb3IgXCJuYXRpdmVcIiciKTsKKworLy8gVGVzdCBwYXNzaW5nIGJsb2cgcGFydHMgaW4g YSBzZXF1ZW5jZS1saWtlIG9iamVjdCB0aGF0IHRocm93cyBvbiBwcm9wZXJ0eSBhY2Nlc3MuCit2 YXIgdGhyb3dpbmdTZXF1ZW5jZSA9IHtsZW5ndGg6IDQsIDA6ICdoZWxsbycsIDM6ICd3b3JsZCd9 OworT2JqZWN0LmRlZmluZVByb3BlcnR5KHRocm93aW5nU2VxdWVuY2UsICIxIiwgeworICAgIGdl dDogZnVuY3Rpb24oKSB7IHRocm93IG5ldyBFcnJvcigiTWlzYmVoYXZpbmcgcHJvcGVydHkiKTsg fSwKKyAgICBlbnVtZXJhYmxlOiB0cnVlLCBjb25maWd1cmFibGU6IHRydWUKK30pOworT2JqZWN0 LmRlZmluZVByb3BlcnR5KHRocm93aW5nU2VxdWVuY2UsICIyIiwgeworICAgIGdldDogZnVuY3Rp b24oKSB7IHRocm93IG5ldyBFcnJvcigiVGhpcyBzaG91bGQgbm90IGJlIHRocm93biIpOyB9LAor ICAgIGVudW1lcmFibGU6IHRydWUsIGNvbmZpZ3VyYWJsZTogdHJ1ZQorfSk7CitzaG91bGRUaHJv dygibmV3IEJsb2IodGhyb3dpbmdTZXF1ZW5jZSkiLCAiJ0Vycm9yOiBNaXNiZWhhdmluZyBwcm9w ZXJ0eSciKTsK 216995 2013-11-14 16:16:11 -0800 2013-11-14 16:53:33 -0800 Patch bug-124343-20131114191610.patch text/plain 4864 costan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE1OTMxMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEzLTExLTE0ICBWaWN0b3Ig Q29zdGFuICA8Y29zdGFuQGdtYWlsLmNvbT4KKworICAgICAgICBDbGVhbiB1cCBzZXF1ZW5jZSBo YW5kbGluZyBpbiBCbG9iIGNvbnN0cnVjdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQzNDMKKworICAgICAgICBSZXZpZXdlZCBieSBBbGV4ZXkg UHJvc2t1cnlha292LgorCisgICAgICAgIEFkZGVkIHRlc3QgY2FzZSB0byBMYXlvdXRUZXN0cy9m YXN0L2ZpbGVzL2Jsb2ItY29uc3RydWN0b3IuaHRtbAorCisgICAgICAgICogYmluZGluZ3MvanMv SlNCbG9iQ3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkpTQmxvYkNvbnN0cnVjdG9yOjpj b25zdHJ1Y3RKU0Jsb2IpOgorICAgICAgICAgICAgSGFuZGxlIGV4Y2VwdGlvbnMgaW4gc2VxdWVu Y2VzLCBlbGltaW5hdGUgZG91YmxlIHR5cGUtY2hlY2tpbmcgZm9yCisgICAgICAgICAgICBBcnJh eUJ1ZmZlciwgQXJyYXlCdWZmZXJWaWV3IGFuZCBCbG9iIHBhcnRzLgorCiAyMDEzLTExLTE0ICBB bGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIEltcGxlbWVudCBy YXcgZm9ybWF0IGZvciBXZWJDcnlwdG8ga2V5IGV4cG9ydApJbmRleDogU291cmNlL1dlYkNvcmUv YmluZGluZ3MvanMvSlNCbG9iQ3VzdG9tLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9qcy9KU0Jsb2JDdXN0b20uY3BwCShyZXZpc2lvbiAxNTkzMTApCisrKyBTb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0Jsb2JDdXN0b20uY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0xMTQsMTUgKzExNCwxOCBAQCBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIEpTQmxvYkNv bnN0CiAKICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgYmxvYlBhcnRzTGVuZ3RoOyArK2kp IHsKICAgICAgICAgSlNWYWx1ZSBpdGVtID0gYmxvYlBhcnRzLT5nZXQoZXhlYywgaSk7CisgICAg ICAgIGlmIChleGVjLT5oYWRFeGNlcHRpb24oKSkKKyAgICAgICAgICAgIHJldHVybiBKU1ZhbHVl OjplbmNvZGUoanNVbmRlZmluZWQoKSk7CisKICNpZiBFTkFCTEUoQkxPQikKLSAgICAgICAgaWYg KGl0ZW0uaW5oZXJpdHMoSlNBcnJheUJ1ZmZlcjo6aW5mbygpKSkKLSAgICAgICAgICAgIGJsb2JC dWlsZGVyLmFwcGVuZCh0b0FycmF5QnVmZmVyKGl0ZW0pKTsKLSAgICAgICAgZWxzZSBpZiAoaXRl bS5pbmhlcml0cyhKU0FycmF5QnVmZmVyVmlldzo6aW5mbygpKSkKLSAgICAgICAgICAgIGJsb2JC dWlsZGVyLmFwcGVuZCh0b0FycmF5QnVmZmVyVmlldyhpdGVtKSk7CisgICAgICAgIGlmIChBcnJh eUJ1ZmZlciogYXJyYXlCdWZmZXIgPSB0b0FycmF5QnVmZmVyKGl0ZW0pKQorICAgICAgICAgICAg YmxvYkJ1aWxkZXIuYXBwZW5kKGFycmF5QnVmZmVyKTsKKyAgICAgICAgZWxzZSBpZiAoUmVmUHRy PEFycmF5QnVmZmVyVmlldz4gYXJyYXlCdWZmZXJWaWV3ID0gdG9BcnJheUJ1ZmZlclZpZXcoaXRl bSkpCisgICAgICAgICAgICBibG9iQnVpbGRlci5hcHBlbmQoYXJyYXlCdWZmZXJWaWV3LnJlbGVh c2UoKSk7CiAgICAgICAgIGVsc2UKICNlbmRpZgotICAgICAgICBpZiAoaXRlbS5pbmhlcml0cyhK U0Jsb2I6OmluZm8oKSkpCi0gICAgICAgICAgICBibG9iQnVpbGRlci5hcHBlbmQodG9CbG9iKGl0 ZW0pKTsKKyAgICAgICAgaWYgKEJsb2IqIGJsb2IgPSB0b0Jsb2IoaXRlbSkpCisgICAgICAgICAg ICBibG9iQnVpbGRlci5hcHBlbmQoYmxvYik7CiAgICAgICAgIGVsc2UgewogICAgICAgICAgICAg U3RyaW5nIHN0cmluZyA9IGl0ZW0udG9TdHJpbmcoZXhlYyktPnZhbHVlKGV4ZWMpOwogICAgICAg ICAgICAgaWYgKGV4ZWMtPmhhZEV4Y2VwdGlvbigpKQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTU5MzEw KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTMtMTEtMTQgIFZpY3RvciBDb3N0YW4gIDxjb3N0YW5AZ21haWwuY29tPgorCisgICAg ICAgIENsZWFuIHVwIHNlcXVlbmNlIGhhbmRsaW5nIGluIEJsb2IgY29uc3RydWN0b3IKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNDM0MworCisgICAg ICAgIFJldmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCisKKyAgICAgICAgKiBmYXN0L2Zp bGVzL2Jsb2ItY29uc3RydWN0b3ItZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZhc3QvZmlsZXMv c2NyaXB0LXRlc3RzL2Jsb2ItY29uc3RydWN0b3IuanM6CisgICAgICAgICAgICBBZGQgdGVzdCB3 aXRoIHNlcXVlbmNlIHRoYXQgdGhyb3dzIGFuIGVycm9yIG9uIHByb3BlcnR5IGFjY2Vzcy4KKyAg ICAgICAgKGdldCBPYmplY3QpOgorCiAyMDEzLTExLTE0ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8 YXBAYXBwbGUuY29tPgogCiAgICAgICAgIEltcGxlbWVudCByYXcgZm9ybWF0IGZvciBXZWJDcnlw dG8ga2V5IGV4cG9ydApJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9maWxlcy9ibG9iLWNvbnN0cnVj dG9yLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2ZpbGVzL2Js b2ItY29uc3RydWN0b3ItZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAxNTkzMTApCisrKyBMYXlvdXRU ZXN0cy9mYXN0L2ZpbGVzL2Jsb2ItY29uc3RydWN0b3ItZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNv cHkpCkBAIC03OCw2ICs3OCw3IEBAIFBBU1MgbmV3IEJsb2Ioe2xlbmd0aDogMSwgMDogJ3N0cmlu Zyd9KS4KIFBBU1MgbmV3IEJsb2Ioe2xlbmd0aDogMiwgMDogbmV3IFVpbnQ4QXJyYXkoMTAwKSwg MTogbmV3IEludDE2QXJyYXkoMTAwKX0pLnNpemUgaXMgMzAwCiBQQVNTIG5ldyBCbG9iKHtsZW5n dGg6IDEsIDA6ICdzdHJpbmcnfSwge3R5cGU6ICd0ZXh0L2h0bWwnfSkudHlwZSBpcyAndGV4dC9o dG1sJwogUEFTUyBuZXcgQmxvYih7bGVuZ3RoOiAwfSwge2VuZGluZ3M6J2lsbGVnYWwnfSkgdGhy ZXcgZXhjZXB0aW9uIFR5cGVFcnJvcjogVGhlIGVuZGluZ3MgcHJvcGVydHkgbXVzdCBiZSBlaXRo ZXIgInRyYW5zcGFyZW50IiBvciAibmF0aXZlIi4KK1BBU1MgbmV3IEJsb2IodGhyb3dpbmdTZXF1 ZW5jZSkgdGhyZXcgZXhjZXB0aW9uIEVycm9yOiBNaXNiZWhhdmluZyBwcm9wZXJ0eS4KIFBBU1Mg c3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKIAogVEVTVCBDT01QTEVURQpJbmRleDogTGF5b3V0 VGVzdHMvZmFzdC9maWxlcy9zY3JpcHQtdGVzdHMvYmxvYi1jb25zdHJ1Y3Rvci5qcwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2ZpbGVzL3NjcmlwdC10ZXN0cy9ibG9iLWNvbnN0cnVj dG9yLmpzCShyZXZpc2lvbiAxNTkzMTApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2ZpbGVzL3Njcmlw dC10ZXN0cy9ibG9iLWNvbnN0cnVjdG9yLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0xMDYsMyArMTA2 LDE1IEBAIHNob3VsZEJlKCJuZXcgQmxvYih7bGVuZ3RoOiAxLCAwOiAnc3RyaW4KIHNob3VsZEJl KCJuZXcgQmxvYih7bGVuZ3RoOiAyLCAwOiBuZXcgVWludDhBcnJheSgxMDApLCAxOiBuZXcgSW50 MTZBcnJheSgxMDApfSkuc2l6ZSIsICIzMDAiKTsKIHNob3VsZEJlKCJuZXcgQmxvYih7bGVuZ3Ro OiAxLCAwOiAnc3RyaW5nJ30sIHt0eXBlOiAndGV4dC9odG1sJ30pLnR5cGUiLCAiJ3RleHQvaHRt bCciKTsKIHNob3VsZFRocm93KCJuZXcgQmxvYih7bGVuZ3RoOiAwfSwge2VuZGluZ3M6J2lsbGVn YWwnfSkiLCAiJ1R5cGVFcnJvcjogVGhlIGVuZGluZ3MgcHJvcGVydHkgbXVzdCBiZSBlaXRoZXIg XCJ0cmFuc3BhcmVudFwiIG9yIFwibmF0aXZlXCInIik7CisKKy8vIFRlc3QgcGFzc2luZyBibG9n IHBhcnRzIGluIGEgc2VxdWVuY2UtbGlrZSBvYmplY3QgdGhhdCB0aHJvd3Mgb24gcHJvcGVydHkg YWNjZXNzLgordmFyIHRocm93aW5nU2VxdWVuY2UgPSB7bGVuZ3RoOiA0LCAwOiAnaGVsbG8nLCAz OiAnd29ybGQnfTsKK09iamVjdC5kZWZpbmVQcm9wZXJ0eSh0aHJvd2luZ1NlcXVlbmNlLCAiMSIs IHsKKyAgICBnZXQ6IGZ1bmN0aW9uKCkgeyB0aHJvdyBuZXcgRXJyb3IoIk1pc2JlaGF2aW5nIHBy b3BlcnR5Iik7IH0sCisgICAgZW51bWVyYWJsZTogdHJ1ZSwgY29uZmlndXJhYmxlOiB0cnVlCit9 KTsKK09iamVjdC5kZWZpbmVQcm9wZXJ0eSh0aHJvd2luZ1NlcXVlbmNlLCAiMiIsIHsKKyAgICBn ZXQ6IGZ1bmN0aW9uKCkgeyB0aHJvdyBuZXcgRXJyb3IoIlRoaXMgc2hvdWxkIG5vdCBiZSB0aHJv d24iKTsgfSwKKyAgICBlbnVtZXJhYmxlOiB0cnVlLCBjb25maWd1cmFibGU6IHRydWUKK30pOwor c2hvdWxkVGhyb3coIm5ldyBCbG9iKHRocm93aW5nU2VxdWVuY2UpIiwgIidFcnJvcjogTWlzYmVo YXZpbmcgcHJvcGVydHknIik7Cg==