124341 2013-11-14 02:30:16 -0800 Generate toSVGPolyline|gonElement() to replace static_cast<> 2013-11-14 03:23:35 -0800 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim commit-queue d-r esprehn+autocc fmalita glenn gyuyoung.kim kling kondapallykalyan pdr schenney zimmermann oldest_to_newest 950574 0 gyuyoung.kim 2013-11-14 02:30:16 -0800 toSVGFoo() supports more plenty helper functions. So, toSVGFoo() needs to be used instead of static_cast<>. 950575 1 216912 gyuyoung.kim 2013-11-14 02:31:37 -0800 Created attachment 216912 Patch 950585 2 216912 commit-queue 2013-11-14 03:23:32 -0800 Comment on attachment 216912 Patch Clearing flags on attachment: 216912 Committed r159281: <http://trac.webkit.org/changeset/159281> 950586 3 commit-queue 2013-11-14 03:23:35 -0800 All reviewed patches have been landed. Closing bug. 216912 2013-11-14 02:31:37 -0800 2013-11-14 03:23:31 -0800 Patch bug-124341-20131114193135.patch text/plain 5139 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5Mjc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjRjMzNiOTI4MmZkNTBj NzRjNWE5ODA5NDMxNzExY2ZlMjFkZWE1Ny4uMWUxNzQ0ZTAzMGU5ZjZkMjNiZjcwNjY0ZTYyNTY2 MGZkYzk4MmRiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI4IEBACiAyMDEzLTExLTE0ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CiAKKyAgICAgICAgR2VuZXJhdGUg dG9TVkdQb2x5bGluZXxnb25FbGVtZW50KCkgdG8gcmVwbGFjZSBzdGF0aWNfY2FzdDw+CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQzNDEKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICB0b1NWR0ZvbygpIHN1 cHBvcnRzIG1vcmUgcGxlbnR5IGhlbHBlciBmdW5jdGlvbnMuIFNvLCB0b1NWR0ZvbygpIG5lZWRz CisgICAgICAgIHRvIGJlIHVzZWQgaW5zdGVhZCBvZiBzdGF0aWNfY2FzdDw+LgorCisgICAgICAg IEFkZGl0aW9uYWxseSwgY2xlYW51cCBvdGhlciBzdGF0aWNfY2FzdDw+IGFzIHdlbGwuCisKKyAg ICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBjaGFuZ2VzLgorCisgICAgICAgICogcmVu ZGVyaW5nL3N2Zy9TVkdQYXRoRGF0YS5jcHA6CisgICAgICAgIChXZWJDb3JlOjp1cGRhdGVQYXRo RnJvbUVsbGlwc2VFbGVtZW50KToKKyAgICAgICAgKFdlYkNvcmU6OnVwZGF0ZVBhdGhGcm9tTGlu ZUVsZW1lbnQpOgorICAgICAgICAoV2ViQ29yZTo6dXBkYXRlUGF0aEZyb21Qb2x5Z29uRWxlbWVu dCk6CisgICAgICAgIChXZWJDb3JlOjp1cGRhdGVQYXRoRnJvbVBvbHlsaW5lRWxlbWVudCk6Cisg ICAgICAgICogc3ZnL1NWR1BvbHlnb25FbGVtZW50Lmg6CisgICAgICAgICogc3ZnL1NWR1BvbHls aW5lRWxlbWVudC5oOgorICAgICAgICAqIHN2Zy9zdmd0YWdzLmluOiBBZGQgKmdlbmVyYXRlVHlw ZUhlbHBlcnMqIGtleXdvcmQgdG8gcG9seWdvbiwgcG9seWxpbmUKKworMjAxMy0xMS0xNCAgR3l1 eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgorCiAgICAgICAgIEludHJvZHVj ZSBGSUxURVJfVFlQRV9DQVNUUyBmb3IgY2hpbGQgZmlsdGVyIGNsYXNzCiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjQzMzIKIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9TVkdQYXRoRGF0YS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvc3ZnL1NWR1BhdGhEYXRhLmNwcAppbmRleCAwNGUyMTIxMTk1ODBkODI5 ZmU3NmVmYjMwODExY2ViNmQzYjZiZmUyLi42N2M0ZjUyMzgyMmY0M2U4MDdkNWNkYjc3NDc3NTRk ZDQ1ZTVhNTE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1NWR1Bh dGhEYXRhLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1NWR1BhdGhEYXRh LmNwcApAQCAtNDgsOCArNDgsNyBAQCBzdGF0aWMgdm9pZCB1cGRhdGVQYXRoRnJvbUNpcmNsZUVs ZW1lbnQoU1ZHRWxlbWVudCogZWxlbWVudCwgUGF0aCYgcGF0aCkKIAogc3RhdGljIHZvaWQgdXBk YXRlUGF0aEZyb21FbGxpcHNlRWxlbWVudChTVkdFbGVtZW50KiBlbGVtZW50LCBQYXRoJiBwYXRo KQogewotICAgIEFTU0VSVF9XSVRIX1NFQ1VSSVRZX0lNUExJQ0FUSU9OKGVsZW1lbnQtPmhhc1Rh Z05hbWUoU1ZHTmFtZXM6OmVsbGlwc2VUYWcpKTsKLSAgICBTVkdFbGxpcHNlRWxlbWVudCogZWxs aXBzZSA9IHN0YXRpY19jYXN0PFNWR0VsbGlwc2VFbGVtZW50Kj4oZWxlbWVudCk7CisgICAgU1ZH RWxsaXBzZUVsZW1lbnQqIGVsbGlwc2UgPSB0b1NWR0VsbGlwc2VFbGVtZW50KGVsZW1lbnQpOwog CiAgICAgU1ZHTGVuZ3RoQ29udGV4dCBsZW5ndGhDb250ZXh0KGVsZW1lbnQpOwogICAgIGZsb2F0 IHJ4ID0gZWxsaXBzZS0+cngoKS52YWx1ZShsZW5ndGhDb250ZXh0KTsKQEAgLTYzLDggKzYyLDcg QEAgc3RhdGljIHZvaWQgdXBkYXRlUGF0aEZyb21FbGxpcHNlRWxlbWVudChTVkdFbGVtZW50KiBl bGVtZW50LCBQYXRoJiBwYXRoKQogCiBzdGF0aWMgdm9pZCB1cGRhdGVQYXRoRnJvbUxpbmVFbGVt ZW50KFNWR0VsZW1lbnQqIGVsZW1lbnQsIFBhdGgmIHBhdGgpCiB7Ci0gICAgQVNTRVJUX1dJVEhf U0VDVVJJVFlfSU1QTElDQVRJT04oZWxlbWVudC0+aGFzVGFnTmFtZShTVkdOYW1lczo6bGluZVRh ZykpOwotICAgIFNWR0xpbmVFbGVtZW50KiBsaW5lID0gc3RhdGljX2Nhc3Q8U1ZHTGluZUVsZW1l bnQqPihlbGVtZW50KTsKKyAgICBTVkdMaW5lRWxlbWVudCogbGluZSA9IHRvU1ZHTGluZUVsZW1l bnQoZWxlbWVudCk7CiAKICAgICBTVkdMZW5ndGhDb250ZXh0IGxlbmd0aENvbnRleHQoZWxlbWVu dCk7CiAgICAgcGF0aC5tb3ZlVG8oRmxvYXRQb2ludChsaW5lLT54MSgpLnZhbHVlKGxlbmd0aENv bnRleHQpLCBsaW5lLT55MSgpLnZhbHVlKGxlbmd0aENvbnRleHQpKSk7CkBAIC03OCwxMCArNzYs NyBAQCBzdGF0aWMgdm9pZCB1cGRhdGVQYXRoRnJvbVBhdGhFbGVtZW50KFNWR0VsZW1lbnQqIGVs ZW1lbnQsIFBhdGgmIHBhdGgpCiAKIHN0YXRpYyB2b2lkIHVwZGF0ZVBhdGhGcm9tUG9seWdvbkVs ZW1lbnQoU1ZHRWxlbWVudCogZWxlbWVudCwgUGF0aCYgcGF0aCkKIHsKLSAgICBBU1NFUlRfV0lU SF9TRUNVUklUWV9JTVBMSUNBVElPTihlbGVtZW50LT5oYXNUYWdOYW1lKFNWR05hbWVzOjpwb2x5 Z29uVGFnKSk7Ci0gICAgU1ZHUG9seWdvbkVsZW1lbnQqIHBvbHlnb24gPSBzdGF0aWNfY2FzdDxT VkdQb2x5Z29uRWxlbWVudCo+KGVsZW1lbnQpOwotCi0gICAgU1ZHUG9pbnRMaXN0JiBwb2ludHMg PSBwb2x5Z29uLT5wb2ludExpc3QoKTsKKyAgICBTVkdQb2ludExpc3QmIHBvaW50cyA9IHRvU1ZH UG9seWdvbkVsZW1lbnQoZWxlbWVudCktPnBvaW50TGlzdCgpOwogICAgIGlmIChwb2ludHMuaXNF bXB0eSgpKQogICAgICAgICByZXR1cm47CiAKQEAgLTk2LDEwICs5MSw3IEBAIHN0YXRpYyB2b2lk IHVwZGF0ZVBhdGhGcm9tUG9seWdvbkVsZW1lbnQoU1ZHRWxlbWVudCogZWxlbWVudCwgUGF0aCYg cGF0aCkKIAogc3RhdGljIHZvaWQgdXBkYXRlUGF0aEZyb21Qb2x5bGluZUVsZW1lbnQoU1ZHRWxl bWVudCogZWxlbWVudCwgUGF0aCYgcGF0aCkKIHsKLSAgICBBU1NFUlRfV0lUSF9TRUNVUklUWV9J TVBMSUNBVElPTihlbGVtZW50LT5oYXNUYWdOYW1lKFNWR05hbWVzOjpwb2x5bGluZVRhZykpOwot ICAgIFNWR1BvbHlsaW5lRWxlbWVudCogcG9seWxpbmUgPSBzdGF0aWNfY2FzdDxTVkdQb2x5bGlu ZUVsZW1lbnQqPihlbGVtZW50KTsKLQotICAgIFNWR1BvaW50TGlzdCYgcG9pbnRzID0gcG9seWxp bmUtPnBvaW50TGlzdCgpOworICAgIFNWR1BvaW50TGlzdCYgcG9pbnRzID0gdG9TVkdQb2x5bGlu ZUVsZW1lbnQoZWxlbWVudCktPnBvaW50TGlzdCgpOwogICAgIGlmIChwb2ludHMuaXNFbXB0eSgp KQogICAgICAgICByZXR1cm47CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdQ b2x5Z29uRWxlbWVudC5oIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR1BvbHlnb25FbGVtZW50LmgK aW5kZXggMzc5YjQ1NDY0NGIyYjUzZWE5YmVmMjgxZWE0YTdiM2I3ZmNjMzg2Ny4uMzA5NzhlMGE0 NDcyZTdmYWFkZDA2OWYxNmY5ZjMxZmE4YjBjMWZkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvc3ZnL1NWR1BvbHlnb25FbGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR1Bv bHlnb25FbGVtZW50LmgKQEAgLTM0LDYgKzM0LDggQEAgcHJpdmF0ZToKICAgICBTVkdQb2x5Z29u RWxlbWVudChjb25zdCBRdWFsaWZpZWROYW1lJiwgRG9jdW1lbnQmKTsKIH07CiAKK05PREVfVFlQ RV9DQVNUUyhTVkdQb2x5Z29uRWxlbWVudCkKKwogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQogCiAj ZW5kaWYgLy8gRU5BQkxFKFNWRykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdQ b2x5bGluZUVsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdQb2x5bGluZUVsZW1lbnQu aAppbmRleCA2NmRhYmY0NTNhZGI5N2M0OTgzZjg3MzkyMTQzOTZmMWY5MDkyYzZkLi5lMjdhNmU4 OGNlNzk4YmRmMThjYmIzNzc5NmU0MTVjNGRjYzAyMDdiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9zdmcvU1ZHUG9seWxpbmVFbGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NW R1BvbHlsaW5lRWxlbWVudC5oCkBAIC0zNCw2ICszNCw4IEBAIHByaXZhdGU6CiAgICAgU1ZHUG9s eWxpbmVFbGVtZW50KGNvbnN0IFF1YWxpZmllZE5hbWUmLCBEb2N1bWVudCYpOwogfTsKIAorTk9E RV9UWVBFX0NBU1RTKFNWR1BvbHlsaW5lRWxlbWVudCkKKwogfSAvLyBuYW1lc3BhY2UgV2ViQ29y ZQogCiAjZW5kaWYgLy8gRU5BQkxFKFNWRykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2 Zy9zdmd0YWdzLmluIGIvU291cmNlL1dlYkNvcmUvc3ZnL3N2Z3RhZ3MuaW4KaW5kZXggMjEwYjQw ODcxZTRkN2Y2MWEyZWNkMjNmY2VmM2EzYmIwYTkwYTcxNS4uN2E2ODg2MDQ3ZjE5M2UyOWMxZTY2 Y2U5ZmEyMmFiNTg3MDk2NTU2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3ZnL3N2Z3Rh Z3MuaW4KKysrIGIvU291cmNlL1dlYkNvcmUvc3ZnL3N2Z3RhZ3MuaW4KQEAgLTc5LDggKzc5LDgg QEAgbWlzc2luZ19nbHlwaCBnZW5lcmF0ZVR5cGVIZWxwZXJzCiBtcGF0aCBpbnRlcmZhY2VOYW1l PVNWR01QYXRoRWxlbWVudCwgZ2VuZXJhdGVUeXBlSGVscGVycwogcGF0aCBnZW5lcmF0ZVR5cGVI ZWxwZXJzCiBwYXR0ZXJuIGdlbmVyYXRlVHlwZUhlbHBlcnMKLXBvbHlnb24KLXBvbHlsaW5lCitw b2x5Z29uIGdlbmVyYXRlVHlwZUhlbHBlcnMKK3BvbHlsaW5lIGdlbmVyYXRlVHlwZUhlbHBlcnMK IHJhZGlhbEdyYWRpZW50IGdlbmVyYXRlVHlwZUhlbHBlcnMKIHJlY3QgZ2VuZXJhdGVUeXBlSGVs cGVycwogc2NyaXB0IGNvbnN0cnVjdG9yTmVlZHNDcmVhdGVkQnlQYXJzZXIsIGdlbmVyYXRlVHlw ZUhlbHBlcnMK