124330 2013-11-13 18:54:19 -0800 Web Inspector: InspectorBackendDispatcher improvements 2013-11-13 18:59:23 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck graouts joepeck timothy webkit-bug-importer oldest_to_newest 950481 0 joepeck 2013-11-13 18:54:19 -0800 • Convert the error number vector to a simple int[]. • Use ASCIILiteral where possible. • Fix a style issue. 950482 1 webkit-bug-importer 2013-11-13 18:54:36 -0800 <rdar://problem/15466075> 950483 2 216887 joepeck 2013-11-13 18:56:05 -0800 Created attachment 216887 [PATCH] Proposed Fix 950485 3 joepeck 2013-11-13 18:59:23 -0800 Committed <http://trac.webkit.org/changeset/159272>. 216887 2013-11-13 18:56:05 -0800 2013-11-13 18:57:38 -0800 [PATCH] Proposed Fix improve.patch text/plain 4746 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0MWY0ODI3Li5kZGVkNjRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTgg QEAKIDIwMTMtMTEtMTMgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBJbnNwZWN0b3JCYWNrZW5kRGlzcGF0Y2hlciBpbXByb3Zl bWVudHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy NDMzMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog aW5zcGVjdG9yL0luc3BlY3RvckJhY2tlbmREaXNwYXRjaGVyLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6Okluc3BlY3RvckJhY2tlbmREaXNwYXRjaGVyOjpzZW5kUmVzcG9uc2UpOgorICAgICAgICAo V2ViQ29yZTo6SW5zcGVjdG9yQmFja2VuZERpc3BhdGNoZXI6OnJlcG9ydFByb3RvY29sRXJyb3Ip OgorICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JCYWNrZW5kRGlzcGF0Y2hlci5oOgorICAg ICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yU3VwcGxlbWVudGFsQmFja2VuZERpc3BhdGNoZXI6Oklu c3BlY3RvclN1cHBsZW1lbnRhbEJhY2tlbmREaXNwYXRjaGVyKToKKworMjAxMy0xMS0xMyAgSm9z ZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAgIFVucmV2aWV3ZWQg V2luZG93cyBCdWlsZCBGaXggYWZ0ZXIgcjE1OTI2OC4KIAogICAgICAgICBNaXNzZWQgYWRkaW5n IEluc3BlY3RvckJhY2tlbmREaXNwYXRjaGVyLmggYW5kIGNwcCB0byB0aGUgV2luZG93cyBidWls ZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JCYWNrZW5k RGlzcGF0Y2hlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQmFja2Vu ZERpc3BhdGNoZXIuY3BwCmluZGV4IGM2MTU2NTkuLmFjZGFhNzAgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JCYWNrZW5kRGlzcGF0Y2hlci5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckJhY2tlbmREaXNwYXRjaGVyLmNwcApA QCAtMTU0LDggKzE1NCw4IEBAIHZvaWQgSW5zcGVjdG9yQmFja2VuZERpc3BhdGNoZXI6OnNlbmRS ZXNwb25zZShsb25nIGNhbGxJZCwgUGFzc1JlZlB0cjxJbnNwZWN0b3JPCiAgICAgfQogCiAgICAg UmVmUHRyPEluc3BlY3Rvck9iamVjdD4gcmVzcG9uc2VNZXNzYWdlID0gSW5zcGVjdG9yT2JqZWN0 OjpjcmVhdGUoKTsKLSAgICByZXNwb25zZU1lc3NhZ2UtPnNldE9iamVjdCgicmVzdWx0IiwgcmVz dWx0KTsKLSAgICByZXNwb25zZU1lc3NhZ2UtPnNldE51bWJlcigiaWQiLCBjYWxsSWQpOworICAg IHJlc3BvbnNlTWVzc2FnZS0+c2V0T2JqZWN0KEFTQ0lJTGl0ZXJhbCgicmVzdWx0IiksIHJlc3Vs dCk7CisgICAgcmVzcG9uc2VNZXNzYWdlLT5zZXROdW1iZXIoQVNDSUlMaXRlcmFsKCJpZCIpLCBj YWxsSWQpOwogICAgIG1faW5zcGVjdG9yRnJvbnRlbmRDaGFubmVsLT5zZW5kTWVzc2FnZVRvRnJv bnRlbmQocmVzcG9uc2VNZXNzYWdlLT50b0pTT05TdHJpbmcoKSk7CiB9CiAKQEAgLTE2NiwzNSAr MTY2LDM0IEBAIHZvaWQgSW5zcGVjdG9yQmFja2VuZERpc3BhdGNoZXI6OnJlcG9ydFByb3RvY29s RXJyb3IoY29uc3QgbG9uZyogY29uc3QgY2FsbElkLCBDCiAKIHZvaWQgSW5zcGVjdG9yQmFja2Vu ZERpc3BhdGNoZXI6OnJlcG9ydFByb3RvY29sRXJyb3IoY29uc3QgbG9uZyogY29uc3QgY2FsbElk LCBDb21tb25FcnJvckNvZGUgZXJyb3JDb2RlLCBjb25zdCBTdHJpbmcmIGVycm9yTWVzc2FnZSwg UGFzc1JlZlB0cjxJbnNwZWN0b3JBcnJheT4gZGF0YSkgY29uc3QKIHsKLSAgICBERUZJTkVfU1RB VElDX0xPQ0FMKFZlY3RvcjxpbnQ+LCBjb21tb25FcnJvcnMsICgpKTsKLSAgICBpZiAoIWNvbW1v bkVycm9ycy5zaXplKCkpIHsKLSAgICAgICAgY29tbW9uRXJyb3JzLmluc2VydChQYXJzZUVycm9y LCAtMzI3MDApOwotICAgICAgICBjb21tb25FcnJvcnMuaW5zZXJ0KEludmFsaWRSZXF1ZXN0LCAt MzI2MDApOwotICAgICAgICBjb21tb25FcnJvcnMuaW5zZXJ0KE1ldGhvZE5vdEZvdW5kLCAtMzI2 MDEpOwotICAgICAgICBjb21tb25FcnJvcnMuaW5zZXJ0KEludmFsaWRQYXJhbXMsIC0zMjYwMik7 Ci0gICAgICAgIGNvbW1vbkVycm9ycy5pbnNlcnQoSW50ZXJuYWxFcnJvciwgLTMyNjAzKTsKLSAg ICAgICAgY29tbW9uRXJyb3JzLmluc2VydChTZXJ2ZXJFcnJvciwgLTMyMDAwKTsKLSAgICB9Cisg ICAgc3RhdGljIGNvbnN0IGludCBlcnJvckNvZGVzW10gPSB7CisgICAgICAgIC0zMjcwMCwgLy8g UGFyc2VFcnJvcgorICAgICAgICAtMzI2MDAsIC8vIEludmFsaWRSZXF1ZXN0CisgICAgICAgIC0z MjYwMSwgLy8gTWV0aG9kTm90Rm91bmQKKyAgICAgICAgLTMyNjAyLCAvLyBJbnZhbGlkUGFyYW1z CisgICAgICAgIC0zMjYwMywgLy8gSW50ZXJuYWxFcnJvcgorICAgICAgICAtMzIwMDAsIC8vIFNl cnZlckVycm9yCisgICAgfTsKIAogICAgIEFTU0VSVChlcnJvckNvZGUgPj0gMCk7Ci0gICAgQVNT RVJUKCh1bnNpZ25lZCllcnJvckNvZGUgPCBjb21tb25FcnJvcnMuc2l6ZSgpKTsKLSAgICBBU1NF UlQoY29tbW9uRXJyb3JzW2Vycm9yQ29kZV0pOworICAgIEFTU0VSVCgodW5zaWduZWQpZXJyb3JD b2RlIDwgV1RGX0FSUkFZX0xFTkdUSChlcnJvckNvZGVzKSk7CisgICAgQVNTRVJUKGVycm9yQ29k ZXNbZXJyb3JDb2RlXSk7CiAKICAgICBpZiAoIW1faW5zcGVjdG9yRnJvbnRlbmRDaGFubmVsKQog ICAgICAgICByZXR1cm47CiAKICAgICBSZWZQdHI8SW5zcGVjdG9yT2JqZWN0PiBlcnJvciA9IElu c3BlY3Rvck9iamVjdDo6Y3JlYXRlKCk7Ci0gICAgZXJyb3ItPnNldE51bWJlcigiY29kZSIsIGNv bW1vbkVycm9yc1tlcnJvckNvZGVdKTsKLSAgICBlcnJvci0+c2V0U3RyaW5nKCJtZXNzYWdlIiwg ZXJyb3JNZXNzYWdlKTsKKyAgICBlcnJvci0+c2V0TnVtYmVyKEFTQ0lJTGl0ZXJhbCgiY29kZSIp LCBlcnJvckNvZGVzW2Vycm9yQ29kZV0pOworICAgIGVycm9yLT5zZXRTdHJpbmcoQVNDSUlMaXRl cmFsKCJtZXNzYWdlIiksIGVycm9yTWVzc2FnZSk7CiAgICAgaWYgKGRhdGEpCi0gICAgICAgIGVy cm9yLT5zZXRBcnJheSgiZGF0YSIsIGRhdGEpOworICAgICAgICBlcnJvci0+c2V0QXJyYXkoQVND SUlMaXRlcmFsKCJkYXRhIiksIGRhdGEpOwogCiAgICAgUmVmUHRyPEluc3BlY3Rvck9iamVjdD4g bWVzc2FnZSA9IEluc3BlY3Rvck9iamVjdDo6Y3JlYXRlKCk7Ci0gICAgbWVzc2FnZS0+c2V0T2Jq ZWN0KCJlcnJvciIsIGVycm9yLnJlbGVhc2UoKSk7CisgICAgbWVzc2FnZS0+c2V0T2JqZWN0KEFT Q0lJTGl0ZXJhbCgiZXJyb3IiKSwgZXJyb3IucmVsZWFzZSgpKTsKICAgICBpZiAoY2FsbElkKQot ICAgICAgICBtZXNzYWdlLT5zZXROdW1iZXIoImlkIiwgKmNhbGxJZCk7CisgICAgICAgIG1lc3Nh Z2UtPnNldE51bWJlcihBU0NJSUxpdGVyYWwoImlkIiksICpjYWxsSWQpOwogICAgIGVsc2UKLSAg ICAgICAgbWVzc2FnZS0+c2V0VmFsdWUoImlkIiwgSW5zcGVjdG9yVmFsdWU6Om51bGwoKSk7Cisg ICAgICAgIG1lc3NhZ2UtPnNldFZhbHVlKEFTQ0lJTGl0ZXJhbCgiaWQiKSwgSW5zcGVjdG9yVmFs dWU6Om51bGwoKSk7CiAKICAgICBtX2luc3BlY3RvckZyb250ZW5kQ2hhbm5lbC0+c2VuZE1lc3Nh Z2VUb0Zyb250ZW5kKG1lc3NhZ2UtPnRvSlNPTlN0cmluZygpKTsKIH0KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JCYWNrZW5kRGlzcGF0Y2hlci5oIGIvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckJhY2tlbmREaXNwYXRjaGVyLmgKaW5kZXgg Y2NjNGE1ZC4uYzI2ZTZkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0lu c3BlY3RvckJhY2tlbmREaXNwYXRjaGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L0luc3BlY3RvckJhY2tlbmREaXNwYXRjaGVyLmgKQEAgLTQwLDcgKzQwLDcgQEAgdHlwZWRlZiBT dHJpbmcgRXJyb3JTdHJpbmc7CiAKIGNsYXNzIEluc3BlY3RvclN1cHBsZW1lbnRhbEJhY2tlbmRE aXNwYXRjaGVyIDogcHVibGljIFJlZkNvdW50ZWQ8SW5zcGVjdG9yU3VwcGxlbWVudGFsQmFja2Vu ZERpc3BhdGNoZXI+IHsKIHB1YmxpYzoKLSAgICBJbnNwZWN0b3JTdXBwbGVtZW50YWxCYWNrZW5k RGlzcGF0Y2hlcihJbnNwZWN0b3JCYWNrZW5kRGlzcGF0Y2hlciAqYmFja2VuZERpc3BhdGNoZXIp IDogbV9iYWNrZW5kRGlzcGF0Y2hlcihiYWNrZW5kRGlzcGF0Y2hlcikgeyB9CisgICAgSW5zcGVj dG9yU3VwcGxlbWVudGFsQmFja2VuZERpc3BhdGNoZXIoSW5zcGVjdG9yQmFja2VuZERpc3BhdGNo ZXIqIGJhY2tlbmREaXNwYXRjaGVyKSA6IG1fYmFja2VuZERpc3BhdGNoZXIoYmFja2VuZERpc3Bh dGNoZXIpIHsgfQogICAgIHZpcnR1YWwgfkluc3BlY3RvclN1cHBsZW1lbnRhbEJhY2tlbmREaXNw YXRjaGVyKCkgeyB9CiAgICAgdmlydHVhbCB2b2lkIGRpc3BhdGNoKGxvbmcgY2FsbElkLCBjb25z dCBTdHJpbmcmIG1ldGhvZCwgUGFzc1JlZlB0cjxJbnNwZWN0b3JPYmplY3Q+IG1lc3NhZ2UpID0g MDsKIHByb3RlY3RlZDoK