12433 2007-01-27 03:19:48 -0800 ASSERT right-clicking on misspelled word in fixUpOldMenus on TOT 2007-01-29 23:18:25 -0800 1 1 1 Unclassified WebKit New Bugs 420+ Mac OS X 10.4 RESOLVED DUPLICATE 12134 InRadar P1 Normal --- 1 eric webkit-unassigned oldest_to_newest 32145 0 eric 2007-01-27 03:19:48 -0800 When clicking on selected text, Safari crashed in fixUpOldMenus assertion: // Versions of Mail compiled with older WebKits will end up without three context menu items, // though with the separators between them. Here we check for that problem and reinsert the // three missing items. This shouldn't affect any clients other than Mail since the tags for // the three items were not public API. We can remove this code when we no longer support // previously-built versions of Mail on Tiger. See 4498606 for more details. ASSERT([[newMenuItems objectAtIndex:1] isSeparatorItem]); ASSERT([[defaultMenuItems objectAtIndex:1] tag] == WebMenuItemTagSearchWeb); // crashed here. (gdb) po defaultMenuItems <NSCFArray 0x1800a680>( <MenuItem: 0x17526950 animation>, <MenuItem: 0x1731fda0 >, <MenuItem: 0x1804ac30 Ignore Spelling>, <MenuItem: 0x173fd190 Learn Spelling>, <MenuItem: 0x175ad450 >, <MenuItem: 0x1753c2b0 Search in Spotlight>, <MenuItem: 0x1757d6c0 Search in Google>, <MenuItem: 0x173ecf40 >, <MenuItem: 0x17b02980 Look Up in Dictionary>, <MenuItem: 0x1797a690 >, <MenuItem: 0x1798af70 Cut>, <MenuItem: 0x1734ebc0 Copy>, <MenuItem: 0x17725370 Paste>, <MenuItem: 0x17378b10 >, <MenuItem: 0x17572e30 Spelling, submenu: 0x18862d50 ()>, <MenuItem: 0x1803a9b0 Font, submenu: 0x18862c30 ()>, <MenuItem: 0x175f94d0 Speech, submenu: 0x17546aa0 ()>, <MenuItem: 0x179a1f50 Writing Direction, submenu: 0x180aad30 ()> ) #0 0x00398122 in fixMenusFromOldClients at WebContextMenuClient.mm:89 #1 0x00398ebc in WebContextMenuClient::getCustomMenuFromDefaultItems at WebContextMenuClient.mm:177 #2 0x013eeb57 in WebCore::ContextMenuController::handleContextMenuEvent at ContextMenuController.cpp:88 #3 0x0122c247 in WebCore::EventTargetNode::defaultEventHandler at EventTargetNode.cpp:573 #4 0x01224502 in WebCore::HTMLTextFieldInnerTextElement::defaultEventHandler at HTMLTextFieldInnerElement.cpp:64 #5 0x011a5166 in WebCore::RenderTextControl::forwardEvent at RenderTextControl.cpp:753 #6 0x010d2f10 in WebCore::HTMLTextAreaElement::defaultEventHandler at HTMLTextAreaElement.cpp:238 #7 0x0122a57b in WebCore::EventTargetNode::dispatchGenericEvent at EventTargetNode.cpp:262 #8 0x0122be5e in WebCore::EventTargetNode::dispatchEvent at EventTargetNode.cpp:297 #9 0x0122acf5 in WebCore::EventTargetNode::dispatchMouseEvent at EventTargetNode.cpp:455 #10 0x0122b3a0 in WebCore::EventTargetNode::dispatchMouseEvent at EventTargetNode.cpp:382 #11 0x013e9a5c in WebCore::EventHandler::dispatchMouseEvent at EventHandler.cpp:1027 #12 0x013e9dd5 in WebCore::EventHandler::sendContextMenuEvent at EventHandler.cpp:1124 #13 0x0033af9c in -[WebHTMLView menuForEvent:] at WebHTMLView.mm:2568 #14 0x9334c33a in -[NSWindow sendEvent:] #15 0x0002338e in ?? #16 0x9333e350 in -[NSApplication sendEvent:] #17 0x00022f1e in ?? #18 0x93268dfe in -[NSApplication run] #19 0x9325cd2f in NSApplicationMain #20 0x0005f7de in ?? #21 0x0005f6f9 in ?? I was clicking on selected text in a bugzilla form. tiger safari, TOT webkit. 32110 1 ddkilzer 2007-01-27 03:45:48 -0800 What's the "animation" item in the menu item list? Is that a local modification for a patch-in-progress, or is it something only available when right-clicking on SVG animations? (In reply to comment #0) > (gdb) po defaultMenuItems > <NSCFArray 0x1800a680>( > <MenuItem: 0x17526950 animation>, > <MenuItem: 0x1731fda0 >, > <MenuItem: 0x1804ac30 Ignore Spelling>, > <MenuItem: 0x173fd190 Learn Spelling>, > <MenuItem: 0x175ad450 >, > <MenuItem: 0x1753c2b0 Search in Spotlight>, > <MenuItem: 0x1757d6c0 Search in Google>, > <MenuItem: 0x173ecf40 >, > <MenuItem: 0x17b02980 Look Up in Dictionary>, > <MenuItem: 0x1797a690 >, > <MenuItem: 0x1798af70 Cut>, > <MenuItem: 0x1734ebc0 Copy>, > <MenuItem: 0x17725370 Paste>, > <MenuItem: 0x17378b10 >, > <MenuItem: 0x17572e30 Spelling, submenu: 0x18862d50 ()>, > <MenuItem: 0x1803a9b0 Font, submenu: 0x18862c30 ()>, > <MenuItem: 0x175f94d0 Speech, submenu: 0x17546aa0 ()>, > <MenuItem: 0x179a1f50 Writing Direction, submenu: 0x180aad30 ()> > ) 32107 2 eric 2007-01-27 03:50:41 -0800 it was the spelling word I clicked on iirc. 32104 3 eric 2007-01-27 03:56:40 -0800 Clicking on any misspelled word hits this assert. 31343 4 mrowe 2007-01-28 15:40:36 -0800 <rdar://problem/4960100> 30582 5 aroben 2007-01-29 23:18:25 -0800 *** This bug has been marked as a duplicate of 12134 ***